René's URL Explorer Experiment


Title: [5.X branch only] fix(common): don't recreate view when context shape doesn't change by pkozlowski-opensource · Pull Request #18277 · angular/angular · GitHub

Open Graph Title: [5.X branch only] fix(common): don't recreate view when context shape doesn't change by pkozlowski-opensource · Pull Request #18277 · angular/angular

X Title: [5.X branch only] fix(common): don't recreate view when context shape doesn't change by pkozlowski-opensource · Pull Request #18277 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Fixes #13407 Problem description When using ngTemplateOutlet with context as an object literal in a template and binding to the context's property the embedded view would get re-created even if...

X Description: Fixes #13407 Problem description When using ngTemplateOutlet with context as an object literal in a template and binding to the context's property the embedded view would get re-created eve...

Opengraph URL: https://github.com/angular/angular/pull/18277

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c8a5ee53-3967-807f-552b-c1ce35f29b1c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5B4:EAD6D:FEAD9C:13EDA1C:6B024B53
html-safe-nonceb4f13156806567c49b59c373d0f69b265b55c91fd35ee7ab6eadb8a9f5b8ddac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUI0OkVBRDZEOkZFQUQ5QzoxM0VEQTFDOjZCMDI0QjUzIiwidmlzaXRvcl9pZCI6IjY0NTYzOTQ1Nzg1OTY2MTI5NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacde264b52075f8b1348f4884f3077141bae691e0764be2600c4aaad3136099855
hovercard-subject-tagpull_request:131764409
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/18277/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1f294a61b4f46acfb3655b30260f926b1798e1a60394844770968087208a6bb8/angular/angular/pull/18277
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1f294a61b4f46acfb3655b30260f926b1798e1a60394844770968087208a6bb8/angular/angular/pull/18277
og:image:altFixes #13407 Problem description When using ngTemplateOutlet with context as an object literal in a template and binding to the context's property the embedded view would get re-created even if...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkozlowski-opensource
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/18277#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18277
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18277
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18277
Reloadhttps://github.com/angular/angular/pull/18277
Reloadhttps://github.com/angular/angular/pull/18277
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
vicbhttps://github.com/vicb
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:template_outlet_context_recreatehttps://github.com/pkozlowski-opensource/angular/tree/template_outlet_context_recreate
Conversationhttps://github.com/angular/angular/pull/18277
Commits1 (1)https://github.com/angular/angular/pull/18277/commits
Checkshttps://github.com/angular/angular/pull/18277/checks
Files changedhttps://github.com/angular/angular/pull/18277/files
[5.X branch only] fix(common): don't recreate view when context shape doesn't changehttps://github.com/angular/angular/pull/18277#top
vicbhttps://github.com/vicb
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:template_outlet_context_recreatehttps://github.com/pkozlowski-opensource/angular/tree/template_outlet_context_recreate
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Jul 21, 2017https://github.com/angular/angular/pull/18277#issue-244655934
#13407https://github.com/angular/angular/issues/13407
Please reload this pagehttps://github.com/angular/angular/pull/18277
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 21, 2017https://github.com/angular/angular/pull/18277#event-1173793996
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: common https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jul 21, 2017https://github.com/angular/angular/pull/18277#event-1173794260
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 21, 2017 https://github.com/angular/angular/pull/18277#pullrequestreview-51536834
View reviewed changes https://github.com/angular/angular/pull/18277/files
packages/common/src/directives/ng_template_outlet.tshttps://github.com/angular/angular/pull/18277/files#diff-20d288941ee1867b664d07243d9b51965fa98e4b3d692eb3b001661e8cd20641
vicbhttps://github.com/vicb
Jul 21, 2017https://github.com/angular/angular/pull/18277#discussion_r128817526
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18277
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 21, 2017 https://github.com/angular/angular/pull/18277#pullrequestreview-51537209
View reviewed changes https://github.com/angular/angular/pull/18277/files
packages/common/src/directives/ng_template_outlet.tshttps://github.com/angular/angular/pull/18277/files#diff-20d288941ee1867b664d07243d9b51965fa98e4b3d692eb3b001661e8cd20641
vicbhttps://github.com/vicb
Jul 21, 2017https://github.com/angular/angular/pull/18277#discussion_r128817854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18277
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 21, 2017 https://github.com/angular/angular/pull/18277#pullrequestreview-51537789
View reviewed changes https://github.com/angular/angular/pull/18277/files
packages/common/src/directives/ng_template_outlet.tshttps://github.com/angular/angular/pull/18277/files#diff-20d288941ee1867b664d07243d9b51965fa98e4b3d692eb3b001661e8cd20641
vicbhttps://github.com/vicb
Jul 21, 2017https://github.com/angular/angular/pull/18277#discussion_r128818375
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18277
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Jul 24, 2017https://github.com/angular/angular/pull/18277#discussion_r129058062
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18277
vicbhttps://github.com/vicb
Jul 24, 2017https://github.com/angular/angular/pull/18277#discussion_r129119910
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18277
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/d5f1e9839bf25e6f9122ec412d88382f8cd6951b..f0c578e6fec8e57033b44f5c765ac2c303480b29
d5f1e98https://github.com/angular/angular/commit/d5f1e9839bf25e6f9122ec412d88382f8cd6951b
f0c578ehttps://github.com/angular/angular/commit/f0c578e6fec8e57033b44f5c765ac2c303480b29
Compare https://github.com/angular/angular/compare/d5f1e9839bf25e6f9122ec412d88382f8cd6951b..f0c578e6fec8e57033b44f5c765ac2c303480b29
July 24, 2017 14:58https://github.com/angular/angular/pull/18277#event-1176285824
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 24, 2017 https://github.com/angular/angular/pull/18277#pullrequestreview-51860986
View reviewed changes https://github.com/angular/angular/pull/18277/files
packages/common/src/directives/ng_template_outlet.tshttps://github.com/angular/angular/pull/18277/files#diff-20d288941ee1867b664d07243d9b51965fa98e4b3d692eb3b001661e8cd20641
vicbhttps://github.com/vicb
Jul 24, 2017https://github.com/angular/angular/pull/18277#discussion_r129120296
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18277
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/f0c578e6fec8e57033b44f5c765ac2c303480b29..14713de7923177a74d84be80560df50081611f15
f0c578ehttps://github.com/angular/angular/commit/f0c578e6fec8e57033b44f5c765ac2c303480b29
14713dehttps://github.com/angular/angular/commit/14713de7923177a74d84be80560df50081611f15
Compare https://github.com/angular/angular/compare/f0c578e6fec8e57033b44f5c765ac2c303480b29..14713de7923177a74d84be80560df50081611f15
July 25, 2017 08:58https://github.com/angular/angular/pull/18277#event-1177584839
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Jul 25, 2017https://github.com/angular/angular/pull/18277#issuecomment-317684217
@vicbhttps://github.com/vicb
Please reload this pagehttps://github.com/angular/angular/pull/18277
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 26, 2017https://github.com/angular/angular/pull/18277#issuecomment-318177170
Please reload this pagehttps://github.com/angular/angular/pull/18277
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 27, 2017https://github.com/angular/angular/pull/18277#event-1182134525
https://github.com/pkozlowski-opensource
fix(common): don't recreate view when context shape doesn't changehttps://github.com/angular/angular/pull/18277/commits/2871389f7d360dd21e86212c72033759fc1d71b1
2871389https://github.com/angular/angular/pull/18277/commits/2871389f7d360dd21e86212c72033759fc1d71b1
angular#13407https://github.com/angular/angular/issues/13407
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/14713de7923177a74d84be80560df50081611f15..2871389f7d360dd21e86212c72033759fc1d71b1
14713dehttps://github.com/angular/angular/commit/14713de7923177a74d84be80560df50081611f15
2871389https://github.com/angular/angular/commit/2871389f7d360dd21e86212c72033759fc1d71b1
Compare https://github.com/angular/angular/compare/14713de7923177a74d84be80560df50081611f15..2871389f7d360dd21e86212c72033759fc1d71b1
August 7, 2017 18:16https://github.com/angular/angular/pull/18277#event-1195891024
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Aug 7, 2017https://github.com/angular/angular/pull/18277#event-1195895304
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 7, 2017 https://github.com/angular/angular/pull/18277#pullrequestreview-54749164
View reviewed changes https://github.com/angular/angular/pull/18277/files/2871389f7d360dd21e86212c72033759fc1d71b1
https://github.com/vicb
vicbhttps://github.com/vicb
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Aug 7, 2017https://github.com/angular/angular/pull/18277#event-1195984588
https://github.com/vicb
vicbhttps://github.com/vicb
685cc26https://github.com/angular/angular/commit/685cc26ab2dc7f8d836ec932a43d45edfa0f8e97
Aug 7, 2017https://github.com/angular/angular/pull/18277#event-1196176195
asnowwolfhttps://github.com/asnowwolf
Aug 11, 2017 https://github.com/angular/angular/pull/18277#ref-commit-b30fce5
https://github.com/pkozlowski-opensource
fix(common): don't recreate view when context shape doesn't change (https://github.com/asnowwolf/angular/commit/b30fce59d7a8773dcddde698b1c38e9827ad3978
a…https://github.com/angular/angular/pull/18277
b30fce5https://github.com/asnowwolf/angular/commit/b30fce59d7a8773dcddde698b1c38e9827ad3978
…ngular#18277https://github.com/angular/angular/pull/18277
angular#13407https://github.com/angular/angular/issues/13407
juleskremerhttps://github.com/juleskremer
Aug 26, 2017 https://github.com/angular/angular/pull/18277#ref-commit-4c764aa
https://github.com/pkozlowski-opensource
https://github.com/juleskremer
fix(common): don't recreate view when context shape doesn't change (https://github.com/juleskremer/angular/commit/4c764aa9b3b1facf5aac69ea05c21402b1c5fc26
a…https://github.com/angular/angular/pull/18277
4c764aahttps://github.com/juleskremer/angular/commit/4c764aa9b3b1facf5aac69ea05c21402b1c5fc26
…ngular#18277https://github.com/angular/angular/pull/18277
angular#13407https://github.com/angular/angular/issues/13407
juleskremerhttps://github.com/juleskremer
Aug 28, 2017 https://github.com/angular/angular/pull/18277#ref-commit-5c93f5f
https://github.com/pkozlowski-opensource
https://github.com/juleskremer
fix(common): don't recreate view when context shape doesn't change (https://github.com/juleskremer/angular/commit/5c93f5f9fbfcee21e51ab485f74237470c0a11df
a…https://github.com/angular/angular/pull/18277
5c93f5fhttps://github.com/juleskremer/angular/commit/5c93f5f9fbfcee21e51ab485f74237470c0a11df
…ngular#18277https://github.com/angular/angular/pull/18277
angular#13407https://github.com/angular/angular/issues/13407
https://github.com/trotyl
trotylhttps://github.com/trotyl
Oct 24, 2017 https://github.com/angular/angular/pull/18277#ref-issue-267821264
Events being swallowed when using an ngTemplateOutlet with context surrounded by an element with a click listener #19882 https://github.com/angular/angular/issues/19882
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18277#issuecomment-530683101
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/18277
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18277#event-2627983854
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18277
https://github.com/vicb
vicb https://github.com/vicb
https://github.com/angular/angular/pull/18277/files/2871389f7d360dd21e86212c72033759fc1d71b1
Please reload this pagehttps://github.com/angular/angular/pull/18277
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: common https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
ngOutletContext causes template to re-initialize on data changes https://github.com/angular/angular/issues/13407
Please reload this pagehttps://github.com/angular/angular/pull/18277
https://github.com/pkozlowski-opensource
https://github.com/vicb
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.