René's URL Explorer Experiment


Title: fix(router): shouldn't break history when CanDeactivate cancel back by jasonaden · Pull Request #18135 · angular/angular · GitHub

Open Graph Title: fix(router): shouldn't break history when CanDeactivate cancel back by jasonaden · Pull Request #18135 · angular/angular

X Title: fix(router): shouldn't break history when CanDeactivate cancel back by jasonaden · Pull Request #18135 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: navigation Rebased from #13922. Closes #13586

X Description: navigation Rebased from #13922. Closes #13586

Opengraph URL: https://github.com/angular/angular/pull/18135

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d2885054-c15a-8d06-52b6-00880ce52a9f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD082:1F7384:D3259E:1184691:6B00FA76
html-safe-nonce94f366c6a4a2d02ed60d123803b4bfbbdb9f47ca4f8f2970258be16a7696760d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDgyOjFGNzM4NDpEMzI1OUU6MTE4NDY5MTo2QjAwRkE3NiIsInZpc2l0b3JfaWQiOiI1NDMwODc3NzUxMjAyNjA5NzgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac92e2e2c8b1b3bc37b54c06e1df71ed935df8f29a3763d8100e41e1b9f653fbee
hovercard-subject-tagpull_request:130667391
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/18135/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9c1d412e5c5e160d1e744a330c8636388a0e5703f7cbfaef08111869e95de5d5/angular/angular/pull/18135
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9c1d412e5c5e160d1e744a330c8636388a0e5703f7cbfaef08111869e95de5d5/angular/angular/pull/18135
og:image:altnavigation Rebased from #13922. Closes #13586
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasonaden
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/18135#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18135
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18135
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18135
Reloadhttps://github.com/angular/angular/pull/18135
Reloadhttps://github.com/angular/angular/pull/18135
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
jasonadenhttps://github.com/jasonaden
angular:masterhttps://github.com/angular/angular/tree/master
jasonaden:fix_13586_history_can_deactivate_cancelhttps://github.com/jasonaden/angular/tree/fix_13586_history_can_deactivate_cancel
Conversationhttps://github.com/angular/angular/pull/18135
Commits1 (1)https://github.com/angular/angular/pull/18135/commits
Checkshttps://github.com/angular/angular/pull/18135/checks
Files changedhttps://github.com/angular/angular/pull/18135/files
fix(router): shouldn't break history when CanDeactivate cancel backhttps://github.com/angular/angular/pull/18135#top
jasonadenhttps://github.com/jasonaden
angular:masterhttps://github.com/angular/angular/tree/master
jasonaden:fix_13586_history_can_deactivate_cancelhttps://github.com/jasonaden/angular/tree/fix_13586_history_can_deactivate_cancel
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Jul 14, 2017https://github.com/angular/angular/pull/18135#issue-243102712
#13922https://github.com/angular/angular/pull/13922
#13586https://github.com/angular/angular/issues/13586
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/googlebot
googlebothttps://github.com/googlebot
Jul 14, 2017https://github.com/angular/angular/pull/18135#issuecomment-315458714
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Jul 14, 2017https://github.com/angular/angular/pull/18135#event-1164906887
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
vicbhttps://github.com/vicb
July 14, 2017 20:24https://github.com/angular/angular/pull/18135#event-1164907012
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Jul 14, 2017https://github.com/angular/angular/pull/18135#event-1164907354
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Jul 14, 2017 https://github.com/angular/angular/pull/18135#ref-pullrequest-200754048
fix(router): don't break history when CanDeactivate cancel back navigation #13922 https://github.com/angular/angular/pull/13922
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 19, 2017 https://github.com/angular/angular/pull/18135#pullrequestreview-51060590
View reviewed changes https://github.com/angular/angular/pull/18135/files
vicbhttps://github.com/vicb
https://github.com/angular/angular/pull/18135#pullrequestreview-51060590
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#13922 (comment)https://github.com/angular/angular/pull/13922#issuecomment-290574181
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/jibbers42
jibbers42https://github.com/jibbers42
Jul 20, 2017https://github.com/angular/angular/pull/18135#issuecomment-316649230
@vicbhttps://github.com/vicb
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/mhevery
mheveryhttps://github.com/mhevery
force-pushedhttps://github.com/angular/angular/compare/08b36cb50d046cf0a00fcc07e88b35578ee89580..5d4b36f80f295455f4250c4257462b22ce6b3372
08b36cbhttps://github.com/angular/angular/commit/08b36cb50d046cf0a00fcc07e88b35578ee89580
5d4b36fhttps://github.com/angular/angular/commit/5d4b36f80f295455f4250c4257462b22ce6b3372
Compare https://github.com/angular/angular/compare/08b36cb50d046cf0a00fcc07e88b35578ee89580..5d4b36f80f295455f4250c4257462b22ce6b3372
July 20, 2017 21:49https://github.com/angular/angular/pull/18135#event-1172950500
https://github.com/DzmitryShylovich
https://github.com/mhevery
fix(router): shouldn't break history when CanDeactivate cancel backhttps://github.com/angular/angular/pull/18135/commits/61e7fdab24fab4d34ef00dddab09abd12c6eaf84
61e7fdahttps://github.com/angular/angular/pull/18135/commits/61e7fdab24fab4d34ef00dddab09abd12c6eaf84
angular#13586https://github.com/angular/angular/issues/13586
https://github.com/mhevery
mheveryhttps://github.com/mhevery
force-pushedhttps://github.com/angular/angular/compare/042cae1c0f62535aef63363e898166c90d2790ef..61e7fdab24fab4d34ef00dddab09abd12c6eaf84
042cae1https://github.com/angular/angular/commit/042cae1c0f62535aef63363e898166c90d2790ef
61e7fdahttps://github.com/angular/angular/commit/61e7fdab24fab4d34ef00dddab09abd12c6eaf84
Compare https://github.com/angular/angular/compare/042cae1c0f62535aef63363e898166c90d2790ef..61e7fdab24fab4d34ef00dddab09abd12c6eaf84
July 26, 2017 17:12https://github.com/angular/angular/pull/18135#event-1180306905
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Jul 26, 2017https://github.com/angular/angular/pull/18135#event-1180306973
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 26, 2017https://github.com/angular/angular/pull/18135#issuecomment-318126118
61e7fdahttps://github.com/angular/angular/commit/61e7fdab24fab4d34ef00dddab09abd12c6eaf84
https://pr18135-61e7fda.ngbuilds.io/https://pr18135-61e7fda.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/MacKinley
MacKinleyhttps://github.com/MacKinley
Sep 26, 2017https://github.com/angular/angular/pull/18135#issuecomment-332232213
#15664https://github.com/angular/angular/issues/15664
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/patrickracicot
patrickracicothttps://github.com/patrickracicot
Oct 25, 2017 https://github.com/angular/angular/pull/18135#ref-issue-218489400
Canceled Location.forward() breaks history #15664 https://github.com/angular/angular/issues/15664
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Dec 21, 2017https://github.com/angular/angular/pull/18135#issuecomment-353487557
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Dec 21, 2017https://github.com/angular/angular/pull/18135#event-1398888004
https://github.com/alfredorevilla
alfredorevillahttps://github.com/alfredorevilla
Mar 5, 2018https://github.com/angular/angular/pull/18135#issuecomment-370537416
Please reload this pagehttps://github.com/angular/angular/pull/18135
@jasonadenhttps://github.com/jasonaden
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/thanhnhan2tn
thanhnhan2tnhttps://github.com/thanhnhan2tn
Jul 17, 2018https://github.com/angular/angular/pull/18135#issuecomment-405545283
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/apostnov
apostnovhttps://github.com/apostnov
Jan 24, 2019https://github.com/angular/angular/pull/18135#issuecomment-457378737
Please reload this pagehttps://github.com/angular/angular/pull/18135
@jasonadenhttps://github.com/jasonaden
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/DanielHabenicht
DanielHabenichthttps://github.com/DanielHabenicht
Apr 27, 2019 https://github.com/angular/angular/pull/18135#ref-issue-196702796
Deactivation Guard breaks the routing history #13586 https://github.com/angular/angular/issues/13586
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/18135#issuecomment-531485858
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/18135#event-2634173379
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18135
https://github.com/vicb
vicb https://github.com/vicb
https://github.com/angular/angular/pull/18135/files/042cae1c0f62535aef63363e898166c90d2790ef
Please reload this pagehttps://github.com/angular/angular/pull/18135
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Deactivation Guard breaks the routing history https://github.com/angular/angular/issues/13586
Please reload this pagehttps://github.com/angular/angular/pull/18135
https://github.com/jasonaden
https://github.com/googlebot
https://github.com/jibbers42
https://github.com/mary-poppins
https://github.com/MacKinley
https://github.com/alfredorevilla
https://github.com/thanhnhan2tn
https://github.com/apostnov
https://github.com/vicb
https://github.com/DzmitryShylovich
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.