René's URL Explorer Experiment


Title: fix(router): child CanActivate guard should wait for parent to complete by jasonaden · Pull Request #18110 · angular/angular · GitHub

Open Graph Title: fix(router): child CanActivate guard should wait for parent to complete by jasonaden · Pull Request #18110 · angular/angular

X Title: fix(router): child CanActivate guard should wait for parent to complete by jasonaden · Pull Request #18110 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Closes #15670

X Description: Closes #15670

Opengraph URL: https://github.com/angular/angular/pull/18110

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:049bb9c5-8f2f-8003-7186-b4d48502aa94
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BA8:14700E:BA730B:EE3F2D:6B00F9A1
html-safe-nonce8a9efec4e5b0cf960fd68b322fae1f8e2e69da61c5c2e90550cce343f6c5c136
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkE4OjE0NzAwRTpCQTczMEI6RUUzRjJEOjZCMDBGOUExIiwidmlzaXRvcl9pZCI6IjY5ODE1MDQwNDQ3Nzg5Nzc2OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd2210ada03d1a466b95eb53ec30c4397d49afd55aefaea68c4b07997513ea457
hovercard-subject-tagpull_request:130489683
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/18110/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0ebbcb09d35d2e175308bf867aa927ce14cb08975ae7ec23f523b3eec5c7978d/angular/angular/pull/18110
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0ebbcb09d35d2e175308bf867aa927ce14cb08975ae7ec23f523b3eec5c7978d/angular/angular/pull/18110
og:image:altCloses #15670
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasonaden
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/18110#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18110
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18110
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18110
Reloadhttps://github.com/angular/angular/pull/18110
Reloadhttps://github.com/angular/angular/pull/18110
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
jasonadenhttps://github.com/jasonaden
angular:masterhttps://github.com/angular/angular/tree/master
jasonaden:fix_can_activate_waithttps://github.com/jasonaden/angular/tree/fix_can_activate_wait
Conversationhttps://github.com/angular/angular/pull/18110
Commits1 (1)https://github.com/angular/angular/pull/18110/commits
Checkshttps://github.com/angular/angular/pull/18110/checks
Files changedhttps://github.com/angular/angular/pull/18110/files
fix(router): child CanActivate guard should wait for parent to completehttps://github.com/angular/angular/pull/18110#top
jasonadenhttps://github.com/jasonaden
angular:masterhttps://github.com/angular/angular/tree/master
jasonaden:fix_can_activate_waithttps://github.com/jasonaden/angular/tree/fix_can_activate_wait
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Jul 13, 2017https://github.com/angular/angular/pull/18110#issue-242859926
#15670https://github.com/angular/angular/issues/15670
Please reload this pagehttps://github.com/angular/angular/pull/18110
https://github.com/googlebot
googlebothttps://github.com/googlebot
Jul 13, 2017https://github.com/angular/angular/pull/18110#issuecomment-315230778
Please reload this pagehttps://github.com/angular/angular/pull/18110
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Jul 13, 2017https://github.com/angular/angular/pull/18110#event-1163510443
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Jul 13, 2017https://github.com/angular/angular/pull/18110#issuecomment-315230965
@nrgonzalez777https://github.com/nrgonzalez777
#15672https://github.com/angular/angular/pull/15672
Please reload this pagehttps://github.com/angular/angular/pull/18110
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jul 19, 2017https://github.com/angular/angular/pull/18110#event-1170708021
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 19, 2017 https://github.com/angular/angular/pull/18110#pullrequestreview-50995446
View reviewed changes https://github.com/angular/angular/pull/18110/files
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/18110/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
vicbhttps://github.com/vicb
Jul 19, 2017https://github.com/angular/angular/pull/18110#discussion_r128325982
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18110
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 19, 2017 https://github.com/angular/angular/pull/18110#pullrequestreview-50995536
View reviewed changes https://github.com/angular/angular/pull/18110/files
vicbhttps://github.com/vicb
https://github.com/angular/angular/pull/18110#pullrequestreview-50995536
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18110
https://github.com/mhevery
mheveryhttps://github.com/mhevery
force-pushedhttps://github.com/angular/angular/compare/08b36cb50d046cf0a00fcc07e88b35578ee89580..5d4b36f80f295455f4250c4257462b22ce6b3372
08b36cbhttps://github.com/angular/angular/commit/08b36cb50d046cf0a00fcc07e88b35578ee89580
5d4b36fhttps://github.com/angular/angular/commit/5d4b36f80f295455f4250c4257462b22ce6b3372
Compare https://github.com/angular/angular/compare/08b36cb50d046cf0a00fcc07e88b35578ee89580..5d4b36f80f295455f4250c4257462b22ce6b3372
July 20, 2017 21:49https://github.com/angular/angular/pull/18110#event-1172950438
https://github.com/mhevery
mheveryhttps://github.com/mhevery
force-pushedhttps://github.com/angular/angular/compare/717822ade31db75ea918a8f2811913e62513c6f5..e55a859aa4a2760a03338912cf82b2b0b6e149e7
717822ahttps://github.com/angular/angular/commit/717822ade31db75ea918a8f2811913e62513c6f5
e55a859https://github.com/angular/angular/commit/e55a859aa4a2760a03338912cf82b2b0b6e149e7
Compare https://github.com/angular/angular/compare/717822ade31db75ea918a8f2811913e62513c6f5..e55a859aa4a2760a03338912cf82b2b0b6e149e7
July 26, 2017 17:13https://github.com/angular/angular/pull/18110#event-1180308078
https://github.com/DzmitryShylovich
https://github.com/jasonaden
fix(router): child CanActivate guard should wait for parent to completehttps://github.com/angular/angular/pull/18110/commits/f5d9f773cbd30f2d78e3e420925e8852b2da9839
f5d9f77https://github.com/angular/angular/pull/18110/commits/f5d9f773cbd30f2d78e3e420925e8852b2da9839
angular#15670https://github.com/angular/angular/issues/15670
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
force-pushedhttps://github.com/angular/angular/compare/e55a859aa4a2760a03338912cf82b2b0b6e149e7..f5d9f773cbd30f2d78e3e420925e8852b2da9839
e55a859https://github.com/angular/angular/commit/e55a859aa4a2760a03338912cf82b2b0b6e149e7
f5d9f77https://github.com/angular/angular/commit/f5d9f773cbd30f2d78e3e420925e8852b2da9839
Compare https://github.com/angular/angular/compare/e55a859aa4a2760a03338912cf82b2b0b6e149e7..f5d9f773cbd30f2d78e3e420925e8852b2da9839
July 26, 2017 17:18https://github.com/angular/angular/pull/18110#event-1180316473
https://github.com/vicb
vicbhttps://github.com/vicb
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jul 26, 2017https://github.com/angular/angular/pull/18110#event-1180318596
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 26, 2017 https://github.com/angular/angular/pull/18110#pullrequestreview-52434209
View reviewed changes https://github.com/angular/angular/pull/18110/files/f5d9f773cbd30f2d78e3e420925e8852b2da9839
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Jul 26, 2017https://github.com/angular/angular/pull/18110#event-1180324902
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 26, 2017https://github.com/angular/angular/pull/18110#issuecomment-318131248
f5d9f77https://github.com/angular/angular/commit/f5d9f773cbd30f2d78e3e420925e8852b2da9839
https://pr18110-f5d9f77.ngbuilds.io/https://pr18110-f5d9f77.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/18110
https://github.com/mhevery
mheveryhttps://github.com/mhevery
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Jul 26, 2017https://github.com/angular/angular/pull/18110#event-1180613614
https://github.com/mhevery
mheveryhttps://github.com/mhevery
086f4aahttps://github.com/angular/angular/commit/086f4aa72c8b7251f6e53db503b1793a4c9772fd
Jul 26, 2017https://github.com/angular/angular/pull/18110#event-1180823619
mheveryhttps://github.com/mhevery
Jul 26, 2017 https://github.com/angular/angular/pull/18110#ref-commit-b9e32c8
https://github.com/mhevery
fix(router): child CanActivate guard should wait for parent to comple…https://github.com/angular/angular/commit/b9e32c833aa27765ea2bff0463fe898c780ee506
b9e32c8https://github.com/angular/angular/commit/b9e32c833aa27765ea2bff0463fe898c780ee506
#18110https://github.com/angular/angular/pull/18110
#15670https://github.com/angular/angular/issues/15670
#18110https://github.com/angular/angular/pull/18110
mheveryhttps://github.com/mhevery
Jul 27, 2017 https://github.com/angular/angular/pull/18110#ref-commit-c17ba61
https://github.com/mhevery
Revert "fix(router): child CanActivate guard should wait for parent t…https://github.com/mhevery/angular/commit/c17ba6143cbe1b7daa2f7caaf03f7ff8db746c5b
c17ba61https://github.com/mhevery/angular/commit/c17ba6143cbe1b7daa2f7caaf03f7ff8db746c5b
angular#18110https://github.com/angular/angular/pull/18110
086f4aahttps://github.com/mhevery/angular/commit/086f4aa72c8b7251f6e53db503b1793a4c9772fd
asnowwolfhttps://github.com/asnowwolf
Aug 11, 2017 https://github.com/angular/angular/pull/18110#ref-commit-49a7513
https://github.com/DzmitryShylovich
fix(router): child CanActivate guard should wait for parent to comple…https://github.com/asnowwolf/angular/commit/49a75138b77dba2cd6999e4a0289a0c18b12166b
49a7513https://github.com/asnowwolf/angular/commit/49a75138b77dba2cd6999e4a0289a0c18b12166b
angular#18110https://github.com/angular/angular/pull/18110
angular#15670https://github.com/angular/angular/issues/15670
angular#18110https://github.com/angular/angular/pull/18110
https://github.com/albv
albvhttps://github.com/albv
Aug 17, 2017 https://github.com/angular/angular/pull/18110#ref-issue-186267482
Allow CanActivate[Child] Guards to be "blocking" #12627 https://github.com/angular/angular/issues/12627
juleskremerhttps://github.com/juleskremer
Aug 26, 2017 https://github.com/angular/angular/pull/18110#ref-commit-0e6622e
https://github.com/DzmitryShylovich
https://github.com/juleskremer
fix(router): child CanActivate guard should wait for parent to comple…https://github.com/juleskremer/angular/commit/0e6622eee7458a42126dbf041945782d191b76b8
0e6622ehttps://github.com/juleskremer/angular/commit/0e6622eee7458a42126dbf041945782d191b76b8
angular#18110https://github.com/angular/angular/pull/18110
angular#15670https://github.com/angular/angular/issues/15670
angular#18110https://github.com/angular/angular/pull/18110
juleskremerhttps://github.com/juleskremer
Aug 28, 2017 https://github.com/angular/angular/pull/18110#ref-commit-50376d4
https://github.com/DzmitryShylovich
https://github.com/juleskremer
fix(router): child CanActivate guard should wait for parent to comple…https://github.com/juleskremer/angular/commit/50376d4a434e8d52082b1843cc52510aff80a734
50376d4https://github.com/juleskremer/angular/commit/50376d4a434e8d52082b1843cc52510aff80a734
angular#18110https://github.com/angular/angular/pull/18110
angular#15670https://github.com/angular/angular/issues/15670
angular#18110https://github.com/angular/angular/pull/18110
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18110#issuecomment-530658439
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/18110
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18110#event-2627807802
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18110
https://github.com/vicb
vicb https://github.com/vicb
https://github.com/angular/angular/pull/18110/files/f5d9f773cbd30f2d78e3e420925e8852b2da9839
Please reload this pagehttps://github.com/angular/angular/pull/18110
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
CanActivate guards on child routes run before parent CanActivate guards finish https://github.com/angular/angular/issues/15670
Please reload this pagehttps://github.com/angular/angular/pull/18110
https://github.com/jasonaden
https://github.com/googlebot
https://github.com/mary-poppins
https://github.com/vicb
https://github.com/mhevery
https://github.com/DzmitryShylovich
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.