| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:74479a83-46d0-0fa3-18f5-520ddb69fd1f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9776:269AD9:2122C3E:2C3DCB1:6B0184C4 |
| html-safe-nonce | 83db920726cfa8ef893b569dc4ea54e21ab20fdc1dcb7b7b18468c6868de8a56 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Nzc2OjI2OUFEOToyMTIyQzNFOjJDM0RDQjE6NkIwMTg0QzQiLCJ2aXNpdG9yX2lkIjoiMjA0MTgwNjYwNjU0MjQwNjg1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 269968ef66cbf949f920b0bc8c4dff3434072c019761e1a013043411c433699a |
| hovercard-subject-tag | pull_request:130352880 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/18095/files |
| twitter:image | https://avatars.githubusercontent.com/u/265378?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/265378?s=400&v=4 |
| og:image:alt | PR Type
What kind of change does this PR introduce?
[x] Bugfix
What is the current behavior?
We cannot use number values for cases of select ICUs even if the number is a string value: {gender, sel... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/18095/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18095%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18095%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/18095/files |
| Reload | https://github.com/angular/angular/pull/18095/files |
| Reload | https://github.com/angular/angular/pull/18095/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| ocombe | https://github.com/ocombe |
| angular:master | https://github.com/angular/angular/tree/master |
| ocombe:fix-icu-numbers | https://github.com/ocombe/angular/tree/fix-icu-numbers |
|
Conversation
6
| https://github.com/angular/angular/pull/18095 |
|
Commits
2
| https://github.com/angular/angular/pull/18095/commits |
|
Checks
0
| https://github.com/angular/angular/pull/18095/checks |
|
Files changed
| https://github.com/angular/angular/pull/18095/files |
| Please reload this page | https://github.com/angular/angular/pull/18095/files |
|
fix(compiler): allow numbers as ICU select cases
| https://github.com/angular/angular/pull/18095/files#top |
|
Show all changes
2 commits
| https://github.com/angular/angular/pull/18095/files |
|
3119a08
fix(compiler): allow numbers for ICU message cases in lexer
ocombe Jul 13, 2017
| https://github.com/angular/angular/pull/18095/commits/3119a0844c81cbd5c88300ef8894bc973bb19921 |
|
660f33a
Merge branch 'master' into fix-icu-numbers
mhevery Jul 20, 2017
| https://github.com/angular/angular/pull/18095/commits/660f33a1d9394cd16f5850041a61c3e59c789990 |
|
Clear filters
| https://github.com/angular/angular/pull/18095/files |
| Please reload this page | https://github.com/angular/angular/pull/18095/files |
| Please reload this page | https://github.com/angular/angular/pull/18095/files |
|
lexer.ts
| https://github.com/angular/angular/pull/18095/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645 |
|
integration_common.ts
| https://github.com/angular/angular/pull/18095/files#diff-49ffa50ab8e1d42c63f661b9e0f9b76025b9ab204dc6532d6213b311f35b5aca |
|
integration_xliff_spec.ts
| https://github.com/angular/angular/pull/18095/files#diff-5db13d1e17d2282e2cee8a748c417ca6f2fb5439f23c1e87b743dc61053ee88a |
|
integration_xmb_xtb_spec.ts
| https://github.com/angular/angular/pull/18095/files#diff-3237df44e0997d844c4e62c546e36bb33ab2a9d65b501fb5c33446ae14c71ecf |
|
html_parser_spec.ts
| https://github.com/angular/angular/pull/18095/files#diff-89a64880957c8a712e0279b8f561ce34f0aafe2f95553c3c114917c7785b95b4 |
| packages/compiler/src/ml_parser/lexer.ts | https://github.com/angular/angular/pull/18095/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645 |
|
View file
| https://github.com/ocombe/angular/blob/660f33a1d9394cd16f5850041a61c3e59c789990/packages/compiler/src/ml_parser/lexer.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/18095/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/18095/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645 |
|
| https://github.com/angular/angular/pull/18095/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645 |
| packages/compiler/test/i18n/integration_common.ts | https://github.com/angular/angular/pull/18095/files#diff-49ffa50ab8e1d42c63f661b9e0f9b76025b9ab204dc6532d6213b311f35b5aca |
|
View file
| https://github.com/ocombe/angular/blob/660f33a1d9394cd16f5850041a61c3e59c789990/packages/compiler/test/i18n/integration_common.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/18095/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/18095/files#diff-49ffa50ab8e1d42c63f661b9e0f9b76025b9ab204dc6532d6213b311f35b5aca |
|
| https://github.com/angular/angular/pull/18095/files#diff-49ffa50ab8e1d42c63f661b9e0f9b76025b9ab204dc6532d6213b311f35b5aca |
|
| https://github.com/angular/angular/pull/18095/files#diff-49ffa50ab8e1d42c63f661b9e0f9b76025b9ab204dc6532d6213b311f35b5aca |
|
| https://github.com/angular/angular/pull/18095/files#diff-49ffa50ab8e1d42c63f661b9e0f9b76025b9ab204dc6532d6213b311f35b5aca |
| packages/compiler/test/i18n/integration_xliff_spec.ts | https://github.com/angular/angular/pull/18095/files#diff-5db13d1e17d2282e2cee8a748c417ca6f2fb5439f23c1e87b743dc61053ee88a |
|
View file
| https://github.com/ocombe/angular/blob/660f33a1d9394cd16f5850041a61c3e59c789990/packages/compiler/test/i18n/integration_xliff_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/18095/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/18095/files#diff-5db13d1e17d2282e2cee8a748c417ca6f2fb5439f23c1e87b743dc61053ee88a |
|
| https://github.com/angular/angular/pull/18095/files#diff-5db13d1e17d2282e2cee8a748c417ca6f2fb5439f23c1e87b743dc61053ee88a |
|
| https://github.com/angular/angular/pull/18095/files#diff-5db13d1e17d2282e2cee8a748c417ca6f2fb5439f23c1e87b743dc61053ee88a |
|
| https://github.com/angular/angular/pull/18095/files#diff-5db13d1e17d2282e2cee8a748c417ca6f2fb5439f23c1e87b743dc61053ee88a |
|
| https://github.com/angular/angular/pull/18095/files#diff-5db13d1e17d2282e2cee8a748c417ca6f2fb5439f23c1e87b743dc61053ee88a |
| packages/compiler/test/i18n/integration_xmb_xtb_spec.ts | https://github.com/angular/angular/pull/18095/files#diff-3237df44e0997d844c4e62c546e36bb33ab2a9d65b501fb5c33446ae14c71ecf |
|
View file
| https://github.com/ocombe/angular/blob/660f33a1d9394cd16f5850041a61c3e59c789990/packages/compiler/test/i18n/integration_xmb_xtb_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/18095/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/18095/files#diff-3237df44e0997d844c4e62c546e36bb33ab2a9d65b501fb5c33446ae14c71ecf |
|
| https://github.com/angular/angular/pull/18095/files#diff-3237df44e0997d844c4e62c546e36bb33ab2a9d65b501fb5c33446ae14c71ecf |
|
| https://github.com/angular/angular/pull/18095/files#diff-3237df44e0997d844c4e62c546e36bb33ab2a9d65b501fb5c33446ae14c71ecf |
| packages/compiler/test/ml_parser/html_parser_spec.ts | https://github.com/angular/angular/pull/18095/files#diff-89a64880957c8a712e0279b8f561ce34f0aafe2f95553c3c114917c7785b95b4 |
|
View file
| https://github.com/ocombe/angular/blob/660f33a1d9394cd16f5850041a61c3e59c789990/packages/compiler/test/ml_parser/html_parser_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/18095/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/18095/files#diff-89a64880957c8a712e0279b8f561ce34f0aafe2f95553c3c114917c7785b95b4 |
|
| https://github.com/angular/angular/pull/18095/files#diff-89a64880957c8a712e0279b8f561ce34f0aafe2f95553c3c114917c7785b95b4 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |