René's URL Explorer Experiment


Title: fix(compiler): allow numbers as ICU select cases by ocombe · Pull Request #18095 · angular/angular · GitHub

Open Graph Title: fix(compiler): allow numbers as ICU select cases by ocombe · Pull Request #18095 · angular/angular

X Title: fix(compiler): allow numbers as ICU select cases by ocombe · Pull Request #18095 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? We cannot use number values for cases of select ICUs even if the number is a string value: {gender, sel...

X Description: PR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? We cannot use number values for cases of select ICUs even if the number is a string value: {gender, sel...

Opengraph URL: https://github.com/angular/angular/pull/18095

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dbb33354-e0c9-0fb1-c675-58f160c9f58a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD218:34DB8F:1D16DA1:26D855E:6B017253
html-safe-noncedc9aef5ad00ded44291c3f1697affaae9ecd7425044b62189a56d83230b25d9d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjE4OjM0REI4RjoxRDE2REExOjI2RDg1NUU6NkIwMTcyNTMiLCJ2aXNpdG9yX2lkIjoiMjM0OTg1MjkyNjcxMDczOTUzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9226772ea47bc2a3d00d1fea3081574a77c5385849ea013b99287ef05f36aa3f
hovercard-subject-tagpull_request:130352880
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/18095/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aa40a9a9f9e8e45be2d38502c7943398ff446aa468a40b6cf10320685914fe2f/angular/angular/pull/18095
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aa40a9a9f9e8e45be2d38502c7943398ff446aa468a40b6cf10320685914fe2f/angular/angular/pull/18095
og:image:altPR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? We cannot use number values for cases of select ICUs even if the number is a string value: {gender, sel...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameocombe
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/18095#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18095
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18095
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18095
Reloadhttps://github.com/angular/angular/pull/18095
Reloadhttps://github.com/angular/angular/pull/18095
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:fix-icu-numbershttps://github.com/ocombe/angular/tree/fix-icu-numbers
Conversationhttps://github.com/angular/angular/pull/18095
Commits2 (2)https://github.com/angular/angular/pull/18095/commits
Checkshttps://github.com/angular/angular/pull/18095/checks
Files changedhttps://github.com/angular/angular/pull/18095/files
fix(compiler): allow numbers as ICU select caseshttps://github.com/angular/angular/pull/18095#top
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:fix-icu-numbershttps://github.com/ocombe/angular/tree/fix-icu-numbers
https://github.com/ocombe
ocombehttps://github.com/ocombe
Jul 13, 2017https://github.com/angular/angular/pull/18095#issue-242677046
#17799https://github.com/angular/angular/issues/17799
Please reload this pagehttps://github.com/angular/angular/pull/18095
https://github.com/ocombe
ocombehttps://github.com/ocombe
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jul 13, 2017https://github.com/angular/angular/pull/18095#event-1162426951
https://github.com/ocombe
ocombehttps://github.com/ocombe
vicbhttps://github.com/vicb
July 13, 2017 11:59https://github.com/angular/angular/pull/18095#event-1162426961
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 13, 2017https://github.com/angular/angular/pull/18095#event-1162427035
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 18, 2017 https://github.com/angular/angular/pull/18095#pullrequestreview-50697153
View reviewed changes https://github.com/angular/angular/pull/18095/files
packages/compiler/test/i18n/integration_common.tshttps://github.com/angular/angular/pull/18095/files#diff-49ffa50ab8e1d42c63f661b9e0f9b76025b9ab204dc6532d6213b311f35b5aca
vicbhttps://github.com/vicb
Jul 18, 2017https://github.com/angular/angular/pull/18095#discussion_r128053352
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18095
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 18, 2017 https://github.com/angular/angular/pull/18095#pullrequestreview-50697663
View reviewed changes https://github.com/angular/angular/pull/18095/files
packages/compiler/test/ml_parser/html_parser_spec.tshttps://github.com/angular/angular/pull/18095/files#diff-89a64880957c8a712e0279b8f561ce34f0aafe2f95553c3c114917c7785b95b4
vicbhttps://github.com/vicb
Jul 18, 2017https://github.com/angular/angular/pull/18095#discussion_r128053798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18095
https://github.com/vicb
vicbhttps://github.com/vicb
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jul 18, 2017https://github.com/angular/angular/pull/18095#event-1168872362
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/38c44af1f9a78dadc380f59cdf3e677dd681e0ec..26193c8f82489f725a7a6ac1c6ce0b5083d8921e
38c44afhttps://github.com/angular/angular/commit/38c44af1f9a78dadc380f59cdf3e677dd681e0ec
26193c8https://github.com/angular/angular/commit/26193c8f82489f725a7a6ac1c6ce0b5083d8921e
Compare https://github.com/angular/angular/compare/38c44af1f9a78dadc380f59cdf3e677dd681e0ec..26193c8f82489f725a7a6ac1c6ce0b5083d8921e
July 19, 2017 08:33https://github.com/angular/angular/pull/18095#event-1169790990
https://github.com/angular
angularhttps://github.com/angular
mary-poppinshttps://github.com/mary-poppins
Jul 19, 2017https://github.com/angular/angular/pull/18095#event-1169791598
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 19, 2017https://github.com/angular/angular/pull/18095#issuecomment-316315774
https://pr18095-26193c8.ngbuilds.io/https://pr18095-26193c8.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/18095
https://github.com/vicb
vicbhttps://github.com/vicb
Jul 19, 2017 https://github.com/angular/angular/pull/18095#pullrequestreview-50968303
View reviewed changes https://github.com/angular/angular/pull/18095/files
https://github.com/vicb
vicbhttps://github.com/vicb
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Jul 19, 2017https://github.com/angular/angular/pull/18095#event-1170608406
https://github.com/ocombe
fix(compiler): allow numbers for ICU message cases in lexerhttps://github.com/angular/angular/pull/18095/commits/3119a0844c81cbd5c88300ef8894bc973bb19921
3119a08https://github.com/angular/angular/pull/18095/commits/3119a0844c81cbd5c88300ef8894bc973bb19921
angular#17799https://github.com/angular/angular/issues/17799
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/26193c8f82489f725a7a6ac1c6ce0b5083d8921e..3119a0844c81cbd5c88300ef8894bc973bb19921
26193c8https://github.com/angular/angular/commit/26193c8f82489f725a7a6ac1c6ce0b5083d8921e
3119a08https://github.com/angular/angular/commit/3119a0844c81cbd5c88300ef8894bc973bb19921
Compare https://github.com/angular/angular/compare/26193c8f82489f725a7a6ac1c6ce0b5083d8921e..3119a0844c81cbd5c88300ef8894bc973bb19921
July 19, 2017 16:49https://github.com/angular/angular/pull/18095#event-1170620348
https://github.com/mhevery
mheveryhttps://github.com/mhevery
force-pushedhttps://github.com/angular/angular/compare/08b36cb50d046cf0a00fcc07e88b35578ee89580..5d4b36f80f295455f4250c4257462b22ce6b3372
08b36cbhttps://github.com/angular/angular/commit/08b36cb50d046cf0a00fcc07e88b35578ee89580
5d4b36fhttps://github.com/angular/angular/commit/5d4b36f80f295455f4250c4257462b22ce6b3372
Compare https://github.com/angular/angular/compare/08b36cb50d046cf0a00fcc07e88b35578ee89580..5d4b36f80f295455f4250c4257462b22ce6b3372
July 20, 2017 21:49https://github.com/angular/angular/pull/18095#event-1172950411
https://github.com/mhevery
Merge branch 'master' into fix-icu-numbershttps://github.com/angular/angular/pull/18095/commits/660f33a1d9394cd16f5850041a61c3e59c789990
660f33ahttps://github.com/angular/angular/pull/18095/commits/660f33a1d9394cd16f5850041a61c3e59c789990
https://github.com/googlebot
googlebothttps://github.com/googlebot
Jul 20, 2017https://github.com/angular/angular/pull/18095#issuecomment-316850360
Please reload this pagehttps://github.com/angular/angular/pull/18095
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 20, 2017https://github.com/angular/angular/pull/18095#event-1173008045
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 20, 2017https://github.com/angular/angular/pull/18095#issuecomment-316854216
660f33ahttps://github.com/angular/angular/commit/660f33a1d9394cd16f5850041a61c3e59c789990
https://pr18095-660f33a.ngbuilds.io/https://pr18095-660f33a.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/18095
https://github.com/mhevery
mheveryhttps://github.com/mhevery
a3a5429https://github.com/angular/angular/commit/a3a54299afd41cc2049953c52ff869ef9c36fc37
Jul 20, 2017https://github.com/angular/angular/pull/18095#event-1173053705
https://github.com/ocombe
ocombehttps://github.com/ocombe
July 21, 2017 12:13https://github.com/angular/angular/pull/18095#event-1173765374
mheveryhttps://github.com/mhevery
Jul 26, 2017 https://github.com/angular/angular/pull/18095#ref-commit-a8ac77b
https://github.com/ocombe
https://github.com/mhevery
fix(compiler): allow numbers for ICU message cases in lexer (https://github.com/angular/angular/commit/a8ac77b645073fed4454e99f42ea792e7640703d
#18095https://github.com/angular/angular/pull/18095
)https://github.com/angular/angular/commit/a8ac77b645073fed4454e99f42ea792e7640703d
a8ac77bhttps://github.com/angular/angular/commit/a8ac77b645073fed4454e99f42ea792e7640703d
#18095https://github.com/angular/angular/pull/18095
#17799https://github.com/angular/angular/issues/17799
asnowwolfhttps://github.com/asnowwolf
Aug 11, 2017 https://github.com/angular/angular/pull/18095#ref-commit-8f6d51b
https://github.com/ocombe
fix(compiler): allow numbers for ICU message cases in lexer (https://github.com/asnowwolf/angular/commit/8f6d51b1098b4299c4199a1263d3df32778b8165
angular#…https://github.com/angular/angular/pull/18095
8f6d51bhttps://github.com/asnowwolf/angular/commit/8f6d51b1098b4299c4199a1263d3df32778b8165
…18095https://github.com/angular/angular/pull/18095
angular#18095https://github.com/angular/angular/pull/18095
angular#17799https://github.com/angular/angular/issues/17799
juleskremerhttps://github.com/juleskremer
Aug 26, 2017 https://github.com/angular/angular/pull/18095#ref-commit-cc01e90
https://github.com/ocombe
https://github.com/juleskremer
fix(compiler): allow numbers for ICU message cases in lexer (https://github.com/juleskremer/angular/commit/cc01e90f1db3398e619e7aafd90de890b58b4edc
angular#…https://github.com/angular/angular/pull/18095
cc01e90https://github.com/juleskremer/angular/commit/cc01e90f1db3398e619e7aafd90de890b58b4edc
…18095https://github.com/angular/angular/pull/18095
angular#18095https://github.com/angular/angular/pull/18095
angular#17799https://github.com/angular/angular/issues/17799
juleskremerhttps://github.com/juleskremer
Aug 28, 2017 https://github.com/angular/angular/pull/18095#ref-commit-0b6c969
https://github.com/ocombe
https://github.com/juleskremer
fix(compiler): allow numbers for ICU message cases in lexer (https://github.com/juleskremer/angular/commit/0b6c969bfc146e1d237e72222cbb0b2bbceacf82
angular#…https://github.com/angular/angular/pull/18095
0b6c969https://github.com/juleskremer/angular/commit/0b6c969bfc146e1d237e72222cbb0b2bbceacf82
…18095https://github.com/angular/angular/pull/18095
angular#18095https://github.com/angular/angular/pull/18095
angular#17799https://github.com/angular/angular/issues/17799
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18095#issuecomment-530648091
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/18095
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18095#event-2627734374
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18095
https://github.com/vicb
vicb https://github.com/vicb
https://github.com/angular/angular/pull/18095/files/26193c8f82489f725a7a6ac1c6ce0b5083d8921e
Please reload this pagehttps://github.com/angular/angular/pull/18095
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Please reload this pagehttps://github.com/angular/angular/pull/18095
https://github.com/ocombe
https://github.com/mary-poppins
https://github.com/googlebot
https://github.com/vicb
https://github.com/mhevery
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.