| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:0fd2a6bf-395c-9261-b4d3-4ddd30d05a88 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECD4:6DC60:1A77542:2152777:6B01825C |
| html-safe-nonce | a92b119afb5092061519d3fe47370ca69cea6dad34fa5086c3e1729b540e081e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0Q0OjZEQzYwOjFBNzc1NDI6MjE1Mjc3Nzo2QjAxODI1QyIsInZpc2l0b3JfaWQiOiIzMTM4NjYxNTM5MzQ3NzkyNDc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5526ee37be14f6da9ebff8179a7811ef5c28d836625a868c03714178d6e7c682 |
| hovercard-subject-tag | pull_request:126581573 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/17638/commits |
| twitter:image | https://opengraph.githubassets.com/7b50e5b72e4753260c774a67374f0c39b2670880764c29da5ae2b4310ca65052/angular/angular/pull/17638 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7b50e5b72e4753260c774a67374f0c39b2670880764c29da5ae2b4310ca65052/angular/angular/pull/17638 |
| og:image:alt | Please check if the PR fulfills these requirements
Tests for the changes have been added
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
See #15573.
What is t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ocombe |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/17638/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F17638%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F17638%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/17638/commits |
| Reload | https://github.com/angular/angular/pull/17638/commits |
| Reload | https://github.com/angular/angular/pull/17638/commits |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| ocombe | https://github.com/ocombe |
| angular:master | https://github.com/angular/angular/tree/master |
| ocombe:i18n-version | https://github.com/ocombe/angular/tree/i18n-version |
| Conversation | https://github.com/angular/angular/pull/17638 |
| Commits15 (15) | https://github.com/angular/angular/pull/17638/commits |
| Checks | https://github.com/angular/angular/pull/17638/checks |
| Files changed | https://github.com/angular/angular/pull/17638/files |
| fix(compiler): fix i18n IDs generation, add a migration tool | https://github.com/angular/angular/pull/17638/commits#top |
| ocombe | https://github.com/ocombe |
| angular:master | https://github.com/angular/angular/tree/master |
| ocombe:i18n-version | https://github.com/ocombe/angular/tree/i18n-version |
| refactor(compiler): add a version to the i18n serializers | https://github.com/angular/angular/pull/17638/commits/12d930c9548104a9808280d78cb7e7aea8a98324 |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| 12d930c | https://github.com/angular/angular/pull/17638/commits/12d930c9548104a9808280d78cb7e7aea8a98324 |
| https://github.com/angular/angular/tree/12d930c9548104a9808280d78cb7e7aea8a98324 |
| test(compiler): add tests for i18n serializers V1 | https://github.com/angular/angular/pull/17638/commits/a3c6a25e18ed4423239e36963eda170eb82a1e21 |
| vicb | https://github.com/angular/angular/commits?author=vicb |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| a3c6a25 | https://github.com/angular/angular/pull/17638/commits/a3c6a25e18ed4423239e36963eda170eb82a1e21 |
| https://github.com/angular/angular/tree/a3c6a25e18ed4423239e36963eda170eb82a1e21 |
| refactor(compiler): add a version parameter for i18n extraction | https://github.com/angular/angular/pull/17638/commits/ed6b3064f508999606b83c594884abbb2102fb06 |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| ed6b306 | https://github.com/angular/angular/pull/17638/commits/ed6b3064f508999606b83c594884abbb2102fb06 |
| https://github.com/angular/angular/tree/ed6b3064f508999606b83c594884abbb2102fb06 |
| test(compiler): add integration tests for extraction | https://github.com/angular/angular/pull/17638/commits/2f07c4a3f69a1e1b876bbffd5cdf82bd9532c50f |
| vicb | https://github.com/angular/angular/commits?author=vicb |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| 2f07c4a | https://github.com/angular/angular/pull/17638/commits/2f07c4a3f69a1e1b876bbffd5cdf82bd9532c50f |
| https://github.com/angular/angular/tree/2f07c4a3f69a1e1b876bbffd5cdf82bd9532c50f |
| refactor(compiler): misc i18n refactoring | https://github.com/angular/angular/pull/17638/commits/8ac8b826fad0c7ed671cec4e5dc3f78f6e55ae9f |
| vicb | https://github.com/angular/angular/commits?author=vicb |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| 8ac8b82 | https://github.com/angular/angular/pull/17638/commits/8ac8b826fad0c7ed671cec4e5dc3f78f6e55ae9f |
| https://github.com/angular/angular/tree/8ac8b826fad0c7ed671cec4e5dc3f78f6e55ae9f |
| feat(compiler): generate a mapping from i18n v1 id to v0 ids | https://github.com/angular/angular/pull/17638/commits/6a4960a1942b0e870c4857c9764642af6677a51e |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| 6a4960a | https://github.com/angular/angular/pull/17638/commits/6a4960a1942b0e870c4857c9764642af6677a51e |
| https://github.com/angular/angular/tree/6a4960a1942b0e870c4857c9764642af6677a51e |
| feat(compiler): add an `@internal` function to return the message content by Id | https://github.com/angular/angular/pull/17638/commits/f9e9d51833145af3e430701af68faa4d5df0a486 |
| vicb | https://github.com/angular/angular/commits?author=vicb |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| f9e9d51 | https://github.com/angular/angular/pull/17638/commits/f9e9d51833145af3e430701af68faa4d5df0a486 |
| https://github.com/angular/angular/tree/f9e9d51833145af3e430701af68faa4d5df0a486 |
| feat(compiler): compute i18n conflicts | https://github.com/angular/angular/pull/17638/commits/d297238f79509046a4558ffaf1537595e34d2a2c |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| d297238 | https://github.com/angular/angular/pull/17638/commits/d297238f79509046a4558ffaf1537595e34d2a2c |
| https://github.com/angular/angular/tree/d297238f79509046a4558ffaf1537595e34d2a2c |
| refactor(compiler): ApplyMapping - to finish | https://github.com/angular/angular/pull/17638/commits/c5723711994ab010637d1cf03e2a8d5588d8c2a2 |
| vicb | https://github.com/angular/angular/commits?author=vicb |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| c572371 | https://github.com/angular/angular/pull/17638/commits/c5723711994ab010637d1cf03e2a8d5588d8c2a2 |
| https://github.com/angular/angular/tree/c5723711994ab010637d1cf03e2a8d5588d8c2a2 |
| feat(compiler): resolve i18n migration conflicts | https://github.com/angular/angular/pull/17638/commits/e3120af22390014ed8d4c925ba7d85675ab52367 |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| e3120af | https://github.com/angular/angular/pull/17638/commits/e3120af22390014ed8d4c925ba7d85675ab52367 |
| https://github.com/angular/angular/tree/e3120af22390014ed8d4c925ba7d85675ab52367 |
| feat(compiler-cli): create a `migrate_i18n_0to1` script | https://github.com/angular/angular/pull/17638/commits/e4d71845f77af27172fea34fa7d5cb50249ee3ee |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| e4d7184 | https://github.com/angular/angular/pull/17638/commits/e4d71845f77af27172fea34fa7d5cb50249ee3ee |
| https://github.com/angular/angular/tree/e4d71845f77af27172fea34fa7d5cb50249ee3ee |
| feat(compiler-cli): add ngtools_api entry for the migration script | https://github.com/angular/angular/pull/17638/commits/acce4cb9dec72be93e6cb4d89b04faf110910362 |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| acce4cb | https://github.com/angular/angular/pull/17638/commits/acce4cb9dec72be93e6cb4d89b04faf110910362 |
| https://github.com/angular/angular/tree/acce4cb9dec72be93e6cb4d89b04faf110910362 |
| feat(core): adding I18N_VERSION token for jit compiler | https://github.com/angular/angular/pull/17638/commits/0d9a67a441478835ba156bcebb5456053d14ac5d |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| 0d9a67a | https://github.com/angular/angular/pull/17638/commits/0d9a67a441478835ba156bcebb5456053d14ac5d |
| https://github.com/angular/angular/tree/0d9a67a441478835ba156bcebb5456053d14ac5d |
| feat(compiler-cli): adding i18nVersion to ngc | https://github.com/angular/angular/pull/17638/commits/0f842fd9364e48b020dd4516eca3102aa82d5fa1 |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| 0f842fd | https://github.com/angular/angular/pull/17638/commits/0f842fd9364e48b020dd4516eca3102aa82d5fa1 |
| https://github.com/angular/angular/tree/0f842fd9364e48b020dd4516eca3102aa82d5fa1 |
| feat(compiler-cli): adding mapping option for migration tool | https://github.com/angular/angular/pull/17638/commits/ccb2ae96e17d9d5b7373f4a1337236f1836b80ef |
| https://github.com/ocombe |
| ocombe | https://github.com/angular/angular/commits?author=ocombe |
| ccb2ae9 | https://github.com/angular/angular/pull/17638/commits/ccb2ae96e17d9d5b7373f4a1337236f1836b80ef |
| https://github.com/angular/angular/tree/ccb2ae96e17d9d5b7373f4a1337236f1836b80ef |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |