| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:46ab67fe-2f84-e574-00a3-28d53cd46924 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 95F6:154D88:1590838:1B816CE:6B01724F |
| html-safe-nonce | fc9d1d678fe900d9f492ebd38f70d25f813c43063eb11bf3bcf736c0cdfcc9fe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUY2OjE1NEQ4ODoxNTkwODM4OjFCODE2Q0U6NkIwMTcyNEYiLCJ2aXNpdG9yX2lkIjoiOTE4MzcxMTk3NTYzMTMxOTYzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1eabdacd27059423b54fd9d4a596dbd79572a206fe89293ee473153e0886fae6 |
| hovercard-subject-tag | pull_request:126581573 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/17638/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7b50e5b72e4753260c774a67374f0c39b2670880764c29da5ae2b4310ca65052/angular/angular/pull/17638 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7b50e5b72e4753260c774a67374f0c39b2670880764c29da5ae2b4310ca65052/angular/angular/pull/17638 |
| og:image:alt | Please check if the PR fulfills these requirements
Tests for the changes have been added
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
See #15573.
What is t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ocombe |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/17638#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F17638 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F17638 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/17638 |
| Reload | https://github.com/angular/angular/pull/17638 |
| Reload | https://github.com/angular/angular/pull/17638 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| ocombe | https://github.com/ocombe |
| angular:master | https://github.com/angular/angular/tree/master |
| ocombe:i18n-version | https://github.com/ocombe/angular/tree/i18n-version |
| Conversation | https://github.com/angular/angular/pull/17638 |
| Commits15 (15) | https://github.com/angular/angular/pull/17638/commits |
| Checks | https://github.com/angular/angular/pull/17638/checks |
| Files changed | https://github.com/angular/angular/pull/17638/files |
| fix(compiler): fix i18n IDs generation, add a migration tool | https://github.com/angular/angular/pull/17638#top |
| ocombe | https://github.com/ocombe |
| angular:master | https://github.com/angular/angular/tree/master |
| ocombe:i18n-version | https://github.com/ocombe/angular/tree/i18n-version |
|
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Jun 20, 2017 | https://github.com/angular/angular/pull/17638#issue-237278296 |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| #15573 | https://github.com/angular/angular/issues/15573 |
| #15573 | https://github.com/angular/angular/issues/15573 |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Jun 20, 2017 | https://github.com/angular/angular/pull/17638#event-1131403574 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| vicb | https://github.com/vicb |
| June 20, 2017 16:54 | https://github.com/angular/angular/pull/17638#event-1131403582 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Jun 20, 2017 | https://github.com/angular/angular/pull/17638#event-1131403702 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
|
Jun 20, 2017
| https://github.com/angular/angular/pull/17638#ref-pullrequest-218214763 |
|
fix(compiler): fix i18n IDs generation, add a migration tool
#15621
| https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45842063 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/src/i18n_options.ts | https://github.com/angular/angular/pull/17638/files#diff-0f75f9a5246a3328ba1d57d0ee620da16f3b4e813865d58f6935960983a4a47a |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123618851 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45842244 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123619028 |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45843075 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123619808 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| ocombe | https://github.com/ocombe |
| Jun 23, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123695187 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45843453 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123620163 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| ocombe | https://github.com/ocombe |
| Jun 23, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123695301 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| vicb | https://github.com/vicb |
| Jun 27, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124162634 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45843632 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/test/i18n/migration/v0_to_v1_spec.ts | https://github.com/angular/angular/pull/17638/files#diff-11a67553c0976d69c72c0ea4e59fff91aa652209bac8c6cf1b3e988185b89efc |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123620335 |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45843897 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/test/i18n/migration/v0_to_v1_spec.ts | https://github.com/angular/angular/pull/17638/files#diff-11a67553c0976d69c72c0ea4e59fff91aa652209bac8c6cf1b3e988185b89efc |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123620577 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45845939 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/integrationtest/tsconfig-xi18n.json | https://github.com/angular/angular/pull/17638/files#diff-081e11c955c1910b99cf2b4638a4eb2db52e75798745e9b016614d4e340ba29a |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123622387 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| ocombe | https://github.com/ocombe |
| Jun 23, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123694957 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @tbosch | https://github.com/tbosch |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| vicb | https://github.com/vicb |
| Jun 26, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124144962 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45846247 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/src/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-c72de2847f2d0834b0846425c54ef4702dec5064b975850fe26bb0d1f46f7e59 |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123622681 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45846512 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123622917 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 22, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-45846676 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 22, 2017 | https://github.com/angular/angular/pull/17638#discussion_r123623051 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 26, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46407954 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/src/i18n_options.ts | https://github.com/angular/angular/pull/17638/files#diff-0f75f9a5246a3328ba1d57d0ee620da16f3b4e813865d58f6935960983a4a47a |
| vicb | https://github.com/vicb |
| Jun 26, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124143793 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 26, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46407970 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/src/i18n_options.ts | https://github.com/angular/angular/pull/17638/files#diff-0f75f9a5246a3328ba1d57d0ee620da16f3b4e813865d58f6935960983a4a47a |
| vicb | https://github.com/vicb |
| Jun 26, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124143807 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 26, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46407991 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/src/i18n_options.ts | https://github.com/angular/angular/pull/17638/files#diff-0f75f9a5246a3328ba1d57d0ee620da16f3b4e813865d58f6935960983a4a47a |
| vicb | https://github.com/vicb |
| Jun 26, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124143833 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 26, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46408011 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/src/i18n_options.ts | https://github.com/angular/angular/pull/17638/files#diff-0f75f9a5246a3328ba1d57d0ee620da16f3b4e813865d58f6935960983a4a47a |
| vicb | https://github.com/vicb |
| Jun 26, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124143849 |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 26, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46409156 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/integrationtest/src/mapping_v1_to_v0.json | https://github.com/angular/angular/pull/17638/files#diff-cac3f9e67d819a36afb7de79bb4bad62c660bf0dceee84985775a6abc1c842a6 |
| vicb | https://github.com/vicb |
| Jun 26, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124144906 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 26, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46409345 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/src/i18n_options.ts | https://github.com/angular/angular/pull/17638/files#diff-0f75f9a5246a3328ba1d57d0ee620da16f3b4e813865d58f6935960983a4a47a |
| vicb | https://github.com/vicb |
| Jun 26, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124145082 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 26, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46409581 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler-cli/src/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-c72de2847f2d0834b0846425c54ef4702dec5064b975850fe26bb0d1f46f7e59 |
| vicb | https://github.com/vicb |
| Jun 26, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124145310 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 27, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46428026 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 27, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124162857 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 27, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46428169 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 27, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124162998 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 27, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46428291 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 27, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124163131 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 27, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46428306 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 27, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124163149 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 27, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46428370 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 27, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124163218 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| vicb | https://github.com/vicb |
| Jun 27, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124164337 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 27, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46428972 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 27, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124163775 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| ocombe | https://github.com/ocombe |
| Jun 30, 2017 | https://github.com/angular/angular/pull/17638#discussion_r125050460 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 27, 2017
| https://github.com/angular/angular/pull/17638#pullrequestreview-46429336 |
|
View reviewed changes
| https://github.com/angular/angular/pull/17638/files |
| packages/compiler/src/i18n/migration/v0_to_v1.ts | https://github.com/angular/angular/pull/17638/files#diff-26acd021025c913aced0645e46f7e1ffba35b1625cdb3d341ddbe6adf32e4ba8 |
| vicb | https://github.com/vicb |
| Jun 27, 2017 | https://github.com/angular/angular/pull/17638#discussion_r124164105 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Jun 30, 2017 | https://github.com/angular/angular/pull/17638#issuecomment-312312116 |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jun 30, 2017 | https://github.com/angular/angular/pull/17638#issuecomment-312314742 |
| https://pr17638-6409883.ngbuilds.io/ | https://pr17638-6409883.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
|
Jun 30, 2017
| https://github.com/angular/angular/pull/17638#ref-issue-239830903 |
|
MessageSpan contain the same value for startCol & endCol
#17881
| https://github.com/angular/angular/issues/17881 |
| https://github.com/angular |
| angular | https://github.com/angular |
| mary-poppins | https://github.com/mary-poppins |
| Jun 30, 2017 | https://github.com/angular/angular/pull/17638#event-1146287362 |
| ocombe | https://github.com/ocombe |
| July 17, 2017 11:09 | https://github.com/angular/angular/pull/17638#commits-pushed-12d930c |
|
| https://github.com/ocombe |
| refactor(compiler): add a version to the i18n serializers | https://github.com/angular/angular/pull/17638/commits/12d930c9548104a9808280d78cb7e7aea8a98324 |
| 12d930c | https://github.com/angular/angular/pull/17638/commits/12d930c9548104a9808280d78cb7e7aea8a98324 |
| angular#15573 | https://github.com/angular/angular/issues/15573 |
|
| https://github.com/vicb |
|
| https://github.com/ocombe |
| test(compiler): add tests for i18n serializers V1 | https://github.com/angular/angular/pull/17638/commits/a3c6a25e18ed4423239e36963eda170eb82a1e21 |
| a3c6a25 | https://github.com/angular/angular/pull/17638/commits/a3c6a25e18ed4423239e36963eda170eb82a1e21 |
|
| https://github.com/ocombe |
| refactor(compiler): add a version parameter for i18n extraction | https://github.com/angular/angular/pull/17638/commits/ed6b3064f508999606b83c594884abbb2102fb06 |
| ed6b306 | https://github.com/angular/angular/pull/17638/commits/ed6b3064f508999606b83c594884abbb2102fb06 |
|
| https://github.com/vicb |
|
| https://github.com/ocombe |
| test(compiler): add integration tests for extraction | https://github.com/angular/angular/pull/17638/commits/2f07c4a3f69a1e1b876bbffd5cdf82bd9532c50f |
| 2f07c4a | https://github.com/angular/angular/pull/17638/commits/2f07c4a3f69a1e1b876bbffd5cdf82bd9532c50f |
|
| https://github.com/vicb |
|
| https://github.com/ocombe |
| refactor(compiler): misc i18n refactoring | https://github.com/angular/angular/pull/17638/commits/8ac8b826fad0c7ed671cec4e5dc3f78f6e55ae9f |
| 8ac8b82 | https://github.com/angular/angular/pull/17638/commits/8ac8b826fad0c7ed671cec4e5dc3f78f6e55ae9f |
|
| https://github.com/ocombe |
| feat(compiler): generate a mapping from i18n v1 id to v0 ids | https://github.com/angular/angular/pull/17638/commits/6a4960a1942b0e870c4857c9764642af6677a51e |
| 6a4960a | https://github.com/angular/angular/pull/17638/commits/6a4960a1942b0e870c4857c9764642af6677a51e |
|
| https://github.com/vicb |
|
| https://github.com/ocombe |
| feat(compiler): add an @internal function to return the message con… | https://github.com/angular/angular/pull/17638/commits/f9e9d51833145af3e430701af68faa4d5df0a486 |
| f9e9d51 | https://github.com/angular/angular/pull/17638/commits/f9e9d51833145af3e430701af68faa4d5df0a486 |
|
| https://github.com/ocombe |
| feat(compiler): compute i18n conflicts | https://github.com/angular/angular/pull/17638/commits/d297238f79509046a4558ffaf1537595e34d2a2c |
| d297238 | https://github.com/angular/angular/pull/17638/commits/d297238f79509046a4558ffaf1537595e34d2a2c |
|
| https://github.com/vicb |
|
| https://github.com/ocombe |
| refactor(compiler): ApplyMapping - to finish | https://github.com/angular/angular/pull/17638/commits/c5723711994ab010637d1cf03e2a8d5588d8c2a2 |
| c572371 | https://github.com/angular/angular/pull/17638/commits/c5723711994ab010637d1cf03e2a8d5588d8c2a2 |
|
| https://github.com/ocombe |
| feat(compiler): resolve i18n migration conflicts | https://github.com/angular/angular/pull/17638/commits/e3120af22390014ed8d4c925ba7d85675ab52367 |
| e3120af | https://github.com/angular/angular/pull/17638/commits/e3120af22390014ed8d4c925ba7d85675ab52367 |
|
| https://github.com/ocombe |
| feat(compiler-cli): create a migrate_i18n_0to1 script | https://github.com/angular/angular/pull/17638/commits/e4d71845f77af27172fea34fa7d5cb50249ee3ee |
| e4d7184 | https://github.com/angular/angular/pull/17638/commits/e4d71845f77af27172fea34fa7d5cb50249ee3ee |
|
| https://github.com/ocombe |
| feat(compiler-cli): add ngtools_api entry for the migration script | https://github.com/angular/angular/pull/17638/commits/acce4cb9dec72be93e6cb4d89b04faf110910362 |
| acce4cb | https://github.com/angular/angular/pull/17638/commits/acce4cb9dec72be93e6cb4d89b04faf110910362 |
|
| https://github.com/ocombe |
| feat(core): adding I18N_VERSION token for jit compiler | https://github.com/angular/angular/pull/17638/commits/0d9a67a441478835ba156bcebb5456053d14ac5d |
| 0d9a67a | https://github.com/angular/angular/pull/17638/commits/0d9a67a441478835ba156bcebb5456053d14ac5d |
|
| https://github.com/ocombe |
| feat(compiler-cli): adding i18nVersion to ngc | https://github.com/angular/angular/pull/17638/commits/0f842fd9364e48b020dd4516eca3102aa82d5fa1 |
| 0f842fd | https://github.com/angular/angular/pull/17638/commits/0f842fd9364e48b020dd4516eca3102aa82d5fa1 |
|
| https://github.com/ocombe |
| feat(compiler-cli): adding mapping option for migration tool | https://github.com/angular/angular/pull/17638/commits/ccb2ae96e17d9d5b7373f4a1337236f1836b80ef |
| ccb2ae9 | https://github.com/angular/angular/pull/17638/commits/ccb2ae96e17d9d5b7373f4a1337236f1836b80ef |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/6409883fe40fc9dcb82544990db8a9eb077698d6..9d366bb4fc408a4329bba7fb4daea3818c46bd65 |
| 6409883 | https://github.com/angular/angular/commit/6409883fe40fc9dcb82544990db8a9eb077698d6 |
| 9d366bb | https://github.com/angular/angular/commit/9d366bb4fc408a4329bba7fb4daea3818c46bd65 |
|
Compare
| https://github.com/angular/angular/compare/6409883fe40fc9dcb82544990db8a9eb077698d6..9d366bb4fc408a4329bba7fb4daea3818c46bd65 |
| July 17, 2017 09:24 | https://github.com/angular/angular/pull/17638#event-1166099098 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 17, 2017 | https://github.com/angular/angular/pull/17638#issuecomment-315708619 |
| https://pr17638-9d366bb.ngbuilds.io/ | https://pr17638-9d366bb.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/08b36cb50d046cf0a00fcc07e88b35578ee89580..5d4b36f80f295455f4250c4257462b22ce6b3372 |
| 08b36cb | https://github.com/angular/angular/commit/08b36cb50d046cf0a00fcc07e88b35578ee89580 |
| 5d4b36f | https://github.com/angular/angular/commit/5d4b36f80f295455f4250c4257462b22ce6b3372 |
|
Compare
| https://github.com/angular/angular/compare/08b36cb50d046cf0a00fcc07e88b35578ee89580..5d4b36f80f295455f4250c4257462b22ce6b3372 |
| July 20, 2017 21:49 | https://github.com/angular/angular/pull/17638#event-1172950083 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/a3bb636b36a75b8dc8a0ca519eb6a6d8868ffd83..ccb2ae96e17d9d5b7373f4a1337236f1836b80ef |
| a3bb636 | https://github.com/angular/angular/commit/a3bb636b36a75b8dc8a0ca519eb6a6d8868ffd83 |
| ccb2ae9 | https://github.com/angular/angular/commit/ccb2ae96e17d9d5b7373f4a1337236f1836b80ef |
|
Compare
| https://github.com/angular/angular/compare/a3bb636b36a75b8dc8a0ca519eb6a6d8868ffd83..ccb2ae96e17d9d5b7373f4a1337236f1836b80ef |
| July 26, 2017 18:06 | https://github.com/angular/angular/pull/17638#event-1180396348 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
| Sep 7, 2017 | https://github.com/angular/angular/pull/17638#event-1239541912 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Nov 3, 2017 | https://github.com/angular/angular/pull/17638#issuecomment-341647999 |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Nov 3, 2017 | https://github.com/angular/angular/pull/17638#event-1324469585 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 12, 2019 | https://github.com/angular/angular/pull/17638#issuecomment-530979881 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 12, 2019 | https://github.com/angular/angular/pull/17638#event-2630371871 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F17638 |
|
| https://github.com/vicb |
|
vicb
| https://github.com/vicb |
|
| https://github.com/angular/angular/pull/17638/files/bbc30206e1a11c458b26158b01f931ed8b03d110 |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
| Please reload this page | https://github.com/angular/angular/pull/17638 |
|
| https://github.com/ocombe |
|
| https://github.com/googlebot |
|
| https://github.com/mary-poppins |
|
| https://github.com/vicb |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |