René's URL Explorer Experiment


Title: fix(compiler-cli): add fallback to xlf format to extractor by denyo · Pull Request #16338 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): add fallback to xlf format to extractor by denyo · Pull Request #16338 · angular/angular

X Title: fix(compiler-cli): add fallback to xlf format to extractor by denyo · Pull Request #16338 · angular/angular

Description: What kind of change does this PR introduce? [x] Bugfix What is the current behavior? Running ./node_modules/.bin/ng-xi18n to extract messages without the --i18nFormat parameter results in TypeError: Cannot read property 'toLowerCase' of null at Extractor.serialize (/.../node_modules/@angular/compiler-cli/src/extractor.js:46:32) at /.../node_modules/@angular/compiler-cli/src/extractor.js:32:33 at process._tickCallback (internal/process/next_tick.js:109:7) at Module.runMain (module.js:606:11) at run (bootstrap_node.js:393:7) at startup (bootstrap_node.js:150:9) at bootstrap_node.js:508:3 Extraction failed What is the new behavior? Running ./node_modules/.bin/ng-xi18n without a format works because it falls back to a default format of xlf as described in the Cookbook here: https://angular.io/docs/ts/latest/cookbook/i18n.html#!#ng-xi18n Does this PR introduce a breaking change? [x] No

Open Graph Description: What kind of change does this PR introduce? [x] Bugfix What is the current behavior? Running ./node_modules/.bin/ng-xi18n to extract messages without the --i18nFormat parameter results in TypeErro...

X Description: What kind of change does this PR introduce? [x] Bugfix What is the current behavior? Running ./node_modules/.bin/ng-xi18n to extract messages without the --i18nFormat parameter results in TypeErro...

Opengraph URL: https://github.com/angular/angular/pull/16338

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2d2f57eb-3331-c35e-7490-9cc90c35dc15
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id872E:EAD6D:1765736:1D49F94:6B0272EB
html-safe-noncec1e81e16fbd87bd34447e8ef0a82f15550f93ad75ae1704ae63b8458512cc6ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzJFOkVBRDZEOjE3NjU3MzY6MUQ0OUY5NDo2QjAyNzJFQiIsInZpc2l0b3JfaWQiOiI4MTYyOTc0OTM1NzM2ODA4MTcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2d0ab4c1c5799570fc5c762fb84c53705ca3620bd0efcf10f43e4eceb8e93e28
hovercard-subject-tagpull_request:117666200
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/16338/files
twitter:imagehttps://avatars.githubusercontent.com/u/4380295?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4380295?s=400&v=4
og:image:altWhat kind of change does this PR introduce? [x] Bugfix What is the current behavior? Running ./node_modules/.bin/ng-xi18n to extract messages without the --i18nFormat parameter results in TypeErro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/16338/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F16338%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F16338%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/16338/files
Reloadhttps://github.com/angular/angular/pull/16338/files
Reloadhttps://github.com/angular/angular/pull/16338/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
denyohttps://github.com/denyo
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 4 https://github.com/angular/angular/pull/16338
Commits 2 https://github.com/angular/angular/pull/16338/commits
Checks 0 https://github.com/angular/angular/pull/16338/checks
Files changed https://github.com/angular/angular/pull/16338/files
Please reload this pagehttps://github.com/angular/angular/pull/16338/files
fix(compiler-cli): add fallback to xlf format to extractor https://github.com/angular/angular/pull/16338/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/16338/files
1de4d5d fix(compiler-cli): add fallback to xlf format to extractor denyo Apr 26, 2017 https://github.com/angular/angular/pull/16338/commits/1de4d5d10877606ebb2d275b4e45789a82b5da5c
de7276e fix(compiler-cli): set xlf as default in I18nExtractionCliOptions denyo Apr 27, 2017 https://github.com/angular/angular/pull/16338/commits/de7276eacadd6f1f64c5048cf242fbcd25db8c2e
Clear filters https://github.com/angular/angular/pull/16338/files
Please reload this pagehttps://github.com/angular/angular/pull/16338/files
Please reload this pagehttps://github.com/angular/angular/pull/16338/files
offline_compiler_test.sh https://github.com/angular/angular/pull/16338/files#diff-18052478ecd6962b3b0dfca5ce3d81d53dcf894c40d17981ce88c40c5be7a14f
cli_options.ts https://github.com/angular/angular/pull/16338/files#diff-85cd3f3a5944817158e1294646e32127c162a28608d9e0d905e0f99574feb3c7
scripts/ci/offline_compiler_test.shhttps://github.com/angular/angular/pull/16338/files#diff-18052478ecd6962b3b0dfca5ce3d81d53dcf894c40d17981ce88c40c5be7a14f
View file https://github.com/angular/angular/blob/de7276eacadd6f1f64c5048cf242fbcd25db8c2e/scripts/ci/offline_compiler_test.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/16338/{{ revealButtonHref }}
https://github.com/angular/angular/pull/16338/files#diff-18052478ecd6962b3b0dfca5ce3d81d53dcf894c40d17981ce88c40c5be7a14f
https://github.com/angular/angular/pull/16338/files#diff-18052478ecd6962b3b0dfca5ce3d81d53dcf894c40d17981ce88c40c5be7a14f
tools/@angular/tsc-wrapped/src/cli_options.tshttps://github.com/angular/angular/pull/16338/files#diff-85cd3f3a5944817158e1294646e32127c162a28608d9e0d905e0f99574feb3c7
View file https://github.com/angular/angular/blob/de7276eacadd6f1f64c5048cf242fbcd25db8c2e/tools/%40angular/tsc-wrapped/src/cli_options.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/16338/{{ revealButtonHref }}
https://github.com/angular/angular/pull/16338/files#diff-85cd3f3a5944817158e1294646e32127c162a28608d9e0d905e0f99574feb3c7
https://github.com/angular/angular/pull/16338/files#diff-85cd3f3a5944817158e1294646e32127c162a28608d9e0d905e0f99574feb3c7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.