René's URL Explorer Experiment


Title: fix(compiler): Don't strip `/*# sourceURL ... */` by asnowwolf · Pull Request #16088 · angular/angular · GitHub

Open Graph Title: fix(compiler): Don't strip `/*# sourceURL ... */` by asnowwolf · Pull Request #16088 · angular/angular

X Title: fix(compiler): Don't strip `/*# sourceURL ... */` by asnowwolf · Pull Request #16088 · angular/angular

Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) What kind of change does this PR introduce? (check one with "x") Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Other... Please describe: What is the current behavior? (You can also link to an open issue here) Currently, shimCssText only keep /*# sourceMappingUrl ... */ comments and strip /*# sourceURL ... */ comments. So, Chrome can't find the source maps for component style(that's created in new style tags) What is the new behavior? Don't strip /*# sourceURL ...*/ comments. Chrome will find source maps for component styles properly. Does this PR introduce a breaking change? (check one with "x") Yes No If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... Other information:

Open Graph Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have bee...

X Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have bee...

Opengraph URL: https://github.com/angular/angular/pull/16088

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:152d4976-4276-c21a-1ce1-dd681b727add
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F66:293912:6EC22F:915F06:6B024D5C
html-safe-nonced0209ada60ffc2287d23249b54569244baea982f49fd7ebbacb0ae59c3bfaec3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjY2OjI5MzkxMjo2RUMyMkY6OTE1RjA2OjZCMDI0RDVDIiwidmlzaXRvcl9pZCI6IjE5NDY0MTEyNzY5MDk1NjMyMjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac659f0e08d8b42496ded6bde97ed7e0c85c29d4714d6a8a9a09419f929416faaa
hovercard-subject-tagpull_request:116342281
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/16088/files
twitter:imagehttps://avatars.githubusercontent.com/u/1446119?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1446119?s=400&v=4
og:image:altPlease check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have bee...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/16088/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F16088%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F16088%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/16088/files
Reloadhttps://github.com/angular/angular/pull/16088/files
Reloadhttps://github.com/angular/angular/pull/16088/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
asnowwolfhttps://github.com/asnowwolf
angular:masterhttps://github.com/angular/angular/tree/master
asnowwolf:dont-strip-source-url-commenthttps://github.com/asnowwolf/angular/tree/dont-strip-source-url-comment
Conversation 10 https://github.com/angular/angular/pull/16088
Commits 1 https://github.com/angular/angular/pull/16088/commits
Checks 0 https://github.com/angular/angular/pull/16088/checks
Files changed https://github.com/angular/angular/pull/16088/files
Please reload this pagehttps://github.com/angular/angular/pull/16088/files
fix(compiler): Don't strip /*# sourceURL ... */ https://github.com/angular/angular/pull/16088/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/16088/files
783cfcd fix(compiler): Don't strip `/*# sourceURL ... */` asnowwolf Apr 18, 2017 https://github.com/angular/angular/pull/16088/commits/783cfcd58ab6bb4cd20ea52672599c239a1d8728
Clear filters https://github.com/angular/angular/pull/16088/files
Please reload this pagehttps://github.com/angular/angular/pull/16088/files
Please reload this pagehttps://github.com/angular/angular/pull/16088/files
shadow_css.ts https://github.com/angular/angular/pull/16088/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
shadow_css_spec.ts https://github.com/angular/angular/pull/16088/files#diff-7006e5c5c6e550971f2407abd1edf691bb4c483e04190380f0bb1d8efcacfd08
packages/compiler/src/shadow_css.tshttps://github.com/angular/angular/pull/16088/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
View file https://github.com/asnowwolf/angular/blob/783cfcd58ab6bb4cd20ea52672599c239a1d8728/packages/compiler/src/shadow_css.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/16088/{{ revealButtonHref }}
https://github.com/angular/angular/pull/16088/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/16088/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/16088/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/16088/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
packages/compiler/test/shadow_css_spec.tshttps://github.com/angular/angular/pull/16088/files#diff-7006e5c5c6e550971f2407abd1edf691bb4c483e04190380f0bb1d8efcacfd08
View file https://github.com/asnowwolf/angular/blob/783cfcd58ab6bb4cd20ea52672599c239a1d8728/packages/compiler/test/shadow_css_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/16088/{{ revealButtonHref }}
https://github.com/angular/angular/pull/16088/files#diff-7006e5c5c6e550971f2407abd1edf691bb4c483e04190380f0bb1d8efcacfd08
https://github.com/angular/angular/pull/16088/files#diff-7006e5c5c6e550971f2407abd1edf691bb4c483e04190380f0bb1d8efcacfd08
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.