René's URL Explorer Experiment


Title: fix(aio): set the pageId to the file-not-found URL if the doc is not available by petebacondarwin · Pull Request #16085 · angular/angular · GitHub

Open Graph Title: fix(aio): set the pageId to the file-not-found URL if the doc is not available by petebacondarwin · Pull Request #16085 · angular/angular

X Title: fix(aio): set the pageId to the file-not-found URL if the doc is not available by petebacondarwin · Pull Request #16085 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Previously, the AppComponent.pageId was set via the current URL, rather than the document being displayed. This is only really noticeable when the URL does not match a valid doc and we are actually...

X Description: Previously, the AppComponent.pageId was set via the current URL, rather than the document being displayed. This is only really noticeable when the URL does not match a valid doc and we are actually...

Opengraph URL: https://github.com/angular/angular/pull/16085

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bd3e3af6-6b45-039c-8258-e3e66a1b2f87
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7BE:1C67A5:10A647:1522C5:6B0291BF
html-safe-nonced747c90cbfcf158febd0cca36a168708e981532e68a7f49f535c21e2b397c9e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0JFOjFDNjdBNToxMEE2NDc6MTUyMkM1OjZCMDI5MUJGIiwidmlzaXRvcl9pZCI6IjEyNjIwMzI2OTI4MTM4Njk0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb68375c90f1d146d847d80d6e4c70b3222f2fe8bcd170fbfae57c5edba619b09
hovercard-subject-tagpull_request:116319648
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/16085/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aec81feaa3916b073b90ba3ea085b529cc92152f878b10079e3540e1f8c1a1e7/angular/angular/pull/16085
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aec81feaa3916b073b90ba3ea085b529cc92152f878b10079e3540e1f8c1a1e7/angular/angular/pull/16085
og:image:altPreviously, the AppComponent.pageId was set via the current URL, rather than the document being displayed. This is only really noticeable when the URL does not match a valid doc and we are actually...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/16085#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F16085
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F16085
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/16085
Reloadhttps://github.com/angular/angular/pull/16085
Reloadhttps://github.com/angular/angular/pull/16085
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:aio-not-found-idhttps://github.com/petebacondarwin/angular/tree/aio-not-found-id
Conversationhttps://github.com/angular/angular/pull/16085
Commits1 (1)https://github.com/angular/angular/pull/16085/commits
Checkshttps://github.com/angular/angular/pull/16085/checks
Files changedhttps://github.com/angular/angular/pull/16085/files
fix(aio): set the pageId to the file-not-found URL if the doc is not availablehttps://github.com/angular/angular/pull/16085#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:aio-not-found-idhttps://github.com/petebacondarwin/angular/tree/aio-not-found-id
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Apr 18, 2017https://github.com/angular/angular/pull/16085#issue-222405793
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
comp: aio https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20aio%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Apr 18, 2017https://github.com/angular/angular/pull/16085#event-1046592427
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 18, 2017https://github.com/angular/angular/pull/16085#event-1046592495
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Apr 18, 2017https://github.com/angular/angular/pull/16085#issuecomment-294828724
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Apr 18, 2017 https://github.com/angular/angular/pull/16085#pullrequestreview-33224182
View reviewed changes https://github.com/angular/angular/pull/16085/files
aio/src/app/app.component.tshttps://github.com/angular/angular/pull/16085/files#diff-1f1b0f61d69d97efb20c38573759f7a0d5d4e5090648a4019c2f9175d56783ce
gkalpakhttps://github.com/gkalpak
Apr 18, 2017https://github.com/angular/angular/pull/16085#discussion_r111947880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/16085
petebacondarwinhttps://github.com/petebacondarwin
Apr 18, 2017https://github.com/angular/angular/pull/16085#discussion_r111984088
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/16085
aio/src/app/app.component.tshttps://github.com/angular/angular/pull/16085/files#diff-1f1b0f61d69d97efb20c38573759f7a0d5d4e5090648a4019c2f9175d56783ce
gkalpakhttps://github.com/gkalpak
Apr 18, 2017https://github.com/angular/angular/pull/16085#discussion_r111948082
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/16085
petebacondarwinhttps://github.com/petebacondarwin
Apr 18, 2017https://github.com/angular/angular/pull/16085#discussion_r111983966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/16085
aio/src/app/documents/document.service.tshttps://github.com/angular/angular/pull/16085/files#diff-99c20f0604b9cc01e16b0bf6b876d7be6caf4041f7cc337d1cd2c45ba4fe76f2
gkalpakhttps://github.com/gkalpak
Apr 18, 2017https://github.com/angular/angular/pull/16085#discussion_r111948243
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/16085
petebacondarwinhttps://github.com/petebacondarwin
Apr 18, 2017https://github.com/angular/angular/pull/16085#discussion_r111983493
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Apr 18, 2017https://github.com/angular/angular/pull/16085#issuecomment-294838566
herehttps://pr16085-7c1a895455b47769c1b6f1e4cd360548a00a2c19.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/sjtrimble
sjtrimblehttps://github.com/sjtrimble
Apr 18, 2017 https://github.com/angular/angular/pull/16085#ref-pullrequest-222442652
feat(aio): 404 page #16089 https://github.com/angular/angular/pull/16089
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
comp: aio https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20aio%22
comp: aio https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20aio%22
Apr 18, 2017https://github.com/angular/angular/pull/16085#event-1046866864
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/49c0cd0c7b33a6d94283167575af15906b734173..b7b94a8c49b7becb2404917ee439635f11414d56
49c0cd0https://github.com/angular/angular/commit/49c0cd0c7b33a6d94283167575af15906b734173
b7b94a8https://github.com/angular/angular/commit/b7b94a8c49b7becb2404917ee439635f11414d56
Compare https://github.com/angular/angular/compare/49c0cd0c7b33a6d94283167575af15906b734173..b7b94a8c49b7becb2404917ee439635f11414d56
April 18, 2017 15:22https://github.com/angular/angular/pull/16085#event-1046880201
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Apr 18, 2017https://github.com/angular/angular/pull/16085#issuecomment-294881588
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Apr 18, 2017https://github.com/angular/angular/pull/16085#issuecomment-294883098
herehttps://pr16085-49c0cd0c7b33a6d94283167575af15906b734173.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Apr 18, 2017https://github.com/angular/angular/pull/16085#issuecomment-294884752
herehttps://pr16085-b7b94a8c49b7becb2404917ee439635f11414d56.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Apr 19, 2017 https://github.com/angular/angular/pull/16085#pullrequestreview-33421164
View reviewed changes https://github.com/angular/angular/pull/16085/files
https://github.com/petebacondarwin
fix(aio): set the pageId to the file-not-found URL if the doc is not …https://github.com/angular/angular/pull/16085/commits/f3e681217795347ea295a14cd9330123d588cc79
f3e6812https://github.com/angular/angular/pull/16085/commits/f3e681217795347ea295a14cd9330123d588cc79
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/b7b94a8c49b7becb2404917ee439635f11414d56..f3e681217795347ea295a14cd9330123d588cc79
b7b94a8https://github.com/angular/angular/commit/b7b94a8c49b7becb2404917ee439635f11414d56
f3e6812https://github.com/angular/angular/commit/f3e681217795347ea295a14cd9330123d588cc79
Compare https://github.com/angular/angular/compare/b7b94a8c49b7becb2404917ee439635f11414d56..f3e681217795347ea295a14cd9330123d588cc79
April 19, 2017 07:42https://github.com/angular/angular/pull/16085#event-1048031182
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Apr 19, 2017https://github.com/angular/angular/pull/16085#issuecomment-295148793
f3e6812https://github.com/angular/angular/commit/f3e681217795347ea295a14cd9330123d588cc79
herehttps://pr16085-f3e681217795347ea295a14cd9330123d588cc79.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
e951612https://github.com/angular/angular/commit/e951612af2ea4bfe03cd1957decb316f507900fe
Apr 19, 2017https://github.com/angular/angular/pull/16085#event-1048070993
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
April 19, 2017 08:09https://github.com/angular/angular/pull/16085#event-1048071704
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 11, 2019https://github.com/angular/angular/pull/16085#issuecomment-530275925
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 11, 2019https://github.com/angular/angular/pull/16085#event-2624836301
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F16085
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/16085/files/b7b94a8c49b7becb2404917ee439635f11414d56
Please reload this pagehttps://github.com/angular/angular/pull/16085
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Please reload this pagehttps://github.com/angular/angular/pull/16085
https://github.com/petebacondarwin
https://github.com/mary-poppins
https://github.com/gkalpak
https://github.com/IgorMinar
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.