| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dad26ce1-aca3-462d-5d98-7b628d90de9b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 971A:19F84C:23B5893:2D6C143:6B016DF1 |
| html-safe-nonce | d166430598cebdab13317a72e4a704c94a1f2b8f4c8841b518cbc72e2f71f78e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzFBOjE5Rjg0QzoyM0I1ODkzOjJENkMxNDM6NkIwMTZERjEiLCJ2aXNpdG9yX2lkIjoiMjE3ODA2MTYzOTM5NDM1NjcyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2cbf2daece65e8119021a31f31976a2480ceb617680e8dd880ebb275af202eaa |
| hovercard-subject-tag | pull_request:113440949 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/15621/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b1c95ed87d2d57e26716534126ae7f6e5633b5b2c9f99335a353d2cbe56a68c2/angular/angular/pull/15621 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b1c95ed87d2d57e26716534126ae7f6e5633b5b2c9f99335a353d2cbe56a68c2/angular/angular/pull/15621 |
| og:image:alt | Please check if the PR fulfills these requirements
Tests for the changes have been added
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
See #15573.
What is t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ocombe |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/15621#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F15621 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F15621 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/15621 |
| Reload | https://github.com/angular/angular/pull/15621 |
| Reload | https://github.com/angular/angular/pull/15621 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| ocombe | https://github.com/ocombe |
| angular:master | https://github.com/angular/angular/tree/master |
| ocombe:fix-digest-15573 | https://github.com/ocombe/angular/tree/fix-digest-15573 |
| Conversation | https://github.com/angular/angular/pull/15621 |
| Commits3 (3) | https://github.com/angular/angular/pull/15621/commits |
| Checks | https://github.com/angular/angular/pull/15621/checks |
| Files changed | https://github.com/angular/angular/pull/15621/files |
| fix(compiler): fix i18n IDs generation, add a migration tool | https://github.com/angular/angular/pull/15621#top |
| ocombe | https://github.com/ocombe |
| angular:master | https://github.com/angular/angular/tree/master |
| ocombe:fix-digest-15573 | https://github.com/ocombe/angular/tree/fix-digest-15573 |
|
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#issue-218214763 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| #15573 | https://github.com/angular/angular/issues/15573 |
| #15573 | https://github.com/angular/angular/issues/15573 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#event-1022404130 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| vicb | https://github.com/vicb |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#event-1022404137 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| marclaval | https://github.com/marclaval |
| vicb | https://github.com/vicb |
| March 30, 2017 14:23 | https://github.com/angular/angular/pull/15621#event-1022404142 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#event-1022404224 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/adce33538dd5cf35ee2b7078d4ae6863abc66abd..bc15bbf32adc5e86c746fcf4f4ae417a41f05616 |
| adce335 | https://github.com/angular/angular/commit/adce33538dd5cf35ee2b7078d4ae6863abc66abd |
| bc15bbf | https://github.com/angular/angular/commit/bc15bbf32adc5e86c746fcf4f4ae417a41f05616 |
|
Compare
| https://github.com/angular/angular/compare/adce33538dd5cf35ee2b7078d4ae6863abc66abd..bc15bbf32adc5e86c746fcf4f4ae417a41f05616 |
| March 30, 2017 14:33 | https://github.com/angular/angular/pull/15621#event-1022423756 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-30048217 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files |
| packages/compiler/test/i18n/digest_spec.ts | https://github.com/angular/angular/pull/15621/files#diff-1e8042479217c42bd44751c7266319421c47766495a09942e98eef5fa6cc7399 |
| vicb | https://github.com/vicb |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#discussion_r108977017 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#discussion_r108978861 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-30048628 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files |
| packages/compiler/test/i18n/extractor_merger_spec.ts | https://github.com/angular/angular/pull/15621/files#diff-d67c746fcbaba772adb53b2058a5999376a42db6d11168c10b9f43338e4d16a9 |
| vicb | https://github.com/vicb |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#discussion_r108977399 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#discussion_r108978790 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-30048742 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files |
| packages/compiler/test/i18n/i18n_parser_spec.ts | https://github.com/angular/angular/pull/15621/files#diff-9b869a83124502e7d03a8679cc43c7b806716d376c8d38ddd4a3cef7ae6aec03 |
| vicb | https://github.com/vicb |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#discussion_r108977515 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-30049017 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files |
| packages/compiler/test/i18n/serializers/i18n_ast_spec.ts | https://github.com/angular/angular/pull/15621/files#diff-8759abb680af28b1c93c4e751cee67d621a9dc32afe5f26d506feb384f634843 |
| vicb | https://github.com/vicb |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#discussion_r108977757 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-30049088 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files |
| packages/compiler/test/i18n/serializers/xtb_spec.ts | https://github.com/angular/angular/pull/15621/files#diff-c293fcf5d00e8d731c3ca67b504ea08ee62ac10e90419024fe3865507e6dc845 |
| vicb | https://github.com/vicb |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#discussion_r108977833 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#event-1022676839 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| Mar 30, 2017 | https://github.com/angular/angular/pull/15621#issuecomment-290472484 |
| @ocombe | https://github.com/ocombe |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-30050269 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files |
| vicb | https://github.com/vicb |
| https://github.com/angular/angular/pull/15621#pullrequestreview-30050269 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/bc15bbf32adc5e86c746fcf4f4ae417a41f05616..d2acf58a4b35543a2201431c866d8da9068c35b7 |
| bc15bbf | https://github.com/angular/angular/commit/bc15bbf32adc5e86c746fcf4f4ae417a41f05616 |
| d2acf58 | https://github.com/angular/angular/commit/d2acf58a4b35543a2201431c866d8da9068c35b7 |
|
Compare
| https://github.com/angular/angular/compare/bc15bbf32adc5e86c746fcf4f4ae417a41f05616..d2acf58a4b35543a2201431c866d8da9068c35b7 |
| April 12, 2017 11:01 | https://github.com/angular/angular/pull/15621#event-1039933532 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Apr 12, 2017 | https://github.com/angular/angular/pull/15621#issuecomment-293562592 |
| @vicb | https://github.com/vicb |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/d2acf58a4b35543a2201431c866d8da9068c35b7..5e04000ec8dcff63cf25067cd88516d537b2b2c5 |
| d2acf58 | https://github.com/angular/angular/commit/d2acf58a4b35543a2201431c866d8da9068c35b7 |
| 5e04000 | https://github.com/angular/angular/commit/5e04000ec8dcff63cf25067cd88516d537b2b2c5 |
|
Compare
| https://github.com/angular/angular/compare/d2acf58a4b35543a2201431c866d8da9068c35b7..5e04000ec8dcff63cf25067cd88516d537b2b2c5 |
| April 12, 2017 12:38 | https://github.com/angular/angular/pull/15621#event-1040058411 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
|
May 2, 2017
| https://github.com/angular/angular/pull/15621#ref-issue-225727620 |
|
[i18n] plans
#16477
| https://github.com/angular/angular/issues/16477 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/9a155966ac54ca4a9e4e7528a75336f1c5641c3c..7382687fdbf690f5e3ca6e2d5253650a8897bb91 |
| 9a15596 | https://github.com/angular/angular/commit/9a155966ac54ca4a9e4e7528a75336f1c5641c3c |
| 7382687 | https://github.com/angular/angular/commit/7382687fdbf690f5e3ca6e2d5253650a8897bb91 |
|
Compare
| https://github.com/angular/angular/compare/9a155966ac54ca4a9e4e7528a75336f1c5641c3c..7382687fdbf690f5e3ca6e2d5253650a8897bb91 |
| May 4, 2017 09:04 | https://github.com/angular/angular/pull/15621#event-1068565107 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42482210 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files |
| packages/compiler/src/i18n/serializers/xliff.ts | https://github.com/angular/angular/pull/15621/files#diff-abd5f9e87f7aa7f5750dadbaa943f64b373817ac2e0b9f0767088f40cda2a237 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120514160 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120578314 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42482417 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files |
| packages/compiler/test/i18n/serializers/xliff_spec.ts | https://github.com/angular/angular/pull/15621/files#diff-359bd12b683d3993afd98032a877a7ac3ed2e171b9dd8d8177c967908ca8a3fb |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120514369 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
|
| https://github.com/ocombe |
| refactor(compiler): change xliff serializer digest function to decimal | https://github.com/angular/angular/pull/15621/commits/5eb3a127b9ecfd994e6ae3c52e256884e06b772d |
| 5eb3a12 | https://github.com/angular/angular/pull/15621/commits/5eb3a127b9ecfd994e6ae3c52e256884e06b772d |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/76deb4afd00f68f83a327eaeb8bdaf6489efe71e..cd6d937906d431d8318a90484935c29a87968854 |
| 76deb4a | https://github.com/angular/angular/commit/76deb4afd00f68f83a327eaeb8bdaf6489efe71e |
| cd6d937 | https://github.com/angular/angular/commit/cd6d937906d431d8318a90484935c29a87968854 |
|
Compare
| https://github.com/angular/angular/compare/76deb4afd00f68f83a327eaeb8bdaf6489efe71e..cd6d937906d431d8318a90484935c29a87968854 |
| June 7, 2017 12:51 | https://github.com/angular/angular/pull/15621#event-1113587939 |
|
| https://github.com/ocombe |
| fix(compiler): ignore ph/ICU expressions when generating i18n ids | https://github.com/angular/angular/pull/15621/commits/a11b716d02a5a817089c861b99bbad02a19d465f |
| a11b716 | https://github.com/angular/angular/pull/15621/commits/a11b716d02a5a817089c861b99bbad02a19d465f |
| angular#15573 | https://github.com/angular/angular/issues/15573 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/cd6d937906d431d8318a90484935c29a87968854..cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a |
| cd6d937 | https://github.com/angular/angular/commit/cd6d937906d431d8318a90484935c29a87968854 |
| cbe3748 | https://github.com/angular/angular/commit/cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a |
|
Compare
| https://github.com/angular/angular/compare/cd6d937906d431d8318a90484935c29a87968854..cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a |
| June 7, 2017 13:15 | https://github.com/angular/angular/pull/15621#event-1113628069 |
|
| https://github.com/ocombe |
| feat(compiler-cli): add tool ng-migrate-i18n & i18nVersion param | https://github.com/angular/angular/pull/15621/commits/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| d8eaf6f | https://github.com/angular/angular/pull/15621/commits/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| angular#15573 | https://github.com/angular/angular/issues/15573 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| force-pushed | https://github.com/angular/angular/compare/cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a..d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| cbe3748 | https://github.com/angular/angular/commit/cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a |
| d8eaf6f | https://github.com/angular/angular/commit/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
|
Compare
| https://github.com/angular/angular/compare/cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a..d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| June 7, 2017 13:39 | https://github.com/angular/angular/pull/15621#event-1113669022 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42665833 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f |
| packages/compiler/src/i18n/digest.ts | https://github.com/angular/angular/pull/15621/files/5eb3a127b9ecfd994e6ae3c52e256884e06b772d..a11b716d02a5a817089c861b99bbad02a19d465f#diff-a8f92ef025006a8a12f605ea7bf793c86c6706e68fa6a0da65190f893529d3a8 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120682481 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42665995 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f |
| packages/compiler/src/i18n/digest.ts | https://github.com/angular/angular/pull/15621/files/5eb3a127b9ecfd994e6ae3c52e256884e06b772d..a11b716d02a5a817089c861b99bbad02a19d465f#diff-a8f92ef025006a8a12f605ea7bf793c86c6706e68fa6a0da65190f893529d3a8 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120682635 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42672581 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler/src/i18n/i18n_html_parser.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-c50a1c4b29df6d4db887049f85daf2afa8e0cf5ec3fbd50054f541962b0f5535 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120688594 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42672948 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler-cli/src/extractor.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-e65d1b21741a7629f56fd23c517f5394966a816013163d6d0603290d226cbfdb |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120688890 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42684914 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler-cli/src/extractor.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-e65d1b21741a7629f56fd23c517f5394966a816013163d6d0603290d226cbfdb |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120699717 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120722547 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/ocombe/angular/blob/d8eaf6f215074ab4f9641dfd724da1b1909eaa99/packages/compiler-cli/src/extractor.ts#L37 | https://github.com/ocombe/angular/blob/d8eaf6f215074ab4f9641dfd724da1b1909eaa99/packages/compiler-cli/src/extractor.ts#L37 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120744709 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| comment above | https://github.com/angular/angular/pull/15621#pullrequestreview-42672948 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42686765 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler/src/i18n/i18n_html_parser.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-c50a1c4b29df6d4db887049f85daf2afa8e0cf5ec3fbd50054f541962b0f5535 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120701344 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42688465 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler/src/i18n/migrator.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120702817 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120722916 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42688988 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler/src/i18n/migrator.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120703276 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120723012 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42691209 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler-cli/src/codegen.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-a08f7c117046cff08f7c4fb75fd57f19fc2bb8359083b082b4068f6893837207 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120705279 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120723067 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42693966 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler/src/i18n/migrator.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120707894 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42695830 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler/src/i18n/migrator.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120709675 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42697027 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler/src/i18n/migrator.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120710829 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120723859 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42697453 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler-cli/src/migrator.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-2e31a792cee8da17213272a8fbf3d885946d6ab8749e91fe714f6048d005e328 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120711257 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120724810 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120739455 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42698653 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler-cli/src/migrator.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-2e31a792cee8da17213272a8fbf3d885946d6ab8749e91fe714f6048d005e328 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120712325 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120712866 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120726591 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Jun 7, 2017
| https://github.com/angular/angular/pull/15621#pullrequestreview-42699642 |
|
View reviewed changes
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| packages/compiler/src/config.ts | https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-e5f0f3f28e3b4d2dfc5325417a46e40dafa02f828aaf2ab399206bb0723209ae |
| vicb | https://github.com/vicb |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120713221 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| ocombe | https://github.com/ocombe |
| Jun 7, 2017 | https://github.com/angular/angular/pull/15621#discussion_r120727106 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Jun 20, 2017 | https://github.com/angular/angular/pull/15621#issuecomment-309821337 |
| #17638 | https://github.com/angular/angular/pull/17638 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
| Jun 20, 2017 | https://github.com/angular/angular/pull/15621#event-1131404420 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 11, 2019 | https://github.com/angular/angular/pull/15621#issuecomment-530588846 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 11, 2019 | https://github.com/angular/angular/pull/15621#event-2627329390 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F15621 |
|
| https://github.com/vicb |
|
vicb
| https://github.com/vicb |
|
| https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
|
| https://github.com/vicb |
|
vicb
| https://github.com/vicb |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/angular/angular/pull/15621 |
|
| https://github.com/ocombe |
|
| https://github.com/vicb |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |