René's URL Explorer Experiment


Title: fix(compiler): fix i18n IDs generation, add a migration tool by ocombe · Pull Request #15621 · angular/angular · GitHub

Open Graph Title: fix(compiler): fix i18n IDs generation, add a migration tool by ocombe · Pull Request #15621 · angular/angular

X Title: fix(compiler): fix i18n IDs generation, add a migration tool by ocombe · Pull Request #15621 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Please check if the PR fulfills these requirements Tests for the changes have been added What kind of change does this PR introduce? Bugfix What is the current behavior? See #15573. What is t...

X Description: Please check if the PR fulfills these requirements Tests for the changes have been added What kind of change does this PR introduce? Bugfix What is the current behavior? See #15573. What is t...

Opengraph URL: https://github.com/angular/angular/pull/15621

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dad26ce1-aca3-462d-5d98-7b628d90de9b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id971A:19F84C:23B5893:2D6C143:6B016DF1
html-safe-nonced166430598cebdab13317a72e4a704c94a1f2b8f4c8841b518cbc72e2f71f78e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzFBOjE5Rjg0QzoyM0I1ODkzOjJENkMxNDM6NkIwMTZERjEiLCJ2aXNpdG9yX2lkIjoiMjE3ODA2MTYzOTM5NDM1NjcyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2cbf2daece65e8119021a31f31976a2480ceb617680e8dd880ebb275af202eaa
hovercard-subject-tagpull_request:113440949
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/15621/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1c95ed87d2d57e26716534126ae7f6e5633b5b2c9f99335a353d2cbe56a68c2/angular/angular/pull/15621
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1c95ed87d2d57e26716534126ae7f6e5633b5b2c9f99335a353d2cbe56a68c2/angular/angular/pull/15621
og:image:altPlease check if the PR fulfills these requirements Tests for the changes have been added What kind of change does this PR introduce? Bugfix What is the current behavior? See #15573. What is t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameocombe
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/15621#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F15621
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F15621
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/15621
Reloadhttps://github.com/angular/angular/pull/15621
Reloadhttps://github.com/angular/angular/pull/15621
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:fix-digest-15573https://github.com/ocombe/angular/tree/fix-digest-15573
Conversationhttps://github.com/angular/angular/pull/15621
Commits3 (3)https://github.com/angular/angular/pull/15621/commits
Checkshttps://github.com/angular/angular/pull/15621/checks
Files changedhttps://github.com/angular/angular/pull/15621/files
fix(compiler): fix i18n IDs generation, add a migration toolhttps://github.com/angular/angular/pull/15621#top
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:fix-digest-15573https://github.com/ocombe/angular/tree/fix-digest-15573
https://github.com/ocombe
ocombehttps://github.com/ocombe
Mar 30, 2017https://github.com/angular/angular/pull/15621#issue-218214763
Please reload this pagehttps://github.com/angular/angular/pull/15621
#15573https://github.com/angular/angular/issues/15573
#15573https://github.com/angular/angular/issues/15573
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/ocombe
ocombehttps://github.com/ocombe
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
breaking changes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Mar 30, 2017https://github.com/angular/angular/pull/15621#event-1022404130
https://github.com/ocombe
ocombehttps://github.com/ocombe
vicbhttps://github.com/vicb
Mar 30, 2017https://github.com/angular/angular/pull/15621#event-1022404137
https://github.com/ocombe
ocombehttps://github.com/ocombe
marclavalhttps://github.com/marclaval
vicbhttps://github.com/vicb
March 30, 2017 14:23https://github.com/angular/angular/pull/15621#event-1022404142
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 30, 2017https://github.com/angular/angular/pull/15621#event-1022404224
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/adce33538dd5cf35ee2b7078d4ae6863abc66abd..bc15bbf32adc5e86c746fcf4f4ae417a41f05616
adce335https://github.com/angular/angular/commit/adce33538dd5cf35ee2b7078d4ae6863abc66abd
bc15bbfhttps://github.com/angular/angular/commit/bc15bbf32adc5e86c746fcf4f4ae417a41f05616
Compare https://github.com/angular/angular/compare/adce33538dd5cf35ee2b7078d4ae6863abc66abd..bc15bbf32adc5e86c746fcf4f4ae417a41f05616
March 30, 2017 14:33https://github.com/angular/angular/pull/15621#event-1022423756
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-30048217
View reviewed changes https://github.com/angular/angular/pull/15621/files
packages/compiler/test/i18n/digest_spec.tshttps://github.com/angular/angular/pull/15621/files#diff-1e8042479217c42bd44751c7266319421c47766495a09942e98eef5fa6cc7399
vicbhttps://github.com/vicb
Mar 30, 2017https://github.com/angular/angular/pull/15621#discussion_r108977017
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Mar 30, 2017https://github.com/angular/angular/pull/15621#discussion_r108978861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-30048628
View reviewed changes https://github.com/angular/angular/pull/15621/files
packages/compiler/test/i18n/extractor_merger_spec.tshttps://github.com/angular/angular/pull/15621/files#diff-d67c746fcbaba772adb53b2058a5999376a42db6d11168c10b9f43338e4d16a9
vicbhttps://github.com/vicb
Mar 30, 2017https://github.com/angular/angular/pull/15621#discussion_r108977399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Mar 30, 2017https://github.com/angular/angular/pull/15621#discussion_r108978790
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-30048742
View reviewed changes https://github.com/angular/angular/pull/15621/files
packages/compiler/test/i18n/i18n_parser_spec.tshttps://github.com/angular/angular/pull/15621/files#diff-9b869a83124502e7d03a8679cc43c7b806716d376c8d38ddd4a3cef7ae6aec03
vicbhttps://github.com/vicb
Mar 30, 2017https://github.com/angular/angular/pull/15621#discussion_r108977515
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-30049017
View reviewed changes https://github.com/angular/angular/pull/15621/files
packages/compiler/test/i18n/serializers/i18n_ast_spec.tshttps://github.com/angular/angular/pull/15621/files#diff-8759abb680af28b1c93c4e751cee67d621a9dc32afe5f26d506feb384f634843
vicbhttps://github.com/vicb
Mar 30, 2017https://github.com/angular/angular/pull/15621#discussion_r108977757
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-30049088
View reviewed changes https://github.com/angular/angular/pull/15621/files
packages/compiler/test/i18n/serializers/xtb_spec.tshttps://github.com/angular/angular/pull/15621/files#diff-c293fcf5d00e8d731c3ca67b504ea08ee62ac10e90419024fe3865507e6dc845
vicbhttps://github.com/vicb
Mar 30, 2017https://github.com/angular/angular/pull/15621#discussion_r108977833
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Mar 30, 2017https://github.com/angular/angular/pull/15621#event-1022676839
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017https://github.com/angular/angular/pull/15621#issuecomment-290472484
@ocombehttps://github.com/ocombe
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-30050269
View reviewed changes https://github.com/angular/angular/pull/15621/files
vicbhttps://github.com/vicb
https://github.com/angular/angular/pull/15621#pullrequestreview-30050269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/bc15bbf32adc5e86c746fcf4f4ae417a41f05616..d2acf58a4b35543a2201431c866d8da9068c35b7
bc15bbfhttps://github.com/angular/angular/commit/bc15bbf32adc5e86c746fcf4f4ae417a41f05616
d2acf58https://github.com/angular/angular/commit/d2acf58a4b35543a2201431c866d8da9068c35b7
Compare https://github.com/angular/angular/compare/bc15bbf32adc5e86c746fcf4f4ae417a41f05616..d2acf58a4b35543a2201431c866d8da9068c35b7
April 12, 2017 11:01https://github.com/angular/angular/pull/15621#event-1039933532
https://github.com/ocombe
ocombehttps://github.com/ocombe
Apr 12, 2017https://github.com/angular/angular/pull/15621#issuecomment-293562592
@vicbhttps://github.com/vicb
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/d2acf58a4b35543a2201431c866d8da9068c35b7..5e04000ec8dcff63cf25067cd88516d537b2b2c5
d2acf58https://github.com/angular/angular/commit/d2acf58a4b35543a2201431c866d8da9068c35b7
5e04000https://github.com/angular/angular/commit/5e04000ec8dcff63cf25067cd88516d537b2b2c5
Compare https://github.com/angular/angular/compare/d2acf58a4b35543a2201431c866d8da9068c35b7..5e04000ec8dcff63cf25067cd88516d537b2b2c5
April 12, 2017 12:38https://github.com/angular/angular/pull/15621#event-1040058411
https://github.com/ocombe
ocombehttps://github.com/ocombe
May 2, 2017 https://github.com/angular/angular/pull/15621#ref-issue-225727620
[i18n] plans #16477 https://github.com/angular/angular/issues/16477
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/9a155966ac54ca4a9e4e7528a75336f1c5641c3c..7382687fdbf690f5e3ca6e2d5253650a8897bb91
9a15596https://github.com/angular/angular/commit/9a155966ac54ca4a9e4e7528a75336f1c5641c3c
7382687https://github.com/angular/angular/commit/7382687fdbf690f5e3ca6e2d5253650a8897bb91
Compare https://github.com/angular/angular/compare/9a155966ac54ca4a9e4e7528a75336f1c5641c3c..7382687fdbf690f5e3ca6e2d5253650a8897bb91
May 4, 2017 09:04https://github.com/angular/angular/pull/15621#event-1068565107
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42482210
View reviewed changes https://github.com/angular/angular/pull/15621/files
packages/compiler/src/i18n/serializers/xliff.tshttps://github.com/angular/angular/pull/15621/files#diff-abd5f9e87f7aa7f5750dadbaa943f64b373817ac2e0b9f0767088f40cda2a237
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120514160
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120578314
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42482417
View reviewed changes https://github.com/angular/angular/pull/15621/files
packages/compiler/test/i18n/serializers/xliff_spec.tshttps://github.com/angular/angular/pull/15621/files#diff-359bd12b683d3993afd98032a877a7ac3ed2e171b9dd8d8177c967908ca8a3fb
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120514369
Please reload this pagehttps://github.com/angular/angular/pull/15621
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/ocombe
refactor(compiler): change xliff serializer digest function to decimalhttps://github.com/angular/angular/pull/15621/commits/5eb3a127b9ecfd994e6ae3c52e256884e06b772d
5eb3a12https://github.com/angular/angular/pull/15621/commits/5eb3a127b9ecfd994e6ae3c52e256884e06b772d
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/76deb4afd00f68f83a327eaeb8bdaf6489efe71e..cd6d937906d431d8318a90484935c29a87968854
76deb4ahttps://github.com/angular/angular/commit/76deb4afd00f68f83a327eaeb8bdaf6489efe71e
cd6d937https://github.com/angular/angular/commit/cd6d937906d431d8318a90484935c29a87968854
Compare https://github.com/angular/angular/compare/76deb4afd00f68f83a327eaeb8bdaf6489efe71e..cd6d937906d431d8318a90484935c29a87968854
June 7, 2017 12:51https://github.com/angular/angular/pull/15621#event-1113587939
https://github.com/ocombe
fix(compiler): ignore ph/ICU expressions when generating i18n idshttps://github.com/angular/angular/pull/15621/commits/a11b716d02a5a817089c861b99bbad02a19d465f
a11b716https://github.com/angular/angular/pull/15621/commits/a11b716d02a5a817089c861b99bbad02a19d465f
angular#15573https://github.com/angular/angular/issues/15573
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/cd6d937906d431d8318a90484935c29a87968854..cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a
cd6d937https://github.com/angular/angular/commit/cd6d937906d431d8318a90484935c29a87968854
cbe3748https://github.com/angular/angular/commit/cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a
Compare https://github.com/angular/angular/compare/cd6d937906d431d8318a90484935c29a87968854..cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a
June 7, 2017 13:15https://github.com/angular/angular/pull/15621#event-1113628069
https://github.com/ocombe
feat(compiler-cli): add tool ng-migrate-i18n & i18nVersion paramhttps://github.com/angular/angular/pull/15621/commits/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
d8eaf6fhttps://github.com/angular/angular/pull/15621/commits/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
angular#15573https://github.com/angular/angular/issues/15573
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a..d8eaf6f215074ab4f9641dfd724da1b1909eaa99
cbe3748https://github.com/angular/angular/commit/cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a
d8eaf6fhttps://github.com/angular/angular/commit/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
Compare https://github.com/angular/angular/compare/cbe3748e60c1b1fa6b1af9a10e735c4ce0c7568a..d8eaf6f215074ab4f9641dfd724da1b1909eaa99
June 7, 2017 13:39https://github.com/angular/angular/pull/15621#event-1113669022
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42665833
View reviewed changes https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f
packages/compiler/src/i18n/digest.tshttps://github.com/angular/angular/pull/15621/files/5eb3a127b9ecfd994e6ae3c52e256884e06b772d..a11b716d02a5a817089c861b99bbad02a19d465f#diff-a8f92ef025006a8a12f605ea7bf793c86c6706e68fa6a0da65190f893529d3a8
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120682481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42665995
View reviewed changes https://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f
packages/compiler/src/i18n/digest.tshttps://github.com/angular/angular/pull/15621/files/5eb3a127b9ecfd994e6ae3c52e256884e06b772d..a11b716d02a5a817089c861b99bbad02a19d465f#diff-a8f92ef025006a8a12f605ea7bf793c86c6706e68fa6a0da65190f893529d3a8
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120682635
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42672581
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler/src/i18n/i18n_html_parser.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-c50a1c4b29df6d4db887049f85daf2afa8e0cf5ec3fbd50054f541962b0f5535
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120688594
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42672948
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler-cli/src/extractor.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-e65d1b21741a7629f56fd23c517f5394966a816013163d6d0603290d226cbfdb
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120688890
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42684914
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler-cli/src/extractor.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-e65d1b21741a7629f56fd23c517f5394966a816013163d6d0603290d226cbfdb
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120699717
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120722547
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/ocombe/angular/blob/d8eaf6f215074ab4f9641dfd724da1b1909eaa99/packages/compiler-cli/src/extractor.ts#L37https://github.com/ocombe/angular/blob/d8eaf6f215074ab4f9641dfd724da1b1909eaa99/packages/compiler-cli/src/extractor.ts#L37
Please reload this pagehttps://github.com/angular/angular/pull/15621
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120744709
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
comment abovehttps://github.com/angular/angular/pull/15621#pullrequestreview-42672948
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42686765
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler/src/i18n/i18n_html_parser.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-c50a1c4b29df6d4db887049f85daf2afa8e0cf5ec3fbd50054f541962b0f5535
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120701344
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42688465
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler/src/i18n/migrator.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120702817
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120722916
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42688988
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler/src/i18n/migrator.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120703276
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120723012
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42691209
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler-cli/src/codegen.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-a08f7c117046cff08f7c4fb75fd57f19fc2bb8359083b082b4068f6893837207
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120705279
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120723067
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42693966
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler/src/i18n/migrator.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120707894
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42695830
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler/src/i18n/migrator.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120709675
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42697027
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler/src/i18n/migrator.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-907fa86cd28d7a9ea27d243753e4913ec62e9499e5d812397c26dc05b7271728
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120710829
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120723859
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42697453
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler-cli/src/migrator.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-2e31a792cee8da17213272a8fbf3d885946d6ab8749e91fe714f6048d005e328
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120711257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120724810
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120739455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42698653
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler-cli/src/migrator.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-2e31a792cee8da17213272a8fbf3d885946d6ab8749e91fe714f6048d005e328
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120712325
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120712866
Please reload this pagehttps://github.com/angular/angular/pull/15621
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120726591
Please reload this pagehttps://github.com/angular/angular/pull/15621
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicbhttps://github.com/vicb
Jun 7, 2017 https://github.com/angular/angular/pull/15621#pullrequestreview-42699642
View reviewed changes https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
packages/compiler/src/config.tshttps://github.com/angular/angular/pull/15621/files/a11b716d02a5a817089c861b99bbad02a19d465f..d8eaf6f215074ab4f9641dfd724da1b1909eaa99#diff-e5f0f3f28e3b4d2dfc5325417a46e40dafa02f828aaf2ab399206bb0723209ae
vicbhttps://github.com/vicb
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120713221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
ocombehttps://github.com/ocombe
Jun 7, 2017https://github.com/angular/angular/pull/15621#discussion_r120727106
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/ocombe
ocombehttps://github.com/ocombe
Jun 20, 2017https://github.com/angular/angular/pull/15621#issuecomment-309821337
#17638https://github.com/angular/angular/pull/17638
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/ocombe
ocombehttps://github.com/ocombe
Jun 20, 2017https://github.com/angular/angular/pull/15621#event-1131404420
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 11, 2019https://github.com/angular/angular/pull/15621#issuecomment-530588846
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 11, 2019https://github.com/angular/angular/pull/15621#event-2627329390
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F15621
https://github.com/vicb
vicb https://github.com/vicb
https://github.com/angular/angular/pull/15621/files/d8eaf6f215074ab4f9641dfd724da1b1909eaa99
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/vicb
vicb https://github.com/vicb
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
breaking changes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/angular/angular/pull/15621
https://github.com/ocombe
https://github.com/vicb
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.