Title: fix(compiler-cli): ngtools should accept `useFactory` (lazy routes) by fulls1z3 · Pull Request #15334 · angular/angular · GitHub
Open Graph Title: fix(compiler-cli): ngtools should accept `useFactory` (lazy routes) by fulls1z3 · Pull Request #15334 · angular/angular
X Title: fix(compiler-cli): ngtools should accept `useFactory` (lazy routes) by fulls1z3 · Pull Request #15334 · angular/angular
Description: Add the required functionality to _collectRoutes function of ngtools_impl.ts, so that the ngtools respect provided factories with p.useFactory (as well as provided values with useValue). Closes #15305 Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) What kind of change does this PR introduce? (check one with "x") [X] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Other... Please describe: What is the current behavior? (You can also link to an open issue here) Providing a factory method (useFactory) for the DI token ROUTES causes the discovery of lazy-routes to fail. Further details are documented on #15305. What is the new behavior? With this PR, it's possible to provide a factory method for the DI token ROUTES, and @ngtools/webpack accepts the values provided by the factory with useFactory (as well as provided values with useValue). Does this PR introduce a breaking change? (check one with "x") [ ] Yes [X] No If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... Other information: For these changes, no tests and documents have been added or changed. Actually, there were already no specific tests and documents found to evaluate/document the current and new behavior.
Open Graph Description: Add the required functionality to _collectRoutes function of ngtools_impl.ts, so that the ngtools respect provided factories with p.useFactory (as well as provided values with useValue). Closes #15...
X Description: Add the required functionality to _collectRoutes function of ngtools_impl.ts, so that the ngtools respect provided factories with p.useFactory (as well as provided values with useValue). Closes #15...
Opengraph URL: https://github.com/angular/angular/pull/15334
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5339a8fa-7005-51eb-1817-f592f57be3c2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9406:882E2:D9A20C:120545F:6B00F805 |
| html-safe-nonce | 7ee4fcd09fb1cc54b9c5736ebffd42077d725f5a6b364a95c15954313a28dedb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDA2Ojg4MkUyOkQ5QTIwQzoxMjA1NDVGOjZCMDBGODA1IiwidmlzaXRvcl9pZCI6IjQxNTk4NDYzMTY2OTgwNDAzMjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fd8ad373307495d650957448e170fa5f3bab48ec09f736458e3d1545672fc1a8 |
| hovercard-subject-tag | pull_request:111713908 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/15334/files |
| twitter:image | https://avatars.githubusercontent.com/u/19705684?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19705684?s=400&v=4 |
| og:image:alt | Add the required functionality to _collectRoutes function of ngtools_impl.ts, so that the ngtools respect provided factories with p.useFactory (as well as provided values with useValue). Closes #15... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width