René's URL Explorer Experiment


Title: fix(compiler-cli): ngtools should accept `useFactory` (lazy routes) by fulls1z3 · Pull Request #15334 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): ngtools should accept `useFactory` (lazy routes) by fulls1z3 · Pull Request #15334 · angular/angular

X Title: fix(compiler-cli): ngtools should accept `useFactory` (lazy routes) by fulls1z3 · Pull Request #15334 · angular/angular

Description: Add the required functionality to _collectRoutes function of ngtools_impl.ts, so that the ngtools respect provided factories with p.useFactory (as well as provided values with useValue). Closes #15305 Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) What kind of change does this PR introduce? (check one with "x") [X] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Other... Please describe: What is the current behavior? (You can also link to an open issue here) Providing a factory method (useFactory) for the DI token ROUTES causes the discovery of lazy-routes to fail. Further details are documented on #15305. What is the new behavior? With this PR, it's possible to provide a factory method for the DI token ROUTES, and @ngtools/webpack accepts the values provided by the factory with useFactory (as well as provided values with useValue). Does this PR introduce a breaking change? (check one with "x") [ ] Yes [X] No If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... Other information: For these changes, no tests and documents have been added or changed. Actually, there were already no specific tests and documents found to evaluate/document the current and new behavior.

Open Graph Description: Add the required functionality to _collectRoutes function of ngtools_impl.ts, so that the ngtools respect provided factories with p.useFactory (as well as provided values with useValue). Closes #15...

X Description: Add the required functionality to _collectRoutes function of ngtools_impl.ts, so that the ngtools respect provided factories with p.useFactory (as well as provided values with useValue). Closes #15...

Opengraph URL: https://github.com/angular/angular/pull/15334

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5339a8fa-7005-51eb-1817-f592f57be3c2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9406:882E2:D9A20C:120545F:6B00F805
html-safe-nonce7ee4fcd09fb1cc54b9c5736ebffd42077d725f5a6b364a95c15954313a28dedb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDA2Ojg4MkUyOkQ5QTIwQzoxMjA1NDVGOjZCMDBGODA1IiwidmlzaXRvcl9pZCI6IjQxNTk4NDYzMTY2OTgwNDAzMjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfd8ad373307495d650957448e170fa5f3bab48ec09f736458e3d1545672fc1a8
hovercard-subject-tagpull_request:111713908
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/15334/files
twitter:imagehttps://avatars.githubusercontent.com/u/19705684?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19705684?s=400&v=4
og:image:altAdd the required functionality to _collectRoutes function of ngtools_impl.ts, so that the ngtools respect provided factories with p.useFactory (as well as provided values with useValue). Closes #15...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/15334/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F15334%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F15334%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/15334/files
Reloadhttps://github.com/angular/angular/pull/15334/files
Reloadhttps://github.com/angular/angular/pull/15334/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
fulls1z3https://github.com/fulls1z3
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 8 https://github.com/angular/angular/pull/15334
Commits 1 https://github.com/angular/angular/pull/15334/commits
Checks 0 https://github.com/angular/angular/pull/15334/checks
Files changed https://github.com/angular/angular/pull/15334/files
Please reload this pagehttps://github.com/angular/angular/pull/15334/files
fix(compiler-cli): ngtools should accept useFactory (lazy routes) https://github.com/angular/angular/pull/15334/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/15334/files
d22acc7 fix(compiler-cli): ngtools should accept `useFactory` (lazy routes) Mar 21, 2017 https://github.com/angular/angular/pull/15334/commits/d22acc70be7e41d74db82dcdcc224646a4b38598
Clear filters https://github.com/angular/angular/pull/15334/files
Please reload this pagehttps://github.com/angular/angular/pull/15334/files
Please reload this pagehttps://github.com/angular/angular/pull/15334/files
packages/compiler-cli/src/ngtools_impl.tshttps://github.com/angular/angular/pull/15334/files#diff-e1d97a608dc2cff9ab6c78059bd21c4f6eccefbb139a634e37bac461a7a4e8a4
View file https://github.com/angular/angular/blob/d22acc70be7e41d74db82dcdcc224646a4b38598/packages/compiler-cli/src/ngtools_impl.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/15334/{{ revealButtonHref }}
https://github.com/angular/angular/pull/15334/files#diff-e1d97a608dc2cff9ab6c78059bd21c4f6eccefbb139a634e37bac461a7a4e8a4
https://github.com/angular/angular/pull/15334/files#diff-e1d97a608dc2cff9ab6c78059bd21c4f6eccefbb139a634e37bac461a7a4e8a4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.