René's URL Explorer Experiment


Title: [4.x only] feat(compiler): should only inject services annotated with @Injectable by DzmitryShylovich · Pull Request #14931 · angular/angular · GitHub

Open Graph Title: [4.x only] feat(compiler): should only inject services annotated with @Injectable by DzmitryShylovich · Pull Request #14931 · angular/angular

X Title: [4.x only] feat(compiler): should only inject services annotated with @Injectable by DzmitryShylovich · Pull Request #14931 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Closes #12467 Closes #13820

X Description: Closes #12467 Closes #13820

Opengraph URL: https://github.com/angular/angular/pull/14931

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:29fa0cc4-0c40-a13a-7d7a-0412450df0fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2BE:3F4253:1659687:1DB5908:6B013CC5
html-safe-nonceb5227c1dd385637c93dbfe92afb1bfce3a2eca54160c1c0c1839648ac7648005
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkJFOjNGNDI1MzoxNjU5Njg3OjFEQjU5MDg6NkIwMTNDQzUiLCJ2aXNpdG9yX2lkIjoiMzE5NzU3MTczMDY2MzgyNTMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0ae51c30542d95f68730fcfd7e09cad1729108cacb1238f5f6be29703f1b6199
hovercard-subject-tagpull_request:109123748
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/14931/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d93200f60e1166ba6d8f93d6b24e09858cbdad6749b15dc168d933cd2f979e9c/angular/angular/pull/14931
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d93200f60e1166ba6d8f93d6b24e09858cbdad6749b15dc168d933cd2f979e9c/angular/angular/pull/14931
og:image:altCloses #12467 Closes #13820
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDzmitryShylovich
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/14931#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F14931
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F14931
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/14931
Reloadhttps://github.com/angular/angular/pull/14931
Reloadhttps://github.com/angular/angular/pull/14931
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
DzmitryShylovichhttps://github.com/DzmitryShylovich
angular:masterhttps://github.com/angular/angular/tree/master
DzmitryShylovich:gh/13820https://github.com/DzmitryShylovich/angular/tree/gh/13820
Conversationhttps://github.com/angular/angular/pull/14931
Commits1 (1)https://github.com/angular/angular/pull/14931/commits
Checkshttps://github.com/angular/angular/pull/14931/checks
Files changedhttps://github.com/angular/angular/pull/14931/files
[4.x only] feat(compiler): should only inject services annotated with @Injectablehttps://github.com/angular/angular/pull/14931#top
DzmitryShylovichhttps://github.com/DzmitryShylovich
angular:masterhttps://github.com/angular/angular/tree/master
DzmitryShylovich:gh/13820https://github.com/DzmitryShylovich/angular/tree/gh/13820
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
Mar 4, 2017https://github.com/angular/angular/pull/14931#issue-211909031
#12467https://github.com/angular/angular/issues/12467
#13820https://github.com/angular/angular/issues/13820
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 4, 2017https://github.com/angular/angular/pull/14931#event-986593198
https://github.com/DzmitryShylovich
feat(compiler): should only inject services annotated withhttps://github.com/angular/angular/pull/14931/commits/b23ad395b73d15149a804cae623cde05a3419f4c
@Injectablehttps://github.com/Injectable
b23ad39https://github.com/angular/angular/pull/14931/commits/b23ad395b73d15149a804cae623cde05a3419f4c
@Injectablehttps://github.com/Injectable
@Injectablehttps://github.com/Injectable
@componenthttps://github.com/component
@Injectablehttps://github.com/Injectable
@componenthttps://github.com/component
angular#12467https://github.com/angular/angular/issues/12467
angular#13820https://github.com/angular/angular/issues/13820
https://github.com/lacolaco
lacolacohttps://github.com/lacolaco
Mar 13, 2017https://github.com/angular/angular/pull/14931#issuecomment-286001271
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://github.com/Toxicable
Toxicablehttps://github.com/Toxicable
Mar 13, 2017https://github.com/angular/angular/pull/14931#issuecomment-286001838
Please reload this pagehttps://github.com/angular/angular/pull/14931
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://github.com/lacolaco
lacolacohttps://github.com/lacolaco
Mar 13, 2017https://github.com/angular/angular/pull/14931#issuecomment-286002508
Please reload this pagehttps://github.com/angular/angular/pull/14931
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
Mar 13, 2017https://github.com/angular/angular/pull/14931#issuecomment-286032846
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://github.com/lacolaco
lacolacohttps://github.com/lacolaco
Mar 13, 2017https://github.com/angular/angular/pull/14931#issuecomment-286038584
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://angular.io/docs/ts/latest/guide/style-guide.html#!#07-04https://angular.io/docs/ts/latest/guide/style-guide.html#!#07-04
https://angular.io/docs/ts/latest/guide/dependency-injection.html#!#injectablehttps://angular.io/docs/ts/latest/guide/dependency-injection.html#!#injectable
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://github.com/chuckjaz
chuckjazhttps://github.com/chuckjaz
Apr 13, 2017 https://github.com/angular/angular/pull/14931#ref-issue-199326190
[4.x] Don't allow injecting classes without @Injectable #13820 https://github.com/angular/angular/issues/13820
https://github.com/chuckjaz
chuckjazhttps://github.com/chuckjaz
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature
May 23, 2017https://github.com/angular/angular/pull/14931#event-1094536315
https://github.com/vicb
vicbhttps://github.com/vicb
Feb 13, 2018https://github.com/angular/angular/pull/14931#issuecomment-365446135
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://github.com/vicb
vicbhttps://github.com/vicb
Feb 13, 2018https://github.com/angular/angular/pull/14931#event-1472797492
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/14931#issuecomment-531137849
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/14931#event-2631487073
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F14931
Please reload this pagehttps://github.com/angular/angular/pull/14931
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature
[4.x] Don't allow injecting classes without @Injectable https://github.com/angular/angular/issues/13820
Improve error message for when Injectable() is missing https://github.com/angular/angular/issues/12467
Please reload this pagehttps://github.com/angular/angular/pull/14931
https://github.com/DzmitryShylovich
https://github.com/lacolaco
https://github.com/Toxicable
https://github.com/vicb
https://github.com/chuckjaz
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.