| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bbe2d6ec-1821-a50c-3ef8-2d912459559d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA2C:34CAB:503763:67D28A:6B00DAD6 |
| html-safe-nonce | b61d71cb6771ddc6cf5d21a91b06a72177b738f36732b741dd9b04505e9a50cf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTJDOjM0Q0FCOjUwMzc2Mzo2N0QyOEE6NkIwMERBRDYiLCJ2aXNpdG9yX2lkIjoiMzU3MDM5OTEzODA2OTY2NjUxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 38c0a3006e407cf435c4fa54bcbad32bb18f72bbf91afe59145b16bcb8eaabe1 |
| hovercard-subject-tag | pull_request:108874197 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/14894/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ef2849ff456ca57947d40e81b4ff478eb0a94c26fa8242e5de64ebff8489669c/angular/angular/pull/14894 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ef2849ff456ca57947d40e81b4ff478eb0a94c26fa8242e5de64ebff8489669c/angular/angular/pull/14894 |
| og:image:alt | Fixes #12631
What kind of change does this PR introduce? (check one with "x")
[x] Bugfix
What is the current behavior? (You can also link to an open issue here)
ngc will generate an erro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chuckjaz |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/14894#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F14894 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F14894 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/14894 |
| Reload | https://github.com/angular/angular/pull/14894 |
| Reload | https://github.com/angular/angular/pull/14894 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests139 (139) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| chuckjaz | https://github.com/chuckjaz |
| angular:master | https://github.com/angular/angular/tree/master |
| chuckjaz:issue12631 | https://github.com/chuckjaz/angular/tree/issue12631 |
| Conversation | https://github.com/angular/angular/pull/14894 |
| Commits1 (1) | https://github.com/angular/angular/pull/14894/commits |
| Checks | https://github.com/angular/angular/pull/14894/checks |
| Files changed | https://github.com/angular/angular/pull/14894/files |
| fix(compiler): support interface types in injectable constuctors | https://github.com/angular/angular/pull/14894#top |
| chuckjaz | https://github.com/chuckjaz |
| angular:master | https://github.com/angular/angular/tree/master |
| chuckjaz:issue12631 | https://github.com/chuckjaz/angular/tree/issue12631 |
|
| https://github.com/chuckjaz |
| chuckjaz | https://github.com/chuckjaz |
| Mar 2, 2017 | https://github.com/angular/angular/pull/14894#issue-211549272 |
| #12631 | https://github.com/angular/angular/issues/12631 |
| Please reload this page | https://github.com/angular/angular/pull/14894 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 2, 2017 | https://github.com/angular/angular/pull/14894#event-984586039 |
| https://github.com/chuckjaz |
| chuckjaz | https://github.com/chuckjaz |
| force-pushed | https://github.com/angular/angular/compare/940ac04aad988d30a0d15fe6b0cc92de68495cd5..70c8cd2a395ca63a4d4d06bca07de7639f3d44b0 |
| 940ac04 | https://github.com/angular/angular/commit/940ac04aad988d30a0d15fe6b0cc92de68495cd5 |
| 70c8cd2 | https://github.com/angular/angular/commit/70c8cd2a395ca63a4d4d06bca07de7639f3d44b0 |
|
Compare
| https://github.com/angular/angular/compare/940ac04aad988d30a0d15fe6b0cc92de68495cd5..70c8cd2a395ca63a4d4d06bca07de7639f3d44b0 |
| March 2, 2017 23:49 | https://github.com/angular/angular/pull/14894#event-984614913 |
| https://github.com/chuckjaz |
| chuckjaz | https://github.com/chuckjaz |
|
Mar 3, 2017
| https://github.com/angular/angular/pull/14894#ref-issue-182715065 |
|
Better error message when using a service with a generic parameter
#12262
| https://github.com/angular/angular/issues/12262 |
| https://github.com/tbosch |
| tbosch | https://github.com/tbosch |
|
Mar 7, 2017
| https://github.com/angular/angular/pull/14894#pullrequestreview-25407063 |
|
View reviewed changes
| https://github.com/angular/angular/pull/14894/files |
| modules/@angular/compiler/test/aot/static_reflector_spec.ts | https://github.com/angular/angular/pull/14894/files#diff-b74156f18b124435cbcfa3767ea4f16aa9cb3f53ede14ad8b28a3b81585d3b62 |
| tbosch | https://github.com/tbosch |
| Mar 7, 2017 | https://github.com/angular/angular/pull/14894#discussion_r104564522 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/14894 |
| https://github.com/tbosch |
| tbosch | https://github.com/tbosch |
|
Mar 7, 2017
| https://github.com/angular/angular/pull/14894#pullrequestreview-25407444 |
|
View reviewed changes
| https://github.com/angular/angular/pull/14894/files |
| https://github.com/tbosch |
| tbosch | https://github.com/tbosch |
|
Mar 7, 2017
| https://github.com/angular/angular/pull/14894#pullrequestreview-25407820 |
|
View reviewed changes
| https://github.com/angular/angular/pull/14894/files |
| https://github.com/chuckjaz |
| chuckjaz | https://github.com/chuckjaz |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Mar 8, 2017 | https://github.com/angular/angular/pull/14894#event-991772427 |
| https://github.com/chuckjaz |
| chuckjaz | https://github.com/chuckjaz |
| force-pushed | https://github.com/angular/angular/compare/70c8cd2a395ca63a4d4d06bca07de7639f3d44b0..095ad3612df209b36e3901d1d837af70854ce27e |
| 70c8cd2 | https://github.com/angular/angular/commit/70c8cd2a395ca63a4d4d06bca07de7639f3d44b0 |
| 095ad36 | https://github.com/angular/angular/commit/095ad3612df209b36e3901d1d837af70854ce27e |
|
Compare
| https://github.com/angular/angular/compare/70c8cd2a395ca63a4d4d06bca07de7639f3d44b0..095ad3612df209b36e3901d1d837af70854ce27e |
| March 11, 2017 01:17 | https://github.com/angular/angular/pull/14894#event-995798839 |
| https://github.com/chuckjaz |
| chuckjaz | https://github.com/chuckjaz |
|
pr_action: queued
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22pr_action%3A%20queued%22 |
| Mar 13, 2017 | https://github.com/angular/angular/pull/14894#event-997870277 |
|
| https://github.com/chuckjaz |
| fix(compiler): support interface types in injectable constuctors | https://github.com/angular/angular/pull/14894/commits/b40ce9b9b30fa154bce9b913b8f41534ed422b63 |
| b40ce9b | https://github.com/angular/angular/pull/14894/commits/b40ce9b9b30fa154bce9b913b8f41534ed422b63 |
| angular#12631 | https://github.com/angular/angular/issues/12631 |
| https://github.com/chuckjaz |
| chuckjaz | https://github.com/chuckjaz |
| force-pushed | https://github.com/angular/angular/compare/095ad3612df209b36e3901d1d837af70854ce27e..b40ce9b9b30fa154bce9b913b8f41534ed422b63 |
| 095ad36 | https://github.com/angular/angular/commit/095ad3612df209b36e3901d1d837af70854ce27e |
| b40ce9b | https://github.com/angular/angular/commit/b40ce9b9b30fa154bce9b913b8f41534ed422b63 |
|
Compare
| https://github.com/angular/angular/compare/095ad3612df209b36e3901d1d837af70854ce27e..b40ce9b9b30fa154bce9b913b8f41534ed422b63 |
| March 14, 2017 23:50 | https://github.com/angular/angular/pull/14894#event-1000041796 |
| https://github.com/chuckjaz |
| chuckjaz | https://github.com/chuckjaz |
| b00fe20 | https://github.com/angular/angular/commit/b00fe20afd103f4f5406ab25cbd908a32cce56b3 |
| Mar 15, 2017 | https://github.com/angular/angular/pull/14894#event-1001209993 |
| https://github.com/itsdevdom |
| itsdevdom | https://github.com/itsdevdom |
|
Mar 20, 2017
| https://github.com/angular/angular/pull/14894#ref-issue-214193602 |
|
Build in Prod Mode failed
itsdevdom/angular-notifier#7
| https://github.com/itsdevdom/angular-notifier/issues/7 |
| https://github.com/MadUser |
| MadUser | https://github.com/MadUser |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/14894#ref-issue-218200718 |
|
ng build --prod breaks -> support interface types in injectable constuctors
angular/angular-cli#5757
| https://github.com/angular/angular-cli/issues/5757 |
| asnowwolf | https://github.com/asnowwolf |
|
Aug 11, 2017
| https://github.com/angular/angular/pull/14894#ref-commit-b7fe0e9 |
|
| https://github.com/chuckjaz |
| fix(compiler): support interface types in injectable constuctors ( | https://github.com/asnowwolf/angular/commit/b7fe0e912debcc69bf86ed072824e4136f9c4de0 |
| ang… | https://github.com/angular/angular/pull/14894 |
| b7fe0e9 | https://github.com/asnowwolf/angular/commit/b7fe0e912debcc69bf86ed072824e4136f9c4de0 |
| …ular#14894 | https://github.com/angular/angular/pull/14894 |
| angular#12631 | https://github.com/angular/angular/issues/12631 |
| juleskremer | https://github.com/juleskremer |
|
Aug 28, 2017
| https://github.com/angular/angular/pull/14894#ref-commit-45d70ae |
|
| https://github.com/chuckjaz |
|
| https://github.com/juleskremer |
| fix(compiler): support interface types in injectable constuctors ( | https://github.com/juleskremer/angular/commit/45d70aede4e1d30171734923282d4ee3e6a3d4c5 |
| ang… | https://github.com/angular/angular/pull/14894 |
| 45d70ae | https://github.com/juleskremer/angular/commit/45d70aede4e1d30171734923282d4ee3e6a3d4c5 |
| …ular#14894 | https://github.com/angular/angular/pull/14894 |
| angular#12631 | https://github.com/angular/angular/issues/12631 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 11, 2019 | https://github.com/angular/angular/pull/14894#issuecomment-530179802 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/14894 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 11, 2019 | https://github.com/angular/angular/pull/14894#event-2624126159 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F14894 |
|
| https://github.com/tbosch |
|
tbosch
| https://github.com/tbosch |
|
| https://github.com/angular/angular/pull/14894/files/70c8cd2a395ca63a4d4d06bca07de7639f3d44b0 |
| Please reload this page | https://github.com/angular/angular/pull/14894 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
AoT error with @Inject and interface type
| https://github.com/angular/angular/issues/12631 |
| Please reload this page | https://github.com/angular/angular/pull/14894 |
|
| https://github.com/chuckjaz |
|
| https://github.com/tbosch |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |