René's URL Explorer Experiment


Title: fix(router): don't break history when CanDeactivate cancel back navigation by DzmitryShylovich · Pull Request #13922 · angular/angular · GitHub

Open Graph Title: fix(router): don't break history when CanDeactivate cancel back navigation by DzmitryShylovich · Pull Request #13922 · angular/angular

X Title: fix(router): don't break history when CanDeactivate cancel back navigation by DzmitryShylovich · Pull Request #13922 · angular/angular

Description: Closes ##13586 Description: location.back() is called before router so there's no way to prevent if when CanDeactivate return false. To maintain proper history we need to push (location.pushState) new entry into the history instead of replacing (location.replaceState) the current entry. History before the fix Action Length Current index Url Init navigation 1 1 / Navigate /route1 2 2 /route1 Navigate /route2 3 3 /route2 Navigate /route3 4 4 /route3 Navigate back (CanDeactivate false) 4 3 (here we are replacing current state instead of pushing new entry, this is why index is 3 instead of 4) /route3 Navigate back (CanDeactivate true) 4 2 /route1 After the fix Action Length Current index Url Init navigation 1 1 / Navigate /route1 2 2 /route1 Navigate /route2 3 3 /route2 Navigate /route3 4 4 /route3 Navigate back (CanDeactivate false) 4 4 /route3 Navigate back (CanDeactivate true) 4 3 /route2 TLTR our goal: we need to call location.pushState instead of location.replaceState when CanDeactivate cancels back navigation http://plnkr.co/edit/GMkEl74JkQiRPMv6Km5Z?p=preview

Open Graph Description: Closes ##13586 Description: location.back() is called before router so there's no way to prevent if when CanDeactivate return false. To maintain proper history we need to push (location.pushSta...

X Description: Closes ##13586 Description: location.back() is called before router so there's no way to prevent if when CanDeactivate return false. To maintain proper history we need to push (location.pus...

Opengraph URL: https://github.com/angular/angular/pull/13922

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23a001c8-473d-9407-a78c-bf3339ad8b1f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE87A:F7C4C:B45690:F311B0:6B00F6A9
html-safe-noncec3adb9fb4da9055a0b9c60b094bbaf0dedd54c0a6226239293dd07bdb576279b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODdBOkY3QzRDOkI0NTY5MDpGMzExQjA6NkIwMEY2QTkiLCJ2aXNpdG9yX2lkIjoiNzg4NzUxNzc3MDg0ODQ2NjYwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacde571e02ad7ab2d623ecb430a2f1992d7a7ccf7ce4e12153b984f67a34c459ee
hovercard-subject-tagpull_request:101533005
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/13922/files
twitter:imagehttps://avatars.githubusercontent.com/u/9335533?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9335533?s=400&v=4
og:image:altCloses ##13586 Description: location.back() is called before router so there's no way to prevent if when CanDeactivate return false. To maintain proper history we need to push (location.pushSta...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/13922/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13922%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13922%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/13922/files
Reloadhttps://github.com/angular/angular/pull/13922/files
Reloadhttps://github.com/angular/angular/pull/13922/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
DzmitryShylovichhttps://github.com/DzmitryShylovich
angular:masterhttps://github.com/angular/angular/tree/master
DzmitryShylovich:gh/13586https://github.com/DzmitryShylovich/angular/tree/gh/13586
Conversation 14 https://github.com/angular/angular/pull/13922
Commits 1 https://github.com/angular/angular/pull/13922/commits
Checks 0 https://github.com/angular/angular/pull/13922/checks
Files changed https://github.com/angular/angular/pull/13922/files
Please reload this pagehttps://github.com/angular/angular/pull/13922/files
fix(router): don't break history when CanDeactivate cancel back navigation https://github.com/angular/angular/pull/13922/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/13922/files
81f02d2 fix(router): shouldn't break history when CanDeactivate cancel back DzmitryShylovich Jan 13, 2017 https://github.com/angular/angular/pull/13922/commits/81f02d264c088ced84365fbda9c0ff08292857c7
Clear filters https://github.com/angular/angular/pull/13922/files
Please reload this pagehttps://github.com/angular/angular/pull/13922/files
Please reload this pagehttps://github.com/angular/angular/pull/13922/files
router.ts https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
integration.spec.ts https://github.com/angular/angular/pull/13922/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
packages/router/src/router.tshttps://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
View file https://github.com/DzmitryShylovich/angular/blob/81f02d264c088ced84365fbda9c0ff08292857c7/packages/router/src/router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13922/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/13922/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/13922/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
View file https://github.com/DzmitryShylovich/angular/blob/81f02d264c088ced84365fbda9c0ff08292857c7/packages/router/test/integration.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13922/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13922/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/13922/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/13922/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/13922/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/13922/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/13922/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.