René's URL Explorer Experiment


Title: fix(router): don't break history when CanDeactivate cancel back navigation by DzmitryShylovich · Pull Request #13922 · angular/angular · GitHub

Open Graph Title: fix(router): don't break history when CanDeactivate cancel back navigation by DzmitryShylovich · Pull Request #13922 · angular/angular

X Title: fix(router): don't break history when CanDeactivate cancel back navigation by DzmitryShylovich · Pull Request #13922 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Closes ##13586 Description: location.back() is called before router so there's no way to prevent if when CanDeactivate return false. To maintain proper history we need to push (location.pushSta...

X Description: Closes ##13586 Description: location.back() is called before router so there's no way to prevent if when CanDeactivate return false. To maintain proper history we need to push (location.pus...

Opengraph URL: https://github.com/angular/angular/pull/13922

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d6e03d1e-9510-20d2-a822-781dce3c2748
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE508:91CF4:B7E068:F53768:6B00EEA9
html-safe-nonce2e2207ac89b923a88563b5ee68e863880d5d557e66ae6c47fab39b8dc19f9aad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTA4OjkxQ0Y0OkI3RTA2ODpGNTM3Njg6NkIwMEVFQTkiLCJ2aXNpdG9yX2lkIjoiMzQ2NTU0NjMyMDUxNTc1NTY4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac424e325c75080329ad4e8c4e98c709735737adf361c07f8644304f20c55a8d17
hovercard-subject-tagpull_request:101533005
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/13922/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/77a712792c8865a5935069b2cec7af5a74f62269679fabfc0aeb75a4dacee0c5/angular/angular/pull/13922
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/77a712792c8865a5935069b2cec7af5a74f62269679fabfc0aeb75a4dacee0c5/angular/angular/pull/13922
og:image:altCloses ##13586 Description: location.back() is called before router so there's no way to prevent if when CanDeactivate return false. To maintain proper history we need to push (location.pushSta...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDzmitryShylovich
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/13922#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13922
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13922
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/13922
Reloadhttps://github.com/angular/angular/pull/13922
Reloadhttps://github.com/angular/angular/pull/13922
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
DzmitryShylovichhttps://github.com/DzmitryShylovich
angular:masterhttps://github.com/angular/angular/tree/master
DzmitryShylovich:gh/13586https://github.com/DzmitryShylovich/angular/tree/gh/13586
Conversationhttps://github.com/angular/angular/pull/13922
Commits1 (1)https://github.com/angular/angular/pull/13922/commits
Checkshttps://github.com/angular/angular/pull/13922/checks
Files changedhttps://github.com/angular/angular/pull/13922/files
fix(router): don't break history when CanDeactivate cancel back navigationhttps://github.com/angular/angular/pull/13922#top
DzmitryShylovichhttps://github.com/DzmitryShylovich
angular:masterhttps://github.com/angular/angular/tree/master
DzmitryShylovich:gh/13586https://github.com/DzmitryShylovich/angular/tree/gh/13586
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
Jan 13, 2017https://github.com/angular/angular/pull/13922#issue-200754048
Please reload this pagehttps://github.com/angular/angular/pull/13922
#13586https://github.com/angular/angular/issues/13586
http://plnkr.co/edit/GMkEl74JkQiRPMv6Km5Z?p=previewhttp://plnkr.co/edit/GMkEl74JkQiRPMv6Km5Z?p=preview
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jan 13, 2017https://github.com/angular/angular/pull/13922#event-922964016
https://github.com/mhevery
mheveryhttps://github.com/mhevery
vicbhttps://github.com/vicb
January 18, 2017 23:56https://github.com/angular/angular/pull/13922#event-928355628
https://github.com/mhevery
mheveryhttps://github.com/mhevery
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Jan 18, 2017https://github.com/angular/angular/pull/13922#event-928355702
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Feb 10, 2017https://github.com/angular/angular/pull/13922#issuecomment-279075070
@vicbhttps://github.com/vicb
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/vicb
vicbhttps://github.com/vicb
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Mar 29, 2017https://github.com/angular/angular/pull/13922#event-1019555182
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 29, 2017https://github.com/angular/angular/pull/13922#issuecomment-290246524
@DzmitryShylovichhttps://github.com/DzmitryShylovich
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017 https://github.com/angular/angular/pull/13922#pullrequestreview-30099944
View reviewed changes https://github.com/angular/angular/pull/13922/files
modules/@angular/router/src/router.tshttps://github.com/angular/angular/pull/13922/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
vicbhttps://github.com/vicb
Mar 30, 2017https://github.com/angular/angular/pull/13922#discussion_r109024852
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/13922
DzmitryShylovichhttps://github.com/DzmitryShylovich
Mar 30, 2017https://github.com/angular/angular/pull/13922#discussion_r109025395
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
thishttps://github.com/angular/angular/pull/13922/files#diff-f48b128ef12ddeb072207e5ba88d04eeR1954
Please reload this pagehttps://github.com/angular/angular/pull/13922
DzmitryShylovichhttps://github.com/DzmitryShylovich
Mar 30, 2017https://github.com/angular/angular/pull/13922#discussion_r109040344
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017 https://github.com/angular/angular/pull/13922#pullrequestreview-30100055
View reviewed changes https://github.com/angular/angular/pull/13922/files
modules/@angular/router/src/router.tshttps://github.com/angular/angular/pull/13922/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
vicbhttps://github.com/vicb
Mar 30, 2017https://github.com/angular/angular/pull/13922#discussion_r109024961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/vicb
vicbhttps://github.com/vicb
Mar 30, 2017 https://github.com/angular/angular/pull/13922#pullrequestreview-30100103
View reviewed changes https://github.com/angular/angular/pull/13922/files
vicbhttps://github.com/vicb
https://github.com/angular/angular/pull/13922#pullrequestreview-30100103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/vicb
vicbhttps://github.com/vicb
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Mar 30, 2017https://github.com/angular/angular/pull/13922#event-1023030694
https://github.com/DzmitryShylovich
fix(router): shouldn't break history when CanDeactivate cancel backhttps://github.com/angular/angular/pull/13922/commits/81f02d264c088ced84365fbda9c0ff08292857c7
81f02d2https://github.com/angular/angular/pull/13922/commits/81f02d264c088ced84365fbda9c0ff08292857c7
angular#13586https://github.com/angular/angular/issues/13586
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
Mar 30, 2017https://github.com/angular/angular/pull/13922#issuecomment-290574181
Please reload this pagehttps://github.com/angular/angular/pull/13922
@vicbhttps://github.com/vicb
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
Mar 31, 2017https://github.com/angular/angular/pull/13922#issuecomment-290700751
@vicbhttps://github.com/vicb
#15664https://github.com/angular/angular/issues/15664
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/bakhshi
bakhshihttps://github.com/bakhshi
May 24, 2017 https://github.com/angular/angular/pull/13922#pullrequestreview-40016669
View reviewed changes https://github.com/angular/angular/pull/13922/files/81f02d264c088ced84365fbda9c0ff08292857c7
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Jul 14, 2017 https://github.com/angular/angular/pull/13922#ref-pullrequest-243102712
fix(router): shouldn't break history when CanDeactivate cancel back #18135 https://github.com/angular/angular/pull/18135
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Jul 14, 2017https://github.com/angular/angular/pull/13922#issuecomment-315458893
#18135https://github.com/angular/angular/pull/18135
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Jul 14, 2017https://github.com/angular/angular/pull/13922#event-1164908059
https://github.com/blueberrynotblue
blueberrynotbluehttps://github.com/blueberrynotblue
Aug 3, 2017https://github.com/angular/angular/pull/13922#issuecomment-319879830
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/UlricW
UlricWhttps://github.com/UlricW
Jan 12, 2018https://github.com/angular/angular/pull/13922#issuecomment-357255349
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/zvonimirprofico
zvonimirproficohttps://github.com/zvonimirprofico
Apr 22, 2019https://github.com/angular/angular/pull/13922#issuecomment-485428048
#13586 (comment)https://github.com/angular/angular/issues/13586#issuecomment-485036336
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/13922#issuecomment-531522359
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/13922#event-2634386718
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13922
https://github.com/vicb
vicb https://github.com/vicb
https://github.com/angular/angular/pull/13922/files/96b0b21aa0d4f4608b187297b939bddf51025396
https://github.com/bakhshi
bakhshi https://github.com/bakhshi
https://github.com/angular/angular/pull/13922/files/81f02d264c088ced84365fbda9c0ff08292857c7
Please reload this pagehttps://github.com/angular/angular/pull/13922
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/angular/angular/pull/13922
https://github.com/DzmitryShylovich
https://github.com/mhevery
https://github.com/vicb
https://github.com/jasonaden
https://github.com/blueberrynotblue
https://github.com/UlricW
https://github.com/zvonimirprofico
https://github.com/bakhshi
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.