| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d6e03d1e-9510-20d2-a822-781dce3c2748 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E508:91CF4:B7E068:F53768:6B00EEA9 |
| html-safe-nonce | 2e2207ac89b923a88563b5ee68e863880d5d557e66ae6c47fab39b8dc19f9aad |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTA4OjkxQ0Y0OkI3RTA2ODpGNTM3Njg6NkIwMEVFQTkiLCJ2aXNpdG9yX2lkIjoiMzQ2NTU0NjMyMDUxNTc1NTY4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 424e325c75080329ad4e8c4e98c709735737adf361c07f8644304f20c55a8d17 |
| hovercard-subject-tag | pull_request:101533005 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/13922/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/77a712792c8865a5935069b2cec7af5a74f62269679fabfc0aeb75a4dacee0c5/angular/angular/pull/13922 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/77a712792c8865a5935069b2cec7af5a74f62269679fabfc0aeb75a4dacee0c5/angular/angular/pull/13922 |
| og:image:alt | Closes ##13586
Description:
location.back() is called before router so there's no way to prevent if when CanDeactivate return false.
To maintain proper history we need to push (location.pushSta... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DzmitryShylovich |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/13922#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13922 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13922 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/13922 |
| Reload | https://github.com/angular/angular/pull/13922 |
| Reload | https://github.com/angular/angular/pull/13922 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| angular:master | https://github.com/angular/angular/tree/master |
| DzmitryShylovich:gh/13586 | https://github.com/DzmitryShylovich/angular/tree/gh/13586 |
| Conversation | https://github.com/angular/angular/pull/13922 |
| Commits1 (1) | https://github.com/angular/angular/pull/13922/commits |
| Checks | https://github.com/angular/angular/pull/13922/checks |
| Files changed | https://github.com/angular/angular/pull/13922/files |
| fix(router): don't break history when CanDeactivate cancel back navigation | https://github.com/angular/angular/pull/13922#top |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| angular:master | https://github.com/angular/angular/tree/master |
| DzmitryShylovich:gh/13586 | https://github.com/DzmitryShylovich/angular/tree/gh/13586 |
|
| https://github.com/DzmitryShylovich |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| Jan 13, 2017 | https://github.com/angular/angular/pull/13922#issue-200754048 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| #13586 | https://github.com/angular/angular/issues/13586 |
| http://plnkr.co/edit/GMkEl74JkQiRPMv6Km5Z?p=preview | http://plnkr.co/edit/GMkEl74JkQiRPMv6Km5Z?p=preview |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jan 13, 2017 | https://github.com/angular/angular/pull/13922#event-922964016 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| vicb | https://github.com/vicb |
| January 18, 2017 23:56 | https://github.com/angular/angular/pull/13922#event-928355628 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
| Jan 18, 2017 | https://github.com/angular/angular/pull/13922#event-928355702 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Feb 10, 2017 | https://github.com/angular/angular/pull/13922#issuecomment-279075070 |
| @vicb | https://github.com/vicb |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 29, 2017 | https://github.com/angular/angular/pull/13922#event-1019555182 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| Mar 29, 2017 | https://github.com/angular/angular/pull/13922#issuecomment-290246524 |
| @DzmitryShylovich | https://github.com/DzmitryShylovich |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/13922#pullrequestreview-30099944 |
|
View reviewed changes
| https://github.com/angular/angular/pull/13922/files |
| modules/@angular/router/src/router.ts | https://github.com/angular/angular/pull/13922/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb |
| vicb | https://github.com/vicb |
| Mar 30, 2017 | https://github.com/angular/angular/pull/13922#discussion_r109024852 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| Mar 30, 2017 | https://github.com/angular/angular/pull/13922#discussion_r109025395 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this | https://github.com/angular/angular/pull/13922/files#diff-f48b128ef12ddeb072207e5ba88d04eeR1954 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| Mar 30, 2017 | https://github.com/angular/angular/pull/13922#discussion_r109040344 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/13922#pullrequestreview-30100055 |
|
View reviewed changes
| https://github.com/angular/angular/pull/13922/files |
| modules/@angular/router/src/router.ts | https://github.com/angular/angular/pull/13922/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb |
| vicb | https://github.com/vicb |
| Mar 30, 2017 | https://github.com/angular/angular/pull/13922#discussion_r109024961 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 30, 2017
| https://github.com/angular/angular/pull/13922#pullrequestreview-30100103 |
|
View reviewed changes
| https://github.com/angular/angular/pull/13922/files |
| vicb | https://github.com/vicb |
| https://github.com/angular/angular/pull/13922#pullrequestreview-30100103 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 30, 2017 | https://github.com/angular/angular/pull/13922#event-1023030694 |
|
| https://github.com/DzmitryShylovich |
| fix(router): shouldn't break history when CanDeactivate cancel back | https://github.com/angular/angular/pull/13922/commits/81f02d264c088ced84365fbda9c0ff08292857c7 |
| 81f02d2 | https://github.com/angular/angular/pull/13922/commits/81f02d264c088ced84365fbda9c0ff08292857c7 |
| angular#13586 | https://github.com/angular/angular/issues/13586 |
| https://github.com/DzmitryShylovich |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| Mar 30, 2017 | https://github.com/angular/angular/pull/13922#issuecomment-290574181 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| @vicb | https://github.com/vicb |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/DzmitryShylovich |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| Mar 31, 2017 | https://github.com/angular/angular/pull/13922#issuecomment-290700751 |
| @vicb | https://github.com/vicb |
| #15664 | https://github.com/angular/angular/issues/15664 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/bakhshi |
| bakhshi | https://github.com/bakhshi |
|
May 24, 2017
| https://github.com/angular/angular/pull/13922#pullrequestreview-40016669 |
|
View reviewed changes
| https://github.com/angular/angular/pull/13922/files/81f02d264c088ced84365fbda9c0ff08292857c7 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
Jul 14, 2017
| https://github.com/angular/angular/pull/13922#ref-pullrequest-243102712 |
|
fix(router): shouldn't break history when CanDeactivate cancel back
#18135
| https://github.com/angular/angular/pull/18135 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| Jul 14, 2017 | https://github.com/angular/angular/pull/13922#issuecomment-315458893 |
| #18135 | https://github.com/angular/angular/pull/18135 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| Jul 14, 2017 | https://github.com/angular/angular/pull/13922#event-1164908059 |
| https://github.com/blueberrynotblue |
| blueberrynotblue | https://github.com/blueberrynotblue |
| Aug 3, 2017 | https://github.com/angular/angular/pull/13922#issuecomment-319879830 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/UlricW |
| UlricW | https://github.com/UlricW |
| Jan 12, 2018 | https://github.com/angular/angular/pull/13922#issuecomment-357255349 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/zvonimirprofico |
| zvonimirprofico | https://github.com/zvonimirprofico |
| Apr 22, 2019 | https://github.com/angular/angular/pull/13922#issuecomment-485428048 |
| #13586 (comment) | https://github.com/angular/angular/issues/13586#issuecomment-485036336 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/13922#issuecomment-531522359 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/13922#event-2634386718 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13922 |
|
| https://github.com/vicb |
|
vicb
| https://github.com/vicb |
|
| https://github.com/angular/angular/pull/13922/files/96b0b21aa0d4f4608b187297b939bddf51025396 |
|
| https://github.com/bakhshi |
|
bakhshi
| https://github.com/bakhshi |
|
| https://github.com/angular/angular/pull/13922/files/81f02d264c088ced84365fbda9c0ff08292857c7 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/angular/angular/pull/13922 |
|
| https://github.com/DzmitryShylovich |
|
| https://github.com/mhevery |
|
| https://github.com/vicb |
|
| https://github.com/jasonaden |
|
| https://github.com/blueberrynotblue |
|
| https://github.com/UlricW |
|
| https://github.com/zvonimirprofico |
|
| https://github.com/bakhshi |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |