René's URL Explorer Experiment


Title: fix(router): eager loading with loadChildren in aot by DzmitryShylovich · Pull Request #13909 · angular/angular · GitHub

Open Graph Title: fix(router): eager loading with loadChildren in aot by DzmitryShylovich · Pull Request #13909 · angular/angular

X Title: fix(router): eager loading with loadChildren in aot by DzmitryShylovich · Pull Request #13909 · angular/angular

Description: Closes #11075 Description: Runtime compiler is not available after aot compilation, so we need to return NgModuleFactory instead of just NgModule, because we cannot compile it at runtime. import { Routes, RouterModule, PreloadAllModules } from '@angular/router'; import { HomeComponent } from './home/home.component'; import { ProfileModuleNgFactory } from '../compiled/src/app/profile.module.ngfactory'; export function loadProfileModule() { return ProfileModuleNgFactory; } export const routes: Routes = [ { path: '', component: HomeComponent, pathMatch: 'full' }, { path: 'profile', loadChildren: loadProfileModule} ]; export const routing = RouterModule.forRoot(routes); instead of import { Routes, RouterModule, PreloadAllModules } from '@angular/router'; import { HomeComponent } from './home/home.component'; import { ProfileModule } from './profile/profile.module'; export function loadProfileModule() { return ProfileModule; } export const routes: Routes = [ { path: '', component: HomeComponent, pathMatch: 'full' }, { path: 'profile', loadChildren: loadProfileModule} ]; export const routing = RouterModule.forRoot(routes);

Open Graph Description: Closes #11075 Description: Runtime compiler is not available after aot compilation, so we need to return NgModuleFactory instead of just NgModule, because we cannot compile it at runtime. import { ...

X Description: Closes #11075 Description: Runtime compiler is not available after aot compilation, so we need to return NgModuleFactory instead of just NgModule, because we cannot compile it at runtime. import { ...

Opengraph URL: https://github.com/angular/angular/pull/13909

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:87cbfea3-f459-cf1e-315a-f200e49f8d04
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD288:2D40DE:1671C2A:1C82BB1:6B017521
html-safe-noncee37b0b1adc416442dbdb281821d5c914ea6bc1f1ee085fc8e027d0996b8558c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjg4OjJENDBERToxNjcxQzJBOjFDODJCQjE6NkIwMTc1MjEiLCJ2aXNpdG9yX2lkIjoiODQ3MTk0MzA3NjE0NTg4NjQ5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaf1840d886633b98b0a7e52dcd983865ec894d8081ec62606870399a92151cc3
hovercard-subject-tagpull_request:101403639
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/13909/files
twitter:imagehttps://avatars.githubusercontent.com/u/9335533?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9335533?s=400&v=4
og:image:altCloses #11075 Description: Runtime compiler is not available after aot compilation, so we need to return NgModuleFactory instead of just NgModule, because we cannot compile it at runtime. import { ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/13909/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13909%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13909%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/13909/files
Reloadhttps://github.com/angular/angular/pull/13909/files
Reloadhttps://github.com/angular/angular/pull/13909/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
mheveryhttps://github.com/mhevery
angular:masterhttps://github.com/angular/angular/tree/master
DzmitryShylovich:gh/11075https://github.com/DzmitryShylovich/angular/tree/gh/11075
Conversation 8 https://github.com/angular/angular/pull/13909
Commits 1 https://github.com/angular/angular/pull/13909/commits
Checks 0 https://github.com/angular/angular/pull/13909/checks
Files changed https://github.com/angular/angular/pull/13909/files
Please reload this pagehttps://github.com/angular/angular/pull/13909/files
fix(router): eager loading with loadChildren in aot https://github.com/angular/angular/pull/13909/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/13909/files
47b1031 fix(router): enable loadChildren with function in aot DzmitryShylovich Jan 13, 2017 https://github.com/angular/angular/pull/13909/commits/47b1031ba4552fd840817da9b7aa7da5780854a8
Clear filters https://github.com/angular/angular/pull/13909/files
Please reload this pagehttps://github.com/angular/angular/pull/13909/files
Please reload this pagehttps://github.com/angular/angular/pull/13909/files
config.ts https://github.com/angular/angular/pull/13909/files#diff-7a89c304351201f1d71851fbbb61a4c5eadcc4b2a9e8ab06dec96634b50dc739
collection.ts https://github.com/angular/angular/pull/13909/files#diff-34ad1fe02cd4152a1f8ed3d25bb3af7abe850feac142df8ef4cccb112c93edcf
index.d.ts https://github.com/angular/angular/pull/13909/files#diff-6efb155b2d620956b1b015413760cf821aa65e65e825635eef685638f4e9a7c0
modules/@angular/router/src/config.tshttps://github.com/angular/angular/pull/13909/files#diff-7a89c304351201f1d71851fbbb61a4c5eadcc4b2a9e8ab06dec96634b50dc739
View file https://github.com/DzmitryShylovich/angular/blob/47b1031ba4552fd840817da9b7aa7da5780854a8/modules/%40angular/router/src/config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13909/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13909/files#diff-7a89c304351201f1d71851fbbb61a4c5eadcc4b2a9e8ab06dec96634b50dc739
https://github.com/angular/angular/pull/13909/files#diff-7a89c304351201f1d71851fbbb61a4c5eadcc4b2a9e8ab06dec96634b50dc739
https://github.com/angular/angular/pull/13909/files#diff-7a89c304351201f1d71851fbbb61a4c5eadcc4b2a9e8ab06dec96634b50dc739
https://github.com/angular/angular/pull/13909/files#diff-7a89c304351201f1d71851fbbb61a4c5eadcc4b2a9e8ab06dec96634b50dc739
modules/@angular/router/src/utils/collection.tshttps://github.com/angular/angular/pull/13909/files#diff-34ad1fe02cd4152a1f8ed3d25bb3af7abe850feac142df8ef4cccb112c93edcf
View file https://github.com/DzmitryShylovich/angular/blob/47b1031ba4552fd840817da9b7aa7da5780854a8/modules/%40angular/router/src/utils/collection.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13909/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13909/files#diff-34ad1fe02cd4152a1f8ed3d25bb3af7abe850feac142df8ef4cccb112c93edcf
https://github.com/angular/angular/pull/13909/files#diff-34ad1fe02cd4152a1f8ed3d25bb3af7abe850feac142df8ef4cccb112c93edcf
https://github.com/angular/angular/pull/13909/files#diff-34ad1fe02cd4152a1f8ed3d25bb3af7abe850feac142df8ef4cccb112c93edcf
https://github.com/angular/angular/pull/13909/files#diff-34ad1fe02cd4152a1f8ed3d25bb3af7abe850feac142df8ef4cccb112c93edcf
tools/public_api_guard/router/index.d.tshttps://github.com/angular/angular/pull/13909/files#diff-6efb155b2d620956b1b015413760cf821aa65e65e825635eef685638f4e9a7c0
View file https://github.com/DzmitryShylovich/angular/blob/47b1031ba4552fd840817da9b7aa7da5780854a8/tools/public_api_guard/router/index.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13909/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13909/files#diff-6efb155b2d620956b1b015413760cf821aa65e65e825635eef685638f4e9a7c0
https://github.com/angular/angular/pull/13909/files#diff-6efb155b2d620956b1b015413760cf821aa65e65e825635eef685638f4e9a7c0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.