René's URL Explorer Experiment


Title: fix(router): eager loading with loadChildren in aot by DzmitryShylovich · Pull Request #13909 · angular/angular · GitHub

Open Graph Title: fix(router): eager loading with loadChildren in aot by DzmitryShylovich · Pull Request #13909 · angular/angular

X Title: fix(router): eager loading with loadChildren in aot by DzmitryShylovich · Pull Request #13909 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Closes #11075 Description: Runtime compiler is not available after aot compilation, so we need to return NgModuleFactory instead of just NgModule, because we cannot compile it at runtime. import { ...

X Description: Closes #11075 Description: Runtime compiler is not available after aot compilation, so we need to return NgModuleFactory instead of just NgModule, because we cannot compile it at runtime. import { ...

Opengraph URL: https://github.com/angular/angular/pull/13909

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1e5fc055-e0ca-0982-80be-7d52edb8f2e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E08:95C88:15FF031:1D15623:6B012E25
html-safe-nonce057869b89022604eda5cd9b83348ddd49c707bc4a76e3a8142a61bd246b95db5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTA4Ojk1Qzg4OjE1RkYwMzE6MUQxNTYyMzo2QjAxMkUyNSIsInZpc2l0b3JfaWQiOiIyMzQ0NTM4NDA3MTkzMDk1NzE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb0e4b7184a29960a5394a9416de7038dd8b6182e7dd4a60ae723e55b14bc87c9
hovercard-subject-tagpull_request:101403639
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/13909/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/42f40071169db5e697bf1287e2fafbc03f653c9fd41e20eb3a8d01ab111a04a7/angular/angular/pull/13909
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/42f40071169db5e697bf1287e2fafbc03f653c9fd41e20eb3a8d01ab111a04a7/angular/angular/pull/13909
og:image:altCloses #11075 Description: Runtime compiler is not available after aot compilation, so we need to return NgModuleFactory instead of just NgModule, because we cannot compile it at runtime. import { ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDzmitryShylovich
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/13909#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13909
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13909
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/13909
Reloadhttps://github.com/angular/angular/pull/13909
Reloadhttps://github.com/angular/angular/pull/13909
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
mheveryhttps://github.com/mhevery
angular:masterhttps://github.com/angular/angular/tree/master
DzmitryShylovich:gh/11075https://github.com/DzmitryShylovich/angular/tree/gh/11075
Conversationhttps://github.com/angular/angular/pull/13909
Commits1 (1)https://github.com/angular/angular/pull/13909/commits
Checkshttps://github.com/angular/angular/pull/13909/checks
Files changedhttps://github.com/angular/angular/pull/13909/files
fix(router): eager loading with loadChildren in aothttps://github.com/angular/angular/pull/13909#top
mheveryhttps://github.com/mhevery
angular:masterhttps://github.com/angular/angular/tree/master
DzmitryShylovich:gh/11075https://github.com/DzmitryShylovich/angular/tree/gh/11075
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
Jan 13, 2017https://github.com/angular/angular/pull/13909#issue-200568935
Please reload this pagehttps://github.com/angular/angular/pull/13909
#11075https://github.com/angular/angular/issues/11075
Please reload this pagehttps://github.com/angular/angular/pull/13909
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jan 13, 2017https://github.com/angular/angular/pull/13909#event-921892444
https://github.com/DzmitryShylovich
fix(router): enable loadChildren with function in aothttps://github.com/angular/angular/pull/13909/commits/47b1031ba4552fd840817da9b7aa7da5780854a8
47b1031https://github.com/angular/angular/pull/13909/commits/47b1031ba4552fd840817da9b7aa7da5780854a8
angular#11075https://github.com/angular/angular/issues/11075
https://github.com/mhevery
mheveryhttps://github.com/mhevery
pr_state: LGTM https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22pr_state%3A%20LGTM%22
Jan 18, 2017https://github.com/angular/angular/pull/13909#event-928355202
https://github.com/mhevery
mheveryhttps://github.com/mhevery
635bf02https://github.com/angular/angular/commit/635bf02b02973c62fb0180e64732fe601d350a45
Jan 18, 2017https://github.com/angular/angular/pull/13909#event-928355434
mheveryhttps://github.com/mhevery
Jan 19, 2017 https://github.com/angular/angular/pull/13909#ref-commit-2af5862
https://github.com/mhevery
fix(router): enable loadChildren with function in aot (https://github.com/angular/angular/commit/2af58622c1789673a527125e059af4c553598a26
#13909https://github.com/angular/angular/pull/13909
)https://github.com/angular/angular/commit/2af58622c1789673a527125e059af4c553598a26
2af5862https://github.com/angular/angular/commit/2af58622c1789673a527125e059af4c553598a26
#11075https://github.com/angular/angular/issues/11075
https://github.com/SamVerschueren
SamVerschuerenhttps://github.com/SamVerschueren
Jan 19, 2017https://github.com/angular/angular/pull/13909#issuecomment-273697307
Please reload this pagehttps://github.com/angular/angular/pull/13909
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
Jan 19, 2017https://github.com/angular/angular/pull/13909#issuecomment-273698888
@SamVerschuerenhttps://github.com/SamVerschueren
Please reload this pagehttps://github.com/angular/angular/pull/13909
https://github.com/DzmitryShylovich
DzmitryShylovichhttps://github.com/DzmitryShylovich
Jan 19, 2017https://github.com/angular/angular/pull/13909#issuecomment-273705042
@SamVerschuerenhttps://github.com/SamVerschueren
Please reload this pagehttps://github.com/angular/angular/pull/13909
https://github.com/SamVerschueren
SamVerschuerenhttps://github.com/SamVerschueren
Jan 19, 2017 https://github.com/angular/angular/pull/13909#ref-issue-201791180
[compiler-cli] Change references from NgModule to NgModuleFactory at build-time #14005 https://github.com/angular/angular/issues/14005
https://github.com/SamVerschueren
SamVerschuerenhttps://github.com/SamVerschueren
Jan 19, 2017https://github.com/angular/angular/pull/13909#issuecomment-273708825
@DzmitryShylovichhttps://github.com/DzmitryShylovich
#14005https://github.com/angular/angular/issues/14005
Please reload this pagehttps://github.com/angular/angular/pull/13909
https://github.com/maxime1992
maxime1992https://github.com/maxime1992
Jan 20, 2017 https://github.com/angular/angular/pull/13909#ref-issue-190481632
ng build -aot error 'entry.split is not a function' on lazy loaded modules angular/angular-cli#3204 https://github.com/angular/angular-cli/issues/3204
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Jan 23, 2017https://github.com/angular/angular/pull/13909#issuecomment-274650555
@samherrmannhttps://github.com/samherrmann
Please reload this pagehttps://github.com/angular/angular/pull/13909
https://github.com/maxime1992
maxime1992https://github.com/maxime1992
Jan 24, 2017 https://github.com/angular/angular/pull/13909#ref-issue-202742062
AOT broken when using loadChildren and a function : Replace modules import by modules factories ? angular/angular-cli#4192 https://github.com/angular/angular-cli/issues/4192
https://github.com/SamVerschueren
SamVerschuerenhttps://github.com/SamVerschueren
Jan 24, 2017https://github.com/angular/angular/pull/13909#issuecomment-274743276
@mheveryhttps://github.com/mhevery
Please reload this pagehttps://github.com/angular/angular/pull/13909
wKozahttps://github.com/wKoza
Feb 12, 2017 https://github.com/angular/angular/pull/13909#ref-commit-fac2a07
https://github.com/DzmitryShylovich
https://github.com/wKoza
fix(router): enable loadChildren with function in aot (https://github.com/wKoza/angular/commit/fac2a075c9ad75a021adbfe7d06fefa823a710d3
angular#13909https://github.com/angular/angular/pull/13909
)https://github.com/wKoza/angular/commit/fac2a075c9ad75a021adbfe7d06fefa823a710d3
fac2a07https://github.com/wKoza/angular/commit/fac2a075c9ad75a021adbfe7d06fefa823a710d3
angular#11075https://github.com/angular/angular/issues/11075
https://github.com/antonmoiseev
antonmoiseevhttps://github.com/antonmoiseev
Jul 12, 2017 https://github.com/angular/angular/pull/13909#ref-issue-242094428
Router fails to synchronously load NgModule with "Runtime compiler is not loaded" error #18061 https://github.com/angular/angular/issues/18061
juleskremerhttps://github.com/juleskremer
Aug 28, 2017 https://github.com/angular/angular/pull/13909#ref-commit-ebc9b58
https://github.com/DzmitryShylovich
https://github.com/juleskremer
fix(router): enable loadChildren with function in aot (https://github.com/juleskremer/angular/commit/ebc9b587938d139d7958af6e9a951ebcf902580f
angular#13909https://github.com/angular/angular/pull/13909
)https://github.com/juleskremer/angular/commit/ebc9b587938d139d7958af6e9a951ebcf902580f
ebc9b58https://github.com/juleskremer/angular/commit/ebc9b587938d139d7958af6e9a951ebcf902580f
angular#11075https://github.com/angular/angular/issues/11075
https://github.com/DhiaEddineSaidi
DhiaEddineSaidihttps://github.com/DhiaEddineSaidi
Apr 23, 2018https://github.com/angular/angular/pull/13909#issuecomment-383448621
Please reload this pagehttps://github.com/angular/angular/pull/13909
Error: Runtime compiler is not loaded in angular6 --prod mode #23878 https://github.com/angular/angular/issues/23878
Angular upgrade to version 7 lazy loaded module cannot be found #27023 https://github.com/angular/angular/issues/27023
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/13909#issuecomment-531245100
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/13909
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/13909#event-2632409224
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13909
Please reload this pagehttps://github.com/angular/angular/pull/13909
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
(bug)router/AOT Unable to use feature-modules in routing when doing AOT compilation https://github.com/angular/angular/issues/11075
Please reload this pagehttps://github.com/angular/angular/pull/13909
https://github.com/DzmitryShylovich
https://github.com/SamVerschueren
https://github.com/mhevery
https://github.com/DhiaEddineSaidi
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.