| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1e5fc055-e0ca-0982-80be-7d52edb8f2e2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E08:95C88:15FF031:1D15623:6B012E25 |
| html-safe-nonce | 057869b89022604eda5cd9b83348ddd49c707bc4a76e3a8142a61bd246b95db5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTA4Ojk1Qzg4OjE1RkYwMzE6MUQxNTYyMzo2QjAxMkUyNSIsInZpc2l0b3JfaWQiOiIyMzQ0NTM4NDA3MTkzMDk1NzE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b0e4b7184a29960a5394a9416de7038dd8b6182e7dd4a60ae723e55b14bc87c9 |
| hovercard-subject-tag | pull_request:101403639 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/13909/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/42f40071169db5e697bf1287e2fafbc03f653c9fd41e20eb3a8d01ab111a04a7/angular/angular/pull/13909 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/42f40071169db5e697bf1287e2fafbc03f653c9fd41e20eb3a8d01ab111a04a7/angular/angular/pull/13909 |
| og:image:alt | Closes #11075
Description:
Runtime compiler is not available after aot compilation, so we need to return NgModuleFactory instead of just NgModule, because we cannot compile it at runtime.
import { ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DzmitryShylovich |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/13909#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13909 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13909 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/13909 |
| Reload | https://github.com/angular/angular/pull/13909 |
| Reload | https://github.com/angular/angular/pull/13909 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| mhevery | https://github.com/mhevery |
| angular:master | https://github.com/angular/angular/tree/master |
| DzmitryShylovich:gh/11075 | https://github.com/DzmitryShylovich/angular/tree/gh/11075 |
| Conversation | https://github.com/angular/angular/pull/13909 |
| Commits1 (1) | https://github.com/angular/angular/pull/13909/commits |
| Checks | https://github.com/angular/angular/pull/13909/checks |
| Files changed | https://github.com/angular/angular/pull/13909/files |
| fix(router): eager loading with loadChildren in aot | https://github.com/angular/angular/pull/13909#top |
| mhevery | https://github.com/mhevery |
| angular:master | https://github.com/angular/angular/tree/master |
| DzmitryShylovich:gh/11075 | https://github.com/DzmitryShylovich/angular/tree/gh/11075 |
|
| https://github.com/DzmitryShylovich |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| Jan 13, 2017 | https://github.com/angular/angular/pull/13909#issue-200568935 |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
| #11075 | https://github.com/angular/angular/issues/11075 |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jan 13, 2017 | https://github.com/angular/angular/pull/13909#event-921892444 |
|
| https://github.com/DzmitryShylovich |
| fix(router): enable loadChildren with function in aot | https://github.com/angular/angular/pull/13909/commits/47b1031ba4552fd840817da9b7aa7da5780854a8 |
| 47b1031 | https://github.com/angular/angular/pull/13909/commits/47b1031ba4552fd840817da9b7aa7da5780854a8 |
| angular#11075 | https://github.com/angular/angular/issues/11075 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
pr_state: LGTM
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22pr_state%3A%20LGTM%22 |
| Jan 18, 2017 | https://github.com/angular/angular/pull/13909#event-928355202 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| 635bf02 | https://github.com/angular/angular/commit/635bf02b02973c62fb0180e64732fe601d350a45 |
| Jan 18, 2017 | https://github.com/angular/angular/pull/13909#event-928355434 |
| mhevery | https://github.com/mhevery |
|
Jan 19, 2017
| https://github.com/angular/angular/pull/13909#ref-commit-2af5862 |
|
| https://github.com/mhevery |
| fix(router): enable loadChildren with function in aot ( | https://github.com/angular/angular/commit/2af58622c1789673a527125e059af4c553598a26 |
| #13909 | https://github.com/angular/angular/pull/13909 |
| ) | https://github.com/angular/angular/commit/2af58622c1789673a527125e059af4c553598a26 |
| 2af5862 | https://github.com/angular/angular/commit/2af58622c1789673a527125e059af4c553598a26 |
| #11075 | https://github.com/angular/angular/issues/11075 |
| https://github.com/SamVerschueren |
| SamVerschueren | https://github.com/SamVerschueren |
| Jan 19, 2017 | https://github.com/angular/angular/pull/13909#issuecomment-273697307 |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
| https://github.com/DzmitryShylovich |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| Jan 19, 2017 | https://github.com/angular/angular/pull/13909#issuecomment-273698888 |
| @SamVerschueren | https://github.com/SamVerschueren |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
| https://github.com/DzmitryShylovich |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| Jan 19, 2017 | https://github.com/angular/angular/pull/13909#issuecomment-273705042 |
| @SamVerschueren | https://github.com/SamVerschueren |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
| https://github.com/SamVerschueren |
| SamVerschueren | https://github.com/SamVerschueren |
|
Jan 19, 2017
| https://github.com/angular/angular/pull/13909#ref-issue-201791180 |
|
[compiler-cli] Change references from NgModule to NgModuleFactory at build-time
#14005
| https://github.com/angular/angular/issues/14005 |
| https://github.com/SamVerschueren |
| SamVerschueren | https://github.com/SamVerschueren |
| Jan 19, 2017 | https://github.com/angular/angular/pull/13909#issuecomment-273708825 |
| @DzmitryShylovich | https://github.com/DzmitryShylovich |
| #14005 | https://github.com/angular/angular/issues/14005 |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
| https://github.com/maxime1992 |
| maxime1992 | https://github.com/maxime1992 |
|
Jan 20, 2017
| https://github.com/angular/angular/pull/13909#ref-issue-190481632 |
|
ng build -aot error 'entry.split is not a function' on lazy loaded modules
angular/angular-cli#3204
| https://github.com/angular/angular-cli/issues/3204 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Jan 23, 2017 | https://github.com/angular/angular/pull/13909#issuecomment-274650555 |
| @samherrmann | https://github.com/samherrmann |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
| https://github.com/maxime1992 |
| maxime1992 | https://github.com/maxime1992 |
|
Jan 24, 2017
| https://github.com/angular/angular/pull/13909#ref-issue-202742062 |
|
AOT broken when using loadChildren and a function : Replace modules import by modules factories ?
angular/angular-cli#4192
| https://github.com/angular/angular-cli/issues/4192 |
| https://github.com/SamVerschueren |
| SamVerschueren | https://github.com/SamVerschueren |
| Jan 24, 2017 | https://github.com/angular/angular/pull/13909#issuecomment-274743276 |
| @mhevery | https://github.com/mhevery |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
| wKoza | https://github.com/wKoza |
|
Feb 12, 2017
| https://github.com/angular/angular/pull/13909#ref-commit-fac2a07 |
|
| https://github.com/DzmitryShylovich |
|
| https://github.com/wKoza |
| fix(router): enable loadChildren with function in aot ( | https://github.com/wKoza/angular/commit/fac2a075c9ad75a021adbfe7d06fefa823a710d3 |
| angular#13909 | https://github.com/angular/angular/pull/13909 |
| ) | https://github.com/wKoza/angular/commit/fac2a075c9ad75a021adbfe7d06fefa823a710d3 |
| fac2a07 | https://github.com/wKoza/angular/commit/fac2a075c9ad75a021adbfe7d06fefa823a710d3 |
| angular#11075 | https://github.com/angular/angular/issues/11075 |
| https://github.com/antonmoiseev |
| antonmoiseev | https://github.com/antonmoiseev |
|
Jul 12, 2017
| https://github.com/angular/angular/pull/13909#ref-issue-242094428 |
|
Router fails to synchronously load NgModule with "Runtime compiler is not loaded" error
#18061
| https://github.com/angular/angular/issues/18061 |
| juleskremer | https://github.com/juleskremer |
|
Aug 28, 2017
| https://github.com/angular/angular/pull/13909#ref-commit-ebc9b58 |
|
| https://github.com/DzmitryShylovich |
|
| https://github.com/juleskremer |
| fix(router): enable loadChildren with function in aot ( | https://github.com/juleskremer/angular/commit/ebc9b587938d139d7958af6e9a951ebcf902580f |
| angular#13909 | https://github.com/angular/angular/pull/13909 |
| ) | https://github.com/juleskremer/angular/commit/ebc9b587938d139d7958af6e9a951ebcf902580f |
| ebc9b58 | https://github.com/juleskremer/angular/commit/ebc9b587938d139d7958af6e9a951ebcf902580f |
| angular#11075 | https://github.com/angular/angular/issues/11075 |
| https://github.com/DhiaEddineSaidi |
| DhiaEddineSaidi | https://github.com/DhiaEddineSaidi |
| Apr 23, 2018 | https://github.com/angular/angular/pull/13909#issuecomment-383448621 |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
|
Error: Runtime compiler is not loaded in angular6 --prod mode
#23878
| https://github.com/angular/angular/issues/23878 |
|
Angular upgrade to version 7 lazy loaded module cannot be found
#27023
| https://github.com/angular/angular/issues/27023 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/13909#issuecomment-531245100 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/13909#event-2632409224 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13909 |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
(bug)router/AOT Unable to use feature-modules in routing when doing AOT compilation
| https://github.com/angular/angular/issues/11075 |
| Please reload this page | https://github.com/angular/angular/pull/13909 |
|
| https://github.com/DzmitryShylovich |
|
| https://github.com/SamVerschueren |
|
| https://github.com/mhevery |
|
| https://github.com/DhiaEddineSaidi |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |