René's URL Explorer Experiment


Title: fix(compiler-cli): add support for more than 2 levels of nested lazy routes by Meligy · Pull Request #13678 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): add support for more than 2 levels of nested lazy routes by Meligy · Pull Request #13678 · angular/angular

X Title: fix(compiler-cli): add support for more than 2 levels of nested lazy routes by Meligy · Pull Request #13678 · angular/angular

Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) What kind of change does this PR introduce? (check one with "x") [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Other... Please describe: What is the current behavior? (You can also link to an open issue here) If you have more than 3 levels of nested lazy routes, like: {app-root}/lazy-loaded-module-1/lazy-loaded-module-2/lazy-loaded-module-3 Where lazy-loaded-module-3 is lazy loaded from lazy-loaded-module-2, and lazy-loaded-module-2 is lazy loaded from module lazy-loaded-module-1, and lazy-loaded-module-1 is lazy loaded from AppModule You get only 2 chunk bundles created in addition to the main bundle, when you build your project using Angular CLI or @ng-tools Webpack plugin. You'll be able to browse to {app-root}/lazy-loaded-module-1/lazy-loaded-module-2/ but get a router error in browser for {app-root}/lazy-loaded-module-1/lazy-loaded-module-2/lazy-loaded-module-3, because no bundle was generated for it. What is the new behavior? Your build will include the same number of chunks as your lazy modules, plus the main chunk of course. Your browser will be able to go to any level of nested lazy-loaded modules you declared. Does this PR introduce a breaking change? (check one with "x") [ ] Yes [x] No If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... Other information: This PR includes work from PR #13676, and superseeds it. The PR can be tested on this sample repository https://github.com/meligy/routing-angular-cli The test path in this sample is /lazy/deep/third/. The UI walks you level by level as well. @hansl would be the best person to review this as he wrote the original implementation. Fixes angular/angular-cli#3663

Open Graph Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have bee...

X Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have bee...

Opengraph URL: https://github.com/angular/angular/pull/13678

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:45b3fb1f-9d2c-93e6-0cba-cfc857b7cf1d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDD0:269AD9:1C72DAA:25F63F6:6B016533
html-safe-nonce2055c52f70bc9adb363261de7713db47194e9103498b5738482ee7067dfbed9d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREQwOjI2OUFEOToxQzcyREFBOjI1RjYzRjY6NkIwMTY1MzMiLCJ2aXNpdG9yX2lkIjoiODEwNzE5NTg5NDgxNTg3NjQwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7e0a47b0b30e9faee84bd5cab2ff60ed7218a54b72c9e82e01730cb225d2fb10
hovercard-subject-tagpull_request:99486088
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/13678/files
twitter:imagehttps://avatars.githubusercontent.com/u/171637?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/171637?s=400&v=4
og:image:altPlease check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have bee...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/13678/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13678%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13678%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/13678/files
Reloadhttps://github.com/angular/angular/pull/13678/files
Reloadhttps://github.com/angular/angular/pull/13678/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
Meligyhttps://github.com/Meligy
angular:masterhttps://github.com/angular/angular/tree/master
Meligy:fix/nested-lazy-routeshttps://github.com/Meligy/angular/tree/fix/nested-lazy-routes
Conversation 15 https://github.com/angular/angular/pull/13678
Commits 2 https://github.com/angular/angular/pull/13678/commits
Checks 0 https://github.com/angular/angular/pull/13678/checks
Files changed https://github.com/angular/angular/pull/13678/files
Please reload this pagehttps://github.com/angular/angular/pull/13678/files
fix(compiler-cli): add support for more than 2 levels of nested lazy routes https://github.com/angular/angular/pull/13678/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/13678/files
93af424 fix(compiler-cli): avoid handling functions in loadChildren as lazy l… Meligy Dec 31, 2016 https://github.com/angular/angular/pull/13678/commits/93af4248e7bb84750fd6abbb44f0dccf021b4604
9daed3e fix(compiler-cli): add support for more than 2 levels of nested lazy … Meligy Dec 31, 2016 https://github.com/angular/angular/pull/13678/commits/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534
Clear filters https://github.com/angular/angular/pull/13678/files
Please reload this pagehttps://github.com/angular/angular/pull/13678/files
Please reload this pagehttps://github.com/angular/angular/pull/13678/files
lazy-feature-nested.module.ts https://github.com/angular/angular/pull/13678/files#diff-1b7316946f692250af6773fe0503b2afeb4ee25d5be8cf7a6cce1963e20d37a5
lazy-feature.module.ts https://github.com/angular/angular/pull/13678/files#diff-5cbaf0d9a2821585ea6d286ee122dc887cd9b6d4ecd918db1f568d8053d868b8
test_ngtools_api.ts https://github.com/angular/angular/pull/13678/files#diff-ec02ed3dc1bfdb3ec03f681c51750bc29f7b8d7187104b1b3eb1a22b97205076
ngtools_impl.ts https://github.com/angular/angular/pull/13678/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
...s/@angular/compiler-cli/integrationtest/ngtools_src/feature/lazy-feature-nested.module.tshttps://github.com/angular/angular/pull/13678/files#diff-1b7316946f692250af6773fe0503b2afeb4ee25d5be8cf7a6cce1963e20d37a5
View file https://github.com/Meligy/angular/blob/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534/modules/%40angular/compiler-cli/integrationtest/ngtools_src/feature/lazy-feature-nested.module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13678/{{ revealButtonHref }}
modules/@angular/compiler-cli/integrationtest/ngtools_src/feature/lazy-feature.module.tshttps://github.com/angular/angular/pull/13678/files#diff-5cbaf0d9a2821585ea6d286ee122dc887cd9b6d4ecd918db1f568d8053d868b8
View file https://github.com/Meligy/angular/blob/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534/modules/%40angular/compiler-cli/integrationtest/ngtools_src/feature/lazy-feature.module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13678/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13678/files#diff-5cbaf0d9a2821585ea6d286ee122dc887cd9b6d4ecd918db1f568d8053d868b8
https://github.com/angular/angular/pull/13678/files#diff-5cbaf0d9a2821585ea6d286ee122dc887cd9b6d4ecd918db1f568d8053d868b8
modules/@angular/compiler-cli/integrationtest/test/test_ngtools_api.tshttps://github.com/angular/angular/pull/13678/files#diff-ec02ed3dc1bfdb3ec03f681c51750bc29f7b8d7187104b1b3eb1a22b97205076
View file https://github.com/Meligy/angular/blob/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534/modules/%40angular/compiler-cli/integrationtest/test/test_ngtools_api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13678/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13678/files#diff-ec02ed3dc1bfdb3ec03f681c51750bc29f7b8d7187104b1b3eb1a22b97205076
https://github.com/angular/angular/pull/13678/files#diff-ec02ed3dc1bfdb3ec03f681c51750bc29f7b8d7187104b1b3eb1a22b97205076
modules/@angular/compiler-cli/src/ngtools_impl.tshttps://github.com/angular/angular/pull/13678/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
View file https://github.com/Meligy/angular/blob/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534/modules/%40angular/compiler-cli/src/ngtools_impl.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13678/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13678/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
https://github.com/angular/angular/pull/13678/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
https://github.com/angular/angular/pull/13678/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
https://github.com/angular/angular/pull/13678/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
https://github.com/angular/angular/pull/13678/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
https://github.com/angular/angular/pull/13678/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.