| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f7852c14-62cd-a136-f41e-49a7497100e7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9D9A:358871:174BB3B:1EAAA08:6B013380 |
| html-safe-nonce | 16d062a3753fb5abbc9e1be8b008cea6055630fcad7cc04b394d6c2acbc9feca |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDlBOjM1ODg3MToxNzRCQjNCOjFFQUFBMDg6NkIwMTMzODAiLCJ2aXNpdG9yX2lkIjoiNTczMjc4MDU3NTkyMDU2NzE2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ca9da80e6d0119b48c88386b1b2b534693638d969cd01135afddaacc4b199fd9 |
| hovercard-subject-tag | pull_request:99486088 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/13678/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0e375187ed5c445c18670e603afcdc9487af46ce4c8ff132f7994522d95c40c8/angular/angular/pull/13678 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0e375187ed5c445c18670e603afcdc9487af46ce4c8ff132f7994522d95c40c8/angular/angular/pull/13678 |
| og:image:alt | Please check if the PR fulfills these requirements
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have bee... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Meligy |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/13678#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13678 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13678 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/13678 |
| Reload | https://github.com/angular/angular/pull/13678 |
| Reload | https://github.com/angular/angular/pull/13678 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| Meligy | https://github.com/Meligy |
| angular:master | https://github.com/angular/angular/tree/master |
| Meligy:fix/nested-lazy-routes | https://github.com/Meligy/angular/tree/fix/nested-lazy-routes |
| Conversation | https://github.com/angular/angular/pull/13678 |
| Commits2 (2) | https://github.com/angular/angular/pull/13678/commits |
| Checks | https://github.com/angular/angular/pull/13678/checks |
| Files changed | https://github.com/angular/angular/pull/13678/files |
| fix(compiler-cli): add support for more than 2 levels of nested lazy routes | https://github.com/angular/angular/pull/13678#top |
| Meligy | https://github.com/Meligy |
| angular:master | https://github.com/angular/angular/tree/master |
| Meligy:fix/nested-lazy-routes | https://github.com/Meligy/angular/tree/fix/nested-lazy-routes |
|
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
| Dec 27, 2016 | https://github.com/angular/angular/pull/13678#issue-197761524 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| @ng-tools | https://github.com/ng-tools |
| #13676 | https://github.com/angular/angular/pull/13676 |
| https://github.com/meligy/routing-angular-cli | https://github.com/meligy/routing-angular-cli |
| @hansl | https://github.com/hansl |
| angular/angular-cli#3663 | https://github.com/angular/angular-cli/issues/3663 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 27, 2016 | https://github.com/angular/angular/pull/13678#event-906033381 |
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
| force-pushed | https://github.com/angular/angular/compare/415205447a8fc266e715d1f89cbbedea6a4e484d..3e680beb21000ec26d0ad041ec112f8e42fb6050 |
| 4152054 | https://github.com/angular/angular/commit/415205447a8fc266e715d1f89cbbedea6a4e484d |
| 3e680be | https://github.com/angular/angular/commit/3e680beb21000ec26d0ad041ec112f8e42fb6050 |
|
Compare
| https://github.com/angular/angular/compare/415205447a8fc266e715d1f89cbbedea6a4e484d..3e680beb21000ec26d0ad041ec112f8e42fb6050 |
| December 31, 2016 09:26 | https://github.com/angular/angular/pull/13678#event-908484363 |
|
| https://github.com/Meligy |
| fix(compiler-cli): avoid handling functions in loadChildren as lazy l… | https://github.com/angular/angular/pull/13678/commits/93af4248e7bb84750fd6abbb44f0dccf021b4604 |
| 93af424 | https://github.com/angular/angular/pull/13678/commits/93af4248e7bb84750fd6abbb44f0dccf021b4604 |
| angular/angular-cli#3204 | https://github.com/angular/angular-cli/issues/3204 |
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
| force-pushed | https://github.com/angular/angular/compare/3e680beb21000ec26d0ad041ec112f8e42fb6050..b8158f03d5b57a66cfaa5cc738be296b159daafb |
| 3e680be | https://github.com/angular/angular/commit/3e680beb21000ec26d0ad041ec112f8e42fb6050 |
| b8158f0 | https://github.com/angular/angular/commit/b8158f03d5b57a66cfaa5cc738be296b159daafb |
|
Compare
| https://github.com/angular/angular/compare/3e680beb21000ec26d0ad041ec112f8e42fb6050..b8158f03d5b57a66cfaa5cc738be296b159daafb |
| December 31, 2016 09:27 | https://github.com/angular/angular/pull/13678#event-908484502 |
|
| https://github.com/Meligy |
| fix(compiler-cli): add support for more than 2 levels of nested lazy … | https://github.com/angular/angular/pull/13678/commits/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534 |
| 9daed3e | https://github.com/angular/angular/pull/13678/commits/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534 |
| angular/angular-cli#3663 | https://github.com/angular/angular-cli/issues/3663 |
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
| force-pushed | https://github.com/angular/angular/compare/b8158f03d5b57a66cfaa5cc738be296b159daafb..9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534 |
| b8158f0 | https://github.com/angular/angular/commit/b8158f03d5b57a66cfaa5cc738be296b159daafb |
| 9daed3e | https://github.com/angular/angular/commit/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534 |
|
Compare
| https://github.com/angular/angular/compare/b8158f03d5b57a66cfaa5cc738be296b159daafb..9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534 |
| December 31, 2016 22:41 | https://github.com/angular/angular/pull/13678#event-908588463 |
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
| Dec 31, 2016 | https://github.com/angular/angular/pull/13678#issuecomment-269885384 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| @hans | https://github.com/hans |
| @filipesilva | https://github.com/filipesilva |
| https://cloud.githubusercontent.com/assets/171637/21579517/6bd75b78-d008-11e6-86f8-315afb89709c.png |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| Dec 31, 2016 | https://github.com/angular/angular/pull/13678#issuecomment-269886192 |
| @hansl | https://github.com/hansl |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| hansl | https://github.com/hansl |
| January 2, 2017 21:42 | https://github.com/angular/angular/pull/13678#event-909268548 |
| https://github.com/conor-mac-aoidh |
| conor-mac-aoidh | https://github.com/conor-mac-aoidh |
| Jan 6, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-270868553 |
| @Meligy | https://github.com/Meligy |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/clydin |
| clydin | https://github.com/clydin |
|
Jan 6, 2017
| https://github.com/angular/angular/pull/13678#ref-issue-190481632 |
|
ng build -aot error 'entry.split is not a function' on lazy loaded modules
angular/angular-cli#3204
| https://github.com/angular/angular-cli/issues/3204 |
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
|
Jan 7, 2017
| https://github.com/angular/angular/pull/13678#ref-issue-196846244 |
|
Nested lazy loading no longer works, bundles not being generated - beta 24
angular/angular-cli#3663
| https://github.com/angular/angular-cli/issues/3663 |
| https://github.com/hansl |
| hansl | https://github.com/hansl |
|
Jan 8, 2017
| https://github.com/angular/angular/pull/13678#pullrequestreview-15615913 |
|
View reviewed changes
| https://github.com/angular/angular/pull/13678/files/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534 |
| hansl | https://github.com/hansl |
| https://github.com/angular/angular/pull/13678#pullrequestreview-15615913 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/hansl |
| hansl | https://github.com/hansl |
|
pr_state: LGTM
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22pr_state%3A%20LGTM%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Jan 8, 2017 | https://github.com/angular/angular/pull/13678#event-915109084 |
| https://github.com/matsko |
| matsko | https://github.com/matsko |
| Jan 9, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271441179 |
| 5d9cbd7 | https://github.com/angular/angular/commit/5d9cbd7d6f20dc0d63bd297ccaf68bd0257cb4b8 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/matsko |
| matsko | https://github.com/matsko |
| Jan 9, 2017 | https://github.com/angular/angular/pull/13678#event-916754273 |
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
|
Jan 10, 2017
| https://github.com/angular/angular/pull/13678#ref-pullrequest-197706034 |
|
fix(compiler-cli): avoid handling functions in loadChildren as lazy load routes paths
#13676
| https://github.com/angular/angular/pull/13676 |
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
| Jan 10, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271503322 |
| @hansl | https://github.com/hansl |
| @matsko | https://github.com/matsko |
| 93af424 | https://github.com/angular/angular/commit/93af4248e7bb84750fd6abbb44f0dccf021b4604 |
| #13676 | https://github.com/angular/angular/pull/13676 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/matsko |
| matsko | https://github.com/matsko |
| Jan 10, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271512604 |
| @Meligy | https://github.com/Meligy |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
| Jan 10, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271530078 |
| @matsko | https://github.com/matsko |
| @hansl | https://github.com/hansl |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/Meligy |
| Meligy | https://github.com/Meligy |
| Jan 10, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271537909 |
| #13676 | https://github.com/angular/angular/pull/13676 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/matsko |
| matsko | https://github.com/matsko |
| Jan 11, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271758006 |
| @Meligy | https://github.com/Meligy |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/JSMike |
| JSMike | https://github.com/JSMike |
| Jan 11, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271897663 |
| @matsko | https://github.com/matsko |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/DzmitryShylovich |
| DzmitryShylovich | https://github.com/DzmitryShylovich |
| Jan 11, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271898004 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/matsko |
| matsko | https://github.com/matsko |
| Jan 11, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271898614 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/JSMike |
| JSMike | https://github.com/JSMike |
| Jan 11, 2017 | https://github.com/angular/angular/pull/13678#issuecomment-271899450 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 10, 2019 | https://github.com/angular/angular/pull/13678#issuecomment-529958873 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 10, 2019 | https://github.com/angular/angular/pull/13678#event-2622452981 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13678 |
|
| https://github.com/hansl |
|
hansl
| https://github.com/hansl |
|
| https://github.com/angular/angular/pull/13678/files/9daed3e3199bd3eb22ab2b415dd4eda3c5f3c534 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
Nested lazy loading no longer works, bundles not being generated - beta 24
| https://github.com/angular/angular-cli/issues/3663 |
| Please reload this page | https://github.com/angular/angular/pull/13678 |
|
| https://github.com/Meligy |
|
| https://github.com/filipesilva |
|
| https://github.com/conor-mac-aoidh |
|
| https://github.com/matsko |
|
| https://github.com/JSMike |
|
| https://github.com/DzmitryShylovich |
|
| https://github.com/hansl |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |