René's URL Explorer Experiment


Title: fix(compiler-cli): avoid handling functions in loadChildren as lazy load routes paths by Meligy · Pull Request #13676 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): avoid handling functions in loadChildren as lazy load routes paths by Meligy · Pull Request #13676 · angular/angular

X Title: fix(compiler-cli): avoid handling functions in loadChildren as lazy load routes paths by Meligy · Pull Request #13676 · angular/angular

Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) N/A for the private API // CC @hansl Docs have been added / updated (for bug fixes / features) N/A What kind of change does this PR introduce? (check one with "x") [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Other... Please describe: What is the current behavior? (You can also link to an open issue here) If you use an official tool that uses the Angular Compiler CLI private API, like Angular CLI (or @ng-tools Webpack plugin), and you have some route code like: import { NonLazyLoadedModule } from './non-lazy-loaded/non-lazy-loaded.module'; export function getNonLazyLoadedModule() { return NonLazyLoadedModule; } export const routes = [ { path: '/some-path', loadChildren: getNonLazyLoadedModule } ]; Building this (for example ng build using Angular CLI beta.24) shows a build error: ERROR in entry.split is not a function And it also shows in the browser. What is the new behavior? No build error in console or browser in that case. Build just succeeds and browser functionality shows no error. Loading modules (lazy or not) works as expected. Does this PR introduce a breaking change? (check one with "x") [ ] Yes [x] No If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... Other information: The core problem in the previous case is that the compiler CLI internal API treats the function getNonLazyLoadedModule() as a lazy loading string (like './non-lazy-loaded/non-lazy-loaded.module#NonLazyLoadedModule'). It passes the output as the entry argument to RouteDef.fromString(entry: string), where the error entry.split is not a function happens. @hansl would be an ideal reviewer for this, having created the private API. Fixes angular/angular-cli#3204

Open Graph Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have bee...

X Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have bee...

Opengraph URL: https://github.com/angular/angular/pull/13676

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8b7f032d-1dae-b507-08be-279c16473ebf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABA6:2DBB21:1983B8E:21FA08C:6B0153F2
html-safe-noncece9b8632ca28a76efe152949cfe9a999f751d2c69e9cd9513487552a12a2d129
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkE2OjJEQkIyMToxOTgzQjhFOjIxRkEwOEM6NkIwMTUzRjIiLCJ2aXNpdG9yX2lkIjoiODQyMjE3MzU1MzQ2NTU3ODQ4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb7a03ce4a9628cf287d7532f6041e471340c1bf9be19d7d92e8e4c1489b0f6dc
hovercard-subject-tagpull_request:99446764
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/13676/files
twitter:imagehttps://avatars.githubusercontent.com/u/171637?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/171637?s=400&v=4
og:image:altPlease check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have bee...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/13676/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13676%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13676%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/13676/files
Reloadhttps://github.com/angular/angular/pull/13676/files
Reloadhttps://github.com/angular/angular/pull/13676/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
Meligyhttps://github.com/Meligy
angular:masterhttps://github.com/angular/angular/tree/master
Meligy:fix/exports-misread-as-routeshttps://github.com/Meligy/angular/tree/fix/exports-misread-as-routes
Conversation 8 https://github.com/angular/angular/pull/13676
Commits 1 https://github.com/angular/angular/pull/13676/commits
Checks 0 https://github.com/angular/angular/pull/13676/checks
Files changed https://github.com/angular/angular/pull/13676/files
Please reload this pagehttps://github.com/angular/angular/pull/13676/files
fix(compiler-cli): avoid handling functions in loadChildren as lazy load routes paths https://github.com/angular/angular/pull/13676/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/13676/files
93af424 fix(compiler-cli): avoid handling functions in loadChildren as lazy l… Meligy Dec 31, 2016 https://github.com/angular/angular/pull/13676/commits/93af4248e7bb84750fd6abbb44f0dccf021b4604
Clear filters https://github.com/angular/angular/pull/13676/files
Please reload this pagehttps://github.com/angular/angular/pull/13676/files
Please reload this pagehttps://github.com/angular/angular/pull/13676/files
modules/@angular/compiler-cli/src/ngtools_impl.tshttps://github.com/angular/angular/pull/13676/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
View file https://github.com/Meligy/angular/blob/93af4248e7bb84750fd6abbb44f0dccf021b4604/modules/%40angular/compiler-cli/src/ngtools_impl.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13676/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13676/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
clydinhttps://github.com/clydin
Dec 27, 2016https://github.com/angular/angular/pull/13676/files#r93961013
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/13676/files
Meligyhttps://github.com/Meligy
Dec 27, 2016https://github.com/angular/angular/pull/13676/files#r93973050
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/13676/files
https://github.com/angular/angular/pull/13676/files#diff-cf40feac97029bc722946717789551eb8c15034f3c7f3a5a75ad0ae451d4d819
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.