René's URL Explorer Experiment


Title: test(forms): refactor integration tests to improve speed by marclaval · Pull Request #13500 · angular/angular · GitHub

Open Graph Title: test(forms): refactor integration tests to improve speed by marclaval · Pull Request #13500 · angular/angular

X Title: test(forms): refactor integration tests to improve speed by marclaval · Pull Request #13500 · angular/angular

Description: While investigating browser disconnections in SauceLabs, I found out that the forms integration test were quite slow and CPU intensive. Using TestBed.configureTestingModule() for all components in beforeEach() is clearly not ideal. These 130 tests were taking 13s to run on my machine. With these changes,the only take 4s!!! As a result, the full campaign goes from 43s to 34s. Hopefully, this will also help with the disconnections. But it might not be enough ...

Open Graph Description: While investigating browser disconnections in SauceLabs, I found out that the forms integration test were quite slow and CPU intensive. Using TestBed.configureTestingModule() for all components in ...

X Description: While investigating browser disconnections in SauceLabs, I found out that the forms integration test were quite slow and CPU intensive. Using TestBed.configureTestingModule() for all components in ...

Opengraph URL: https://github.com/angular/angular/pull/13500

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:62423592-d7cc-b718-6257-c97daccb98a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id835A:B53AF:2CADF5F:3B8C13C:6B01CE81
html-safe-nonce6b70e6a5f036451164d94c62d4af2bf90c667c0b8a087d669a08e0250fc64a2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzVBOkI1M0FGOjJDQURGNUY6M0I4QzEzQzo2QjAxQ0U4MSIsInZpc2l0b3JfaWQiOiI4NTM3ODI1MzUzMzIwNzQ2NjI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac83e578a52816a70c3a0554cd3070ce7ad7b86f263503c369cb3e0225cf67b591
hovercard-subject-tagpull_request:98180342
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/13500/files
twitter:imagehttps://avatars.githubusercontent.com/u/2316643?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2316643?s=400&v=4
og:image:altWhile investigating browser disconnections in SauceLabs, I found out that the forms integration test were quite slow and CPU intensive. Using TestBed.configureTestingModule() for all components in ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/13500/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13500%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F13500%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/13500/files
Reloadhttps://github.com/angular/angular/pull/13500/files
Reloadhttps://github.com/angular/angular/pull/13500/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
chuckjazhttps://github.com/chuckjaz
angular:masterhttps://github.com/angular/angular/tree/master
marclaval:formsTestRefactorhttps://github.com/marclaval/angular/tree/formsTestRefactor
Conversation 5 https://github.com/angular/angular/pull/13500
Commits 1 https://github.com/angular/angular/pull/13500/commits
Checks 0 https://github.com/angular/angular/pull/13500/checks
Files changed 3 https://github.com/angular/angular/pull/13500/files
test(forms): refactor integration tests to improve speed https://github.com/angular/angular/pull/13500/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/13500/files
4ddc56a test(forms): refactor integration tests to improve speed marclaval Dec 15, 2016 https://github.com/angular/angular/pull/13500/commits/4ddc56a3f711acc091fe010c2a9436f936ad0bb2
Clear filters https://github.com/angular/angular/pull/13500/files
Please reload this pagehttps://github.com/angular/angular/pull/13500/files
Please reload this pagehttps://github.com/angular/angular/pull/13500/files
metadata_resolver.ts https://github.com/angular/angular/pull/13500/files#diff-10116ed6877c62aa6067812cf079d06d0d93c5d7b967900f53d7c5f27ec38e06
reactive_integration_spec.ts https://github.com/angular/angular/pull/13500/files#diff-83e30471e738130059e4f6cbe6ea5ae1006c4624878e69c3521c3056a22a201f
template_integration_spec.ts https://github.com/angular/angular/pull/13500/files#diff-280c97b2698404eb9649adcdf391744a2bf603dc1f809482299bffe5f2a8ca5c
modules/@angular/compiler/src/metadata_resolver.tshttps://github.com/angular/angular/pull/13500/files#diff-10116ed6877c62aa6067812cf079d06d0d93c5d7b967900f53d7c5f27ec38e06
View file https://github.com/marclaval/angular/blob/4ddc56a3f711acc091fe010c2a9436f936ad0bb2/modules/%40angular/compiler/src/metadata_resolver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/13500/{{ revealButtonHref }}
https://github.com/angular/angular/pull/13500/files#diff-10116ed6877c62aa6067812cf079d06d0d93c5d7b967900f53d7c5f27ec38e06
https://github.com/angular/angular/pull/13500/files#diff-10116ed6877c62aa6067812cf079d06d0d93c5d7b967900f53d7c5f27ec38e06
https://github.com/angular/angular/pull/13500/files#diff-10116ed6877c62aa6067812cf079d06d0d93c5d7b967900f53d7c5f27ec38e06
Please reload this pagehttps://github.com/angular/angular/pull/13500/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.