René's URL Explorer Experiment


Title: fix(router): update the location before activating components by vsavkin · Pull Request #11063 · angular/angular · GitHub

Open Graph Title: fix(router): update the location before activating components by vsavkin · Pull Request #11063 · angular/angular

X Title: fix(router): update the location before activating components by vsavkin · Pull Request #11063 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Closes #10909, #10845, #10827, #10704, #10930, #11004

X Description: Closes #10909, #10845, #10827, #10704, #10930, #11004

Opengraph URL: https://github.com/angular/angular/pull/11063

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bcb6c599-32be-e9ee-4bb5-0e7388fdc3d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF48:24A0A:7AE1A6:9A96F3:6B011599
html-safe-nonce3637a9e2f6ea737fbec25af6db41354bb00508a7342723f473c256977e6cd722
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjQ4OjI0QTBBOjdBRTFBNjo5QTk2RjM6NkIwMTE1OTkiLCJ2aXNpdG9yX2lkIjoiNDUzNjUwNzAyNDM0MjU4Njc3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb1b5762ad061da6eb45e89f16f2ea9a7bdba33264a7a74c05bcc74b24a21ee33
hovercard-subject-tagpull_request:82686966
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/11063/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ab135d463fd6c85757c9aa09f125de2a2284c5e5c603666185b434c8e6df2cc8/angular/angular/pull/11063
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ab135d463fd6c85757c9aa09f125de2a2284c5e5c603666185b434c8e6df2cc8/angular/angular/pull/11063
og:image:altCloses #10909, #10845, #10827, #10704, #10930, #11004
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevsavkin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/11063#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F11063
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F11063
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/11063
Reloadhttps://github.com/angular/angular/pull/11063
Reloadhttps://github.com/angular/angular/pull/11063
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
vsavkinhttps://github.com/vsavkin
angular:masterhttps://github.com/angular/angular/tree/master
vsavkin:router_fixes_25https://github.com/vsavkin/angular/tree/router_fixes_25
Conversationhttps://github.com/angular/angular/pull/11063
Commits6 (6)https://github.com/angular/angular/pull/11063/commits
Checkshttps://github.com/angular/angular/pull/11063/checks
Files changedhttps://github.com/angular/angular/pull/11063/files
fix(router): update the location before activating componentshttps://github.com/angular/angular/pull/11063#top
vsavkinhttps://github.com/vsavkin
angular:masterhttps://github.com/angular/angular/tree/master
vsavkin:router_fixes_25https://github.com/vsavkin/angular/tree/router_fixes_25
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
Aug 25, 2016https://github.com/angular/angular/pull/11063#issue-173156859
Please reload this pagehttps://github.com/angular/angular/pull/11063
#10909https://github.com/angular/angular/issues/10909
#10845https://github.com/angular/angular/issues/10845
#10827https://github.com/angular/angular/issues/10827
#10704https://github.com/angular/angular/issues/10704
#10930https://github.com/angular/angular/issues/10930
#11004https://github.com/angular/angular/issues/11004
Please reload this pagehttps://github.com/angular/angular/pull/11063
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 25, 2016https://github.com/angular/angular/pull/11063#event-767169013
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Aug 25, 2016https://github.com/angular/angular/pull/11063#event-767169331
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
force-pushedhttps://github.com/angular/angular/compare/f5378eb1ec476d12a16e1b2bbb1bb957ee367b7e..ee6e9a48d08041d6ce0751dde6f4311537b86b78
f5378ebhttps://github.com/angular/angular/commit/f5378eb1ec476d12a16e1b2bbb1bb957ee367b7e
ee6e9a4https://github.com/angular/angular/commit/ee6e9a48d08041d6ce0751dde6f4311537b86b78
Compare https://github.com/angular/angular/compare/f5378eb1ec476d12a16e1b2bbb1bb957ee367b7e..ee6e9a48d08041d6ce0751dde6f4311537b86b78
August 25, 2016 10:58https://github.com/angular/angular/pull/11063#event-767256918
https://github.com/robwormald
robwormaldhttps://github.com/robwormald
pr_state: LGTM https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22pr_state%3A%20LGTM%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Aug 25, 2016https://github.com/angular/angular/pull/11063#event-768219037
https://github.com/vicb
vicbhttps://github.com/vicb
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Aug 25, 2016https://github.com/angular/angular/pull/11063#event-768221081
https://github.com/brandonroberts
brandonrobertshttps://github.com/brandonroberts
Aug 25, 2016https://github.com/angular/angular/pull/11063#issuecomment-242577518
Please reload this pagehttps://github.com/angular/angular/pull/11063
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 25, 2016https://github.com/angular/angular/pull/11063#issuecomment-242577644
@brandonrobertshttps://github.com/brandonroberts
Please reload this pagehttps://github.com/angular/angular/pull/11063
https://github.com/vicb
vicbhttps://github.com/vicb
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Aug 25, 2016https://github.com/angular/angular/pull/11063#event-768226433
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 26, 2016https://github.com/angular/angular/pull/11063#issuecomment-242632828
@vsavkinhttps://github.com/vsavkin
Please reload this pagehttps://github.com/angular/angular/pull/11063
vsavkinhttps://github.com/vsavkin
August 26, 2016 00:28https://github.com/angular/angular/pull/11063#commits-pushed-70d3767
https://github.com/vsavkin
fix(router): update the location before activating componentshttps://github.com/angular/angular/pull/11063/commits/70d376719c26961be687fae0f312aa5b75ac8d16
70d3767https://github.com/angular/angular/pull/11063/commits/70d376719c26961be687fae0f312aa5b75ac8d16
https://github.com/vsavkin
fix(router): fix the order of guards, so canActivateChild runs before…https://github.com/angular/angular/pull/11063/commits/a18c8596a50ff91d6715a59e371bc40494ddca33
a18c859https://github.com/angular/angular/pull/11063/commits/a18c8596a50ff91d6715a59e371bc40494ddca33
https://github.com/vsavkin
fix(router): use encodeUri/decodeUri to encode fragmenthttps://github.com/angular/angular/pull/11063/commits/17850d3484ee3ecba9d53a08bf8696183c058ad1
17850d3https://github.com/angular/angular/pull/11063/commits/17850d3484ee3ecba9d53a08bf8696183c058ad1
https://github.com/vsavkin
refactor(router): make RouterLink and RouterLinkWithHref create url i…https://github.com/angular/angular/pull/11063/commits/eef6d128a681076bb9951230281eb27d89917f82
eef6d12https://github.com/angular/angular/pull/11063/commits/eef6d128a681076bb9951230281eb27d89917f82
https://github.com/vsavkin
feat(router): add support for custom error handlershttps://github.com/angular/angular/pull/11063/commits/544bd7019940da05fe4fdb08a1380a7ae011df97
544bd70https://github.com/angular/angular/pull/11063/commits/544bd7019940da05fe4fdb08a1380a7ae011df97
https://github.com/vsavkin
fix(router): add an option to disable initial navigationhttps://github.com/angular/angular/pull/11063/commits/a9d49db71f5c9a1f98ed25e28c57c96241c0836a
a9d49dbhttps://github.com/angular/angular/pull/11063/commits/a9d49db71f5c9a1f98ed25e28c57c96241c0836a
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
force-pushedhttps://github.com/angular/angular/compare/6afd5c01cb15003181eb9a5ed4f5e6b7405cb30a..a9d49db71f5c9a1f98ed25e28c57c96241c0836a
6afd5c0https://github.com/angular/angular/commit/6afd5c01cb15003181eb9a5ed4f5e6b7405cb30a
a9d49dbhttps://github.com/angular/angular/commit/a9d49db71f5c9a1f98ed25e28c57c96241c0836a
Compare https://github.com/angular/angular/compare/6afd5c01cb15003181eb9a5ed4f5e6b7405cb30a..a9d49db71f5c9a1f98ed25e28c57c96241c0836a
August 26, 2016 07:31https://github.com/angular/angular/pull/11063#event-768532953
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Aug 26, 2016https://github.com/angular/angular/pull/11063#event-768533056
https://github.com/vicb
vicbhttps://github.com/vicb
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Aug 26, 2016https://github.com/angular/angular/pull/11063#event-769081096
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 26, 2016 https://github.com/angular/angular/pull/11063#ref-pullrequest-173493845
fix(router): update the location before activating components #11102 https://github.com/angular/angular/pull/11102
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 26, 2016https://github.com/angular/angular/pull/11063#issuecomment-242785605
#11102https://github.com/angular/angular/pull/11102
Please reload this pagehttps://github.com/angular/angular/pull/11063
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 26, 2016https://github.com/angular/angular/pull/11063#event-769150389
vicbhttps://github.com/vicb
Aug 26, 2016 https://github.com/angular/angular/pull/11063#ref-commit-4445887
https://github.com/vicb
fix(Router): merge artifactshttps://github.com/vicb/angular/commit/444588725712b400bcab593aabcd1726774c535a
4445887https://github.com/vicb/angular/commit/444588725712b400bcab593aabcd1726774c535a
angular#11063https://github.com/angular/angular/pull/11063
angular#11102https://github.com/angular/angular/pull/11102
vicbhttps://github.com/vicb
Aug 26, 2016 https://github.com/angular/angular/pull/11063#ref-commit-fc1e45d
https://github.com/vicb
fix(Router): merge artifactshttps://github.com/angular/angular/commit/fc1e45db92c7449d7c6f28696df24da3f052ae4b
fc1e45dhttps://github.com/angular/angular/commit/fc1e45db92c7449d7c6f28696df24da3f052ae4b
#11063https://github.com/angular/angular/pull/11063
#11102https://github.com/angular/angular/pull/11102
Router: location.path is old URL during all component hooks. Updates after a tick. #10909 https://github.com/angular/angular/issues/10909
Can Activate child, can Activate operational order #10845 https://github.com/angular/angular/issues/10845
Router is serializing fragment parts on Router.runNavigate() causing corrupted URL #10827 https://github.com/angular/angular/issues/10827
routerLinkActive not activating if used on different tag than routerLink is used on #10704 https://github.com/angular/angular/issues/10704
Router : Resolve guard throw an exception when observable emits an error rc5 #10930 https://github.com/angular/angular/issues/10930
https://github.com/ericmartinezr
ericmartinezrhttps://github.com/ericmartinezr
Aug 30, 2016 https://github.com/angular/angular/pull/11063#ref-issue-173980107
child canActivate is called before parent canActivate is resolved when using AuthGuards #11161 https://github.com/angular/angular/issues/11161
https://github.com/RicardoD7I
RicardoD7Ihttps://github.com/RicardoD7I
Sep 10, 2016 https://github.com/angular/angular/pull/11063#ref-issue-154335641
Working Router agnostic now, hooray! But, one thing.. angulartics/angulartics2#29 https://github.com/angulartics/angulartics2/issues/29
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 9, 2019https://github.com/angular/angular/pull/11063#issuecomment-529425160
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/11063
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 9, 2019https://github.com/angular/angular/pull/11063#event-2618311037
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F11063
Please reload this pagehttps://github.com/angular/angular/pull/11063
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Router: location.path is old URL during all component hooks. Updates after a tick. https://github.com/angular/angular/issues/10909
Please reload this pagehttps://github.com/angular/angular/pull/11063
https://github.com/vsavkin
https://github.com/brandonroberts
https://github.com/vicb
https://github.com/robwormald
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.