René's URL Explorer Experiment


Title: fix(router): canLoad should cancel a navigation instead of failing it by vsavkin · Pull Request #11001 · angular/angular · GitHub

Open Graph Title: fix(router): canLoad should cancel a navigation instead of failing it by vsavkin · Pull Request #11001 · angular/angular

X Title: fix(router): canLoad should cancel a navigation instead of failing it by vsavkin · Pull Request #11001 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Currently canLoad returning false fails a navigation instead of canceling it. This is different from canActivate. This PR changes it so canLoad behaves similar to canActivate.

X Description: Currently canLoad returning false fails a navigation instead of canceling it. This is different from canActivate. This PR changes it so canLoad behaves similar to canActivate.

Opengraph URL: https://github.com/angular/angular/pull/11001

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0cadc483-5254-f9ac-2fd9-f989636f6fb6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB508:2564D8:1837702:1FF5484:6B013BF6
html-safe-nonced0e85f29d3231f0ee4bc10f376eef6ab15a392a65f147d9f7c18569e116354e1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTA4OjI1NjREODoxODM3NzAyOjFGRjU0ODQ6NkIwMTNCRjYiLCJ2aXNpdG9yX2lkIjoiOTc2MTU1MDE5MTY0MzM1MDk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac08155db4c40217a18b45e7189c2f6ec37b633343135050febab2d73654954def
hovercard-subject-tagpull_request:82328903
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/11001/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1b518fb8fa8bb3aa63f14ec81b7d169fdd587721eb0527e4c81ae707b8faeb18/angular/angular/pull/11001
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1b518fb8fa8bb3aa63f14ec81b7d169fdd587721eb0527e4c81ae707b8faeb18/angular/angular/pull/11001
og:image:altCurrently canLoad returning false fails a navigation instead of canceling it. This is different from canActivate. This PR changes it so canLoad behaves similar to canActivate.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevsavkin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/11001#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F11001
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F11001
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/11001
Reloadhttps://github.com/angular/angular/pull/11001
Reloadhttps://github.com/angular/angular/pull/11001
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
karahttps://github.com/kara
angular:masterhttps://github.com/angular/angular/tree/master
vsavkin:can_load_should_work_as_as_can_activatehttps://github.com/vsavkin/angular/tree/can_load_should_work_as_as_can_activate
Conversationhttps://github.com/angular/angular/pull/11001
Commits1 (1)https://github.com/angular/angular/pull/11001/commits
Checkshttps://github.com/angular/angular/pull/11001/checks
Files changedhttps://github.com/angular/angular/pull/11001/files
fix(router): canLoad should cancel a navigation instead of failing ithttps://github.com/angular/angular/pull/11001#top
karahttps://github.com/kara
angular:masterhttps://github.com/angular/angular/tree/master
vsavkin:can_load_should_work_as_as_can_activatehttps://github.com/vsavkin/angular/tree/can_load_should_work_as_as_can_activate
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
Aug 23, 2016https://github.com/angular/angular/pull/11001#issue-172648837
Please reload this pagehttps://github.com/angular/angular/pull/11001
Please reload this pagehttps://github.com/angular/angular/pull/11001
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 23, 2016https://github.com/angular/angular/pull/11001#event-764183455
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Aug 23, 2016https://github.com/angular/angular/pull/11001#event-764184078
https://github.com/naomiblack
naomiblackhttps://github.com/naomiblack
Aug 23, 2016https://github.com/angular/angular/pull/11001#issuecomment-241733128
#10585https://github.com/angular/angular/issues/10585
Please reload this pagehttps://github.com/angular/angular/pull/11001
https://github.com/naomiblack
naomiblackhttps://github.com/naomiblack
IgorMinarhttps://github.com/IgorMinar
Aug 23, 2016https://github.com/angular/angular/pull/11001#event-764482796
https://github.com/naomiblack
naomiblackhttps://github.com/naomiblack
2.0.0-rc.6https://github.com/angular/angular/milestone/65
Aug 23, 2016https://github.com/angular/angular/pull/11001#event-764487041
IgorMinarhttps://github.com/IgorMinar
Aug 23, 2016 https://github.com/angular/angular/pull/11001#discussion-diff-75892400
View reviewed changes https://github.com/angular/angular/pull/11001/files#diff-c13db33e2c346598f54e446392ef465f56ca578eb586e2521b26ae957873a7e6
modules/@angular/router/src/shared.tshttps://github.com/angular/angular/pull/11001/files#diff-c13db33e2c346598f54e446392ef465f56ca578eb586e2521b26ae957873a7e6
IgorMinarhttps://github.com/IgorMinar
Aug 23, 2016https://github.com/angular/angular/pull/11001#discussion_r75892400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/11001
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Aug 23, 2016https://github.com/angular/angular/pull/11001#issuecomment-241775209
Please reload this pagehttps://github.com/angular/angular/pull/11001
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
pr_state: LGTM https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22pr_state%3A%20LGTM%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Aug 23, 2016https://github.com/angular/angular/pull/11001#event-764685045
https://github.com/naomiblack
naomiblackhttps://github.com/naomiblack
vsavkinhttps://github.com/vsavkin
Aug 24, 2016https://github.com/angular/angular/pull/11001#event-766158067
https://github.com/vsavkin
fix(router): canLoad should cancel a navigation instead of failing ithttps://github.com/angular/angular/pull/11001/commits/786487fc92f8057e6c7f16b2bb1a63a72c3de46d
786487fhttps://github.com/angular/angular/pull/11001/commits/786487fc92f8057e6c7f16b2bb1a63a72c3de46d
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
force-pushedhttps://github.com/angular/angular/compare/12c5c3e68d56b1d0462304e65e4581c59004e1ba..786487fc92f8057e6c7f16b2bb1a63a72c3de46d
12c5c3ehttps://github.com/angular/angular/commit/12c5c3e68d56b1d0462304e65e4581c59004e1ba
786487fhttps://github.com/angular/angular/commit/786487fc92f8057e6c7f16b2bb1a63a72c3de46d
Compare https://github.com/angular/angular/compare/12c5c3e68d56b1d0462304e65e4581c59004e1ba..786487fc92f8057e6c7f16b2bb1a63a72c3de46d
August 24, 2016 15:56https://github.com/angular/angular/pull/11001#event-766205123
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Aug 24, 2016https://github.com/angular/angular/pull/11001#event-766205396
https://github.com/kara
karahttps://github.com/kara
f1ce760https://github.com/angular/angular/commit/f1ce7607a63313d7e0c4df957a6fc615fd80cede
Aug 24, 2016https://github.com/angular/angular/pull/11001#event-766318190
https://github.com/brandonroberts
brandonrobertshttps://github.com/brandonroberts
Aug 24, 2016 https://github.com/angular/angular/pull/11001#ref-issue-170068596
Router: Expose errors as events instead of failed promises #10585 https://github.com/angular/angular/issues/10585
https://github.com/YeomansIII
YeomansIIIhttps://github.com/YeomansIII
Dec 15, 2017https://github.com/angular/angular/pull/11001#issuecomment-352075373
Please reload this pagehttps://github.com/angular/angular/pull/11001
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Dec 15, 2017https://github.com/angular/angular/pull/11001#issuecomment-352079234
…https://github.com/angular/angular/pull/11001
#11001 (comment)https://github.com/angular/angular/pull/11001#issuecomment-352075373
https://github.com/notifications/unsubscribe-auth/AANM6Ev0fgcQpUBXRzwDH6dx0cMf3Kgmks5tAreggaJpZM4JqtZZhttps://github.com/notifications/unsubscribe-auth/AANM6Ev0fgcQpUBXRzwDH6dx0cMf3Kgmks5tAreggaJpZM4JqtZZ
Please reload this pagehttps://github.com/angular/angular/pull/11001
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/11001#issuecomment-531069550
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/11001
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/11001#event-2631005040
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F11001
Please reload this pagehttps://github.com/angular/angular/pull/11001
https://github.com/vsavkin
vsavkin https://github.com/vsavkin
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
2.0.0-rc.6 https://github.com/angular/angular/milestone/65
Please reload this pagehttps://github.com/angular/angular/pull/11001
https://github.com/vsavkin
https://github.com/naomiblack
https://github.com/IgorMinar
https://github.com/YeomansIII
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.