René's URL Explorer Experiment


Title: fix(router): resolve guard observables on the first emit by awerlang · Pull Request #10412 · angular/angular · GitHub

Open Graph Title: fix(router): resolve guard observables on the first emit by awerlang · Pull Request #10412 · angular/angular

X Title: fix(router): resolve guard observables on the first emit by awerlang · Pull Request #10412 · angular/angular

Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) What kind of change does this PR introduce? (check one with "x") [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Other... Please describe: What is the current behavior? (You can also link to an open issue here) #9613 What is the new behavior? On the first received value from an observable, decide to continue or cancel (de)activation. Waiting for completion is not required. Does this PR introduce a breaking change? (check one with "x") [ ] Yes [x] No If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... Other information: I believe this isn't a breaking change, even though the behavior is changed (accepting more than one value in the stream), because this wasn't properly documented. Also, I think is much more convenient to not require the observable to complete.

Open Graph Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format Tests for the c...

X Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format Tests for the c...

Opengraph URL: https://github.com/angular/angular/pull/10412

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:efcb4a74-2789-6ea9-7965-b2ef21e2e276
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE86A:F7C4C:B45656:F31160:6B00F6A9
html-safe-noncedbd18e5a3b22f602727c21f40fe4fc085e00045c2c122af361c10b08e6f8994f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODZBOkY3QzRDOkI0NTY1NjpGMzExNjA6NkIwMEY2QTkiLCJ2aXNpdG9yX2lkIjoiNDU1ODM0NzA0OTAwNjg1NTg0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2e0a7d8b01bd7d30c7e94457e49f2fec01af18179311851a5d710705c4c1b733
hovercard-subject-tagpull_request:79469427
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/10412/files
twitter:imagehttps://avatars.githubusercontent.com/u/589286?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/589286?s=400&v=4
og:image:altPlease check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format Tests for the c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/10412/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F10412%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F10412%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/10412/files
Reloadhttps://github.com/angular/angular/pull/10412/files
Reloadhttps://github.com/angular/angular/pull/10412/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
vikermanhttps://github.com/vikerman
angular:masterhttps://github.com/angular/angular/tree/master
awerlang:guards-observablehttps://github.com/awerlang/angular/tree/guards-observable
Conversation 15 https://github.com/angular/angular/pull/10412
Commits 1 https://github.com/angular/angular/pull/10412/commits
Checks 0 https://github.com/angular/angular/pull/10412/checks
Files changed https://github.com/angular/angular/pull/10412/files
Please reload this pagehttps://github.com/angular/angular/pull/10412/files
fix(router): resolve guard observables on the first emit https://github.com/angular/angular/pull/10412/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/10412/files
c6d645f fix(router): resolve guard observables on the first emit awerlang Jul 30, 2016 https://github.com/angular/angular/pull/10412/commits/c6d645f7ca20e9fa54fe86926c2e153a80a28f1b
Clear filters https://github.com/angular/angular/pull/10412/files
Please reload this pagehttps://github.com/angular/angular/pull/10412/files
Please reload this pagehttps://github.com/angular/angular/pull/10412/files
router.ts https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
integration.spec.ts https://github.com/angular/angular/pull/10412/files#diff-0ab3b6ef061822582d4148b7e0cb044685172aa8114ebb6866b5c111a8bfbdcd
modules/@angular/router/src/router.tshttps://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
View file https://github.com/awerlang/angular/blob/c6d645f7ca20e9fa54fe86926c2e153a80a28f1b/modules/%40angular/router/src/router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/10412/{{ revealButtonHref }}
https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
https://github.com/angular/angular/pull/10412/files#diff-e16fda12cf740538684c506da027b3e583048f5f6eabfcfb4da6e439f64ac8cb
modules/@angular/router/test/integration.spec.tshttps://github.com/angular/angular/pull/10412/files#diff-0ab3b6ef061822582d4148b7e0cb044685172aa8114ebb6866b5c111a8bfbdcd
View file https://github.com/awerlang/angular/blob/c6d645f7ca20e9fa54fe86926c2e153a80a28f1b/modules/%40angular/router/test/integration.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/10412/{{ revealButtonHref }}
https://github.com/angular/angular/pull/10412/files#diff-0ab3b6ef061822582d4148b7e0cb044685172aa8114ebb6866b5c111a8bfbdcd
https://github.com/angular/angular/pull/10412/files#diff-0ab3b6ef061822582d4148b7e0cb044685172aa8114ebb6866b5c111a8bfbdcd
https://github.com/angular/angular/pull/10412/files#diff-0ab3b6ef061822582d4148b7e0cb044685172aa8114ebb6866b5c111a8bfbdcd
https://github.com/angular/angular/pull/10412/files#diff-0ab3b6ef061822582d4148b7e0cb044685172aa8114ebb6866b5c111a8bfbdcd
https://github.com/angular/angular/pull/10412/files#diff-0ab3b6ef061822582d4148b7e0cb044685172aa8114ebb6866b5c111a8bfbdcd
https://github.com/angular/angular/pull/10412/files#diff-0ab3b6ef061822582d4148b7e0cb044685172aa8114ebb6866b5c111a8bfbdcd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.