René's URL Explorer Experiment


Title: Hash fragment should not be modified by Angular running PathLocationStrategy · Issue #8105 · angular/angular · GitHub

Open Graph Title: Hash fragment should not be modified by Angular running PathLocationStrategy · Issue #8105 · angular/angular

X Title: Hash fragment should not be modified by Angular running PathLocationStrategy · Issue #8105 · angular/angular

Description: When the location strategy is PathLocationStrategy the hash fragment is still cleared upon navigation. This happens in the RootRouter.commit method, which itself calls Location.go .. and ends calling History.pushState. I think it's reaso...

Open Graph Description: When the location strategy is PathLocationStrategy the hash fragment is still cleared upon navigation. This happens in the RootRouter.commit method, which itself calls Location.go .. and ends calli...

X Description: When the location strategy is PathLocationStrategy the hash fragment is still cleared upon navigation. This happens in the RootRouter.commit method, which itself calls Location.go .. and ends calli...

Opengraph URL: https://github.com/angular/angular/issues/8105

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Hash fragment should not be modified by Angular running PathLocationStrategy ","articleBody":"When the location strategy is `PathLocationStrategy` the hash fragment is still cleared upon navigation.\n\nThis happens in the [RootRouter.commit](https://github.com/angular/angular/blob/60727c4d2ba1e4b0b9455c767d0ef152bcedc7c2/modules/angular2/src/router/router.ts#L517) method, which itself calls `Location.go` .. and ends calling `History.pushState`.\n\nI think it's reasonable (or, actually, expected) NOT to tangle with the hash fragment at all, when the strategy is using URL paths.. what do you think?\n\nA very short piece of code added to `RootRouter.commit` could help achieving this:\n\n```\nvar hash = this._location.hash;\nif (this._location.platformStrategy instanceof PathLocationStrategy && hash.length > 0) {\n  emitPath += '#' + hash;\n}\n```\n\nWhat do you think? Without this change it's hard to embed apps using different location strategies.\n","author":{"url":"https://github.com/emesx","@type":"Person","name":"emesx"},"datePublished":"2016-04-16T14:49:31Z","url":"https://github.com/angular/angular/issues/8105"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:162f1742-6a74-f3b6-9fe3-4e7aabc548a8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE274:3CBB3E:12CD25F:17D88E0:6B0161F5
html-safe-nonce71e60567d9624ded5fbd04338df0b2650b54de33cd66ea9bf8aff29b3649df7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjc0OjNDQkIzRToxMkNEMjVGOjE3RDg4RTA6NkIwMTYxRjUiLCJ2aXNpdG9yX2lkIjoiNjQzNjc1NDAyODE1OTM5NDI5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc451cac5513145fabec547c7ad2c69c83f63747b44312d43e40ed0a38e7fbaad
hovercard-subject-tagissue:148859623
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/8105/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2e372f7bc774a6d8921d97124aa4de6122d4fd1267622f052b10c26761b68a49/angular/angular/issues/8105
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2e372f7bc774a6d8921d97124aa4de6122d4fd1267622f052b10c26761b68a49/angular/angular/issues/8105
og:image:altWhen the location strategy is PathLocationStrategy the hash fragment is still cleared upon navigation. This happens in the RootRouter.commit method, which itself calls Location.go .. and ends calli...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameemesx
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/8105#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F8105
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F8105
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/8105
Reloadhttps://github.com/angular/angular/issues/8105
Reloadhttps://github.com/angular/angular/issues/8105
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/8105
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/8105
Hash fragment should not be modified by Angular running PathLocationStrategy https://github.com/angular/angular/issues/8105#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
https://github.com/emesx
emesxhttps://github.com/emesx
on Apr 16, 2016https://github.com/angular/angular/issues/8105#issue-148859623
RootRouter.commithttps://github.com/angular/angular/blob/60727c4d2ba1e4b0b9455c767d0ef152bcedc7c2/modules/angular2/src/router/router.ts#L517
emesxhttps://github.com/emesx
on Apr 16, 2016https://github.com/angular/angular/issues/8105#event-629943991
https://github.com/zoechi
zoechihttps://github.com/zoechi
on Apr 16, 2016https://github.com/angular/angular/issues/8105#issuecomment-210838613
#6595https://github.com/angular/angular/issues/6595
naomiblackhttps://github.com/naomiblack
hotlist: GT/Internalhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20GT%2FInternal%22
on Apr 27, 2016https://github.com/angular/angular/issues/8105#event-642590591
naomiblackhttps://github.com/naomiblack
vsavkinhttps://github.com/vsavkin
on Apr 27, 2016https://github.com/angular/angular/issues/8105#event-642590700
https://github.com/naomiblack
naomiblackhttps://github.com/naomiblack
on Apr 27, 2016https://github.com/angular/angular/issues/8105#issuecomment-215012742
vsavkinhttps://github.com/vsavkin
hotlist: GT/Internalhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20GT%2FInternal%22
on Jul 7, 2016https://github.com/angular/angular/issues/8105#event-716349096
vsavkinhttps://github.com/vsavkin
on Jul 20, 2016https://github.com/angular/angular/issues/8105#event-729641256
IgorMinarhttps://github.com/IgorMinar
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Oct 4, 2016https://github.com/angular/angular/issues/8105#event-812548164
https://github.com/vsavkin
vsavkinhttps://github.com/vsavkin
on Oct 10, 2016https://github.com/angular/angular/issues/8105#issuecomment-252774989
vsavkinhttps://github.com/vsavkin
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 10, 2016https://github.com/angular/angular/issues/8105#event-818767685
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 9, 2019https://github.com/angular/angular/issues/8105#issuecomment-529704330
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 9, 2019https://github.com/angular/angular/issues/8105#event-2620436616
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/8105
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/8105
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.