Title: SignalFormControl does not update its parent FormGroup when a rule changes its status (disabled / conditional validators) · Issue #72009 · angular/angular · GitHub
Open Graph Title: SignalFormControl does not update its parent FormGroup when a rule changes its status (disabled / conditional validators) · Issue #72009 · angular/angular
X Title: SignalFormControl does not update its parent FormGroup when a rule changes its status (disabled / conditional validators) · Issue #72009 · angular/angular
Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description When a SignalFormControl is placed inside a regular FormGroup, rule-driven status changes are not propagated to the parent. The control its...
Open Graph Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description When a SignalFormControl is placed inside a regular FormGroup, rule-driven status changes are not p...
X Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description When a SignalFormControl is placed inside a regular FormGroup, rule-driven status changes are not p...
Opengraph URL: https://github.com/angular/angular/issues/72009
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SignalFormControl does not update its parent FormGroup when a rule changes its status (disabled / conditional validators)","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nforms\n\n### Is this a regression?\n\nNo\n\n### Description\n\nWhen a `SignalFormControl` is placed inside a regular `FormGroup`, rule-driven status changes are not propagated to the parent. The control itself reports the correct status, but the parent `FormGroup` keeps its previous status and value, and emits nothing.\n\nThis affects the pattern shown in the migration guide (https://angular.dev/guide/forms/signals/migration#disabling-enabling-control), where an external signal drives `disabled()` / `required()` / `applyWhen()`:\n\n- `required(p, { when: () => isRequired() })` switched off on an empty value: control -> `VALID`, parent `FormGroup` stays `INVALID`.\n- `disabled(p, { when: () => isDisabled() })` switched on: control -> `DISABLED`, parent `FormGroup` keeps the control in `value` and keeps the previous status (with a plain `FormControl` the disabled control would be excluded from the parent value and validity).\n\nIn both cases `parent.valueChanges` and `parent.statusChanges` emit 0 times. The parent catches up only on the next value change of the control.\n\n### Expected behavior\n\nThe parent `FormGroup` recomputes its value and validity whenever the `SignalFormControl` status changes, as it does for a `FormControl` (status/value of the parent consistent with the child; disabled child excluded from the parent value and validity).\n\n### Actual behavior\n\nThe parent is only notified when the control value changes.\n\n### Where in the source\n\n`packages/forms/signals/compat/src/signal_form_control/signal_form_control.ts` (main):\n\n- the value effect (L134-L144) calls `notifyParentUnlessPending()` -> `parent.updateValueAndValidity()`;\n- the status effect (L147-L156) only emits the control's own `statusChanges` / `StatusChangeEvent` and does not notify the parent.\n\n`packages/forms/signals/test/node/compat/signal_form_control_in_form_group.spec.ts` only covers validity changes caused by a value change; there is no test where a rule driven by an external signal changes the status.\n\nPossible fix: notify the parent from the status effect as well (inside `untracked`), respecting `pendingParentNotifications` to avoid double updates.\n\n### Workaround\n\n```ts\neffect(() => {\n void control.status; // tracks the Signal Forms signals read by the getter\n untracked(() => control.parent?.updateValueAndValidity());\n});\n```\n\n### Minimal reproduction\n\nNo StackBlitz, self-contained spec:\n\n```ts\nimport { signal } from '@angular/core';\nimport { TestBed } from '@angular/core/testing';\nimport { FormControl, FormGroup } from '@angular/forms';\nimport { disabled, required } from '@angular/forms/signals';\nimport { SignalFormControl } from '@angular/forms/signals/compat';\n\nit('parent FormGroup is not updated on rule-driven status changes', () => {\n const isRequired = signal(true);\n const isDisabled = signal(false);\n const name = TestBed.runInInjectionContext(\n () =>\n new SignalFormControl('', (p) => {\n required(p, { when: () => isRequired() });\n disabled(p, { when: () => isDisabled() });\n }),\n );\n const group = new FormGroup({ name, age: new FormControl(25) });\n TestBed.tick(); // flush initial effect runs, as on first render\n\n let emissions = 0;\n group.statusChanges.subscribe(() => emissions++);\n\n isRequired.set(false);\n TestBed.tick();\n expect(name.status).toBe('VALID');\n expect(group.status).toBe('VALID'); // FAILS: 'INVALID'\n\n isDisabled.set(true);\n TestBed.tick();\n expect(name.status).toBe('DISABLED');\n expect(group.value).toEqual({ age: 25 }); // FAILS: { name: '', age: 25 }\n\n expect(emissions).toBeGreaterThan(0); // FAILS: 0\n});\n```\n\nNote: without the first `TestBed.tick()` the test may pass by accident, because the initial run of the value effect notifies the parent after the rule has already changed.\n\n### Exception or error\n\nNo exception. Failing expectations:\n\n```\nexpect(group.status).toBe('VALID') -> received 'INVALID'\nexpect(group.value).toEqual({ age: 25 }) -> received { name: '', age: 25 }\nexpect(emissions).toBeGreaterThan(0) -> received 0\n```\n\n### Environment\n\n```\n@angular/core 22.2.2\n@angular/forms 22.2.2\nNode 24.21.0\n```\n\nAlso reproduced on @angular/forms 22.2.6.\nSame code on angular/angular main (checked 2026-11-12).\n","author":{"url":"https://github.com/JonataB","@type":"Person","name":"JonataB"},"datePublished":"2026-11-12T16:04:06Z","url":"https://github.com/angular/angular/issues/72009"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:88e8ba0e-515c-fe11-f117-7ee0adefcece |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D788:38E318:290818D:33F347A:6B01D65C |
| html-safe-nonce | ecfe2a748a0cf45ea3d52a11b8d105903c6d3b19daacef702abf3d5a0586bfd4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzg4OjM4RTMxODoyOTA4MThEOjMzRjM0N0E6NkIwMUQ2NUMiLCJ2aXNpdG9yX2lkIjoiMTgyMjM4NDUxODQ2MDQ2MjY4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 45e1aa4b08e0eb9dd8d162ba11b1e40b622881be6a1ced68d296e3fca90e3191 |
| hovercard-subject-tag | issue:6353809119 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/72009/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e24ba291a1a30253065ffe5e2c243d4b9b47865350fe7e10cce52073998cbcf9/angular/angular/issues/72009 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e24ba291a1a30253065ffe5e2c243d4b9b47865350fe7e10cce52073998cbcf9/angular/angular/issues/72009 |
| og:image:alt | Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description When a SignalFormControl is placed inside a regular FormGroup, rule-driven status changes are not p... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JonataB |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width