René's URL Explorer Experiment


Title: SignalFormControl does not update its parent FormGroup when a rule changes its status (disabled / conditional validators) · Issue #72009 · angular/angular · GitHub

Open Graph Title: SignalFormControl does not update its parent FormGroup when a rule changes its status (disabled / conditional validators) · Issue #72009 · angular/angular

X Title: SignalFormControl does not update its parent FormGroup when a rule changes its status (disabled / conditional validators) · Issue #72009 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description When a SignalFormControl is placed inside a regular FormGroup, rule-driven status changes are not propagated to the parent. The control its...

Open Graph Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description When a SignalFormControl is placed inside a regular FormGroup, rule-driven status changes are not p...

X Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description When a SignalFormControl is placed inside a regular FormGroup, rule-driven status changes are not p...

Opengraph URL: https://github.com/angular/angular/issues/72009

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SignalFormControl does not update its parent FormGroup when a rule changes its status (disabled / conditional validators)","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nforms\n\n### Is this a regression?\n\nNo\n\n### Description\n\nWhen a `SignalFormControl` is placed inside a regular `FormGroup`, rule-driven status changes are not propagated to the parent. The control itself reports the correct status, but the parent `FormGroup` keeps its previous status and value, and emits nothing.\n\nThis affects the pattern shown in the migration guide (https://angular.dev/guide/forms/signals/migration#disabling-enabling-control), where an external signal drives `disabled()` / `required()` / `applyWhen()`:\n\n- `required(p, { when: () => isRequired() })` switched off on an empty value: control -> `VALID`, parent `FormGroup` stays `INVALID`.\n- `disabled(p, { when: () => isDisabled() })` switched on: control -> `DISABLED`, parent `FormGroup` keeps the control in `value` and keeps the previous status (with a plain `FormControl` the disabled control would be excluded from the parent value and validity).\n\nIn both cases `parent.valueChanges` and `parent.statusChanges` emit 0 times. The parent catches up only on the next value change of the control.\n\n### Expected behavior\n\nThe parent `FormGroup` recomputes its value and validity whenever the `SignalFormControl` status changes, as it does for a `FormControl` (status/value of the parent consistent with the child; disabled child excluded from the parent value and validity).\n\n### Actual behavior\n\nThe parent is only notified when the control value changes.\n\n### Where in the source\n\n`packages/forms/signals/compat/src/signal_form_control/signal_form_control.ts` (main):\n\n- the value effect (L134-L144) calls `notifyParentUnlessPending()` -> `parent.updateValueAndValidity()`;\n- the status effect (L147-L156) only emits the control's own `statusChanges` / `StatusChangeEvent` and does not notify the parent.\n\n`packages/forms/signals/test/node/compat/signal_form_control_in_form_group.spec.ts` only covers validity changes caused by a value change; there is no test where a rule driven by an external signal changes the status.\n\nPossible fix: notify the parent from the status effect as well (inside `untracked`), respecting `pendingParentNotifications` to avoid double updates.\n\n### Workaround\n\n```ts\neffect(() => {\n  void control.status; // tracks the Signal Forms signals read by the getter\n  untracked(() => control.parent?.updateValueAndValidity());\n});\n```\n\n### Minimal reproduction\n\nNo StackBlitz, self-contained spec:\n\n```ts\nimport { signal } from '@angular/core';\nimport { TestBed } from '@angular/core/testing';\nimport { FormControl, FormGroup } from '@angular/forms';\nimport { disabled, required } from '@angular/forms/signals';\nimport { SignalFormControl } from '@angular/forms/signals/compat';\n\nit('parent FormGroup is not updated on rule-driven status changes', () => {\n  const isRequired = signal(true);\n  const isDisabled = signal(false);\n  const name = TestBed.runInInjectionContext(\n    () =>\n      new SignalFormControl('', (p) => {\n        required(p, { when: () => isRequired() });\n        disabled(p, { when: () => isDisabled() });\n      }),\n  );\n  const group = new FormGroup({ name, age: new FormControl(25) });\n  TestBed.tick(); // flush initial effect runs, as on first render\n\n  let emissions = 0;\n  group.statusChanges.subscribe(() => emissions++);\n\n  isRequired.set(false);\n  TestBed.tick();\n  expect(name.status).toBe('VALID');\n  expect(group.status).toBe('VALID'); // FAILS: 'INVALID'\n\n  isDisabled.set(true);\n  TestBed.tick();\n  expect(name.status).toBe('DISABLED');\n  expect(group.value).toEqual({ age: 25 }); // FAILS: { name: '', age: 25 }\n\n  expect(emissions).toBeGreaterThan(0); // FAILS: 0\n});\n```\n\nNote: without the first `TestBed.tick()` the test may pass by accident, because the initial run of the value effect notifies the parent after the rule has already changed.\n\n### Exception or error\n\nNo exception. Failing expectations:\n\n```\nexpect(group.status).toBe('VALID')        -> received 'INVALID'\nexpect(group.value).toEqual({ age: 25 })  -> received { name: '', age: 25 }\nexpect(emissions).toBeGreaterThan(0)      -> received 0\n```\n\n### Environment\n\n```\n@angular/core 22.2.2\n@angular/forms 22.2.2\nNode 24.21.0\n```\n\nAlso reproduced on @angular/forms 22.2.6.\nSame code on angular/angular main (checked 2026-11-12).\n","author":{"url":"https://github.com/JonataB","@type":"Person","name":"JonataB"},"datePublished":"2026-11-12T16:04:06Z","url":"https://github.com/angular/angular/issues/72009"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:88e8ba0e-515c-fe11-f117-7ee0adefcece
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD788:38E318:290818D:33F347A:6B01D65C
html-safe-nonceecfe2a748a0cf45ea3d52a11b8d105903c6d3b19daacef702abf3d5a0586bfd4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzg4OjM4RTMxODoyOTA4MThEOjMzRjM0N0E6NkIwMUQ2NUMiLCJ2aXNpdG9yX2lkIjoiMTgyMjM4NDUxODQ2MDQ2MjY4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac45e1aa4b08e0eb9dd8d162ba11b1e40b622881be6a1ced68d296e3fca90e3191
hovercard-subject-tagissue:6353809119
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/72009/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e24ba291a1a30253065ffe5e2c243d4b9b47865350fe7e10cce52073998cbcf9/angular/angular/issues/72009
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e24ba291a1a30253065ffe5e2c243d4b9b47865350fe7e10cce52073998cbcf9/angular/angular/issues/72009
og:image:altWhich @angular/* package(s) are the source of the bug? forms Is this a regression? No Description When a SignalFormControl is placed inside a regular FormGroup, rule-driven status changes are not p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJonataB
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/72009#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F72009
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F72009
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/72009
Reloadhttps://github.com/angular/angular/issues/72009
Reloadhttps://github.com/angular/angular/issues/72009
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/72009
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/72009
SignalFormControl does not update its parent FormGroup when a rule changes its status (disabled / conditional validators)https://github.com/angular/angular/issues/72009#top
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/JonataB
JonataBhttps://github.com/JonataB
on Nov 12, 2026https://github.com/angular/angular/issues/72009#issue-6353809119
https://angular.dev/guide/forms/signals/migration#disabling-enabling-controlhttps://angular.dev/guide/forms/signals/migration#disabling-enabling-control
angular-robothttps://github.com/apps/angular-robot
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
on Nov 12, 2026https://github.com/angular/angular/issues/72009#event-35933134265
angular-robothttps://github.com/apps/angular-robot
needsTriagehttps://github.com/angular/angular/milestone/83
on Nov 12, 2026https://github.com/angular/angular/issues/72009#event-35933138212
JeanMechehttps://github.com/JeanMeche
on Nov 12, 2026https://github.com/angular/angular/issues/72009#event-35941067123
fix(forms): notify parent control when SignalFormControl status chang…https://github.com/JeanMeche/angular/commit/647e87bc6434ada4e9fc3e9d6340c6a5e5c3fcda
https://docs.github.com/articles/closing-issues-via-commit-messages
647e87bhttps://github.com/JeanMeche/angular/commit/647e87bc6434ada4e9fc3e9d6340c6a5e5c3fcda
fix(forms): notify parent control when SignalFormControl status chang…https://github.com/JeanMeche/angular/commit/f9e85d025d2c7df485bc7a140b577fa2a77dd1a3
https://docs.github.com/articles/closing-issues-via-commit-messages
f9e85d0https://github.com/JeanMeche/angular/commit/f9e85d025d2c7df485bc7a140b577fa2a77dd1a3
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/72009
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/72009
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.