René's URL Explorer Experiment


Title: Signal Forms / FormValueControl violates ControlValueAccessor contract by calling writeValue back after onChange, causing infinite loop · Issue #67847 · angular/angular · GitHub

Open Graph Title: Signal Forms / FormValueControl violates ControlValueAccessor contract by calling writeValue back after onChange, causing infinite loop · Issue #67847 · angular/angular

X Title: Signal Forms / FormValueControl violates ControlValueAccessor contract by calling writeValue back after onChange, causing infinite loop · Issue #67847 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description Signal forms break the one-way ControlValueAccessor contract by calling writeValue back on a CVA component after that component called onCh...

Open Graph Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description Signal forms break the one-way ControlValueAccessor contract by calling writeValue back on a CVA co...

X Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description Signal forms break the one-way ControlValueAccessor contract by calling writeValue back on a CVA co...

Opengraph URL: https://github.com/angular/angular/issues/67847

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Signal Forms / FormValueControl violates ControlValueAccessor contract by calling writeValue back after onChange, causing infinite loop","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nforms\n\n### Is this a regression?\n\nNo\n\n### Description\n\nSignal forms break the one-way `ControlValueAccessor` contract by calling `writeValue` back on a CVA component after that component called `onChange`, directly contradicting Angular's own documentation.\n\n### The documented contract\n\nAngular's official documentation at angular.dev states clearly:\n\n> **`writeValue(value: any): void`**\n> Writes a new value to the element.\n> This method is called by the forms API to write to the view when **programmatic changes from model to view** are requested.\n\nThis defines a strict one-way contract:\n\n- `writeValue(value)` — called by the **form** for programmatic, external, model-to-view changes only\n- `onChange(value)` — called by the **component** when the user changes the value (view-to-model)\n\nThese two directions must never form a loop. Angular's classic `FormControl` correctly respects this — calling `onChange` updates the `FormControl`'s internal value but does **not** trigger `writeValue` back on the CVA. Signal forms do not respect this.\n\n### What Signal forms does wrong\n\nWhen a CVA component bound via `[formField]` calls `onChange(value)`, the Signal form updates its internal signal. Because Signal form has no concept of **value origin** — it does not distinguish between a programmatic external `set()` and a value that just arrived from the CVA via `onChange` — it reactively pushes the value back to `writeValue` on the same CVA that just sent it:\n\n```\nUser types in CVA component\n  → onChange(\"hello\") called\n    → Signal form signal updates\n      → writeValue(\"hello\") called back on CVA  ← violates documented contract\n```\n\nThe same issue applies to `FormValueControl`, the Signal form equivalent of CVA. There is no mechanism to indicate **who** submitted the change — whether it originated from inside the component or from an external model update. Without that distinction, any reactive form implementation will produce this loopback.\n\n### Real-world impact\n\nWe implemented a CodeMirror editor as a `ControlValueAccessor`. CodeMirror manages its own internal document state. Our contract is:\n\n- `writeValue` = programmatic value from outside, push into CodeMirror\n- `onChange` = user edited the document, notify the form\n\nWhen Signal form calls `writeValue` back after our `onChange`, we are forced to either:\n\n1. **Compare the incoming `writeValue` value against CodeMirror's current document** to detect the loopback — an O(n) string comparison on every keystroke. For large documents exceeding 1MB this causes severe and measurable performance degradation.\n2. **Use a dirty flag** to suppress the loopback `writeValue` — a workaround that should not be necessary and compensates for a broken contract.\n\nNeither workaround is acceptable. `FormControl` does not require either. The behaviour difference between `FormControl` and Signal form for the same CVA implementation is a clear regression in the Signal form design.\n\n### Expected behaviour\n\nSignal form must not call `writeValue` on a CVA in response to a value that was just received from that same CVA's `onChange`. This is the documented contract and the behaviour `FormControl` has always correctly implemented.\n\n### Please provide a link to a minimal reproduction of the bug\n\n_No response_\n\n### Please provide the exception or error you saw\n\n```true\n\n```\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n```true\nAngular CLI: 21.2.3\nNode: 22.21.1\nPackage Manager: npm 10.9.4\nOS: Windows 11 x64\n\nAngular: 21.2.5\n... animations, cli, common, compiler, core, forms, localize, platform-browser, platform-browser-dynamic, router, sdk\n```\n\n### Anything else?\n\n_No response_","author":{"url":"https://github.com/Nness","@type":"Person","name":"Nness"},"datePublished":"2026-03-25T02:52:10Z","url":"https://github.com/angular/angular/issues/67847"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d8cad500-f5d0-6281-a429-91f67f3d40fe
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id91C2:172F33:31AC0:3ED6C:6B01E74D
html-safe-noncefa8048165901c36a4ba6a2455d660687eec3c296a182289f44e15f5f3888340d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUMyOjE3MkYzMzozMUFDMDozRUQ2Qzo2QjAxRTc0RCIsInZpc2l0b3JfaWQiOiI0MTk0NDgzNjY0NTcyMjQ1ODM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacffde2504c582debda8dc5ebe688ebeb401e37362126ad2a00a74442074695a8c
hovercard-subject-tagissue:4132004588
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/67847/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9a724b154f7225997a889710f2a6c6035fc25db3561bc1276370385668abac42/angular/angular/issues/67847
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9a724b154f7225997a889710f2a6c6035fc25db3561bc1276370385668abac42/angular/angular/issues/67847
og:image:altWhich @angular/* package(s) are the source of the bug? forms Is this a regression? No Description Signal forms break the one-way ControlValueAccessor contract by calling writeValue back on a CVA co...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameNness
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/67847#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F67847
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F67847
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/67847
Reloadhttps://github.com/angular/angular/issues/67847
Reloadhttps://github.com/angular/angular/issues/67847
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/67847
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/67847
#67866https://github.com/angular/angular/pull/67866
Signal Forms / FormValueControl violates ControlValueAccessor contract by calling writeValue back after onChange, causing infinite loophttps://github.com/angular/angular/issues/67847#top
#67866https://github.com/angular/angular/pull/67866
https://github.com/alxhub
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
forms: signalshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20signals%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/Nness
Nnesshttps://github.com/Nness
on Mar 25, 2026https://github.com/angular/angular/issues/67847#issue-4132004588
angular-robothttps://github.com/apps/angular-robot
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
gemini-triagedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22gemini-triaged%22
on Mar 25, 2026https://github.com/angular/angular/issues/67847#event-23874338470
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Mar 25, 2026https://github.com/angular/angular/issues/67847#event-23874338849
https://github.com/Nness
Nnesshttps://github.com/Nness
on Mar 25, 2026https://github.com/angular/angular/issues/67847#issuecomment-4122782848
alxhubhttps://github.com/alxhub
forms: signalshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20signals%22
on Mar 25, 2026https://github.com/angular/angular/issues/67847#event-23875947763
github-project-automationhttps://github.com/apps/github-project-automation
Signal Formshttps://github.com/orgs/angular/projects/60
on Mar 25, 2026https://github.com/angular/angular/issues/67847#event-23875949223
alxhubhttps://github.com/alxhub
on Mar 25, 2026https://github.com/angular/angular/issues/67847#event-23875951503
https://github.com/Nness
Nnesshttps://github.com/Nness
on Mar 25, 2026https://github.com/angular/angular/issues/67847#issuecomment-4123538508
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on Mar 25, 2026https://github.com/angular/angular/issues/67847#issuecomment-4128706567
alxhubhttps://github.com/alxhub
on Mar 25, 2026https://github.com/angular/angular/issues/67847#event-23906954062
fix(forms): deduplicate writeValue calls in CVA interophttps://github.com/alxhub/angular/commit/97c21883a836a456946ab6a137bb5685be67c580
https://docs.github.com/articles/closing-issues-via-commit-messages
97c2188https://github.com/alxhub/angular/commit/97c21883a836a456946ab6a137bb5685be67c580
fix(forms): deduplicate writeValue calls in CVA interophttps://github.com/alxhub/angular/commit/31b2e3fc71c90091f47bba0b93e5d0bea9428a91
https://docs.github.com/articles/closing-issues-via-commit-messages
31b2e3fhttps://github.com/alxhub/angular/commit/31b2e3fc71c90091f47bba0b93e5d0bea9428a91
alxhubhttps://github.com/alxhub
Signal Formshttps://github.com/orgs/angular/projects/60
on Mar 25, 2026https://github.com/angular/angular/issues/67847
https://github.com/Nness
Nnesshttps://github.com/Nness
on Mar 26, 2026https://github.com/angular/angular/issues/67847#issuecomment-4130704352
@alxhubhttps://github.com/alxhub
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on Mar 26, 2026https://github.com/angular/angular/issues/67847#issuecomment-4130789880
https://github.com/Nness
Nnesshttps://github.com/Nness
on Mar 26, 2026https://github.com/angular/angular/issues/67847#issuecomment-4131131002
@alxhubhttps://github.com/alxhub
alxhubhttps://github.com/alxhub
on Apr 3, 2026https://github.com/angular/angular/issues/67847#event-24187486296
fix(forms): deduplicate writeValue calls in CVA interophttps://github.com/alxhub/angular/commit/28b320e7c145247c55328d0374752019e5804a97
https://docs.github.com/articles/closing-issues-via-commit-messages
28b320ehttps://github.com/alxhub/angular/commit/28b320e7c145247c55328d0374752019e5804a97
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#67866https://github.com/angular/angular/pull/67866
on Apr 7, 2026https://github.com/angular/angular/issues/67847#event-24274059011
github-project-automationhttps://github.com/apps/github-project-automation
Signal Formshttps://github.com/orgs/angular/projects/60
on Apr 7, 2026https://github.com/angular/angular/issues/67847
angular-robothttps://github.com/angular-robot
on Apr 7, 2026https://github.com/angular/angular/issues/67847#event-24274604786
fix(forms): deduplicate writeValue calls in CVA interophttps://github.com/angular-robot/angular/commit/2e9aeea0fed1a2eae261b95cb1479519d0428b83
https://docs.github.com/articles/closing-issues-via-commit-messages
2e9aeeahttps://github.com/angular-robot/angular/commit/2e9aeea0fed1a2eae261b95cb1479519d0428b83
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 8, 2026https://github.com/angular/angular/issues/67847#issuecomment-4402190606
automatic conversation locking policyhttps://github.com/angular/angular/blob/f0fbced1c55bc8b8ed9df01cea99df42f3e7eae3/contributing-docs/auto-issue-locking.md
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 8, 2026https://github.com/angular/angular/issues/67847#event-25285415233
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/67847
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/67847
alxhubhttps://github.com/alxhub
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
forms: signalshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20signals%22
Signal Formshttps://github.com/orgs/angular/projects/60
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.