René's URL Explorer Experiment


Title: feat(language-service): Pull-Based Diagnostics (LSP 3.17) · Issue #66699 · angular/angular · GitHub

Open Graph Title: feat(language-service): Pull-Based Diagnostics (LSP 3.17) · Issue #66699 · angular/angular

X Title: feat(language-service): Pull-Based Diagnostics (LSP 3.17) · Issue #66699 · angular/angular

Description: Feature Request: Pull-Based Diagnostics (LSP 3.17) Description The Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rather than having the server push them on e...

Open Graph Description: Feature Request: Pull-Based Diagnostics (LSP 3.17) Description The Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rath...

X Description: Feature Request: Pull-Based Diagnostics (LSP 3.17) Description The Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rath...

Opengraph URL: https://github.com/angular/angular/issues/66699

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(language-service): Pull-Based Diagnostics (LSP 3.17)","articleBody":"# Feature Request: Pull-Based Diagnostics (LSP 3.17)\n\n## Description\n\nThe Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rather than having the server push them on every change.\n\n## Current Behavior\n\nCurrently, the Angular Language Service uses push-based diagnostics via `textDocument/publishDiagnostics`. The server pushes diagnostics to the client on every file change, which can cause:\n\n1. **Redundant computations**: Diagnostics are recomputed even for unchanged files\n2. **Server-driven timing**: No control over when diagnostics are computed\n3. **Unnecessary updates**: Switching between tabs triggers diagnostic recomputation\n\n## Expected Behavior\n\nPull-Based Diagnostics (LSP 3.17) should:\n\n1. **Cache results**: Return `Unchanged` report in ~0.2ms when file hasn't changed\n2. **Client-controlled timing**: Let VS Code decide when to request diagnostics\n3. **Workspace batching**: Support `workspace/diagnostic` for all open files\n4. **Refresh signal**: Support `workspace/diagnostic/refresh` for server-initiated refresh\n\n### Protocol Flow\n\n```\nClient                          Server\n  |                                |\n  |-- textDocument/diagnostic ---->|\n  |      (with previousResultId)   |\n  |                                |\n  |\u003c-- Unchanged (resultId match)--|  \u003c- Cache hit: ~0.2ms\n  |         OR                     |\n  |\u003c-- Full (new diagnostics) ----|  \u003c- Cache miss: compute\n```\n\n## Motivation\n\nThis feature works together with #66668 (Client-Side File Watching) to provide comprehensive performance improvements:\n\n| Phase | Optimization | Benefit |\n|-------|-------------|---------|\n| **Project Open** | #66668 File Watching | Fast initialization |\n| **File Editing** | Pull Diagnostics | Cached results, reduced CPU |\n| **Tab Switching** | Pull Diagnostics | Instant cached responses |\n\n## Implementation Notes\n\n- Requires LSP 3.17 support (vscode-languageserver v9.0.1+)\n- Should fall back to push-based diagnostics for older clients\n- Cache should be keyed by `resultId` and document version\n\n## Labels\n\n- `area: language-service`\n- `feature`\n- `vscode-extension`\n","author":{"url":"https://github.com/kbrilla","@type":"Person","name":"kbrilla"},"datePublished":"2026-01-21T22:23:28Z","url":"https://github.com/angular/angular/issues/66699"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e2fdbcf4-5af9-763b-c921-066e555133d2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA3B4:A99C2:3963E7B:48ECDC9:6B01E2DD
html-safe-nonce4f042ff46f4848693361eb2d541565638a2f6c29297a2d8f349daeb414c16154
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0I0OkE5OUMyOjM5NjNFN0I6NDhFQ0RDOTo2QjAxRTJERCIsInZpc2l0b3JfaWQiOiI0MTEzMjk0NTM2MjcxMzIzODcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0997c3e91b53732294afc0026a00efa871d9277ea7ab5bf06c95f998bac1ad60
hovercard-subject-tagissue:3840260298
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/66699/issue_layout
twitter:imagehttps://opengraph.githubassets.com/76e6ac8b7fc87bad1cc0b88316814c2d57dd3181796d7b5ffff9838e430557e2/angular/angular/issues/66699
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/76e6ac8b7fc87bad1cc0b88316814c2d57dd3181796d7b5ffff9838e430557e2/angular/angular/issues/66699
og:image:altFeature Request: Pull-Based Diagnostics (LSP 3.17) Description The Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rath...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekbrilla
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/66699#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F66699
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F66699
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/66699
Reloadhttps://github.com/angular/angular/issues/66699
Reloadhttps://github.com/angular/angular/issues/66699
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/66699
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/66699
feat(language-service): Pull-Based Diagnostics (LSP 3.17)https://github.com/angular/angular/issues/66699#top
area: vscode-extensionIssues related to the Angular Language Service VsCode extensionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20vscode-extension%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/kbrilla
kbrillahttps://github.com/kbrilla
on Jan 21, 2026https://github.com/angular/angular/issues/66699#issue-3840260298
#66668https://github.com/angular/angular/pull/66668
#66668https://github.com/angular/angular/pull/66668
amishnehttps://github.com/amishne
area: language-serviceIssues related to Angular's VS Code language servicehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20language-service%22
on Jan 22, 2026https://github.com/angular/angular/issues/66699#event-22202713090
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jan 22, 2026https://github.com/angular/angular/issues/66699#event-22202713561
alan-agius4https://github.com/alan-agius4
area: vscode-extensionIssues related to the Angular Language Service VsCode extensionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20vscode-extension%22
area: language-serviceIssues related to Angular's VS Code language servicehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20language-service%22
on Jan 22, 2026https://github.com/angular/angular/issues/66699#event-22210566249
kbrillahttps://github.com/kbrilla
on Mar 3, 2026https://github.com/angular/angular/issues/66699#event-23223116420
feat(language-service): implement pull-based diagnostics (LSP 3.17)https://github.com/kbrilla/angular/commit/3d131055a80588fc90ae36d0d60ce39cfb3cd8bb
https://docs.github.com/articles/closing-issues-via-commit-messages
3d13105https://github.com/kbrilla/angular/commit/3d131055a80588fc90ae36d0d60ce39cfb3cd8bb
feat(language-service): implement pull-based diagnostics (LSP 3.17)https://github.com/kbrilla/angular/commit/bedb93c32df9478256fcd2b153d42f487b12c063
https://docs.github.com/articles/closing-issues-via-commit-messages
bedb93chttps://github.com/kbrilla/angular/commit/bedb93c32df9478256fcd2b153d42f487b12c063
JeanMechehttps://github.com/JeanMeche
not plannedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Oct 30, 2026https://github.com/angular/angular/issues/66699#event-34705850836
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/66699
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/66699
area: vscode-extensionIssues related to the Angular Language Service VsCode extensionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20vscode-extension%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.