Title: feat(language-service): Pull-Based Diagnostics (LSP 3.17) · Issue #66699 · angular/angular · GitHub
Open Graph Title: feat(language-service): Pull-Based Diagnostics (LSP 3.17) · Issue #66699 · angular/angular
X Title: feat(language-service): Pull-Based Diagnostics (LSP 3.17) · Issue #66699 · angular/angular
Description: Feature Request: Pull-Based Diagnostics (LSP 3.17) Description The Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rather than having the server push them on e...
Open Graph Description: Feature Request: Pull-Based Diagnostics (LSP 3.17) Description The Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rath...
X Description: Feature Request: Pull-Based Diagnostics (LSP 3.17) Description The Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rath...
Opengraph URL: https://github.com/angular/angular/issues/66699
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"feat(language-service): Pull-Based Diagnostics (LSP 3.17)","articleBody":"# Feature Request: Pull-Based Diagnostics (LSP 3.17)\n\n## Description\n\nThe Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rather than having the server push them on every change.\n\n## Current Behavior\n\nCurrently, the Angular Language Service uses push-based diagnostics via `textDocument/publishDiagnostics`. The server pushes diagnostics to the client on every file change, which can cause:\n\n1. **Redundant computations**: Diagnostics are recomputed even for unchanged files\n2. **Server-driven timing**: No control over when diagnostics are computed\n3. **Unnecessary updates**: Switching between tabs triggers diagnostic recomputation\n\n## Expected Behavior\n\nPull-Based Diagnostics (LSP 3.17) should:\n\n1. **Cache results**: Return `Unchanged` report in ~0.2ms when file hasn't changed\n2. **Client-controlled timing**: Let VS Code decide when to request diagnostics\n3. **Workspace batching**: Support `workspace/diagnostic` for all open files\n4. **Refresh signal**: Support `workspace/diagnostic/refresh` for server-initiated refresh\n\n### Protocol Flow\n\n```\nClient Server\n | |\n |-- textDocument/diagnostic ---->|\n | (with previousResultId) |\n | |\n |\u003c-- Unchanged (resultId match)--| \u003c- Cache hit: ~0.2ms\n | OR |\n |\u003c-- Full (new diagnostics) ----| \u003c- Cache miss: compute\n```\n\n## Motivation\n\nThis feature works together with #66668 (Client-Side File Watching) to provide comprehensive performance improvements:\n\n| Phase | Optimization | Benefit |\n|-------|-------------|---------|\n| **Project Open** | #66668 File Watching | Fast initialization |\n| **File Editing** | Pull Diagnostics | Cached results, reduced CPU |\n| **Tab Switching** | Pull Diagnostics | Instant cached responses |\n\n## Implementation Notes\n\n- Requires LSP 3.17 support (vscode-languageserver v9.0.1+)\n- Should fall back to push-based diagnostics for older clients\n- Cache should be keyed by `resultId` and document version\n\n## Labels\n\n- `area: language-service`\n- `feature`\n- `vscode-extension`\n","author":{"url":"https://github.com/kbrilla","@type":"Person","name":"kbrilla"},"datePublished":"2026-01-21T22:23:28Z","url":"https://github.com/angular/angular/issues/66699"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e2fdbcf4-5af9-763b-c921-066e555133d2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A3B4:A99C2:3963E7B:48ECDC9:6B01E2DD |
| html-safe-nonce | 4f042ff46f4848693361eb2d541565638a2f6c29297a2d8f349daeb414c16154 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0I0OkE5OUMyOjM5NjNFN0I6NDhFQ0RDOTo2QjAxRTJERCIsInZpc2l0b3JfaWQiOiI0MTEzMjk0NTM2MjcxMzIzODcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0997c3e91b53732294afc0026a00efa871d9277ea7ab5bf06c95f998bac1ad60 |
| hovercard-subject-tag | issue:3840260298 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/66699/issue_layout |
| twitter:image | https://opengraph.githubassets.com/76e6ac8b7fc87bad1cc0b88316814c2d57dd3181796d7b5ffff9838e430557e2/angular/angular/issues/66699 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/76e6ac8b7fc87bad1cc0b88316814c2d57dd3181796d7b5ffff9838e430557e2/angular/angular/issues/66699 |
| og:image:alt | Feature Request: Pull-Based Diagnostics (LSP 3.17) Description The Angular Language Service should implement Pull-Based Diagnostics (LSP 3.17) to allow VS Code to request diagnostics on-demand rath... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kbrilla |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width