René's URL Explorer Experiment


Title: zone.js monkey patching of Jasmine's GlobalErrors is a no-op, and would break Jasmine if it wasn't · Issue #63072 · angular/angular · GitHub

Open Graph Title: zone.js monkey patching of Jasmine's GlobalErrors is a no-op, and would break Jasmine if it wasn't · Issue #63072 · angular/angular

X Title: zone.js monkey patching of Jasmine's GlobalErrors is a no-op, and would break Jasmine if it wasn't · Issue #63072 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? Yes Description zone.js attempts to monkey-patch Jasmine's GlobalErrors, for reasons that aren't entirely clear to me. It's a no-op because it happens a...

Open Graph Description: Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? Yes Description zone.js attempts to monkey-patch Jasmine's GlobalErrors, for reasons that aren't entirely clear ...

X Description: Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? Yes Description zone.js attempts to monkey-patch Jasmine's GlobalErrors, for reasons that aren't entirel...

Opengraph URL: https://github.com/angular/angular/issues/63072

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"zone.js monkey patching of Jasmine's GlobalErrors is a no-op, and would break Jasmine if it wasn't","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nzone.js\n\n### Is this a regression?\n\nYes\n\n### Description\n\nzone.js attempts to monkey-patch Jasmine's `GlobalErrors`, for reasons that aren't entirely clear to me. It's a no-op because it happens after Jasmine has already constructed its `GlobalErrors` instance. If the monkey-patching occurred early enough to have any effect, it would crash Jasmine beginning with the next jasmine-core release because [GlobalErrors has required constructor parameters](https://github.com/jasmine/jasmine/blob/42cca93926638d3660efc356b14d3ca3d531e09d/src/core/GlobalErrors.js#L10C25-L10C34) and [zone.js's monkey patch fails to forward them](https://github.com/angular/angular/blob/660444fbf296ce45f0a33d443e804237fa9bb8cc/packages/zone.js/lib/jasmine/jasmine.ts#L65)\n\nMy recommendation is to stop monkey patching `GlobalErrors` altogether. Presumably it's not doing anything important, if nobody noticed that it wasn't working. And any monkey patching creates a situation where any future version of jasmine-core could be incompatible, since you're depending on private interfaces that are outside of the scope of semver. So the less of it you can do, the better. But if you have to monkey patch `GlobalErrors`, it would be best to forward all constructor arguments to the real thing.\n\n### Please provide a link to a minimal reproduction of the bug\n\n_No response_\n\n### Please provide the exception or error you saw\n\n```true\n\n```\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n```true\n\n```\n\n### Anything else?\n\n_No response_","author":{"url":"https://github.com/sgravrock","@type":"Person","name":"sgravrock"},"datePublished":"2025-08-09T17:34:24Z","url":"https://github.com/angular/angular/issues/63072"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ddf4c17d-856a-ed8a-78f7-2b16a674f9c8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id81CC:2F543F:1861B89:203B151:6B020D54
html-safe-nonce204dcc4d51664cd3c9dfdff44efd75ccb2ae98869b412048ad1811903cce514c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUNDOjJGNTQzRjoxODYxQjg5OjIwM0IxNTE6NkIwMjBENTQiLCJ2aXNpdG9yX2lkIjoiNjEzNTM2ODU5NjY3NjgwODAyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac50cbd1e70c1420eb476b000bc9d6a49ecfa9e7b689e1203509cd1d02f697d1e4
hovercard-subject-tagissue:3306622828
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/63072/issue_layout
twitter:imagehttps://opengraph.githubassets.com/94662a31805e120acaddbd9382e3160ee0747ecc4e93101df29d2f9ceb44405a/angular/angular/issues/63072
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/94662a31805e120acaddbd9382e3160ee0747ecc4e93101df29d2f9ceb44405a/angular/angular/issues/63072
og:image:altWhich @angular/* package(s) are the source of the bug? zone.js Is this a regression? Yes Description zone.js attempts to monkey-patch Jasmine's GlobalErrors, for reasons that aren't entirely clear ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesgravrock
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/63072#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F63072
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F63072
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/63072
Reloadhttps://github.com/angular/angular/issues/63072
Reloadhttps://github.com/angular/angular/issues/63072
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/63072
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/63072
zone.js monkey patching of Jasmine's GlobalErrors is a no-op, and would break Jasmine if it wasn'thttps://github.com/angular/angular/issues/63072#top
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/sgravrock
sgravrockhttps://github.com/sgravrock
on Aug 9, 2025https://github.com/angular/angular/issues/63072#issue-3306622828
GlobalErrors has required constructor parametershttps://github.com/jasmine/jasmine/blob/42cca93926638d3660efc356b14d3ca3d531e09d/src/core/GlobalErrors.js#L10C25-L10C34
zone.js's monkey patch fails to forward themhttps://github.com/angular/angular/blob/660444fbf296ce45f0a33d443e804237fa9bb8cc/packages/zone.js/lib/jasmine/jasmine.ts#L65
https://github.com/sgravrock
sgravrockhttps://github.com/sgravrock
on Aug 9, 2025https://github.com/angular/angular/issues/63072#issuecomment-3171962534
JeanMechehttps://github.com/JeanMeche
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
on Aug 9, 2025https://github.com/angular/angular/issues/63072#event-19070139383
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Aug 9, 2025https://github.com/angular/angular/issues/63072#event-19070139813
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
on Aug 9, 2025https://github.com/angular/angular/issues/63072#issuecomment-3172166531
status of zone.jshttps://github.com/angular/angular/blob/main/packages/zone.js/README.md#development-status-of-zonejs
JeanMechehttps://github.com/JeanMeche
needs reproductionThis issue needs a reproduction in order for the team to investigate furtherhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22needs%20reproduction%22
on Aug 9, 2025https://github.com/angular/angular/issues/63072#event-19072006527
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Aug 9, 2025https://github.com/angular/angular/issues/63072#event-19072006767
https://github.com/atscott
atscotthttps://github.com/atscott
on Aug 9, 2025https://github.com/angular/angular/issues/63072#issuecomment-3172198510
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
on Aug 9, 2025https://github.com/angular/angular/issues/63072#issuecomment-3172202537
angular/zone.js@82dfd75https://github.com/angular/zone.js/commit/82dfd75d574604e33e2696a99abfad188764945b
https://github.com/sgravrock
sgravrockhttps://github.com/sgravrock
on Aug 10, 2025https://github.com/angular/angular/issues/63072#issuecomment-3172284142
@atscotthttps://github.com/atscott
@JeanMechehttps://github.com/JeanMeche
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
on Aug 10, 2025https://github.com/angular/angular/issues/63072#issuecomment-3172667975
JeanMechehttps://github.com/JeanMeche
on Aug 10, 2025https://github.com/angular/angular/issues/63072#event-19076291631
refactor(zone.js): remove unused jasmine globalerror monkey patching.https://github.com/JeanMeche/angular/commit/b53a6c5eba1a5599fc967737de16b0c0a7f9fbd7
https://docs.github.com/articles/closing-issues-via-commit-messages
b53a6c5https://github.com/JeanMeche/angular/commit/b53a6c5eba1a5599fc967737de16b0c0a7f9fbd7
https://github.com/sgravrock
sgravrockhttps://github.com/sgravrock
on Aug 10, 2025https://github.com/angular/angular/issues/63072#issuecomment-3172892988
a new feature that changes GlobalErrorshttps://github.com/jasmine/jasmine/commit/395ef85954c1220e87a41174746bdc28f399015c
angular/angular-cli#30861https://github.com/angular/angular-cli/issues/30861
JeanMechehttps://github.com/JeanMeche
on Aug 10, 2025https://github.com/angular/angular/issues/63072#event-19078199932
refactor(zone.js): remove unused jasmine globalerror monkey patching.https://github.com/JeanMeche/angular/commit/a0f5e0332fe80ae28edc81a6bead95d1e829e975
https://docs.github.com/articles/closing-issues-via-commit-messages
a0f5e03https://github.com/JeanMeche/angular/commit/a0f5e0332fe80ae28edc81a6bead95d1e829e975
refactor(zone.js): remove unused jasmine globalerror monkey patching.https://github.com/JeanMeche/angular/commit/e9e61569e71d49bc5271389e3cfafdc0caa922c7
https://docs.github.com/articles/closing-issues-via-commit-messages
e9e6156https://github.com/JeanMeche/angular/commit/e9e61569e71d49bc5271389e3cfafdc0caa922c7
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
on Aug 11, 2025https://github.com/angular/angular/issues/63072#issuecomment-3174177048
angular/zone.js@82dfd75https://github.com/angular/zone.js/commit/82dfd75d574604e33e2696a99abfad188764945b
#63077https://github.com/angular/angular/pull/63077
https://github.com/atscott
atscotthttps://github.com/atscott
on Aug 11, 2025https://github.com/angular/angular/issues/63072#issuecomment-3175842441
angular/zone.js#1185https://github.com/angular/zone.js/pull/1185
@JeanMechehttps://github.com/JeanMeche
jasmine/jasmine@6c56ebchttps://github.com/jasmine/jasmine/commit/6c56ebc9845e37e5a0de8dec274495632ea4db4f
#47195https://github.com/angular/angular/pull/47195
https://github.com/angular/angular/pull/49914/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42https://github.com/angular/angular/pull/49914/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
6d7eb35https://github.com/angular/angular/commit/6d7eb3548c5fc3aedb4a52ff2010141343748e90
#51357https://github.com/angular/angular/issues/51357
atscotthttps://github.com/atscott
needs reproductionThis issue needs a reproduction in order for the team to investigate furtherhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22needs%20reproduction%22
on Aug 11, 2025https://github.com/angular/angular/issues/63072#event-19093226457
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
needsTriagehttps://github.com/angular/angular/milestone/83
on Aug 11, 2025https://github.com/angular/angular/issues/63072#event-19093226865
atscotthttps://github.com/atscott
on Aug 11, 2025https://github.com/angular/angular/issues/63072#event-19099848123
refactor(zone.js): remove unused jasmine globalerror monkey patching. (…https://github.com/angular/angular/commit/e6c84a4a12fc9b7b3b323ae25b4cd6e343d4e217
…https://github.com/angular/angular/pull/63077
https://docs.github.com/articles/closing-issues-via-commit-messages
e6c84a4https://github.com/angular/angular/commit/e6c84a4a12fc9b7b3b323ae25b4cd6e343d4e217
refactor(zone.js): remove unused jasmine globalerror monkey patching. (…https://github.com/angular/angular/commit/b38c43bacc4b09885bfc26c6bd149c5b269d9e81
…https://github.com/angular/angular/pull/63077
https://docs.github.com/articles/closing-issues-via-commit-messages
b38c43bhttps://github.com/angular/angular/commit/b38c43bacc4b09885bfc26c6bd149c5b269d9e81
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
9aef481https://github.com/angular/angular/commit/9aef481172eebd6e575f7d5f50c4a52608cd56cf
on Aug 11, 2025https://github.com/angular/angular/issues/63072#event-19099849526
https://github.com/sgravrock
sgravrockhttps://github.com/sgravrock
on Aug 12, 2025https://github.com/angular/angular/issues/63072#issuecomment-3177242053
angular-robothttps://github.com/angular-robot
on Aug 12, 2025https://github.com/angular/angular/issues/63072#event-19100138922
refactor(zone.js): remove unused jasmine globalerror monkey patching. (…https://github.com/angular-robot/angular/commit/9aef481172eebd6e575f7d5f50c4a52608cd56cf
…https://github.com/angular/angular/pull/63077
https://docs.github.com/articles/closing-issues-via-commit-messages
9aef481https://github.com/angular-robot/angular/commit/9aef481172eebd6e575f7d5f50c4a52608cd56cf
sgravrockhttps://github.com/sgravrock
on Aug 12, 2025https://github.com/angular/angular/issues/63072#event-19100637012
Prevent GloablErrors from being monkey patchedhttps://github.com/jasmine/jasmine/commit/5b06531cacabc33256775ebc7d84ad947e2722c1
5b06531https://github.com/jasmine/jasmine/commit/5b06531cacabc33256775ebc7d84ad947e2722c1
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 12, 2025https://github.com/angular/angular/issues/63072#issuecomment-3283040026
automatic conversation locking policyhttps://github.com/angular/angular/blob/f0fbced1c55bc8b8ed9df01cea99df42f3e7eae3/contributing-docs/auto-issue-locking.md
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 12, 2025https://github.com/angular/angular/issues/63072#event-19648352357
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/63072
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/63072
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.