Title: Service Worker incorrectly handles external Range Requests, causing an infinite loop and bypassing dataGroups configuration · Issue #62333 · angular/angular · GitHub
Open Graph Title: Service Worker incorrectly handles external Range Requests, causing an infinite loop and bypassing dataGroups configuration · Issue #62333 · angular/angular
X Title: Service Worker incorrectly handles external Range Requests, causing an infinite loop and bypassing dataGroups configuration · Issue #62333 · angular/angular
Description: Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? No Description Problem Description The Angular Service Worker in v20.0.5 incorrectly handles fetch events for external URLs that contain an HTTP ...
Open Graph Description: Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? No Description Problem Description The Angular Service Worker in v20.0.5 incorrectly handles fetch events...
X Description: Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? No Description Problem Description The Angular Service Worker in v20.0.5 incorrectly handles fetch events...
Opengraph URL: https://github.com/angular/angular/issues/62333
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Service Worker incorrectly handles external Range Requests, causing an infinite loop and bypassing dataGroups configuration","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nservice-worker\n\n### Is this a regression?\n\nNo\n\n### Description\n\nProblem Description\n\nThe Angular Service Worker in v20.0.5 incorrectly handles fetch events for external URLs that contain an HTTP Range header. This leads to an infinite loop within the service worker, which the browser eventually terminates by serving the index.html file as a fallback.\n\nThis behavior makes it impossible to stream media from external CDNs using libraries like hls.js, as these rely on Range Requests to fetch video segments.\n\nCrucially, this faulty logic has a higher precedence than the dataGroups configuration in ngsw-config.json. Any dataGroups rule intended to create a \"pass-through\" for external URLs (e.g., for https://*/**) is completely ignored for requests containing a Range header.\n\nReproduction\n\nSetup: Create a new Angular application using Angular v20 and add @angular/pwa.\n\nConfiguration: Configure the ngsw-config.json with a \"pass-through\" dataGroup intended to let all external HTTPS requests go directly to the network.\n\nJSON\n\n// ngsw-config.json\n{\n // ...\n \"dataGroups\": [\n {\n \"name\": \"external-https-passthrough\",\n \"urls\": [\n \"https://*/**\"\n ],\n \"cacheConfig\": {\n \"maxSize\": 0,\n \"maxAge\": \"0u\",\n \"strategy\": \"freshness\"\n }\n }\n ]\n}\nAction: In a component, attempt to play a video from any external CDN that delivers video via HLS or DASH. A library like hls.js will trigger requests for media segments (.mp4, .ts) which include a Range: bytes=... header.\n\nObservation: Open the browser's developer tools and inspect the Network tab.\n\nExpected Behavior\n\nThe dataGroups rule for https://*/** should be respected for all external data requests, including those with a Range header.\n\nThe service worker should intercept the request, match it against the dataGroup's pattern, and apply the freshness strategy, fetching the resource directly from the network.\n\nThe video player should receive the correct video segment data and playback should start correctly.\n\nActual Behavior\n\nThe network request for the video segment fails.\n\nThe \"Size\" column in the Network tab shows that the request was handled by the (ServiceWorker).\n\nThe \"Response\" tab for the failed request shows the content of the application's index.html file.\n\nThe hls.js library fails with a mediaError of type fragParsingError because it cannot parse the received HTML content.\n\nRoot Cause Analysis\n\nThe issue lies in the onFetch method of the Driver class in the compiled ngsw-worker.js.\n\nJavaScript\n\n// ngsw-worker.js (un-patched) in Driver.onFetch(event)\nonFetch(event) {\n const req = event.request;\n // ...\n if (req.headers.has(\"range\")) {\n event.respondWith(this.handleRangeRequest(req));\n return; // \u003c-- Problematic early return\n }\n // ...\n // The logic that processes dataGroups is only reached here:\n event.respondWith(this.handleFetch(event)); \n}\nThe if (req.headers.has(\"range\")) check has high precedence and executes near the beginning of the onFetch listener.\n\nIf a request has a Range header, it immediately calls this.handleRangeRequest(req) and then returns.\n\nThis completely bypasses the main event.respondWith(this.handleFetch(event)) call at the end of the method, which is responsible for invoking the logic that evaluates the dataGroups configuration.\n\nThe handleRangeRequest method then calls await fetch(req). Since this is called from within the onFetch listener for the same request, it is re-intercepted by the service worker, causing an infinite loop.\n\nThe browser breaks this loop and serves the index.html as a fallback.\n\nThis special handling for Range Requests seems intended for serving cached media, but it incorrectly intercepts and mishandles all Range requests, including external ones it should be ignoring.\n\nWorkaround\n\nThe only viable solution is to manually patch the generated ngsw-worker.js file after the build process. By injecting a check at the very beginning of the onFetch method, the faulty logic can be bypassed for external requests.\n\nThis sed command in our build script resolves the issue:\n\nBash\n\nsed -i '' \"s/onFetch(event) {/onFetch(event) { const url = new URL(event.request.url); if (url.origin !== self.location.origin) { return; }/g\" dist/path/to/ngsw-worker.js\nThis patch correctly instructs the service worker to immediately cede control for any request not originating from the application's own origin, allowing the browser to handle it normally. This happens before the problematic range header check is reached.\n\nEnvironment\n\nAngular version: 20.0.5\n\nAngular CLI version: 20.0.5\n\n@angular/service-worker version: 20.0.5\n\n### Please provide a link to a minimal reproduction of the bug\n\n_No response_\n\n### Please provide the exception or error you saw\n\n```true\n\n```\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n```true\n\n```\n\n### Anything else?\n\n_No response_","author":{"url":"https://github.com/Benny739","@type":"Person","name":"Benny739"},"datePublished":"2025-06-27T11:50:30Z","url":"https://github.com/angular/angular/issues/62333"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:21073c72-a16f-194e-fb78-db8cafb6f301 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A8FA:1EC9BC:F01B31:132FADE:6B010E45 |
| html-safe-nonce | c8e02e5bfe74914bf61bebe802291629d339abfb7a1d4e3bd04430098e138905 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEZBOjFFQzlCQzpGMDFCMzE6MTMyRkFERTo2QjAxMEU0NSIsInZpc2l0b3JfaWQiOiI3MDAzNjk2NjQzMzA4NTg4NjEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0db3c204537d1bbd5ad926e5287630b10466a70d530c3d97e96cd966ef18c6b4 |
| hovercard-subject-tag | issue:3182543986 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/62333/issue_layout |
| twitter:image | https://opengraph.githubassets.com/db66f570e024216f1ccc7fb13a23f84d175b1357e960f008c540609ed9ea29ce/angular/angular/issues/62333 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/db66f570e024216f1ccc7fb13a23f84d175b1357e960f008c540609ed9ea29ce/angular/angular/issues/62333 |
| og:image:alt | Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? No Description Problem Description The Angular Service Worker in v20.0.5 incorrectly handles fetch events... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Benny739 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width