René's URL Explorer Experiment


Title: Components that contain ViewChild need change detection after view init · Issue #5870 · angular/angular · GitHub

Open Graph Title: Components that contain ViewChild need change detection after view init · Issue #5870 · angular/angular

X Title: Components that contain ViewChild need change detection after view init · Issue #5870 · angular/angular

Description: The following example shows a Component that has a reference to a child directive using a ViewChild query. If the input changes and causes NgFor to create new components, those will execute all view bindings before the child directive is...

Open Graph Description: The following example shows a Component that has a reference to a child directive using a ViewChild query. If the input changes and causes NgFor to create new components, those will execute all vie...

X Description: The following example shows a Component that has a reference to a child directive using a ViewChild query. If the input changes and causes NgFor to create new components, those will execute all vie...

Opengraph URL: https://github.com/angular/angular/issues/5870

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Components that contain ViewChild need change detection after view init","articleBody":"The following example shows a Component that has a reference to a child directive using a `ViewChild` query. If the input changes and causes `NgFor` to create new components, those will execute all view bindings before the child directive is obtained in the component using the `ViewChild` annotation. After the view child is set and after the `ngAfterViewInit` lifecycle hook was called, there will be no additional change detection as the component thinks he's clean. However, if the component has a reference to a view child and this reference is used within the components view, the component should be dirty after the `ngAfterViewInit` lifecycle hook.\n\nThe following example should show all even numbers in blue and all odd numbers in red. Due to the change detection issue, after clicking the \"Cause Change\" button, there is an inconsistency between the view and the model.\n\nThe example can be used as follows to reproduce the issue:\n1. Click the \"Cause Change\" button to change the input array to the `NgFor` directive. `NgFor` will detect the third and fourth element to be new and creates them. The view bindings that access the child directive are execute before the ViewChild was initialized. The component stays checked, even if the ViewChild is referenced within the components view.\n2. Click the \"Cause Change\" button again, where no additional components get created (the list differ does its job), but the view bindings execute again and the issue is gone.\n\nhttp://plnkr.co/edit/zSiHmyzXcm6Yq1jHJgMn?p=preview\n\n``` javascript\nimport {Component, Directive, Input, ViewChild, NgFor} from 'angular2/angular2';\n\n@Directive({\n  selector: '[number]'\n})\nexport class NumberDirective {\n  @Input() number;\n\n  isEven() {\n    return this.number % 2 === 0;\n  }\n}\n\n@Component({\n  selector: 'number-component'\n  template: `\n    \u003cdiv [number]=\"number\" \n         [style.color]=\"getColor()\">{{number}}\u003c/div>\n  `,\n  directives: [NumberDirective]\n})\nexport class NumberComponent {\n  @ViewChild(NumberDirective) numberDirective;\n  @Input() number;\n\n  constructor() {\n    console.log('Constructed');\n  }\n\n  ngOnChange() {\n    console.log('on change', this.numberDirective);\n  }\n\n  ngAfterViewInit() {\n    console.log('after view init', this.numberDirective);\n  }\n\n  getColor() {\n    console.log('getColor', this.numberDirective);\n    return this.numberDirective && this.numberDirective.isEven() ? 'blue' : 'red';\n  }\n}\n\n@Component({\n  selector: 'app'\n  template: `\n    \u003cnumber-component *ngFor=\"#number of numbers\" \n            [number]=\"number\">\u003c/number-component>\n    \u003cbutton (click)=\"change()\">Cause Change\u003c/button>\n  `,\n  directives: [NumberComponent, NgFor]\n})\nexport class App {\n  numbers = [1, 2];\n\n  change() {\n    this.numbers = [1, 2, 3, 4];\n  }\n}\n```\n","author":{"url":"https://github.com/gionkunz","@type":"Person","name":"gionkunz"},"datePublished":"2015-12-13T18:51:45Z","url":"https://github.com/angular/angular/issues/5870"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:bc4b3387-9416-cf3c-9316-e580e8fb3ae8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB0DC:95C88:1A276F4:228B713:6B014797
html-safe-nonceb7c14f69132ebc23216b1ad4201692c4a1f9e555e41df61843f16298b8f353d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMERDOjk1Qzg4OjFBMjc2RjQ6MjI4QjcxMzo2QjAxNDc5NyIsInZpc2l0b3JfaWQiOiI3NDE3Njg5NDkwMTU3ODE1NzAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2cc824ea413bd8b1f38ae2e125e602e0828a6b9a96eba47f768f216d8dddf084
hovercard-subject-tagissue:121936404
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/5870/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d9c2afa6e3c3c2537b329a1aea3c1315bfe7b5f1889404adc15f64d7ab0a3811/angular/angular/issues/5870
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d9c2afa6e3c3c2537b329a1aea3c1315bfe7b5f1889404adc15f64d7ab0a3811/angular/angular/issues/5870
og:image:altThe following example shows a Component that has a reference to a child directive using a ViewChild query. If the input changes and causes NgFor to create new components, those will execute all vie...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegionkunz
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/5870#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F5870
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F5870
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/5870
Reloadhttps://github.com/angular/angular/issues/5870
Reloadhttps://github.com/angular/angular/issues/5870
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/5870
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/5870
Components that contain ViewChild need change detection after view inithttps://github.com/angular/angular/issues/5870#top
https://github.com/gionkunz
gionkunzhttps://github.com/gionkunz
on Dec 13, 2015https://github.com/angular/angular/issues/5870#issue-121936404
http://plnkr.co/edit/zSiHmyzXcm6Yq1jHJgMn?p=previewhttp://plnkr.co/edit/zSiHmyzXcm6Yq1jHJgMn?p=preview
https://github.com/ShiYuanjun-Tim
ShiYuanjun-Timhttps://github.com/ShiYuanjun-Tim
on Jun 1, 2016https://github.com/angular/angular/issues/5870#issuecomment-222912238
feat(router): Add directive for active route link,https://github.com/angular/angular/issues/5877
about why?https://angular.io/docs/ts/latest/guide/lifecycle-hooks.html#!#afterview
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on Jun 6, 2016https://github.com/angular/angular/issues/5870#issuecomment-223902112
@gionkunzhttps://github.com/gionkunz
https://github.com/gionkunz
gionkunzhttps://github.com/gionkunz
on Jun 10, 2016https://github.com/angular/angular/issues/5870#issuecomment-225137264
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
https://github.com/jimitndiaye
jimitndiayehttps://github.com/jimitndiaye
on Jul 11, 2016https://github.com/angular/angular/issues/5870#issuecomment-231730211
https://github.com/spali
spalihttps://github.com/spali
on Aug 5, 2016https://github.com/angular/angular/issues/5870#issuecomment-237826627
http://plnkr.co/edit/cSJPf400VQm168tzUEO6?p=previewhttp://plnkr.co/edit/cSJPf400VQm168tzUEO6?p=preview
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on Aug 5, 2016https://github.com/angular/angular/issues/5870#issuecomment-237898213
@spalihttps://github.com/spali
@jimitndiayehttps://github.com/jimitndiaye
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 5, 2016https://github.com/angular/angular/issues/5870#event-746865856
https://github.com/spali
spalihttps://github.com/spali
on Aug 5, 2016https://github.com/angular/angular/issues/5870#issuecomment-237919072
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
https://github.com/upuxaa
upuxaahttps://github.com/upuxaa
on May 20, 2017https://github.com/angular/angular/issues/5870#issuecomment-302846581
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 11, 2019https://github.com/angular/angular/issues/5870#issuecomment-530430660
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 11, 2019https://github.com/angular/angular/issues/5870#event-2626153437
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/5870
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/5870
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.