Title: Extended diagnostics do not run on structural directive attributes · Issue #57094 · angular/angular · GitHub
Open Graph Title: Extended diagnostics do not run on structural directive attributes · Issue #57094 · angular/angular
X Title: Extended diagnostics do not run on structural directive attributes · Issue #57094 · angular/angular
Description: This came up while I was working on #57033. The visitor that is meant to visit every expression in a template currently skips over the templateAttrs (see). This is incorrect, because the templateAttrs don't get copied over into the eleme...
Open Graph Description: This came up while I was working on #57033. The visitor that is meant to visit every expression in a template currently skips over the templateAttrs (see). This is incorrect, because the templateAt...
X Description: This came up while I was working on #57033. The visitor that is meant to visit every expression in a template currently skips over the templateAttrs (see). This is incorrect, because the templateAt...
Opengraph URL: https://github.com/angular/angular/issues/57094
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Extended diagnostics do not run on structural directive attributes","articleBody":"This came up while I was working on #57033. The visitor that is meant to visit every expression in a template currently skips over the `templateAttrs` ([see](https://github.com/angular/angular/blob/4ac39aeea988bd423795bac70d480620f49f2267/packages/compiler-cli/src/ngtsc/typecheck/extended/api/api.ts#L189)). This is incorrect, because the `templateAttrs` don't get copied over into the element node for something like `\u003cdiv *ngIf=\"expr\">\u003c/div>`. As a result, our current extended diagnostics haven't been checking the expressions of structural directives. In #57033 I tried fixing it, but there were a lot of failures even for the trial run so I expect a lot more for a global one. \r\n\r\nAs a workaround in #57033, I've added a flag that allows the problematic diagnostics to retain their old behavior, but eventually we should remove the `canVisitStructuralAttributes` flag and resolve the failures.","author":{"url":"https://github.com/crisbeto","@type":"Person","name":"crisbeto"},"datePublished":"2024-07-23T08:57:11Z","url":"https://github.com/angular/angular/issues/57094"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:997793e2-4bbf-4dc9-6756-f2a804ceb4b7 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ED94:785A9:C3B290:F9023B:6B00FD39 |
| html-safe-nonce | 1f0ab90a76c337c821abe243f87e7be7eb878e3569eb31c8396746de73c16945 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDk0Ojc4NUE5OkMzQjI5MDpGOTAyM0I6NkIwMEZEMzkiLCJ2aXNpdG9yX2lkIjoiNzk4OTA2NDc1NjM2OTYyMDI4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b8e10b9fed85b833659a57c573d241f14b426cd0318d4ba5a360acab95b84bd1 |
| hovercard-subject-tag | issue:2424647622 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/57094/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9a752a00bae6a7c64c360ee8faf41f58949c0014df11b4807e17aab3be2c6e61/angular/angular/issues/57094 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9a752a00bae6a7c64c360ee8faf41f58949c0014df11b4807e17aab3be2c6e61/angular/angular/issues/57094 |
| og:image:alt | This came up while I was working on #57033. The visitor that is meant to visit every expression in a template currently skips over the templateAttrs (see). This is incorrect, because the templateAt... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | crisbeto |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width