René's URL Explorer Experiment


Title: Creating a view inside an `effect` will track any signal reads that happen in the view · Issue #54548 · angular/angular · GitHub

Open Graph Title: Creating a view inside an `effect` will track any signal reads that happen in the view · Issue #54548 · angular/angular

X Title: Creating a view inside an `effect` will track any signal reads that happen in the view · Issue #54548 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? Don't known / other Is this a regression? No Description I have a PopoverDirective which contains an input that allows the developer to pass in a custom template. It works like this:...

Open Graph Description: Which @angular/* package(s) are the source of the bug? Don't known / other Is this a regression? No Description I have a PopoverDirective which contains an input that allows the developer to pass i...

X Description: Which @angular/* package(s) are the source of the bug? Don't known / other Is this a regression? No Description I have a PopoverDirective which contains an input that allows the developer to pa...

Opengraph URL: https://github.com/angular/angular/issues/54548

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Creating a view inside an `effect` will track any signal reads that happen in the view","articleBody":"### Which @angular/* package(s) are the source of the bug?\r\n\r\nDon't known / other\r\n\r\n### Is this a regression?\r\n\r\nNo\r\n\r\n### Description\r\n\r\nI have a `PopoverDirective` which contains an input that allows the developer to pass in a custom template. It works like this:\r\n```ts\r\n\u003cdiv\r\n  appPopover\r\n  [isPopoverVisible]=\"isPopoverVisible()\"\r\n  [popoverTemplate]=\"popoverTemplate\"\r\n>\r\n   Regular content here\r\n\u003c/div>\r\n\r\n\u003cng-template #popoverTemplate> Popover content here \u003c/ng-template>\r\n```\r\n\r\nInternally, this directive fill open or destroy the popover depending on the `isPopoverVisible` input:\r\n```ts\r\neffect(() => {\r\n  if (this.isPopoverVisible()) {\r\n    this.openPopover();\r\n  } else {\r\n    this.destroyPopover();\r\n  }\r\n});\r\n```\r\n\r\nThis works welll, but when adding signals into the `popoverTemplate` I notice that any effects contained inside the `appPopover` directive will fire again. Even if none of the directive's inputs have changed.\r\n\r\nFor example:\r\n\r\n```ts\r\n\u003cdiv\r\n  appPopover\r\n  [isPopoverVisible]=\"isPopoverVisible()\"\r\n  [popoverTemplate]=\"popoverTemplate\"\r\n>\r\n   Regular content here\r\n\u003c/div>\r\n\r\n\u003cng-template #popoverTemplate> {{ someSignal() }} \u003c/ng-template>\r\n```\r\n\r\nWhen `someSignal` changes, my effect inside the `appPopover` directive will now fire _again_, even though none of its inputs have changed (only the input of the template we pass in has changed).\r\n\r\nThis feels unintentional, I'd like to know if this is intended behaviour, or a bug in the framework.\r\n\r\n### Please provide a link to a minimal reproduction of the bug\r\n\r\nhttps://github.com/kfrancois/angular-effects-repro\r\n\r\nAlso available in Stackblitz: https://stackblitz.com/github/kfrancois/angular-effects-repro\r\n\r\n### Please provide the exception or error you saw\r\n\r\nUsing the above link, follow these steps:\r\n\r\n1. Open the console\r\n2. Click on the `Show popover` button\r\n3. Click on the `Do async logic to populate popover template` button\r\n4. Observe the console output\r\n\r\nOn the \"working\" example, `isPopoverVisible: true` does not log twice.\r\nOn the \"broken\" example, `isPopoverVisible: true` does log twice, which is unexpected.\r\n\r\n### Please provide the environment you discovered this bug in (run `ng version`)\r\n\r\n```true\r\nAngular CLI: 17.2.0\r\nNode: 21.6.1 (Unsupported)\r\nPackage Manager: npm 10.4.0\r\nOS: darwin arm64\r\n\r\nAngular: 17.2.1\r\n```\r\n\r\n\r\n### Anything else?\r\n\r\n_No response_","author":{"url":"https://github.com/kfrancois","@type":"Person","name":"kfrancois"},"datePublished":"2024-02-21T16:54:09Z","url":"https://github.com/angular/angular/issues/54548"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:816097c4-2bb0-6cba-e750-7724e4500509
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB83E:2A5566:1753529:1E9B1B7:6B01FEEC
html-safe-nonce9699f28e8c5a22b32857446ec8836eb2dc11ad4c69631abae679ca756087b6f3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODNFOjJBNTU2NjoxNzUzNTI5OjFFOUIxQjc6NkIwMUZFRUMiLCJ2aXNpdG9yX2lkIjoiMzI4MTAwNzE2NjUzNzk4OTg2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6c786dea6b707a19c5bf848d580051f97bc9de59c347ff247ddc314d9c6378e7
hovercard-subject-tagissue:2147239954
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/54548/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3bc4e6e589418902294e9bcaa60aa9469f1d02c8a4c6c32a5ee89dcf24d064a9/angular/angular/issues/54548
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3bc4e6e589418902294e9bcaa60aa9469f1d02c8a4c6c32a5ee89dcf24d064a9/angular/angular/issues/54548
og:image:altWhich @angular/* package(s) are the source of the bug? Don't known / other Is this a regression? No Description I have a PopoverDirective which contains an input that allows the developer to pass i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekfrancois
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/54548#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F54548
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F54548
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/54548
Reloadhttps://github.com/angular/angular/issues/54548
Reloadhttps://github.com/angular/angular/issues/54548
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/54548
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/54548
Creating a view inside an effect will track any signal reads that happen in the viewhttps://github.com/angular/angular/issues/54548#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: reactivityWork related to fine-grained reactivity in the core frameworkhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20reactivity%22
cross-cutting: signalshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cross-cutting%3A%20signals%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/kfrancois
kfrancoishttps://github.com/kfrancois
on Feb 21, 2024https://github.com/angular/angular/issues/54548#issue-2147239954
https://github.com/kfrancois/angular-effects-reprohttps://github.com/kfrancois/angular-effects-repro
https://stackblitz.com/github/kfrancois/angular-effects-reprohttps://stackblitz.com/github/kfrancois/angular-effects-repro
JeanMechehttps://github.com/JeanMeche
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: reactivityWork related to fine-grained reactivity in the core frameworkhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20reactivity%22
cross-cutting: signalshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cross-cutting%3A%20signals%22
on Feb 21, 2024https://github.com/angular/angular/issues/54548#event-11879906241
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Feb 21, 2024https://github.com/angular/angular/issues/54548#event-11879906587
https://github.com/atscott
atscotthttps://github.com/atscott
on Feb 21, 2024https://github.com/angular/angular/issues/54548#issuecomment-1957715665
https://stackblitz.com/edit/github-kphkvx?file=src%2Fmain.ts,src%2Fapp%2Fbroken-popover.component.ts,src%2Fapp%2Fpopover-directive.ts,src%2Fapp%2Fworking-popover.component.tshttps://stackblitz.com/edit/github-kphkvx?file=src%2Fmain.ts,src%2Fapp%2Fbroken-popover.component.ts,src%2Fapp%2Fpopover-directive.ts,src%2Fapp%2Fworking-popover.component.ts
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 21, 2024https://github.com/angular/angular/issues/54548#event-11880891788
alxhubhttps://github.com/alxhub
on Feb 21, 2024https://github.com/angular/angular/issues/54548#event-11881737833
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on Feb 21, 2024https://github.com/angular/angular/issues/54548#issuecomment-1957841038
atscotthttps://github.com/atscott
on Feb 21, 2024https://github.com/angular/angular/issues/54548#event-11882055584
https://github.com/kfrancois
kfrancoishttps://github.com/kfrancois
on Feb 21, 2024https://github.com/angular/angular/issues/54548#issuecomment-1958132903
https://github.com/kfrancois
kfrancoishttps://github.com/kfrancois
on Feb 21, 2024https://github.com/angular/angular/issues/54548#issuecomment-1958154417
https://github.com/mikezks
mikezkshttps://github.com/mikezks
on Feb 22, 2024https://github.com/angular/angular/issues/54548#issuecomment-1959601933
https://github.com/markostanimirovic
markostanimirovichttps://github.com/markostanimirovic
on Feb 23, 2024https://github.com/angular/angular/issues/54548#issuecomment-1961712985
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on Feb 29, 2024https://github.com/angular/angular/issues/54548#event-11964062234
fix(core): untrack various core operations (#54614)https://github.com/angular/angular/commit/ffbafc7d4a3c61226cb5c524b3ff42ed4f9f1d76
#54614https://github.com/angular/angular/pull/54614
https://docs.github.com/articles/closing-issues-via-commit-messages
ffbafc7https://github.com/angular/angular/commit/ffbafc7d4a3c61226cb5c524b3ff42ed4f9f1d76
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
ffad7b8https://github.com/angular/angular/commit/ffad7b8ea9d1286ddb3ee7a2dac7dd33fd76b3aa
on Feb 29, 2024https://github.com/angular/angular/issues/54548#event-11964063031
angular-robothttps://github.com/angular-robot
on Feb 29, 2024https://github.com/angular/angular/issues/54548#event-11964351496
fix(core): untrack various core operations (angular#54614)https://github.com/angular-robot/angular/commit/ffad7b8ea9d1286ddb3ee7a2dac7dd33fd76b3aa
angular#54614https://github.com/angular/angular/pull/54614
https://docs.github.com/articles/closing-issues-via-commit-messages
ffad7b8https://github.com/angular-robot/angular/commit/ffad7b8ea9d1286ddb3ee7a2dac7dd33fd76b3aa
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 31, 2024https://github.com/angular/angular/issues/54548#issuecomment-2028504244
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 31, 2024https://github.com/angular/angular/issues/54548#event-12302003866
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/54548
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/54548
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: reactivityWork related to fine-grained reactivity in the core frameworkhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20reactivity%22
cross-cutting: signalshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cross-cutting%3A%20signals%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.