René's URL Explorer Experiment


Title: Radio CVA has wrong behavior with callSetDisabledState = 'whenDisabledForLegacyCode' · Issue #53240 · angular/angular · GitHub

Open Graph Title: Radio CVA has wrong behavior with callSetDisabledState = 'whenDisabledForLegacyCode' · Issue #53240 · angular/angular

X Title: Radio CVA has wrong behavior with callSetDisabledState = 'whenDisabledForLegacyCode' · Issue #53240 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description Angular v15 fixed a long-standing bug related to setDisabledState not always being called. The fix was a breaking change, so a configuratio...

Open Graph Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description Angular v15 fixed a long-standing bug related to setDisabledState not always being called. The fix ...

X Description: Which @angular/* package(s) are the source of the bug? forms Is this a regression? No Description Angular v15 fixed a long-standing bug related to setDisabledState not always being called. The fix ...

Opengraph URL: https://github.com/angular/angular/issues/53240

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Radio CVA has wrong behavior with callSetDisabledState = 'whenDisabledForLegacyCode'","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nforms\n\n### Is this a regression?\n\nNo\n\n### Description\n\nAngular v15 fixed a [long-standing bug](https://github.com/angular/angular/issues/35309) related to `setDisabledState` not always being called. The fix was a breaking change, so a configuration option, `callSetDisabledState`, was also introduced to provide a way to opt into the old, \"legacy\" behavior. The bug fix also caused a problem for radio buttons that was [subsequently fixed](https://github.com/angular/angular/pull/48864/) by making the radio CVA default to using the \"legacy\" behavior. However, if you use the configuration option to opt into the legacy behavior (i.e. `callSetDisabledState = 'whenDisabledForLegacyMode'`), the radio CVA **uses the non-legacy behavior**. Here is a visual matrix of the scenarios:\r\n![image](https://github.com/angular/angular/assets/7282195/34dbc0db-c823-4a34-b0b5-7437a752070e)\r\nThis does not make sense. There is no reason that using `'whenDisabledForLegacyMode'` should make the radio CVA use a non-legacy, problematic behavior.\r\n\r\n[The code](https://github.com/angular/angular/blob/b76b3c619bc2ff9ffdd436559a7550398a810b10/packages/forms/src/directives/radio_control_value_accessor.ts#L223) is straightforward. It should just not include `|| callSetDisabledState === 'whenDisabledForLegacyMode'` in the condition.\n\n### Please provide a link to a minimal reproduction of the bug\n\n_No response_\n\n### Please provide the exception or error you saw\n\n_No response_\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n_No response_\n\n### Anything else?\n\n_No response_","author":{"url":"https://github.com/m-akinc","@type":"Person","name":"m-akinc"},"datePublished":"2023-11-28T23:34:01Z","url":"https://github.com/angular/angular/issues/53240"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5b7cf4a4-653c-a812-245a-f038355bbb88
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB186:27D3AD:1F28AD0:27846D5:6B0165C5
html-safe-nonceb53e8aba0f7304f0edd070c29ab7dadc33f16586db141d2e5ba4a22b2dd168fb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTg2OjI3RDNBRDoxRjI4QUQwOjI3ODQ2RDU6NkIwMTY1QzUiLCJ2aXNpdG9yX2lkIjoiNjY4MDk5NzEwNTkwNzA5OTA3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf4b4862256b23405270116d5803ce7260b2a6ab54db2e706db880aa9282d88b4
hovercard-subject-tagissue:2015499182
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/53240/issue_layout
twitter:imagehttps://opengraph.githubassets.com/80b5201537237c111d217aa6974814ae7a15ca1617b328906853137f531f95b8/angular/angular/issues/53240
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/80b5201537237c111d217aa6974814ae7a15ca1617b328906853137f531f95b8/angular/angular/issues/53240
og:image:altWhich @angular/* package(s) are the source of the bug? forms Is this a regression? No Description Angular v15 fixed a long-standing bug related to setDisabledState not always being called. The fix ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamem-akinc
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/53240#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F53240
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F53240
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/53240
Reloadhttps://github.com/angular/angular/issues/53240
Reloadhttps://github.com/angular/angular/issues/53240
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/53240
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/53240
Radio CVA has wrong behavior with callSetDisabledState = 'whenDisabledForLegacyCode'https://github.com/angular/angular/issues/53240#top
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/m-akinc
m-akinchttps://github.com/m-akinc
on Nov 28, 2023https://github.com/angular/angular/issues/53240#issue-2015499182
long-standing bughttps://github.com/angular/angular/issues/35309
subsequently fixedhttps://github.com/angular/angular/pull/48864/
https://private-user-images.githubusercontent.com/7282195/286428439-34dbc0db-c823-4a34-b0b5-7437a752070e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUyNTQwMDIsIm5iZiI6MTc5NTI1MzcwMiwicGF0aCI6Ii83MjgyMTk1LzI4NjQyODQzOS0zNGRiYzBkYi1jODIzLTRhMzQtYjBiNS03NDM3YTc1MjA3MGUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MTEyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjExMjFUMDkzNTAyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTQzNTgzZjJhM2M1MmZiZDRhZDMzODFkMjEyY2ExZjgwYjU1Yjc5MzRhMzg1N2FjZDEyZWQwZjg2MDQ0YTY3ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.qz1SjjxGsF9Xp2cowp9zKfDy0vTxF7hh95EQ-eRjwYY
The codehttps://github.com/angular/angular/blob/b76b3c619bc2ff9ffdd436559a7550398a810b10/packages/forms/src/directives/radio_control_value_accessor.ts#L223
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
on Nov 29, 2023https://github.com/angular/angular/issues/53240#event-11093862642
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Nov 29, 2023https://github.com/angular/angular/issues/53240#event-11093862982
https://github.com/Achilles1515
Achilles1515https://github.com/Achilles1515
on Jan 18, 2024https://github.com/angular/angular/issues/53240#issuecomment-1898562266
@dylhunnhttps://github.com/dylhunn
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
JeanMechehttps://github.com/JeanMeche
on Oct 17, 2025https://github.com/angular/angular/issues/53240#event-20333012779
https://github.com/arturovt
arturovthttps://github.com/arturovt
on Sep 29, 2026https://github.com/angular/angular/issues/53240#issuecomment-5896993630
@JeanMechehttps://github.com/JeanMeche
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
on Oct 29, 2026https://github.com/angular/angular/issues/53240#issuecomment-6510500225
JeanMechehttps://github.com/JeanMeche
not plannedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Oct 29, 2026https://github.com/angular/angular/issues/53240#event-34640724702
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/53240
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/53240
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.