René's URL Explorer Experiment


Title: Unit tests confirm that css generated with attribute selector on host is incorrect as of a16 · Issue #51743 · angular/angular · GitHub

Open Graph Title: Unit tests confirm that css generated with attribute selector on host is incorrect as of a16 · Issue #51743 · angular/angular

X Title: Unit tests confirm that css generated with attribute selector on host is incorrect as of a16 · Issue #51743 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? compiler Is this a regression? Yes Description Below is the css and unit test i wrote to confirm it's generated incorrectly. original css :host[size=full]>espresso-modal-container>es...

Open Graph Description: Which @angular/* package(s) are the source of the bug? compiler Is this a regression? Yes Description Below is the css and unit test i wrote to confirm it's generated incorrectly. original css :hos...

X Description: Which @angular/* package(s) are the source of the bug? compiler Is this a regression? Yes Description Below is the css and unit test i wrote to confirm it's generated incorrectly. original css ...

Opengraph URL: https://github.com/angular/angular/issues/51743

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unit tests confirm that css generated with attribute selector on host is incorrect as of a16","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\ncompiler\n\n### Is this a regression?\n\nYes\n\n### Description\n\nBelow is the css and unit test i wrote to confirm it's generated incorrectly.\r\n\r\n**original css**\r\n\r\n:host[size=full]>espresso-modal-container>espresso-modal-content-container {\r\n  min-width: 100vw;\r\n  max-width: 100vw;\r\n  width: 100vw;\r\n  min-height: 100%;\r\n  max-height: 100%;\r\n  height: 100%\r\n}\r\n\r\n**expected css**\r\n\r\n[size=full][HOSTA]>espresso-modal-container[CONTENTA]>espresso-modal-content-container[CONTENTA] {\r\n  min-width: 100vw;\r\n  max-width: 100vw;\r\n  width: 100vw;\r\n  min-height: 100%;\r\n  max-height: 100%;\r\n  height: 100%\r\n}\r\n\r\n**actual css**\r\n\r\n[size=full]>espresso-modal-container>espresso-modal-content-container[HOSTA] {\r\n  min-width: 100vw;\r\n  max-width: 100vw;\r\n  width: 100vw;\r\n  min-height: 100%;\r\n  max-height: 100%;\r\n  height: 100%\r\n}\r\n\r\n**angular unit test i added to shadow_css_spec.ts**\r\n\r\ndescribe('ShadowCss', () => {\r\n  it('should handle attribute before host', () => {\r\n    const css = ':host[size=full]>espresso-modal-container>espresso-modal-content-container{min-width:100vw;max-width:100vw;width:100vw;min-height:100%;max-height:100%;height:100%}';\r\n    const expected = '[size=full][HOSTA]>espresso-modal-container[CONTENTA]>espresso-modal-content-container[CONTENTA]{min-width:100vw;max-width:100vw;width:100vw;min-height:100%;max-height:100%;height:100%}';\r\n    expect(shim(css, 'CONTENTA', 'HOSTA')).toEqualCss(expected);\r\n  });\r\n\r\n\n\n### Please provide a link to a minimal reproduction of the bug\n\nall is in above details\n\n### Please provide the exception or error you saw\n\n```true\nincorrect css generated as shown and reproduced via the unit test above\n```\n\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n```true\nAngular CLI: 16.1.15\r\nNode: 18.13.0\r\nPackage Manager: yarn 1.22.19\r\nOS: darwin x64\n```\n\n\n### Anything else?\n\nconfirmed this works as expected in 14, not sure about 15","author":{"url":"https://github.com/johnwest80","@type":"Person","name":"johnwest80"},"datePublished":"2023-09-12T16:09:04Z","url":"https://github.com/angular/angular/issues/51743"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2e894c82-a410-c923-f135-b555b1fd2ddc
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC3FE:19E4BB:6E49BF:8EB1B7:6B00E2FF
html-safe-nonced51f2022c645dcd3f190b14bfeff762e95a2cb20bbae1cd68ad8e9bdef7bbe8d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0ZFOjE5RTRCQjo2RTQ5QkY6OEVCMUI3OjZCMDBFMkZGIiwidmlzaXRvcl9pZCI6IjE3MTkzNDM2MjczNDk1ODI1OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac166ca5ce87782b2447417503f224978cca8b9ddf89c9633e343776e6e966792d
hovercard-subject-tagissue:1892836358
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/51743/issue_layout
twitter:imagehttps://opengraph.githubassets.com/cecda05a9a7b0b9d2b974e4d054269ab94276bc0b6e56c8765f8e3602e6e446b/angular/angular/issues/51743
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cecda05a9a7b0b9d2b974e4d054269ab94276bc0b6e56c8765f8e3602e6e446b/angular/angular/issues/51743
og:image:altWhich @angular/* package(s) are the source of the bug? compiler Is this a regression? Yes Description Below is the css and unit test i wrote to confirm it's generated incorrectly. original css :hos...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejohnwest80
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/51743#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F51743
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F51743
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/51743
Reloadhttps://github.com/angular/angular/issues/51743
Reloadhttps://github.com/angular/angular/issues/51743
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/51743
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/51743
Unit tests confirm that css generated with attribute selector on host is incorrect as of a16https://github.com/angular/angular/issues/51743#top
https://github.com/johnwest80
johnwest80https://github.com/johnwest80
on Sep 12, 2023https://github.com/angular/angular/issues/51743#issue-1892836358
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
on Sep 12, 2023https://github.com/angular/angular/issues/51743#issuecomment-1716024423
#49118https://github.com/angular/angular/pull/49118
#49100https://github.com/angular/angular/issues/49100
JeanMechehttps://github.com/JeanMeche
not plannedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Sep 12, 2023https://github.com/angular/angular/issues/51743#event-10348935604
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 13, 2023https://github.com/angular/angular/issues/51743#issuecomment-1760561597
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 13, 2023https://github.com/angular/angular/issues/51743#event-10638203898
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/51743
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/51743
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.