René's URL Explorer Experiment


Title: Unhandled rejections events not emitted when using DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION · Issue #51357 · angular/angular · GitHub

Open Graph Title: Unhandled rejections events not emitted when using DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION · Issue #51357 · angular/angular

X Title: Unhandled rejections events not emitted when using DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION · Issue #51357 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? No Description Setting DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION to true will cause unhandled rejections events to not be emitted because of an except...

Open Graph Description: Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? No Description Setting DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION to true will cause unhandled rejections event...

X Description: Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? No Description Setting DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION to true will cause unhandled rejections event...

Opengraph URL: https://github.com/angular/angular/issues/51357

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unhandled rejections events not emitted when using DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nzone.js\n\n### Is this a regression?\n\nNo\n\n### Description\n\nSetting `DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION` to true will cause unhandled rejections events to not be emitted because of an exception inside the code that sends the events.\r\n\r\n```javascript\r\n__zone_symbol__DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION = true;\r\n// load zone.js\r\nonunhandledrejection = console.dir;\r\nPromise.reject(new Error(\"forced error\"));\r\n```\r\n\r\nThe above code doesn't call the unhandled rejection handler. Zone.js triggers an internal exception while trying to emit the event and this event is caught and silently ignored.\r\nthrown from: https://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/browser/browser.ts#L280\r\nCaught and ignore at: https://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/common/promise.ts#L71\r\n\r\nException thrown\r\n```\r\nTypeError: Failed to construct 'PromiseRejectionEvent': Failed to read the 'promise' property from 'PromiseRejectionEventInit': Required member is undefined.\r\n```\r\n\r\nThe issue is that with `DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION` enabled causes the error send to the handler that emits events to be the original error and not the wrapper error. Only the wrapper error has promise and rejection properties that the handler was using to construct the rejection event.\r\nhttps://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/common/promise.ts#L52-L69\r\n\r\n The issue doesn't happen for the promise rejection handled handler since it gets both the promise and the rejection.\r\nhttps://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/common/promise.ts#L236\r\n\n\n### Please provide a link to a minimal reproduction of the bug\n\n_No response_\n\n### Please provide the exception or error you saw\n\n_No response_\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n_No response_\n\n### Anything else?\n\n_No response_","author":{"url":"https://github.com/ioancris","@type":"Person","name":"ioancris"},"datePublished":"2023-08-14T19:35:02Z","url":"https://github.com/angular/angular/issues/51357"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e275a6c7-19f2-7860-6589-1516ede36586
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC6BC:1C94F:28194E3:3367A30:6B01E5B3
html-safe-noncec8bf1ef7f0825c8634bb8dc3e2dc8e92e211f92f6a5d17c4aeaf3ed95dac1e20
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkJDOjFDOTRGOjI4MTk0RTM6MzM2N0EzMDo2QjAxRTVCMyIsInZpc2l0b3JfaWQiOiIyNTYzODAzODU3ODE3ODIyNjQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc93314d026a4ad6a13759669bc7b4ca8d5deed160474d342caaf6c9f7c49fe9b
hovercard-subject-tagissue:1850416000
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/51357/issue_layout
twitter:imagehttps://opengraph.githubassets.com/40dd905c42feda33d1a5d0637005a17a0302e4968abc08cd85b29a46590f8cfd/angular/angular/issues/51357
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/40dd905c42feda33d1a5d0637005a17a0302e4968abc08cd85b29a46590f8cfd/angular/angular/issues/51357
og:image:altWhich @angular/* package(s) are the source of the bug? zone.js Is this a regression? No Description Setting DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION to true will cause unhandled rejections event...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameioancris
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/51357#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F51357
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F51357
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/51357
Reloadhttps://github.com/angular/angular/issues/51357
Reloadhttps://github.com/angular/angular/issues/51357
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/51357
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/51357
Unhandled rejections events not emitted when using DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTIONhttps://github.com/angular/angular/issues/51357#top
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/ioancris
ioancrishttps://github.com/ioancris
on Aug 14, 2023https://github.com/angular/angular/issues/51357#issue-1850416000
angular/packages/zone.js/lib/browser/browser.tshttps://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/browser/browser.ts#L280
f7cfc3bhttps://github.com/angular/angular/commit/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf
angular/packages/zone.js/lib/common/promise.tshttps://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/common/promise.ts#L71
f7cfc3bhttps://github.com/angular/angular/commit/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf
angular/packages/zone.js/lib/common/promise.tshttps://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/common/promise.ts#L52-L69
f7cfc3bhttps://github.com/angular/angular/commit/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf
angular/packages/zone.js/lib/common/promise.tshttps://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/common/promise.ts#L236
f7cfc3bhttps://github.com/angular/angular/commit/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf
JoostKhttps://github.com/JoostK
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
on Aug 14, 2023https://github.com/angular/angular/issues/51357#event-10091372420
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Aug 14, 2023https://github.com/angular/angular/issues/51357#event-10091373596
https://github.com/matthewjh
matthewjhhttps://github.com/matthewjh
on Dec 19, 2024https://github.com/angular/angular/issues/51357#issuecomment-2555564572
#52492https://github.com/angular/angular/pull/52492
@JiaLiPassionhttps://github.com/JiaLiPassion
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/51357
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/51357
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.