Title: Unhandled rejections events not emitted when using DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION · Issue #51357 · angular/angular · GitHub
Open Graph Title: Unhandled rejections events not emitted when using DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION · Issue #51357 · angular/angular
X Title: Unhandled rejections events not emitted when using DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION · Issue #51357 · angular/angular
Description: Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? No Description Setting DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION to true will cause unhandled rejections events to not be emitted because of an except...
Open Graph Description: Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? No Description Setting DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION to true will cause unhandled rejections event...
X Description: Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? No Description Setting DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION to true will cause unhandled rejections event...
Opengraph URL: https://github.com/angular/angular/issues/51357
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unhandled rejections events not emitted when using DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nzone.js\n\n### Is this a regression?\n\nNo\n\n### Description\n\nSetting `DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION` to true will cause unhandled rejections events to not be emitted because of an exception inside the code that sends the events.\r\n\r\n```javascript\r\n__zone_symbol__DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION = true;\r\n// load zone.js\r\nonunhandledrejection = console.dir;\r\nPromise.reject(new Error(\"forced error\"));\r\n```\r\n\r\nThe above code doesn't call the unhandled rejection handler. Zone.js triggers an internal exception while trying to emit the event and this event is caught and silently ignored.\r\nthrown from: https://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/browser/browser.ts#L280\r\nCaught and ignore at: https://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/common/promise.ts#L71\r\n\r\nException thrown\r\n```\r\nTypeError: Failed to construct 'PromiseRejectionEvent': Failed to read the 'promise' property from 'PromiseRejectionEventInit': Required member is undefined.\r\n```\r\n\r\nThe issue is that with `DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION` enabled causes the error send to the handler that emits events to be the original error and not the wrapper error. Only the wrapper error has promise and rejection properties that the handler was using to construct the rejection event.\r\nhttps://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/common/promise.ts#L52-L69\r\n\r\n The issue doesn't happen for the promise rejection handled handler since it gets both the promise and the rejection.\r\nhttps://github.com/angular/angular/blob/f7cfc3b8fa2c2b2ef0bc2d4086edce70a17944bf/packages/zone.js/lib/common/promise.ts#L236\r\n\n\n### Please provide a link to a minimal reproduction of the bug\n\n_No response_\n\n### Please provide the exception or error you saw\n\n_No response_\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n_No response_\n\n### Anything else?\n\n_No response_","author":{"url":"https://github.com/ioancris","@type":"Person","name":"ioancris"},"datePublished":"2023-08-14T19:35:02Z","url":"https://github.com/angular/angular/issues/51357"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e275a6c7-19f2-7860-6589-1516ede36586 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C6BC:1C94F:28194E3:3367A30:6B01E5B3 |
| html-safe-nonce | c8bf1ef7f0825c8634bb8dc3e2dc8e92e211f92f6a5d17c4aeaf3ed95dac1e20 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkJDOjFDOTRGOjI4MTk0RTM6MzM2N0EzMDo2QjAxRTVCMyIsInZpc2l0b3JfaWQiOiIyNTYzODAzODU3ODE3ODIyNjQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c93314d026a4ad6a13759669bc7b4ca8d5deed160474d342caaf6c9f7c49fe9b |
| hovercard-subject-tag | issue:1850416000 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/51357/issue_layout |
| twitter:image | https://opengraph.githubassets.com/40dd905c42feda33d1a5d0637005a17a0302e4968abc08cd85b29a46590f8cfd/angular/angular/issues/51357 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/40dd905c42feda33d1a5d0637005a17a0302e4968abc08cd85b29a46590f8cfd/angular/angular/issues/51357 |
| og:image:alt | Which @angular/* package(s) are the source of the bug? zone.js Is this a regression? No Description Setting DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION to true will cause unhandled rejections event... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ioancris |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width