Title: Angular PWA and offline server · Issue #51337 · angular/angular · GitHub
Open Graph Title: Angular PWA and offline server · Issue #51337 · angular/angular
X Title: Angular PWA and offline server · Issue #51337 · angular/angular
Description: Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? Yes Description I utilize the PWA functionality to enable offline capabilities for my application. This involves executing the command ng add @an...
Open Graph Description: Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? Yes Description I utilize the PWA functionality to enable offline capabilities for my application. This i...
X Description: Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? Yes Description I utilize the PWA functionality to enable offline capabilities for my application. This i...
Opengraph URL: https://github.com/angular/angular/issues/51337
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Angular PWA and offline server","articleBody":"### Which @angular/* package(s) are the source of the bug?\r\n\r\nservice-worker\r\n\r\n### Is this a regression?\r\n\r\nYes\r\n\r\n### Description\r\n\r\nI utilize the PWA functionality to enable offline capabilities for my application. This involves executing the command ng add @angular/pwa. Initially, everything functions as intended. However, upon testing a scenario where the server experiences an outage or is offline, I observed that the cache storage is being cleared and the service worker is removed.\r\n\r\nIt's worth noting that there are no problems when the client is in an offline state. After investigating the ngsw-worker.js file, I identified a specific code segment responsible for triggering this cache clearance. The code is within the fetchLatestManifest function:\r\n\r\n```\r\nasync fetchLatestManifest(ignoreOfflineError = false) {\r\n const res = await this.safeFetch(this.adapter.newRequest(\"ngsw.json?ngsw-cache-bust=\" + Math.random()));\r\n if (!res.ok) {\r\n if (res.status === 404) {\r\n await this.deleteAllCaches();\r\n await this.scope.registration.unregister();\r\n } else if ((res.status === 503 || res.status === 504) && ignoreOfflineError) {\r\n return null;\r\n }\r\n throw new Error(`Manifest fetch failed! (status: ${res.status})`);\r\n }\r\n this.lastUpdateCheck = this.adapter.time;\r\n return res.json();\r\n}\r\n```\r\n\r\nThis behavior seems counterintuitive, as cache deletion shouldn't occur when the server is offline. Ideally, the service worker should cache the ngsw.json and rely on it, rather than deleting caches when the server experiences downtime. I'm seeking advice on potential solutions to this issue. Should I modify the code to resolve this problem? If so, what changes are recommended to ensure caches are retained even when the server is offline?\r\n\r\n\r\n### Please provide a link to a minimal reproduction of the bug\r\n\r\n_No response_\r\n\r\n### Please provide the exception or error you saw\r\n\r\n_No response_\r\n\r\n### Please provide the environment you discovered this bug in (run `ng version`)\r\n\r\n_No response_\r\n\r\n### Anything else?\r\n\r\n_No response_","author":{"url":"https://github.com/MutazNawas","@type":"Person","name":"MutazNawas"},"datePublished":"2023-08-11T21:55:45Z","url":"https://github.com/angular/angular/issues/51337"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e9af4503-40c7-82b6-ce48-3bc283e99664 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DCEC:2564D8:FAA537:14BE12A:6B0107FD |
| html-safe-nonce | 97a9a975141a9d44e98aaeef90903107ab4113d892d77ebaa69bb516e66f1c85 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0VDOjI1NjREODpGQUE1Mzc6MTRCRTEyQTo2QjAxMDdGRCIsInZpc2l0b3JfaWQiOiI1MzQwNzQ2MjgxOTQ4MDg4MzE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0f12a772898f87f9fcd01185b35e0d160785c21dbdf8a00bf5eee056ba55b3af |
| hovercard-subject-tag | issue:1847472488 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/51337/issue_layout |
| twitter:image | https://opengraph.githubassets.com/46baab9e16ae28f7c969c155d71e6675ddabbdfd3e9c5852e45294fae009f587/angular/angular/issues/51337 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/46baab9e16ae28f7c969c155d71e6675ddabbdfd3e9c5852e45294fae009f587/angular/angular/issues/51337 |
| og:image:alt | Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? Yes Description I utilize the PWA functionality to enable offline capabilities for my application. This i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MutazNawas |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width