Title: [docs] Reactive form gatcha · Issue #49898 · angular/angular · GitHub
Open Graph Title: [docs] Reactive form gatcha · Issue #49898 · angular/angular
X Title: [docs] Reactive form gatcha · Issue #49898 · angular/angular
Description: Describe the problem that you experienced I am often writing complexe reactive forms. And sometimes on valuechanges of one of the fields I need to recompute some value to show in my gui. And it often felt random that, sometime, one the c...
Open Graph Description: Describe the problem that you experienced I am often writing complexe reactive forms. And sometimes on valuechanges of one of the fields I need to recompute some value to show in my gui. And it oft...
X Description: Describe the problem that you experienced I am often writing complexe reactive forms. And sometimes on valuechanges of one of the fields I need to recompute some value to show in my gui. And it oft...
Opengraph URL: https://github.com/angular/angular/issues/49898
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[docs] Reactive form gatcha","articleBody":"### Describe the problem that you experienced\n\nI am often writing complexe reactive forms.\r\nAnd sometimes on valuechanges of one of the fields I need to recompute some value to show in my gui.\r\nAnd it often felt random that, sometime, one the callback of the value changes, I get the old value, and other times the new value. Today I decided to better understand this and document it somewhere for others.\r\n\r\nAfter reading and playing with the code I think I finally get it.\r\n\r\nIf you try to access the value of a control through its parent, you always get the old value, since it isn't updated yet.\r\n\r\nhere is a common use case.\r\non change of field1 or field2 you want to automatically change field 3.\r\n\r\n```typescript\r\n this.editForm.controls.items.valueChanges.pipe(takeUntil(this.onDestroySubject)).subscribe(items => {\r\n this.updateTotals();\r\n });\r\n\r\n this.editForm.controls.discount.valueChanges.pipe(takeUntil(this.onDestroySubject)).subscribe(discount => {\r\n this.updateTotals();\r\n });\r\n \r\n protected updateTotals(): void {\r\n const items = this.editForm.value.items;\r\n const discount = this.editForm.value.discount ?? 0;\r\n const total = items.map(si => si.price).reduce((x, y) => x + y, 0) * (1 - discount);\r\n this.editForm.patchValue({\r\n total,\r\n });\r\n }\r\n```\r\nThis doesn't work, since the parent isn't yet updated when the call back is called. instead you should write you code like this:\r\n\r\n```typescript\r\n protected updateTotals(): void {\r\n const items = this.editForm.controls.items.value;\r\n const discount = this.editForm.controls.discount.value ?? 0;\r\n const total = items.map(si => si.price).reduce((x, y) => x + y, 0) * (1 - discount);\r\n this.editForm.patchValue({\r\n total,\r\n });\r\n }\r\n```\r\n\r\n\r\n\n\n### Enter the URL of the topic with the problem\n\nhttps://angular.io/guide/reactive-forms\n\n### Describe what you were looking for in the documentation\n\nI don't know where exactly stuff like this should be on the docs, or maybe there is another place to write this kind of stuff. \n\n### Describe the actions that led you to experience the problem\n\n_No response_\n\n### Describe what you want to experience that would fix the problem\n\n_No response_\n\n### Add a screenshot if that helps illustrate the problem\n\n_No response_\n\n### If this problem caused an exception or error, please paste it here\n\n_No response_\n\n### If the problem is browser-specific, please specify the device, OS, browser, and version\n\n_No response_\n\n### Provide any additional information here in as much as detail as you can\n\n_No response_","author":{"url":"https://github.com/yelhouti","@type":"Person","name":"yelhouti"},"datePublished":"2023-04-18T06:10:55Z","url":"https://github.com/angular/angular/issues/49898"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6b126e3e-c76e-befb-3c0a-445f3870086c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EA9C:3DD488:17EF0B9:1E5D752:6B0140BF |
| html-safe-nonce | 7c158878d60ead1981704ef9b5954b6a4badad9aac5fa9554963aaa9cbbe12dc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTlDOjNERDQ4ODoxN0VGMEI5OjFFNUQ3NTI6NkIwMTQwQkYiLCJ2aXNpdG9yX2lkIjoiMzE2NzE4MDI2ODIyMjEwMzc0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a1f0b3969adab54b7444b0bff14daa102fb6d81d9058a7a0c934845d42141238 |
| hovercard-subject-tag | issue:1672418771 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/49898/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6724c946c83cc08431457830b38fc6259a373c27f5358fbe15e0b959fd7cb671/angular/angular/issues/49898 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6724c946c83cc08431457830b38fc6259a373c27f5358fbe15e0b959fd7cb671/angular/angular/issues/49898 |
| og:image:alt | Describe the problem that you experienced I am often writing complexe reactive forms. And sometimes on valuechanges of one of the fields I need to recompute some value to show in my gui. And it oft... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | yelhouti |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width