René's URL Explorer Experiment


Title: SwUpdate checkForUpdate can run multiple times simultaneously · Issue #49618 · angular/angular · GitHub

Open Graph Title: SwUpdate checkForUpdate can run multiple times simultaneously · Issue #49618 · angular/angular

X Title: SwUpdate checkForUpdate can run multiple times simultaneously · Issue #49618 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? No Description If you call SwUpdate.checkForUpdate multiple times from application code, it is not deduplicated. Each call will do the full manif...

Open Graph Description: Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? No Description If you call SwUpdate.checkForUpdate multiple times from application code, it is not dedupl...

X Description: Which @angular/* package(s) are the source of the bug? service-worker Is this a regression? No Description If you call SwUpdate.checkForUpdate multiple times from application code, it is not dedupl...

Opengraph URL: https://github.com/angular/angular/issues/49618

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SwUpdate checkForUpdate can run multiple times simultaneously","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nservice-worker\n\n### Is this a regression?\n\nNo\n\n### Description\n\nIf you call `SwUpdate.checkForUpdate` multiple times from application code, it is not deduplicated. Each call will do the full manifest fetch, and will attempt to install a new version if applicable, downloading all the assets multiple times. The assets themselves should mostly be cached by the browser, so there aren't excessive actual requests, but it does potentially slow down the SW thread with what should be completely unnecessary processing.\r\n\r\n\u003cimg width=\"1512\" alt=\"image\" src=\"https://user-images.githubusercontent.com/8922125/228405071-96f5f7ee-35e4-4c37-98b8-9478e4467c1c.png\">\r\n\r\nThis is relevant for our application, as we run a regular background upgrade check on a timer. If a user has many tabs open, we can end up calling `checkForUpdate` multiple times. Ideally, these multiple calls do not actually trigger multiple downloads and updates.\r\n\r\nnote: the builtin `checkForUpdate` calls are all wrapped in the idle scheduler, so they do not have this issue. or, they kind of do, but it doesn't matter as much because they'll run in sequence and the later calls will just fetch the manifest once and do nothing.\r\n\r\nIf this functionality isn't desired, I should be able to make a PR to fix it.\n\n### Please provide a link to a minimal reproduction of the bug\n\n_No response_\n\n### Please provide the exception or error you saw\n\n_No response_\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n```true\n_                      _                 ____ _     ___\r\n    / \\   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|\r\n   / △ \\ | '_ \\ / _` | | | | |/ _` | '__|   | |   | |    | |\r\n  / ___ \\| | | | (_| | |_| | | (_| | |      | |___| |___ | |\r\n /_/   \\_\\_| |_|\\__, |\\__,_|_|\\__,_|_|       \\____|_____|___|\r\n                |___/\r\n    \r\nAngular CLI: 14.2.10\r\nNode: 16.14.2\r\nPackage Manager: yarn 1.22.15 \r\nOS: darwin arm64\r\n\r\nAngular: 14.2.12\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, localize, platform-browser\r\n... platform-browser-dynamic, platform-server, router\r\n... service-worker\r\n\r\nPackage                         Version\r\n---------------------------------------------------------\r\n@angular-devkit/architect       0.1402.10\r\n@angular-devkit/build-angular   14.2.10\r\n@angular-devkit/core            14.2.10\r\n@angular-devkit/schematics      14.2.10\r\n@angular/cdk                    14.2.5\r\n@angular/cli                    14.2.10\r\n@angular/fire                   7.4.1\r\n@angular/material               14.2.5\r\n@nguniversal/builders           14.2.3\r\n@nguniversal/express-engine     14.0.3\r\n@schematics/angular             14.2.10\r\nrxjs                            7.5.7\r\ntypescript                      4.8.4\n```\n\n\n### Anything else?\n\n_No response_","author":{"url":"https://github.com/henry-alakazhang","@type":"Person","name":"henry-alakazhang"},"datePublished":"2023-03-29T02:01:13Z","url":"https://github.com/angular/angular/issues/49618"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c39c097f-e4b5-cf1e-670f-9a3a300a8484
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBB38:E3C4F:DB930C:1189562:6B010802
html-safe-nonceddef8dfec6adc87134815b07ecd1eae204e258145e17b0cae90e4b6bf516e28f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjM4OkUzQzRGOkRCOTMwQzoxMTg5NTYyOjZCMDEwODAyIiwidmlzaXRvcl9pZCI6IjY4NDM4MzMyNjUxMjk0MTA1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1f55770c5874793c1939b89de24a5d75f5afd20814f9a8c0bcbc501e07c6b581
hovercard-subject-tagissue:1644911229
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/49618/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7dbc55a6e5219020be9ff60c5cc7eb4283925cc9ef75c976904ad5ca5dc6fcb6/angular/angular/issues/49618
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7dbc55a6e5219020be9ff60c5cc7eb4283925cc9ef75c976904ad5ca5dc6fcb6/angular/angular/issues/49618
og:image:altWhich @angular/* package(s) are the source of the bug? service-worker Is this a regression? No Description If you call SwUpdate.checkForUpdate multiple times from application code, it is not dedupl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehenry-alakazhang
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/49618#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F49618
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F49618
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/49618
Reloadhttps://github.com/angular/angular/issues/49618
Reloadhttps://github.com/angular/angular/issues/49618
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/49618
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/49618
SwUpdate checkForUpdate can run multiple times simultaneouslyhttps://github.com/angular/angular/issues/49618#top
area: service-workerIssues related to the @angular/service-worker packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/henry-alakazhang
henry-alakazhanghttps://github.com/henry-alakazhang
on Mar 29, 2023https://github.com/angular/angular/issues/49618#issue-1644911229
https://user-images.githubusercontent.com/8922125/228405071-96f5f7ee-35e4-4c37-98b8-9478e4467c1c.png
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: service-workerIssues related to the @angular/service-worker packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
on Apr 3, 2023https://github.com/angular/angular/issues/49618#event-8910154191
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Apr 3, 2023https://github.com/angular/angular/issues/49618#event-8910155123
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
on Aug 29, 2025https://github.com/angular/angular/issues/49618#issuecomment-3236671802
#63364https://github.com/angular/angular/pull/63364
https://angular.dev/ecosystem/service-workershttps://angular.dev/ecosystem/service-workers
JeanMechehttps://github.com/JeanMeche
not plannedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Aug 29, 2025https://github.com/angular/angular/issues/49618#event-19409660216
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 29, 2025https://github.com/angular/angular/issues/49618#issuecomment-3344434225
automatic conversation locking policyhttps://github.com/angular/angular/blob/f0fbced1c55bc8b8ed9df01cea99df42f3e7eae3/contributing-docs/auto-issue-locking.md
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 29, 2025https://github.com/angular/angular/issues/49618#event-19971534633
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/49618
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/49618
area: service-workerIssues related to the @angular/service-worker packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.