René's URL Explorer Experiment


Title: Router can no longer be optionally injected · Issue #47051 · angular/angular · GitHub

Open Graph Title: Router can no longer be optionally injected · Issue #47051 · angular/angular

X Title: Router can no longer be optionally injected · Issue #47051 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? router Is this a regression? Yes Description This was broken in #46914 (released in v14.1.0). You can no longer optionally inject a Router service: constructor(@Optional() private ro...

Open Graph Description: Which @angular/* package(s) are the source of the bug? router Is this a regression? Yes Description This was broken in #46914 (released in v14.1.0). You can no longer optionally inject a Router ser...

X Description: Which @angular/* package(s) are the source of the bug? router Is this a regression? Yes Description This was broken in #46914 (released in v14.1.0). You can no longer optionally inject a Router ser...

Opengraph URL: https://github.com/angular/angular/issues/47051

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Router can no longer be optionally injected","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\nrouter\n\n### Is this a regression?\n\nYes\n\n### Description\n\nThis was broken in #46914 (released in v14.1.0).\r\n\r\nYou can no longer optionally inject a `Router` service:\r\n\r\n```ts\r\n  constructor(@Optional() private router: Router) { }\r\n```\r\n\r\nwithout importing `RouterModule` (or `RouterTestingModule`) results into:\r\n\r\n\r\n```\r\nERROR NullInjectorError: R3InjectorError(AppModule)[Router -> UrlSerializer -> UrlSerializer -> UrlSerializer]: \r\n  NullInjectorError: No provider for UrlSerializer!\r\n```\r\n\r\nOur use case is that we have some general purpose components which have different logic based on the existence of the router.\n\n### Please provide a link to a minimal reproduction of the bug\n\n_No response_\n\n### Please provide the exception or error you saw\n\n_No response_\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n```true\nAngular CLI: 14.1.1\r\nNode: 16.15.1\r\nPackage Manager: npm 8.11.0\r\nOS: darwin arm64\r\n\r\nAngular: 14.1.1\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... platform-browser, platform-browser-dynamic, router\r\n\r\nPackage                         Version\r\n---------------------------------------------------------\r\n@angular-devkit/architect       0.1401.1\r\n@angular-devkit/build-angular   14.1.1\r\n@angular-devkit/core            14.1.1\r\n@angular-devkit/schematics      14.1.1\r\n@schematics/angular             14.1.1\r\nrxjs                            7.5.6\r\ntypescript                      4.7.4\n```\n\n\n### Anything else?\n\n_No response_","author":{"url":"https://github.com/dzonatan","@type":"Person","name":"dzonatan"},"datePublished":"2022-08-05T14:47:32Z","url":"https://github.com/angular/angular/issues/47051"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:868ea4c9-db28-272c-5cf0-6de884b76360
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA282:395430:110BCD9:168EB79:6B010F51
html-safe-nonceaa7378fa8256e542ebfb0594c9622e399944a660abba0b44657d4c9d387c8232
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjgyOjM5NTQzMDoxMTBCQ0Q5OjE2OEVCNzk6NkIwMTBGNTEiLCJ2aXNpdG9yX2lkIjoiNTI5Mjc3MDU1MjM1ODk2NTA3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf5d226d7f746ca4f0dc5bc8a029ecf085212ccc628394ed6e2cc45b9428a2da3
hovercard-subject-tagissue:1330034351
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/47051/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d8b511f72e5a01fa11aca777370d025976d51563b3dc03e2f1e6795ca68183d3/angular/angular/issues/47051
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d8b511f72e5a01fa11aca777370d025976d51563b3dc03e2f1e6795ca68183d3/angular/angular/issues/47051
og:image:altWhich @angular/* package(s) are the source of the bug? router Is this a regression? Yes Description This was broken in #46914 (released in v14.1.0). You can no longer optionally inject a Router ser...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedzonatan
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/47051#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F47051
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F47051
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/47051
Reloadhttps://github.com/angular/angular/issues/47051
Reloadhttps://github.com/angular/angular/issues/47051
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/47051
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/47051
Router can no longer be optionally injectedhttps://github.com/angular/angular/issues/47051#top
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
on Aug 5, 2022https://github.com/angular/angular/issues/47051#issue-1330034351
#46914https://github.com/angular/angular/pull/46914
https://github.com/atscott
atscotthttps://github.com/atscott
on Aug 5, 2022https://github.com/angular/angular/issues/47051#issuecomment-1206581819
atscotthttps://github.com/atscott
not plannedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Aug 5, 2022https://github.com/angular/angular/issues/47051#event-7136782748
https://github.com/atscott
atscotthttps://github.com/atscott
on Aug 5, 2022https://github.com/angular/angular/issues/47051#issuecomment-1206585763
@dzonatanhttps://github.com/dzonatan
https://github.com/atscott
atscotthttps://github.com/atscott
on Aug 5, 2022https://github.com/angular/angular/issues/47051#issuecomment-1206662172
c7fed38https://github.com/angular/angular/commit/c7fed38cf0fbf072182ec666415ea50f8e84f7f7
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
on Aug 10, 2022https://github.com/angular/angular/issues/47051#issuecomment-1210327305
c7fed38https://github.com/angular/angular/commit/c7fed38cf0fbf072182ec666415ea50f8e84f7f7
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2022https://github.com/angular/angular/issues/47051#issuecomment-1242759993
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 10, 2022https://github.com/angular/angular/issues/47051#event-7361121247
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/47051
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/47051
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.