René's URL Explorer Experiment


Title: ExpressionChangedAfterItHasBeenCheckedError is not thrown if ChangeDetection.OnPush is used · Issue #45612 · angular/angular · GitHub

Open Graph Title: ExpressionChangedAfterItHasBeenCheckedError is not thrown if ChangeDetection.OnPush is used · Issue #45612 · angular/angular

X Title: ExpressionChangedAfterItHasBeenCheckedError is not thrown if ChangeDetection.OnPush is used · Issue #45612 · angular/angular

Description: Which @angular/* package(s) are the source of the bug? core Is this a regression? No Description When changing a template value while the change detection is taking place, the user is warned with an ExpressionChangedAfterItHasBeenChecked...

Open Graph Description: Which @angular/* package(s) are the source of the bug? core Is this a regression? No Description When changing a template value while the change detection is taking place, the user is warned with a...

X Description: Which @angular/* package(s) are the source of the bug? core Is this a regression? No Description When changing a template value while the change detection is taking place, the user is warned with a...

Opengraph URL: https://github.com/angular/angular/issues/45612

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ExpressionChangedAfterItHasBeenCheckedError is not thrown if ChangeDetection.OnPush is used","articleBody":"### Which @angular/* package(s) are the source of the bug?\n\ncore\n\n### Is this a regression?\n\nNo\n\n### Description\n\nWhen changing a template value while the change detection is taking place, the user is warned with an `ExpressionChangedAfterItHasBeenCheckedError`.\r\nThis is not the case for components which use the `ChangeDetectionStrategy.OnPush` .\r\n\r\nBy doing some debugging I found the problem:\r\n\r\n1. The async pipe triggers a `markForCheck` for the component, while change detection is running.\r\n2. The refreshView [clears](https://github.com/angular/angular/blob/60b5a3de9d1c249d2322e56612d11d67aecc1d82/packages/core/src/render3/instructions/shared.ts#L477-L479) the dirty state of the component after the view has been checked.\r\n3. The [checkNoChanges](https://github.com/angular/angular/blob/60b5a3de9d1c249d2322e56612d11d67aecc1d82/packages/core/src/application_ref.ts#L846-L850) is performed, and the [refreshComponent](https://github.com/angular/angular/blob/60b5a3de9d1c249d2322e56612d11d67aecc1d82/packages/core/src/render3/instructions/shared.ts#L1751-L1753) function does not perform a refreshView for that component, since it is no longer dirty.\r\n\r\nThis results in no ExpressionChangedAfterItHasBeenCheckedError because the view is not checked, since its dirty status has been cleared in the change detection process\r\n\r\nThis can be really hard to debug without the warning. So I found a workaround for now, that is to add `|| isInCheckNoChangesMode()` to the [refreshView check](https://github.com/angular/angular/blob/60b5a3de9d1c249d2322e56612d11d67aecc1d82/packages/core/src/render3/instructions/shared.ts#L1751) so that it becomes `if (componentView[FLAGS] & (LViewFlags.CheckAlways | LViewFlags.Dirty) || isInCheckNoChangesMode()) {`. This is very ugly and imperformant, but at least it helps detect those errors.\n\n### Please provide a link to a minimal reproduction of the bug\n\nhttps://stackblitz.com/edit/angular-ivy-ked7hw?file=src/app/app.component.ts\n\n### Please provide the exception or error you saw\n\n_No response_\n\n### Please provide the environment you discovered this bug in (run `ng version`)\n\n```true\nAngular CLI: 13.3.2\r\nNode: 16.14.2\r\nPackage Manager: yarn 1.22.18\r\nOS: linux x64\r\n\r\nAngular: 13.3.2\r\n... animations, cdk, cdk-experimental, cli, common, compiler\r\n... compiler-cli, core, forms, material, material-moment-adapter\r\n... platform-browser, platform-browser-dynamic, router\r\n\r\nPackage                         Version\r\n---------------------------------------------------------\r\n@angular-devkit/architect       0.1303.2\r\n@angular-devkit/build-angular   13.3.2\r\n@angular-devkit/core            13.3.2\r\n@angular-devkit/schematics      13.3.2\r\n@schematics/angular             13.3.2\r\nng-packagr                      13.3.0\r\nrxjs                            7.5.5\r\ntypescript                      4.6.3\r\nwebpack                         5.72.0\n```\n\n\n### Anything else?\n\n_No response_","author":{"url":"https://github.com/skrtheboss","@type":"Person","name":"skrtheboss"},"datePublished":"2022-04-13T15:04:25Z","url":"https://github.com/angular/angular/issues/45612"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9a801b5c-7db7-6296-398d-6276562f13f2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC004:2564F:E6ABCA:130F211:6B00FFA3
html-safe-nonce7efee0eaa3ad155f7a9155bb34b52aa08c7d63414f7cb3c9ea789ab00fb6c2e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDA0OjI1NjRGOkU2QUJDQToxMzBGMjExOjZCMDBGRkEzIiwidmlzaXRvcl9pZCI6IjQyMzgxNjc5OTE2ODgxNjczMzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac54a1c84c7d3fea564f95d4f88627518ac4053e5232a4468ed869c7fddb8a8298
hovercard-subject-tagissue:1203431504
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/45612/issue_layout
twitter:imagehttps://opengraph.githubassets.com/74d7da2896a0d30acead96c6bf33d3b0aa540d28ae20b36b9c4c629ffad62d9d/angular/angular/issues/45612
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/74d7da2896a0d30acead96c6bf33d3b0aa540d28ae20b36b9c4c629ffad62d9d/angular/angular/issues/45612
og:image:altWhich @angular/* package(s) are the source of the bug? core Is this a regression? No Description When changing a template value while the change detection is taking place, the user is warned with a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameskrtheboss
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/45612#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F45612
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F45612
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/45612
Reloadhttps://github.com/angular/angular/issues/45612
Reloadhttps://github.com/angular/angular/issues/45612
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/45612
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/45612
ExpressionChangedAfterItHasBeenCheckedError is not thrown if ChangeDetection.OnPush is usedhttps://github.com/angular/angular/issues/45612#top
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
breaking changeshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/skrtheboss
skrthebosshttps://github.com/skrtheboss
on Apr 13, 2022https://github.com/angular/angular/issues/45612#issue-1203431504
clearshttps://github.com/angular/angular/blob/60b5a3de9d1c249d2322e56612d11d67aecc1d82/packages/core/src/render3/instructions/shared.ts#L477-L479
checkNoChangeshttps://github.com/angular/angular/blob/60b5a3de9d1c249d2322e56612d11d67aecc1d82/packages/core/src/application_ref.ts#L846-L850
refreshComponenthttps://github.com/angular/angular/blob/60b5a3de9d1c249d2322e56612d11d67aecc1d82/packages/core/src/render3/instructions/shared.ts#L1751-L1753
refreshView checkhttps://github.com/angular/angular/blob/60b5a3de9d1c249d2322e56612d11d67aecc1d82/packages/core/src/render3/instructions/shared.ts#L1751
https://stackblitz.com/edit/angular-ivy-ked7hw?file=src/app/app.component.tshttps://stackblitz.com/edit/angular-ivy-ked7hw?file=src/app/app.component.ts
Nexthttps://github.com/angular/angular/issues/45612?timeline_page=1
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Apr 13, 2022https://github.com/angular/angular/issues/45612#issuecomment-1098184774
JoostKhttps://github.com/JoostK
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
P4A relatively minor issue that is not relevant to core functionshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P4%22
on Apr 13, 2022https://github.com/angular/angular/issues/45612#event-6428330682
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Apr 13, 2022https://github.com/angular/angular/issues/45612#event-6428331209
https://github.com/atscott
atscotthttps://github.com/atscott
on Apr 13, 2022https://github.com/angular/angular/issues/45612#issuecomment-1098326432
#34443https://github.com/angular/angular/pull/34443
@JoostKhttps://github.com/JoostK
https://github.com/mirobo
mirobohttps://github.com/mirobo
on Jul 5, 2022https://github.com/angular/angular/issues/45612#issuecomment-1174734600
alxhubhttps://github.com/alxhub
breaking changeshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
P1Impacts a large percentage of users; if a workaround exists it is partial or overly painfulhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P1%22
P4A relatively minor issue that is not relevant to core functionshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P4%22
on May 17, 2023https://github.com/angular/angular/issues/45612#event-9269989503
https://github.com/SLKnutson
SLKnutsonhttps://github.com/SLKnutson
on May 31, 2023https://github.com/angular/angular/issues/45612#issuecomment-1570705233
@inputhttps://github.com/input
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on May 31, 2023https://github.com/angular/angular/issues/45612#issuecomment-1570791175
mmalerbahttps://github.com/mmalerba
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
e711f99https://github.com/angular/angular/commit/e711f99d81ea7dbd4526f859c363244fccdf0626
on Apr 24, 2025https://github.com/angular/angular/issues/45612#event-17396599825
angular-robothttps://github.com/angular-robot
on Apr 24, 2025https://github.com/angular/angular/issues/45612#event-17397285196
feat(core): move `provideExperimentalCheckNoChangesForDebug` to `prov…https://github.com/angular-robot/angular/commit/e711f99d81ea7dbd4526f859c363244fccdf0626
https://docs.github.com/articles/closing-issues-via-commit-messages
e711f99https://github.com/angular-robot/angular/commit/e711f99d81ea7dbd4526f859c363244fccdf0626
atscotthttps://github.com/atscott
on May 9, 2025https://github.com/angular/angular/issues/45612#event-17593126967
refactor: Update tests to use exhaustive checkNoChanges by defaulthttps://github.com/atscott/components/commit/514f2446b8dd462989f074a1fd8098c76c11d9ba
514f244https://github.com/atscott/components/commit/514f2446b8dd462989f074a1fd8098c76c11d9ba
test(multiple): Update tests to use exhaustive checkNoChanges by defaulthttps://github.com/atscott/components/commit/82c4484385cfd28b895cba9dc1de7f6d125e415c
82c4484https://github.com/atscott/components/commit/82c4484385cfd28b895cba9dc1de7f6d125e415c
mmalerbahttps://github.com/mmalerba
on May 13, 2025https://github.com/angular/angular/issues/45612#event-17639445653
test(multiple): Update tests to use exhaustive checkNoChanges by defa…https://github.com/angular/components/commit/839dfba8fc3a7bd9f7865a5eeed6aff1155c5d80
839dfbahttps://github.com/angular/components/commit/839dfba8fc3a7bd9f7865a5eeed6aff1155c5d80
test(multiple): Update tests to use exhaustive checkNoChanges by defa…https://github.com/angular/components/commit/a0a0dfd4ef0b9df19892c264dc8bd6887d48b602
a0a0dfdhttps://github.com/angular/components/commit/a0a0dfd4ef0b9df19892c264dc8bd6887d48b602
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 25, 2025https://github.com/angular/angular/issues/45612#issuecomment-2907518303
automatic conversation locking policyhttps://github.com/angular/angular/blob/f0fbced1c55bc8b8ed9df01cea99df42f3e7eae3/contributing-docs/auto-issue-locking.md
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 25, 2025https://github.com/angular/angular/issues/45612#event-17802679133
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/45612
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/45612
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
breaking changeshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.