René's URL Explorer Experiment


Title: Router initializer never completes if initial navigation fails · Issue #44355 · angular/angular · GitHub

Open Graph Title: Router initializer never completes if initial navigation fails · Issue #44355 · angular/angular

X Title: Router initializer never completes if initial navigation fails · Issue #44355 · angular/angular

Description: Which @angular/* package(s) are relevant/releated to the feature request? router Description Rendering an app in SSR (using nguniversal) with an invalid URL (e.g. http://localhost:4200/electronics-spa/en/USD/Brands/Canon/c/brand_10 or%...

Open Graph Description: Which @angular/* package(s) are relevant/releated to the feature request? router Description Rendering an app in SSR (using nguniversal) with an invalid URL (e.g. http://localhost:4200/electronics-...

X Description: Which @angular/* package(s) are relevant/releated to the feature request? router Description Rendering an app in SSR (using nguniversal) with an invalid URL (e.g. http://localhost:4200/electronics-...

Opengraph URL: https://github.com/angular/angular/issues/44355

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Router initializer never completes if initial navigation fails","articleBody":"### Which @angular/* package(s) are relevant/releated to the feature request?\r\n\r\nrouter\r\n\r\n### Description\r\n\r\nRendering an app in SSR (using nguniversal) with an invalid URL (e.g. http://localhost:4200/electronics-spa/en/USD/Brands/Canon/c/brand_10%20or%20(1,2)=(select*from(select%20name_const(CHAR(82,88,106,99,113,78,74,70,73,118,87),1),name_const(CHAR(82,88,106,99,113,78,74,70,73,118,87),1))a)%20--%20and%201%3D1) causes the render to hang, and never release the taken resources.\r\n\r\nThe reason is that the navigation never completes on error, when the `Router` option `initialNavigation` is set to `enabled`.\r\n\r\n### Proposed solution\r\n\r\nExpose `RouterInitializer`.\r\nEDIT: or make the router complete the navigation on error, if that makes sense.\r\n\r\n### Alternatives considered\r\n\r\nWe came up with this _workaround_, but it would be nice if `ɵangular_packages_router_router_h` could be exposed.\r\n\r\n```ts\r\nimport { Injectable, Injector, Provider } from '@angular/core';\r\nimport {\r\n  NavigationError,\r\n  Router,\r\n  ROUTER_CONFIGURATION,\r\n  ɵangular_packages_router_router_h as RouterInitializer,\r\n} from '@angular/router';\r\nimport { filter, take } from 'rxjs/operators';\r\n\r\n@Injectable()\r\nexport class CustomRouterInitializer extends RouterInitializer {\r\n  appInitializer(): Promise\u003cany> {\r\n    const injector: Injector = (this as any).injector;\r\n    const opts = injector.get(ROUTER_CONFIGURATION);\r\n\r\n    if (\r\n      opts.initialNavigation ===\r\n      'enabled' /* for Ng11: || opts.initialNavigation === 'enabledBlocking' */\r\n    ) {\r\n      let resolve: any;\r\n      const res = new Promise((r) => (resolve = r));\r\n\r\n      injector\r\n        .get(Router)\r\n        .events.pipe(\r\n          // We want to explicitly react on NavigationError event occurs just\r\n          // after the first navigation start event\r\n          take(2),\r\n          filter((event) => event instanceof NavigationError)\r\n        )\r\n        .subscribe(() => resolve(false));\r\n\r\n      super.appInitializer().then((val) => resolve(val));\r\n      return res;\r\n    }\r\n\r\n    return super.appInitializer();\r\n  }\r\n}\r\n\r\nexport const routerFixProvider: Provider = {\r\n  provide: RouterInitializer,\r\n  useClass: CustomRouterInitializer,\r\n};\r\n```\r\n\r\nThe above workaround is for ng12. \r\nI noticed that in ng13 there's no similar private API available, unless I'm missing something.","author":{"url":"https://github.com/znikola","@type":"Person","name":"znikola"},"datePublished":"2021-12-02T21:49:31Z","url":"https://github.com/angular/angular/issues/44355"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5dff8eb4-fb56-aad4-b17b-cfda430c8162
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD9C4:27E5CD:BA5F8C:F1D73D:6B00EC5A
html-safe-nonce28845bfd0282d2f6fd30baa4df2d2e52d42a8631556f51e1e97e2185f944beb5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUM0OjI3RTVDRDpCQTVGOEM6RjFENzNEOjZCMDBFQzVBIiwidmlzaXRvcl9pZCI6IjQ0NjgzNDUxMzMxNDU4NDQ4MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd0c1694b7c792c6c874c32f693d5341cfc48acdac44cb7e340ae7e94120a81f0
hovercard-subject-tagissue:1070011544
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/44355/issue_layout
twitter:imagehttps://opengraph.githubassets.com/894ed971f039014473cb4e091df16efef6e1b4a7b253e6af8e802cec274f8b63/angular/angular/issues/44355
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/894ed971f039014473cb4e091df16efef6e1b4a7b253e6af8e802cec274f8b63/angular/angular/issues/44355
og:image:altWhich @angular/* package(s) are relevant/releated to the feature request? router Description Rendering an app in SSR (using nguniversal) with an invalid URL (e.g. http://localhost:4200/electronics-...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameznikola
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/44355#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F44355
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F44355
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/44355
Reloadhttps://github.com/angular/angular/issues/44355
Reloadhttps://github.com/angular/angular/issues/44355
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/44355
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/44355
Router initializer never completes if initial navigation failshttps://github.com/angular/angular/issues/44355#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
area: serverIssues related to server-side renderinghttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20server%22
Fixit H1'2022https://github.com/angular/angular/milestone/113
https://github.com/znikola
znikolahttps://github.com/znikola
on Dec 2, 2021https://github.com/angular/angular/issues/44355#issue-1070011544
http://localhost:4200/electronics-spa/en/USD/Brands/Canon/c/brand_10%20or%20(1,2)=(select*from(select%20name_const(CHAR(82,88,106,99,113,78,74,70,73,118,87),1),name_const(CHAR(82,88,106,99,113,78,74,70,73,118,87),1))a)%20--%20and%201%3D1http://localhost:4200/electronics-spa/en/USD/Brands/Canon/c/brand_10%20or%20(1,2)=(select*from(select%20name_const(CHAR(82,88,106,99,113,78,74,70,73,118,87),1),name_const(CHAR(82,88,106,99,113,78,74,70,73,118,87),1))a)%20--%20and%201%3D1
Nexthttps://github.com/angular/angular/issues/44355?timeline_page=1
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Dec 3, 2021https://github.com/angular/angular/issues/44355#event-5712066158
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Dec 3, 2021https://github.com/angular/angular/issues/44355#event-5712066289
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: serverIssues related to server-side renderinghttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20server%22
on Dec 3, 2021https://github.com/angular/angular/issues/44355#event-5712066631
atscotthttps://github.com/atscott
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
on Dec 16, 2021https://github.com/angular/angular/issues/44355#event-5780535332
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Dec 16, 2021https://github.com/angular/angular/issues/44355#event-5780535411
angular-robothttps://github.com/apps/angular-robot
votes requiredhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22votes%20required%22
on Dec 17, 2021https://github.com/angular/angular/issues/44355#event-5784814969
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Dec 17, 2021https://github.com/angular/angular/issues/44355#issuecomment-996745339
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jan 25, 2022https://github.com/angular/angular/issues/44355#issuecomment-1021216615
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Feb 14, 2022https://github.com/angular/angular/issues/44355#issuecomment-1039121233
communityhttps://angular.io/resources?category=community
packagehttps://angular.io/guide/creating-libraries
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
angular-robothttps://github.com/apps/angular-robot
insufficient voteshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22insufficient%20votes%22
votes requiredhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22votes%20required%22
on Feb 14, 2022https://github.com/angular/angular/issues/44355#event-6067274438
atscotthttps://github.com/atscott
insufficient voteshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22insufficient%20votes%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
on Apr 22, 2022https://github.com/angular/angular/issues/44355#event-6481244897
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Apr 22, 2022https://github.com/angular/angular/issues/44355#event-6481246485
atscotthttps://github.com/atscott
needsTriagehttps://github.com/angular/angular/milestone/83
Fixit H1'2022https://github.com/angular/angular/milestone/113
on Jun 27, 2022https://github.com/angular/angular/issues/44355#event-6887501890
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
e8c7dd1https://github.com/angular/angular/commit/e8c7dd10e93d338456131e11d600bf758ee48634
on Jun 29, 2022https://github.com/angular/angular/issues/44355#event-6906092600
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jul 30, 2022https://github.com/angular/angular/issues/44355#issuecomment-1200244039
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jul 30, 2022https://github.com/angular/angular/issues/44355#event-7094659331
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/44355
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/44355
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
area: serverIssues related to server-side renderinghttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20server%22
Fixit H1'2022https://github.com/angular/angular/milestone/113
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.