René's URL Explorer Experiment


Title: [zonejs] XMLHttpRequest macrotask left hanging if `onload` throws · Issue #41520 · angular/angular · GitHub

Open Graph Title: [zonejs] XMLHttpRequest macrotask left hanging if `onload` throws · Issue #41520 · angular/angular

X Title: [zonejs] XMLHttpRequest macrotask left hanging if `onload` throws · Issue #41520 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/zone.js. Is this a regression? AFAICT it has always been like this. Description ZoneJS invokes the XHR macrotask after all existing load handlers run, but if any of th...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/zone.js. Is this a regression? AFAICT it has always been like this. Description ZoneJS invokes the XHR macrotask after all exis...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/zone.js. Is this a regression? AFAICT it has always been like this. Description ZoneJS invokes the XHR macrotask after all exis...

Opengraph URL: https://github.com/angular/angular/issues/41520

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[zonejs] XMLHttpRequest macrotask left hanging if `onload` throws","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\nThe issue is caused by package @angular/zone.js.\r\n\r\n### Is this a regression?\r\nAFAICT it has always been like this.\r\n\r\n### Description\r\nZoneJS invokes the XHR macrotask after all existing `load` handlers run, but if any of them throw an unhandled exception, the task remains stuck in a `scheduled` state and none of the delegate hooks (e.g. `onInvokeTask()`) run. This creates problems for test environments and any instrumentation that relies on task counts.\r\n\r\n(It is somewhat similar to issue #38795.)\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\n```javascript\r\nZone.root\r\n  .fork({\r\n    name: 'xhr',\r\n    onHasTask(delegate, currentZone, zone, taskState) {\r\n      console.log('hasMacrotask', taskState.macroTask);\r\n      return delegate.hasTask(zone, taskState);\r\n    },      \r\n  })\r\n  .run(() => {\r\n    const xhr = new XMLHttpRequest();\r\n    xhr.open('GET', 'https://cdnjs.cloudflare.com/ajax/libs/zone.js/0.11.4/zone.min.js');\r\n    xhr.addEventListener('load', () => {\r\n      throw new Error();\r\n    });\r\n    xhr.send();\r\n  });\r\n```\r\n\r\nThis code ends by printing `hasMacrotask true` and the XHR task left in a `scheduled` state.\r\n\r\nNote that this repro specifically forks the root zone. If you try to repro this in StackBlitz or in Angular's `NgZone` and for the current zone instead, you'll need to wrap the `addEventListener()` call in `Zone.root.run()` to make it work. The reason is that `NgZone` implements a `onHandleError()` delegate hook that always returns false, and the exception get swallowed instead of being thrown.\r\n","author":{"url":"https://github.com/mleibman","@type":"Person","name":"mleibman"},"datePublished":"2021-04-08T20:45:18Z","url":"https://github.com/angular/angular/issues/41520"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7ee0efa8-576b-0bfa-90e1-f01026153d3a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB324:2270F4:D684C3:11E5207:6B00FF8C
html-safe-nonce8e02760250d1814f9887d958a1ffef7f6b37ee59f44997402c729b6f1739f194
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzI0OjIyNzBGNDpENjg0QzM6MTFFNTIwNzo2QjAwRkY4QyIsInZpc2l0b3JfaWQiOiIzOTQ0MzgzNTE4NDQ4MDkxMDIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc7a275e4ecf99cc739496581b8e9ef2b65de4c794f7cb3442889dda0da45fae0
hovercard-subject-tagissue:853885084
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/41520/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d92c5925b30ed135a89e1d638fad3a404a71b7105266e1a199e0a5dd80168758/angular/angular/issues/41520
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d92c5925b30ed135a89e1d638fad3a404a71b7105266e1a199e0a5dd80168758/angular/angular/issues/41520
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/zone.js. Is this a regression? AFAICT it has always been like this. Description ZoneJS invokes the XHR macrotask after all exis...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemleibman
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/41520#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F41520
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F41520
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/41520
Reloadhttps://github.com/angular/angular/issues/41520
Reloadhttps://github.com/angular/angular/issues/41520
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/41520
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/41520
[zonejs] XMLHttpRequest macrotask left hanging if onload throwshttps://github.com/angular/angular/issues/41520#top
https://github.com/JiaLiPassion
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/mleibman
mleibmanhttps://github.com/mleibman
on Apr 8, 2021https://github.com/angular/angular/issues/41520#issue-853885084
#38795https://github.com/angular/angular/issues/38795
https://github.com/mleibman
mleibmanhttps://github.com/mleibman
on Apr 8, 2021https://github.com/angular/angular/issues/41520#issuecomment-816179704
@JiaLiPassionhttps://github.com/JiaLiPassion
zarendhttps://github.com/zarend
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
on Apr 8, 2021https://github.com/angular/angular/issues/41520#event-4571121382
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Apr 8, 2021https://github.com/angular/angular/issues/41520#event-4571121471
https://github.com/mleibman
mleibmanhttps://github.com/mleibman
on Apr 8, 2021https://github.com/angular/angular/issues/41520#issuecomment-816218389
#41522https://github.com/angular/angular/issues/41522
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
on Apr 9, 2021https://github.com/angular/angular/issues/41520#issuecomment-816770315
@mleibmanhttps://github.com/mleibman
JiaLiPassionhttps://github.com/JiaLiPassion
on Apr 9, 2021https://github.com/angular/angular/issues/41520#event-4575133443
https://github.com/jelbourn
jelbournhttps://github.com/jelbourn
on Apr 9, 2021https://github.com/angular/angular/issues/41520#issuecomment-816958369
#41522https://github.com/angular/angular/issues/41522
https://github.com/mleibman
mleibmanhttps://github.com/mleibman
on Apr 9, 2021https://github.com/angular/angular/issues/41520#issuecomment-816960906
#41522https://github.com/angular/angular/issues/41522
gkalpakhttps://github.com/gkalpak
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 10, 2021https://github.com/angular/angular/issues/41520#event-4577385250
AndrewKushnirhttps://github.com/AndrewKushnir
on Apr 19, 2021https://github.com/angular/angular/issues/41520#event-4613464477
test(zone.js): should invoke XHR task even onload handler throw error. (https://github.com/angular/angular/commit/8c831a257c8f5f394018db29a3c2805c1e5023f0
https://docs.github.com/articles/closing-issues-via-commit-messages
8c831a2https://github.com/angular/angular/commit/8c831a257c8f5f394018db29a3c2805c1e5023f0
test(zone.js): should invoke XHR task even onload handler throw error. (https://github.com/angular/angular/commit/6910118b0d82255be60a8580957383d227bcd58e
https://docs.github.com/articles/closing-issues-via-commit-messages
6910118https://github.com/angular/angular/commit/6910118b0d82255be60a8580957383d227bcd58e
test(zone.js): should invoke XHR task even onload handler throw error. (https://github.com/angular/angular/commit/1f84db80f260bdbe0a7c053593283384f15a72c6
https://docs.github.com/articles/closing-issues-via-commit-messages
1f84db8https://github.com/angular/angular/commit/1f84db80f260bdbe0a7c053593283384f15a72c6
jessicajaniukhttps://github.com/jessicajaniuk
on Apr 21, 2021https://github.com/angular/angular/issues/41520#event-4627627586
test(zone.js): should invoke XHR task even onload handler throw error. (https://github.com/angular/angular/commit/c3614662cb0ae5f93eb4d77f97f68fbba3cc360e
https://docs.github.com/articles/closing-issues-via-commit-messages
c361466https://github.com/angular/angular/commit/c3614662cb0ae5f93eb4d77f97f68fbba3cc360e
test(zone.js): should invoke XHR task even onload handler throw error. (https://github.com/angular/angular/commit/1d1fa1a8f36e49d441e917a922221e5d9b71e24b
https://docs.github.com/articles/closing-issues-via-commit-messages
1d1fa1ahttps://github.com/angular/angular/commit/1d1fa1a8f36e49d441e917a922221e5d9b71e24b
test(zone.js): should invoke XHR task even onload handler throw error. (https://github.com/angular/angular/commit/0830885c951a2b1db1376a91b53aec2b26a5dbc8
https://docs.github.com/articles/closing-issues-via-commit-messages
0830885https://github.com/angular/angular/commit/0830885c951a2b1db1376a91b53aec2b26a5dbc8
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 11, 2021https://github.com/angular/angular/issues/41520#issuecomment-838748040
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 11, 2021https://github.com/angular/angular/issues/41520#event-4728992261
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/41520
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/41520
JiaLiPassionhttps://github.com/JiaLiPassion
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.