René's URL Explorer Experiment


Title: Async guards should have the option to wait for previous guards to finish · Issue #40577 · angular/angular · GitHub

Open Graph Title: Async guards should have the option to wait for previous guards to finish · Issue #40577 · angular/angular

X Title: Async guards should have the option to wait for previous guards to finish · Issue #40577 · angular/angular

Description: This is a copy of #21702 which has been locked due to inactivity. Still it is relevant. I'm submitting a... [ ] Regression [ ] Bug report [X] Feature request [ ] Documentation issue or request [ ] Support request Current behavior When ha...

Open Graph Description: This is a copy of #21702 which has been locked due to inactivity. Still it is relevant. I'm submitting a... [ ] Regression [ ] Bug report [X] Feature request [ ] Documentation issue or request [ ] ...

X Description: This is a copy of #21702 which has been locked due to inactivity. Still it is relevant. I'm submitting a... [ ] Regression [ ] Bug report [X] Feature request [ ] Documentation issue or request ...

Opengraph URL: https://github.com/angular/angular/issues/40577

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Async guards should have the option to wait for previous guards to finish","articleBody":"This is a copy of #21702 which has been locked due to inactivity. Still it is relevant.\r\n\r\n### I'm submitting a...\r\n\r\n[ ] Regression\r\n[ ] Bug report\r\n[X] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request\r\n\r\n### Current behavior\r\n\r\nWhen having multiple async guards (returning promise or observable) for the same path they execute at the same time:\r\n\r\n```ts\r\n{\r\n  path: '',\r\n  canActivate: [\r\n        AuthGuard,\r\n        DetectLanguage,\r\n        GetAppData,\r\n  ],\r\n  children: [ ... ]\r\n}\r\n```\r\n\r\n### Expected behavior\r\n\r\nThere should be an option to let them execute synchronous: \r\n\r\n- guard[i+1] should wait for guard[i] to finish\r\n- If guard[i] returns false all following guards should not execute\r\n\r\n### What is the motivation / use case for changing the behavior?\r\n\r\nThe example above has an authentication which needs to be done first before getting the app data. AuthGuard returns a token that needs to be used within GetAppData. Currently GetAppData runs immediatly without having a token.\r\n\r\n### Workaround\r\n\r\nKinda ugly and confusing workaround:\r\n\r\n```ts\r\n{\r\n      path: '',\r\n      canActivate: [\r\n         AuthGuard,\r\n      ],\r\n      children: [\r\n        {\r\n          path: '',\r\n          canActivate: [\r\n             DetectLanguage,\r\n          ],\r\n          children: [\r\n             {\r\n                path: '',\r\n                canActivate: [\r\n                    GetAppdata,\r\n                ],\r\n                component: MyComponent,\r\n             }\r\n         }\r\n      ]\r\n    }\r\n```","author":{"url":"https://github.com/MickL","@type":"Person","name":"MickL"},"datePublished":"2021-01-26T14:54:08Z","url":"https://github.com/angular/angular/issues/40577"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c352e5ad-16d3-d578-2a1d-aa278abc26f3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idABA2:1AE20C:9371C9:BC146A:6B00EC6B
html-safe-nonceedb1c41851658d90bcec2898778e10feaa0a347c8143df8a841576df4b90282d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkEyOjFBRTIwQzo5MzcxQzk6QkMxNDZBOjZCMDBFQzZCIiwidmlzaXRvcl9pZCI6IjE3NTA1ODQ0NDk2Mzg2Nzc1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace717e6c47235450f69cb6edc9ec2ba77277a7426d307330308a6791dd82862d0
hovercard-subject-tagissue:794296370
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/40577/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bfbc196802918d553b22b9e98660c17ad6a5192d753bb546195404aff7586b11/angular/angular/issues/40577
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bfbc196802918d553b22b9e98660c17ad6a5192d753bb546195404aff7586b11/angular/angular/issues/40577
og:image:altThis is a copy of #21702 which has been locked due to inactivity. Still it is relevant. I'm submitting a... [ ] Regression [ ] Bug report [X] Feature request [ ] Documentation issue or request [ ] ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMickL
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/40577#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F40577
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F40577
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/40577
Reloadhttps://github.com/angular/angular/issues/40577
Reloadhttps://github.com/angular/angular/issues/40577
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/40577
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/40577
Async guards should have the option to wait for previous guards to finishhttps://github.com/angular/angular/issues/40577#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
design complexity: majorhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22design%20complexity%3A%20major%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
state: Needs Designhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20Needs%20Design%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/MickL
MickLhttps://github.com/MickL
on Jan 26, 2021https://github.com/angular/angular/issues/40577#issue-794296370
#21702https://github.com/angular/angular/issues/21702
jessicajaniukhttps://github.com/jessicajaniuk
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Jan 26, 2021https://github.com/angular/angular/issues/40577#event-4251801989
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jan 26, 2021https://github.com/angular/angular/issues/40577#event-4251802073
atscotthttps://github.com/atscott
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
on Jan 26, 2021https://github.com/angular/angular/issues/40577#event-4251894435
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Jan 26, 2021https://github.com/angular/angular/issues/40577#event-4251894553
https://github.com/atscott
atscotthttps://github.com/atscott
on Jan 26, 2021https://github.com/angular/angular/issues/40577#issuecomment-767733949
atscotthttps://github.com/atscott
design complexity: majorhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22design%20complexity%3A%20major%22
state: Needs Designhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20Needs%20Design%22
on Jan 26, 2021https://github.com/angular/angular/issues/40577#event-4252081029
https://github.com/sod
sodhttps://github.com/sod
on Jan 27, 2021https://github.com/angular/angular/issues/40577#issuecomment-768209703
https://ng-run.com/edit/HmMVqtmmHB52knus3yjk?open=app%2Fsequential-routing-guard.service.tshttps://ng-run.com/edit/HmMVqtmmHB52knus3yjk?open=app%2Fsequential-routing-guard.service.ts
#36538https://github.com/angular/angular/issues/36538
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 4, 2021https://github.com/angular/angular/issues/40577#issuecomment-854795131
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
angular-robothttps://github.com/apps/angular-robot
votes requiredhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22votes%20required%22
on Jun 4, 2021https://github.com/angular/angular/issues/40577#event-4843693220
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 25, 2021https://github.com/angular/angular/issues/40577#issuecomment-868528397
communityhttps://angular.io/resources?category=community
packagehttps://angular.io/guide/creating-libraries
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
angular-robothttps://github.com/apps/angular-robot
insufficient voteshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22insufficient%20votes%22
on Jun 25, 2021https://github.com/angular/angular/issues/40577#event-4940277915
https://github.com/atscott
atscotthttps://github.com/atscott
on Jul 23, 2021https://github.com/angular/angular/issues/40577#issuecomment-885939885
#42953https://github.com/angular/angular/issues/42953
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 23, 2021https://github.com/angular/angular/issues/40577#event-5063307290
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 23, 2021https://github.com/angular/angular/issues/40577#issuecomment-903914414
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 23, 2021https://github.com/angular/angular/issues/40577#event-5195466574
https://github.com/atscott
atscotthttps://github.com/atscott
on Jul 6, 2022https://github.com/angular/angular/issues/40577#issuecomment-1176339631
"guards as functions"https://github.com/angular/angular/pull/46684
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/40577
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/40577
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
design complexity: majorhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22design%20complexity%3A%20major%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
state: Needs Designhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20Needs%20Design%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.