René's URL Explorer Experiment


Title: OnPush component in dev mode will only trigger change detection once. · Issue #39545 · angular/angular · GitHub

Open Graph Title: OnPush component in dev mode will only trigger change detection once. · Issue #39545 · angular/angular

X Title: OnPush component in dev mode will only trigger change detection once. · Issue #39545 · angular/angular

Description: Consider the following case. @Component({ template: `

{{increment('componentView')}}
`, changeDetection: ChangeDetectionStrategy.OnPush }) class App { increment() { co...

Open Graph Description: Consider the following case. @Component({ template: `

{{increment('componentView')}}
`, changeDetection: ChangeDetectionStrateg...

X Description: Consider the following case. @Component({ template: ` <button (click)="noop()">Trigger change detection</button> <div>{{increment('componentView')}}</div> ...

Opengraph URL: https://github.com/angular/angular/issues/39545

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"OnPush component in dev mode will only trigger change detection once.","articleBody":"Consider the following case.\r\n\r\n```\r\n      @Component({\r\n        template: `\r\n          \u003cbutton (click)=\"noop()\">Trigger change detection\u003c/button>\r\n          \u003cdiv>{{increment('componentView')}}\u003c/div>\r\n        `,\r\n        changeDetection: ChangeDetectionStrategy.OnPush\r\n      })\r\n      class App {\r\n        increment() {\r\n          counters++;\r\n        }\r\n        noop() {}\r\n      }\r\n      const fixture = TestBed.createComponent(App);\r\n      fixture.detectChanges();\r\n      expect(counters).toEqual(2); // current behavior is 1 \r\n```\r\nThe reason is App is a OnPush component with a hostView, calling fixture.detectChanges() will run a detectChanges() and checkNoChanges() .\r\nAnd the App component is onPush, so the checkNoChanges() run will ignore App component, so the counters will be 1\r\nWhich is not correct.\r\n\r\nAnother case is:\r\n\r\n```\r\n    it('works', () => {\r\n      @Component({\r\n        template: '{{message}}',\r\n        changeDetection: ChangeDetectionStrategy.OnPush\r\n      })\r\n      class OnPushCmp {\r\n        @Input() message = 'initial';\r\n        ngAfterViewInit() {\r\n          this.message = 'updated';\r\n        }\r\n      }\r\n      const comp = TestBed.configureTestingModule({declarations: [OnPushCmp]}).createComponent(OnPushCmp);\r\n      expect(() => comp.detectChanges()).toThrow(); // current behavior is not throw.\r\n    });\r\n```\r\n\r\nThe reason is the same, the `checkNoChanges()` will skip the `OnPushCmp`, so the `ExpressionChanged` error is not thrown.\r\n\r\n\r\n\r\n","author":{"url":"https://github.com/JiaLiPassion","@type":"Person","name":"JiaLiPassion"},"datePublished":"2020-11-03T01:49:27Z","url":"https://github.com/angular/angular/issues/39545"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9f02da22-81da-dafc-1262-828db798925b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB5FE:19E4BB:BDD3FD:F38EE3:6B00FD0A
html-safe-nonceffa4a324d6048da32ca8295a05fb79ad5320d20018d9899b45ac90b4834e4c18
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUZFOjE5RTRCQjpCREQzRkQ6RjM4RUUzOjZCMDBGRDBBIiwidmlzaXRvcl9pZCI6IjYzNzQ5OTQwNTIwMDUyOTc0MTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac33d496e779847606c5d54df445e64f768411020341145276426aa9fc6186cc10
hovercard-subject-tagissue:734956273
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/39545/issue_layout
twitter:imagehttps://opengraph.githubassets.com/49573e575b54ca386083acd3ae20ea8d0fd4a4db151de64b68b70c189a6a091f/angular/angular/issues/39545
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/49573e575b54ca386083acd3ae20ea8d0fd4a4db151de64b68b70c189a6a091f/angular/angular/issues/39545
og:image:altConsider the following case. @Component({ template: `
{{increment('componentView')}}
`, changeDetection: ChangeDetectionStrateg...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJiaLiPassion
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/39545#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F39545
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F39545
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/39545
Reloadhttps://github.com/angular/angular/issues/39545
Reloadhttps://github.com/angular/angular/issues/39545
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/39545
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/39545
OnPush component in dev mode will only trigger change detection once.https://github.com/angular/angular/issues/39545#top
https://github.com/JiaLiPassion
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
on Nov 3, 2020https://github.com/angular/angular/issues/39545#issue-734956273
JiaLiPassionhttps://github.com/JiaLiPassion
on Nov 3, 2020https://github.com/angular/angular/issues/39545#event-3950783328
JiaLiPassionhttps://github.com/JiaLiPassion
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Nov 3, 2020https://github.com/angular/angular/issues/39545#event-3950783542
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Nov 3, 2020https://github.com/angular/angular/issues/39545#event-3950783723
jelbournhttps://github.com/jelbourn
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
on Nov 4, 2020https://github.com/angular/angular/issues/39545#event-3958453740
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Nov 4, 2020https://github.com/angular/angular/issues/39545#event-3958453852
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on May 4, 2022https://github.com/angular/angular/issues/39545#issuecomment-1117355443
TestBed: rethink interactions with the @Input / @output of the root component #12313https://github.com/angular/angular/issues/12313
ExpressionChangedAfterItHasBeenCheckedError is not thrown if ChangeDetection.OnPush is used #45612https://github.com/angular/angular/issues/45612
#12313https://github.com/angular/angular/issues/12313
#45612https://github.com/angular/angular/issues/45612
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 4, 2022https://github.com/angular/angular/issues/39545#event-6548815790
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 4, 2022https://github.com/angular/angular/issues/39545#issuecomment-1146641643
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 4, 2022https://github.com/angular/angular/issues/39545#event-6742143362
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/39545
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/39545
JiaLiPassionhttps://github.com/JiaLiPassion
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.