René's URL Explorer Experiment


Title: NGCC is non-hermetic and produces different output depending on source location in file system · Issue #39293 · angular/angular · GitHub

Open Graph Title: NGCC is non-hermetic and produces different output depending on source location in file system · Issue #39293 · angular/angular

X Title: NGCC is non-hermetic and produces different output depending on source location in file system · Issue #39293 · angular/angular

Description: 🐞 bug report Affected Package angular/compiler-cli Description NGCC produces different output - specifically, in sourcemap transformation - depending on source location in file system. I have two copies of the same project checked out in...

Open Graph Description: 🐞 bug report Affected Package angular/compiler-cli Description NGCC produces different output - specifically, in sourcemap transformation - depending on source location in file system. I have two c...

X Description: 🐞 bug report Affected Package angular/compiler-cli Description NGCC produces different output - specifically, in sourcemap transformation - depending on source location in file system. I have two c...

Opengraph URL: https://github.com/angular/angular/issues/39293

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"NGCC is non-hermetic and produces different output depending on source location in file system","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\nangular/compiler-cli\r\n\r\n\r\n### Description\r\n\r\nNGCC produces different output - specifically, in sourcemap transformation - depending on source location in file system.\r\n\r\nI have two copies of the same project checked out in two places:\r\n\r\nD:/myproj\r\nD:/myproj-other/myproj\r\n\r\nIf I compare node_modules/@angular/animation between the two (this is just an example), the \"sources\" fields on the source maps in node_modules/@angular/animations/fesm2015 (again, just an example) are different \r\n\r\nD:/myproj-other/myproj/node_modules/@angular/animations/fesm2015/animations.js.map\r\n```\r\n{\"version\":3,\"file\":\"animations.js\",\"sources\":[\"../../../../../../packages/animations/src/animation_builder.ts\",\"../../../../../../packages/animations/src/animation_metadata.ts\",\"../../../../../../packages/animations/src/util.ts\",\"../../../../../../packages/animations/src/players/animation_player.ts\",\"../../../../../../packages/animations/src/players/animation_group_player.ts\",\"../../../../../../packages/animations/src/private_export.ts\",\"../../../../../../packages/animations/src/animations.ts\",\"../../../../../../packages/animations/public_api.ts\",\"../../../../../../packages/animations/index.ts\",\"../../../../../../packages/animations/animations.ts\"],\"names\":\r\n...\r\n```\r\nD:/myproj/node_modules/@angular/animations/fesm2015/animations.js.map\r\n\r\n```\r\n{\"version\":3,\"file\":\"animations.js\",\"sources\":[\"../../../../../packages/animations/src/animation_builder.ts\",\"../../../../../packages/animations/src/animation_metadata.ts\",\"../../../../../packages/animations/src/util.ts\",\"../../../../../packages/animations/src/players/animation_player.ts\",\"../../../../../packages/animations/src/players/animation_group_player.ts\",\"../../../../../packages/animations/src/private_export.ts\",\"../../../../../packages/animations/src/animations.ts\",\"../../../../../packages/animations/public_api.ts\",\"../../../../../packages/animations/index.ts\",\"../../../../../packages/animations/animations.ts\"],\"names\":[\r\n...\r\n```\r\nNote that the number of \"../\" is different between them.\r\n\r\nthe __ivy_ngcc_bak file shows the original:\r\n\r\n```\r\n{\"version\":3,\"file\":\"animations.js\",\"sources\":[\"../../../../../../packages/animations/src/animation_builder.ts\",\"../../../../../../packages/animations/src/animation_metadata.ts\",\"../../../../../../packages/animations/src/util.ts\",\"../../../../../../packages/animations/src/players/animation_player.ts\",\"../../../../../../packages/animations/src/players/animation_group_player.ts\",\"../../../../../../packages/animations/src/private_export.ts\",\"../../../../../../packages/animations/src/animations.ts\",\"../../../../../../packages/animations/public_api.ts\",\"../../../../../../packages/animations/index.ts\",\"../../../../../../packages/animations/animations.ts\"],\r\n...\r\n```\r\n\r\nUnfortunately, this difference is significant if you want to do any sort of build caching between machines as the hashes of the input files of any dependencies on ngcc-processed node_modules are different. This has caused me a lot of pain as I am trying to set up Bazel in our system. I had problems with cache misses between our build servers and developer machines that appears to be caused by this. As a temporary workaround I have had to check in our node_modules, along with ngcc generated files.\r\n\r\nI don't have a firm grasp on the details of this bug, but it appears to me arise from the following code in:\r\n\r\nnode_modules/@angular/compiler-cli/src/ngtsc/sourcemaps/src/source_file.js\r\n\r\n```js\r\nvar sourceMap = {\r\n                version: 3,\r\n                file: this.fs.relative(sourcePathDir, this.sourcePath),\r\n                sources: sources.map(function (sf) { return _this.fs.relative(sourcePathDir, sf.sourcePath); }),\r\n                names: names,\r\n                mappings: sourcemap_codec_1.encode(mappings),\r\n                sourcesContent: sources.map(function (sf) { return sf.contents; }),\r\n            };\r\n```\r\n\r\nThe line\r\n```js\r\n                sources: sources.map(function (sf) { return _this.fs.relative(sourcePathDir, sf.sourcePath); }),\r\n```\r\n\r\nends up forming a relative path from\r\n\r\nD:/myproj/path/to/file\r\n\r\nto \r\nD:/packages/path/to/file\r\n\r\nObviously this is going to be different if the first path is\r\n\r\nD:/my/nested/checkout/myproj/path/to/file\r\n\r\n\r\n\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n10.1.5\r\n\r\n**Anything else relevant?**\r\nWindows","author":{"url":"https://github.com/matthewjh","@type":"Person","name":"matthewjh"},"datePublished":"2020-10-15T20:30:10Z","url":"https://github.com/angular/angular/issues/39293"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9addcd36-1dd2-83d1-9900-e4fb97e0d12a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD920:2E3FEE:EB9204:12B3C09:6B010A3C
html-safe-nonce3dc40fc3beb708709d911724b091d13312ef16159e129a9331f28b619588004e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTIwOjJFM0ZFRTpFQjkyMDQ6MTJCM0MwOTo2QjAxMEEzQyIsInZpc2l0b3JfaWQiOiIzNjk4MTkwNDY1NDE4NDYzODA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3f7c4487335d86818246852abf810d05474aa1c2b25cd4e7d9155abf4c3fc6c9
hovercard-subject-tagissue:722655900
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/39293/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bf791a2e9fd65aa4cc856205edffceb0ceaf1129cd8b48fc0709179f3b40a984/angular/angular/issues/39293
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bf791a2e9fd65aa4cc856205edffceb0ceaf1129cd8b48fc0709179f3b40a984/angular/angular/issues/39293
og:image:alt🐞 bug report Affected Package angular/compiler-cli Description NGCC produces different output - specifically, in sourcemap transformation - depending on source location in file system. I have two c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamematthewjh
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/39293#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F39293
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F39293
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/39293
Reloadhttps://github.com/angular/angular/issues/39293
Reloadhttps://github.com/angular/angular/issues/39293
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/39293
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/39293
NGCC is non-hermetic and produces different output depending on source location in file systemhttps://github.com/angular/angular/issues/39293#top
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/matthewjh
matthewjhhttps://github.com/matthewjh
on Oct 15, 2020https://github.com/angular/angular/issues/39293#issue-722655900
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Oct 15, 2020https://github.com/angular/angular/issues/39293#issuecomment-709575789
@matthewjhhttps://github.com/matthewjh
https://github.com/matthewjh
matthewjhhttps://github.com/matthewjh
on Oct 15, 2020https://github.com/angular/angular/issues/39293#issuecomment-709578680
@petebacondarwinhttps://github.com/petebacondarwin
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Oct 16, 2020https://github.com/angular/angular/issues/39293#issuecomment-709913757
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Oct 16, 2020https://github.com/angular/angular/issues/39293#issuecomment-709920248
https://github.com/matthewjh
matthewjhhttps://github.com/matthewjh
on Oct 16, 2020https://github.com/angular/angular/issues/39293#issuecomment-709927423
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Oct 16, 2020https://github.com/angular/angular/issues/39293#issuecomment-709934617
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Oct 16, 2020https://github.com/angular/angular/issues/39293#issuecomment-709957100
#39302https://github.com/angular/angular/pull/39302
AndrewKushnirhttps://github.com/AndrewKushnir
comp: ngcchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
on Oct 16, 2020https://github.com/angular/angular/issues/39293#event-3888378143
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Oct 16, 2020https://github.com/angular/angular/issues/39293#event-3888378221
petebacondarwinhttps://github.com/petebacondarwin
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
on Oct 17, 2020https://github.com/angular/angular/issues/39293#event-3889157302
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Oct 17, 2020https://github.com/angular/angular/issues/39293#event-3889157309
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Oct 19, 2020https://github.com/angular/angular/issues/39293#issuecomment-711833832
#14021https://github.com/angular/angular/issues/14021
#39302https://github.com/angular/angular/pull/39302
petebacondarwinhttps://github.com/petebacondarwin
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 19, 2020https://github.com/angular/angular/issues/39293#event-3892036421
https://github.com/matthewjh
matthewjhhttps://github.com/matthewjh
on Oct 19, 2020https://github.com/angular/angular/issues/39293#issuecomment-712249165
@petebacondarwinhttps://github.com/petebacondarwin
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Nov 19, 2020https://github.com/angular/angular/issues/39293#issuecomment-730491116
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Nov 19, 2020https://github.com/angular/angular/issues/39293#event-4016775461
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/39293
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/39293
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.