René's URL Explorer Experiment


Title: Angular/elements OnPush input changes does not trigger change detection · Issue #38948 · angular/angular · GitHub

Open Graph Title: Angular/elements OnPush input changes does not trigger change detection · Issue #38948 · angular/angular

X Title: Angular/elements OnPush input changes does not trigger change detection · Issue #38948 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/elements Is this a regression? dunno Description create custom elements via @angular/elements from component with input and changeDetection: ChangeDetectionStrategy.On...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/elements Is this a regression? dunno Description create custom elements via @angular/elements from component with input and cha...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/elements Is this a regression? dunno Description create custom elements via @angular/elements from component with input and cha...

Opengraph URL: https://github.com/angular/angular/issues/38948

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Angular/elements OnPush input changes does not trigger change detection","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/elements\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️--> dunno\r\n\r\n\r\n### Description\r\n\r\n- create custom elements via @angular/elements from component with input and `changeDetection: ChangeDetectionStrategy.OnPush`\r\n- set it's initial input value from the application or change it\r\n- component's CD is not triggered, template is not updated\r\n\r\n## 🔬 Minimal Reproduction\r\n\r\nClone https://github.com/artaommahe/Angular-elements-input-update. There are two applications: `widgets` with custom element and `main-app` with custom element usage in other angular app.\r\n\r\nTwo ways to face the issue - from `main-app` or from plain js custom element usage.\r\n\r\n##### Plain js\r\n\r\nplatform's code here https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/widgets/src/index.html#L11\r\n\r\n- run `widgets` dev server `yarn start widgets`\r\n- open `http://localhost:4201/`\r\n- click `inc` button multiple times\r\n- see no changes in widget's template\r\n- click `trigger widget CD` button (runs markForCheck inside widget component)\r\n- see changes\r\n- uncomment this https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/widgets/src/app/some-widget/components/some-widget/some-widget.component.ts#L17\r\n- update page and click `inc` button\r\n- see changes\r\n\r\n##### Other angular app\r\n\r\nplatform's code here https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/main-app/src/app/app.component.ts#L6\r\n\r\n- run `widgets` dev server `yarn start widgets --extra-webpack-config projects/widgets/webpack.config.js` (we cant run two angular-cli apps in one browser tab webpack config changes https://github.com/angular/angular-cli/issues/8902)\r\n- run `main-app` dev server `yarn start main-app`\r\n- open `http://localhost:4200/`\r\n- click `inc` button multiple times\r\n- see no changes in widget's template\r\n- click `trigger widget CD` button (runs markForCheck inside widget component)\r\n- see changes\r\n- uncomment this https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/widgets/src/app/some-widget/components/some-widget/some-widget.component.ts#L17\r\n- update page and click `inc` button\r\n- see changes\r\n\r\nor you can remove `ChangeDetectionStrategy.OnPush` in `some-widget` component and everything will work too\r\n\r\n## 🔥 Exception or Error\r\n\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nPS D:\\projects\\issues\\angular-elements-input-update> yarn ng version                                                                  \r\nyarn run v1.16.0\r\n$ ng version\r\n\r\n     _                      _                 ____ _     ___\r\n    / \\   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|\r\n   / △ \\ | '_ \\ / _` | | | | |/ _` | '__|   | |   | |    | |\r\n  / ___ \\| | | | (_| | |_| | | (_| | |      | |___| |___ | |\r\n /_/   \\_\\_| |_|\\__, |\\__,_|_|\\__,_|_|       \\____|_____|___|\r\n                |___/\r\n    \r\n\r\nAngular CLI: 10.1.2\r\nNode: 12.18.1\r\nOS: win32 x64\r\n\r\nAngular: 10.1.2\r\n... animations, cli, common, compiler, compiler-cli, core\r\n... elements, forms, platform-browser, platform-browser-dynamic\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage                         Version\r\n---------------------------------------------------------\r\n@angular-devkit/architect       0.1001.2\r\n@angular-devkit/build-angular   0.1001.2\r\n@angular-devkit/core            10.1.2\r\n@angular-devkit/schematics      10.1.2\r\n@schematics/angular             10.1.2\r\n@schematics/update              0.1001.2\r\nrxjs                            6.6.3\r\ntypescript                      4.0.3\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n","author":{"url":"https://github.com/artaommahe","@type":"Person","name":"artaommahe"},"datePublished":"2020-09-23T13:14:41Z","url":"https://github.com/angular/angular/issues/38948"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c0ca4319-363a-dd10-2318-603472efcc75
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9B06:96DDF:CC7BD4:10423C5:6B00FDB4
html-safe-nonce4cd76fe1188bc3ca3a21901e73982bc3b61f24d21c0c00c028f544bd5115527d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjA2Ojk2RERGOkNDN0JENDoxMDQyM0M1OjZCMDBGREI0IiwidmlzaXRvcl9pZCI6Ijg3NDgwNjE1MDI3ODg5MjY5MDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb1f686477276dd4857ac592b1f26e115b78cdf873f07b757ff9845f977b3f5c0
hovercard-subject-tagissue:707356883
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/38948/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f71f2e9e12c9add509319688bf334c23b4393a640d142c58ea27f8e22e06f05e/angular/angular/issues/38948
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f71f2e9e12c9add509319688bf334c23b4393a640d142c58ea27f8e22e06f05e/angular/angular/issues/38948
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/elements Is this a regression? dunno Description create custom elements via @angular/elements from component with input and cha...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameartaommahe
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/38948#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F38948
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F38948
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/38948
Reloadhttps://github.com/angular/angular/issues/38948
Reloadhttps://github.com/angular/angular/issues/38948
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/38948
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/38948
Angular/elements OnPush input changes does not trigger change detectionhttps://github.com/angular/angular/issues/38948#top
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: elementsIssues related to Angular Elementshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/artaommahe
artaommahehttps://github.com/artaommahe
on Sep 23, 2020https://github.com/angular/angular/issues/38948#issue-707356883
https://github.com/artaommahe/Angular-elements-input-updatehttps://github.com/artaommahe/Angular-elements-input-update
https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/widgets/src/index.html#L11https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/widgets/src/index.html#L11
https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/widgets/src/app/some-widget/components/some-widget/some-widget.component.ts#L17https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/widgets/src/app/some-widget/components/some-widget/some-widget.component.ts#L17
https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/main-app/src/app/app.component.ts#L6https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/main-app/src/app/app.component.ts#L6
Proposal: Ability to change webpack jsonp function name angular-cli#8902https://github.com/angular/angular-cli/issues/8902
https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/widgets/src/app/some-widget/components/some-widget/some-widget.component.ts#L17https://github.com/artaommahe/Angular-elements-input-update/blob/master/projects/widgets/src/app/some-widget/components/some-widget/some-widget.component.ts#L17
AndrewKushnirhttps://github.com/AndrewKushnir
area: elementsIssues related to Angular Elementshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
on Sep 23, 2020https://github.com/angular/angular/issues/38948#event-3799059877
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Sep 23, 2020https://github.com/angular/angular/issues/38948#event-3799059973
gkalpakhttps://github.com/gkalpak
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Oct 23, 2020https://github.com/angular/angular/issues/38948#event-3914412883
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Oct 23, 2020https://github.com/angular/angular/issues/38948#event-3914412977
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Oct 23, 2020https://github.com/angular/angular/issues/38948#issuecomment-715426264
StackBlitz reproductionhttps://stackblitz.com/edit/ngelements-issue-38948
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Oct 27, 2020https://github.com/angular/angular/issues/38948#issuecomment-717323050
#39452https://github.com/angular/angular/pull/39452
mheveryhttps://github.com/mhevery
on Nov 6, 2020https://github.com/angular/angular/issues/38948#event-3968248148
fix(elements): update the view of an `OnPush` component when inputs c…https://github.com/angular/angular/commit/dd28855455bad294282ed1c4e0bc55b7fca0f9b9
https://docs.github.com/articles/closing-issues-via-commit-messages
dd28855https://github.com/angular/angular/commit/dd28855455bad294282ed1c4e0bc55b7fca0f9b9
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
bdce769https://github.com/angular/angular/commit/bdce7698fc2a49d31d90ae15a4f5629d00dd3085
on Nov 6, 2020https://github.com/angular/angular/issues/38948#event-3968248315
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Dec 7, 2020https://github.com/angular/angular/issues/38948#issuecomment-740030340
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Dec 7, 2020https://github.com/angular/angular/issues/38948#event-4080555054
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/38948
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/38948
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: elementsIssues related to Angular Elementshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.