René's URL Explorer Experiment


Title: Changing form control name attribute issue. · Issue #38465 · angular/angular · GitHub

Open Graph Title: Changing form control name attribute issue. · Issue #38465 · angular/angular

X Title: Changing form control name attribute issue. · Issue #38465 · angular/angular

Description: 🐞 bug report Affected Package @angular/forms Is this a regression? The issue is not a regression. It is applicable to all Angular versions. Description The problem arises in the template driven form (with NgModel) when you change the nam...

Open Graph Description: 🐞 bug report Affected Package @angular/forms Is this a regression? The issue is not a regression. It is applicable to all Angular versions. Description The problem arises in the template driven for...

X Description: 🐞 bug report Affected Package @angular/forms Is this a regression? The issue is not a regression. It is applicable to all Angular versions. Description The problem arises in the template driven for...

Opengraph URL: https://github.com/angular/angular/issues/38465

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Changing form control name attribute issue.","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\n@angular/forms\r\n\r\n### Is this a regression?\r\nThe issue is not a regression. It is applicable to all Angular versions.\r\n\r\n### Description\r\n\r\nThe problem arises in the template driven form (with NgModel) when you change the name attribute of the control in the DOM. If one has, say, 4 `\u003cinput>` fields in an ngFor loop with their own values and name attributes that correspond to the array’s indexes, and removes whichever `\u003cinput>` field but the last one, and then adds a new `\u003cinput>` field, the default value of the newly-added field replaces the value of the third `\u003cinput>` field. That is, the DOM element’s value is affected by the value of the newly-added field, whereas the values of the array elements behind the DOM elements are not. \r\n\r\nThe problem has to do with the FormControls in the FormGroup, related to the rendered DOM elements, and the naming convention for FormControls of using indexes. Removing an `\u003cinput>` DOM element does not change the names of the rest underlying FormControls within the FormGroup even if the name attribute of the control has been changed. It just reorganises the indexes of the DOM elements after the removed field. Thus, when a new `\u003cinput>` element is added after the removal of an element, its FormControl’s name is created with index 3, which is already used in the name of the FormControl for the second last element, and the new FormControl eventually points to the two last `\u003cinput>` DOM elements at the same time.\r\n\r\nTo sum up, we want to lay down the following two considerations. First, what is the reason for the NgModel not to follow the changes in the names of DOM elements and not to update FormControls in the FormGroup? Second, we know that trackBy solves our problem, as suggested in a number of posts online such as [this one](https://github.com/angular/angular/issues/21068#issuecomment-352882911), but we believe that this is a workaround and the real issue is circumvented. That is why we would like to propose another solution with the following patch:\r\n```\r\n--- old_ng_model.js\t2020-08-13 11:12:38.000000000 +0300\r\n+++ ng_model.js\t2020-08-13 11:03:54.000000000 +0300\r\n@@ -151,6 +151,15 @@\r\n         this._checkForErrors();\r\n         if (!this._registered)\r\n             this._setUpControl();\r\n+        if (this._registered && 'name' in changes && changes.name['previousValue']){\r\n+            resolvedPromise.then(() => {\r\n+                let currControl = Object.assign(new NgModel, this);\r\n+                currControl.name = changes.name['previousValue'];\r\n+                return this.formDirective.removeControl(currControl);\r\n+            }).then(() => {\r\n+                this._setUpControl();\r\n+            });\r\n+        }\r\n         if ('isDisabled' in changes) {\r\n             this._updateDisabled(changes);\r\n         }\r\n```\r\n\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nHere’s the code for the minimal reproduction of the problem: https://stackblitz.com/edit/angular-ivy-p8fd6d?file=src%2Fapp%2Fapp.component.html\r\n\r\n##### Steps to Exemplify the Problem:\r\nadd four new elements. The page renders the four `\u003cinput>` fields, the indexes of the elements, and the array of elements behind the `\u003cinput>` fields;\r\nremove an element but the last one;\r\nadd a new element.\r\n\r\n\r\n##### Current behaviour\r\nThe default value of the newly-added element replaces the value of the second last element; the value of the second last element in the `app.component.ts`’s `record` array is not changed.\r\n\r\n##### Expected behaviour\r\n\r\nIt is expected that the addition of a new `\u003cinput>` element should not affect the values of any of the other DOM elements.\r\n\r\n\r\n## 🔥 Exception or Error\r\n\r\nNo exceptions or errors.\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\nThe example is taken from **Angular Version 10**, but the issue is applicable to **all Angular Versions**.","author":{"url":"https://github.com/kirilkalchev","@type":"Person","name":"kirilkalchev"},"datePublished":"2020-08-14T10:42:58Z","url":"https://github.com/angular/angular/issues/38465"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5ae84242-bc83-ba98-866c-f944327da9d9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC124:1148D3:1A5947B:21A83C3:6B0150EB
html-safe-noncec7d5d90967bcb5c548e779c18cf77a2c65482187481f450dbf3d2147ad5b2426
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTI0OjExNDhEMzoxQTU5NDdCOjIxQTgzQzM6NkIwMTUwRUIiLCJ2aXNpdG9yX2lkIjoiNDk5NjcwNjYzMjYwMDczNTk3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac13a03e4d91174191544d73ce7fe87ff11e37cb1f06279da6289d1bedbe5411fc
hovercard-subject-tagissue:679071461
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/38465/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4542fd25ac84633ee40725cdc9a254e097b42e042f3fb6637b713f6a2b0eb68d/angular/angular/issues/38465
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4542fd25ac84633ee40725cdc9a254e097b42e042f3fb6637b713f6a2b0eb68d/angular/angular/issues/38465
og:image:alt🐞 bug report Affected Package @angular/forms Is this a regression? The issue is not a regression. It is applicable to all Angular versions. Description The problem arises in the template driven for...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekirilkalchev
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/38465#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F38465
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F38465
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/38465
Reloadhttps://github.com/angular/angular/issues/38465
Reloadhttps://github.com/angular/angular/issues/38465
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/38465
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/38465
Changing form control name attribute issue.https://github.com/angular/angular/issues/38465#top
https://github.com/crisbeto
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
forms: Controls APIIssues related to AbstractControl, FormControl, FormGroup, FormArray.https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20Controls%20API%22
forms: DOMhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20DOM%22
forms: ngModelhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20ngModel%22
forms: template-drivenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20template-driven%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/kirilkalchev
kirilkalchevhttps://github.com/kirilkalchev
on Aug 14, 2020https://github.com/angular/angular/issues/38465#issue-679071461
this onehttps://github.com/angular/angular/issues/21068#issuecomment-352882911
https://stackblitz.com/edit/angular-ivy-p8fd6d?file=src%2Fapp%2Fapp.component.htmlhttps://stackblitz.com/edit/angular-ivy-p8fd6d?file=src%2Fapp%2Fapp.component.html
sonukapoorhttps://github.com/sonukapoor
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
forms: Controls APIIssues related to AbstractControl, FormControl, FormGroup, FormArray.https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20Controls%20API%22
forms: DOMhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20DOM%22
forms: ngModelhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20ngModel%22
forms: template-drivenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20template-driven%22
on Aug 14, 2020https://github.com/angular/angular/issues/38465#event-3655742287
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Aug 14, 2020https://github.com/angular/angular/issues/38465#event-3655742349
AndrewKushnirhttps://github.com/AndrewKushnir
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Sep 4, 2020https://github.com/angular/angular/issues/38465#event-3727293466
AndrewKushnirhttps://github.com/AndrewKushnir
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
on Oct 23, 2020https://github.com/angular/angular/issues/38465#event-3911870997
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Oct 23, 2020https://github.com/angular/angular/issues/38465#event-3911871062
crisbetohttps://github.com/crisbeto
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
on Jan 16, 2021https://github.com/angular/angular/issues/38465#event-4213986332
crisbetohttps://github.com/crisbeto
on Jan 16, 2021https://github.com/angular/angular/issues/38465#event-4213986340
crisbetohttps://github.com/crisbeto
on Feb 4, 2022https://github.com/angular/angular/issues/38465#event-6009980734
fix(forms): incorrectly keeping track of ngModel with ngFor inside a …https://github.com/crisbeto/angular/commit/59887c27f4b4bb12d76d22201c57c4a8964ee0a4
https://docs.github.com/articles/closing-issues-via-commit-messages
59887c2https://github.com/crisbeto/angular/commit/59887c27f4b4bb12d76d22201c57c4a8964ee0a4
dylhunnhttps://github.com/dylhunn
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
ebf2fc5https://github.com/angular/angular/commit/ebf2fc5224c9debfd839087c9d1d21fb49577d37
on Feb 7, 2022https://github.com/angular/angular/issues/38465#event-6022358223
dylhunnhttps://github.com/dylhunn
on Feb 7, 2022https://github.com/angular/angular/issues/38465#event-6022358622
fix(forms): incorrectly keeping track of ngModel with ngFor inside a …https://github.com/angular/angular/commit/b75e90f8096394eeef85fa7e667889b7b59a35ed
https://docs.github.com/articles/closing-issues-via-commit-messages
b75e90fhttps://github.com/angular/angular/commit/b75e90f8096394eeef85fa7e667889b7b59a35ed
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 10, 2022https://github.com/angular/angular/issues/38465#issuecomment-1064230439
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 10, 2022https://github.com/angular/angular/issues/38465#event-6218966299
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/38465
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/38465
crisbetohttps://github.com/crisbeto
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
forms: Controls APIIssues related to AbstractControl, FormControl, FormGroup, FormArray.https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20Controls%20API%22
forms: DOMhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20DOM%22
forms: ngModelhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20ngModel%22
forms: template-drivenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22forms%3A%20template-driven%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.